Attention is currently required from: fixeria, pespin.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39953?usp=email )
Change subject: Bump version: 1.1.0.2-6d24 → 1.1.1
......................................................................
Patch Set 1:
(1 comment)
File debian/changelog:
https://gerrit.osmocom.org/c/osmo-remsim/+/39953/comment/3053e396_ca82e897?… :
PS1, Line 3: * src/client/user_shell: add missing \n
> Full name of the author (`[ Name Surname ]`) is missing here?
This is the automatically generated format by "make release" (calling "gbp dch" under the hood). It omits the name section if the person making the release is the same as the author of the commits.
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39953?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I7ba61e6fdd67f19950f3f5834bdc2fabe8d7a1c3
Gerrit-Change-Number: 39953
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Apr 2025 09:06:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39948?usp=email )
Change subject: client: use pcap_dispatch to avoid extra pkt buffer copy
......................................................................
Patch Set 2:
(2 comments)
File src/osmo_client_core.c:
https://gerrit.osmocom.org/c/osmo-pcap/+/39948/comment/f8a8c2f6_4763f34e?us… :
PS2, Line 464: == -1
Maybe it's better to check `!= 0` instead? Looking at the man page, I see it may return `PCAP_ERROR_NOT_ACTIVATED` and `PCAP_ERROR`. Note that `errbuf` is only set if returned value is `PCAP_ERROR`.
https://gerrit.osmocom.org/c/osmo-pcap/+/39948/comment/3fb383b6_8f19f4b7?us… :
PS2, Line 464: one
Why not just passing `1`? It needs a value, not a pointer.
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39948?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I055efb66fac5e04c541d75ec2c0f654cdfb17838
Gerrit-Change-Number: 39948
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Apr 2025 08:59:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39944?usp=email )
Change subject: client: use osmo_stream_cli to transmit data to pcap-server
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39944?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I72e8a6ceb4fb1eb70372e13bb139ead0e2bc0860
Gerrit-Change-Number: 39944
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Apr 2025 08:53:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39944?usp=email )
Change subject: client: use osmo_stream_cli to transmit data to pcap-server
......................................................................
Patch Set 4:
(1 comment)
File src/osmo_client_network.c:
https://gerrit.osmocom.org/c/osmo-pcap/+/39944/comment/963c015a_9c5eb012?us… :
PS3, Line 575: OML BTS link
> this needs to be changed
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39944?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I72e8a6ceb4fb1eb70372e13bb139ead0e2bc0860
Gerrit-Change-Number: 39944
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Apr 2025 08:51:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, pespin.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-pcap/+/39944?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Verified+1 by Jenkins Builder
Change subject: client: use osmo_stream_cli to transmit data to pcap-server
......................................................................
client: use osmo_stream_cli to transmit data to pcap-server
Similarly to previous work done in osmo-pcap-server, the switch to
osmo_stream doesn't cover the TLS-enabled scenario, since moving TLS
related code to osmo_stream requires significant amount of work and can
be done in a subsequent step.
Related: SYS#7290
Change-Id: I72e8a6ceb4fb1eb70372e13bb139ead0e2bc0860
---
M include/osmo-pcap/osmo_pcap_client.h
M src/Makefile.am
M src/osmo_client_network.c
M src/osmo_client_vty.c
4 files changed, 143 insertions(+), 35 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/44/39944/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39944?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I72e8a6ceb4fb1eb70372e13bb139ead0e2bc0860
Gerrit-Change-Number: 39944
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>