pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40010?usp=email )
Change subject: xua_as_fsm: Remove unneeded double call to fill_notify_statchg_pars()
......................................................................
xua_as_fsm: Remove unneeded double call to fill_notify_statchg_pars()
Recent commit introduced the helper func fill_notify_statchg_pars(), and
while doing so it wrongly added calls to it twice in
xua_as_fsm_onenter().
The first one is actually not needed, so remove it.
Fixes: f2e324e2f82efc93fd2a1124fa216d680659ed40
Change-Id: I5d1e2768de13e9ab5ede849b3c06347c8669de1c
---
M src/xua_as_fsm.c
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/10/40010/1
diff --git a/src/xua_as_fsm.c b/src/xua_as_fsm.c
index 0493b9b..5adc469 100644
--- a/src/xua_as_fsm.c
+++ b/src/xua_as_fsm.c
@@ -419,8 +419,6 @@
struct osmo_ss7_as *as = xafp->as;
struct osmo_xlm_prim_notify npar;
- fill_notify_statchg_pars(fi, &npar);
-
switch (fi->state) {
case XUA_AS_S_INACTIVE:
/* continue below */
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40010?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I5d1e2768de13e9ab5ede849b3c06347c8669de1c
Gerrit-Change-Number: 40010
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Attention is currently required from: daniel, laforge, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40003?usp=email )
Change subject: ipa: Try picking unused asp_id in AS to use as SLS
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40003?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I723eac25e59002630dca87a738c8eb7c62edec75
Gerrit-Change-Number: 40003
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 11 Apr 2025 13:43:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40004?usp=email )
Change subject: cosmetic: Fix typo in API comment description
......................................................................
cosmetic: Fix typo in API comment description
Change-Id: I12546a9a242ad99164c6851921e5bc7eb07cb567
---
M src/xua_asp_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c
index ec149d1..cd60df2 100644
--- a/src/xua_asp_fsm.c
+++ b/src/xua_asp_fsm.c
@@ -805,7 +805,7 @@
static int ipa_asp_fsm_start(struct osmo_ss7_asp *asp,
enum osmo_ss7_asp_role role, int log_level);
-/*! \brief Start a new ASP finite stae machine for given ASP (stored in asp->fi)
+/*! \brief Start a new ASP finite state machine for given ASP (stored in asp->fi)
* \param[in] asp Application Server Process for which to start FSM
* \param[in] role Role (ASP, SG, IPSP) of this FSM
* \param[in] log_level Logging Level for ASP FSM logging
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40004?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I12546a9a242ad99164c6851921e5bc7eb07cb567
Gerrit-Change-Number: 40004
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40006?usp=email )
Change subject: asp: Rename and clarify asp_id field
......................................................................
Patch Set 1:
(1 comment)
File src/xua_asp_fsm.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40006/comment/e0b8c081_87bf4… :
PS1, Line 219: xua_msg_add_u32(xua, SUA_IEI_ASP_ID, asp->asp_id);
> the commit message only talks about renaming the field, but here the logic is changed to not send th […]
I'm already explaining it in the commit msg:
"and using this same value when sending
our own ASP Identifier during ASPUP.
This was not causing a problem since actually we have no real way to set
asp_id_present on our own in ASP mode yet, so no local ASP Identifier is
ever being transmitted."
It makes more sense to do it here, because this commit is not omly a "rename" commit but a "clarify and rename" commit, and both need to go together since 2 different uses were entangled in the same field.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40006?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I8e4304099db6fb12cf4b40a5b9a4aa3a83c95fde
Gerrit-Change-Number: 40006
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 11 Apr 2025 13:02:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>