- gerrit-log - lists.osmocom.org

[XS] Change in osmo-hnbgw[master]: rua: Change log err level ERROR->NOTICE regarding received unexpected...
by pespin 25 Apr '25

25 Apr '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40152?usp=email ) Change subject: rua: Change log err level ERROR->NOTICE regarding received unexpected RUA context ...................................................................... rua: Change log err level ERROR->NOTICE regarding received unexpected RUA context This is not really an internal error but can actually happen if the HNB or the HNBGW crashed and state is no longer the same in both. Change-Id: Ib588bb71ccbe716a495afec27d38f48881e7e1bc --- M src/osmo-hnbgw/hnbgw_rua.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: lynxis lazus: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-hnbgw/hnbgw_rua.c b/src/osmo-hnbgw/hnbgw_rua.c index 7cc1b27..7a51c8d 100644 --- a/src/osmo-hnbgw/hnbgw_rua.c +++ b/src/osmo-hnbgw/hnbgw_rua.c @@ -271,7 +271,7 @@ /* A Connect message can only be the first message for an unused RUA context */ if (map) { /* Already established this RUA context. But then how can it be a Connect message. */ - LOGHNB(hnb, DRUA, LOGL_ERROR, "rx RUA %s for already active RUA context %u\n", + LOGHNB(hnb, DRUA, LOGL_NOTICE, "rx RUA %s for already active RUA context %u\n", rua_procedure_code_name(rua_procedure), context_id); return -EINVAL; } @@ -300,7 +300,7 @@ default: /* Any message other than Connect must have a valid RUA context */ if (!map) { - LOGHNB(hnb, DRUA, LOGL_ERROR, "rx RUA %s for unknown RUA context %u\n", + LOGHNB(hnb, DRUA, LOGL_NOTICE, "rx RUA %s for unknown RUA context %u\n", rua_procedure_code_name(rua_procedure), context_id); rua_tx_disc_conn_fail(hnb, is_ps, context_id); return -EINVAL; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40152?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib588bb71ccbe716a495afec27d38f48881e7e1bc Gerrit-Change-Number: 40152 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-hnbgw[master]: mgw_fsm: use LOG_MAP() to log error
by pespin 25 Apr '25

25 Apr '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40160?usp=email ) Change subject: mgw_fsm: use LOG_MAP() to log error ...................................................................... mgw_fsm: use LOG_MAP() to log error Change-Id: Ic543a3c17eddf4b1da51172223eccaa62a441fd3 --- M src/osmo-hnbgw/mgw_fsm.c 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: lynxis lazus: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c index d44a6e3..3d230c6 100644 --- a/src/osmo-hnbgw/mgw_fsm.c +++ b/src/osmo-hnbgw/mgw_fsm.c @@ -846,9 +846,9 @@ * into account under the assumption that voice calls typically require a single RAB only. Nevertheless, we * will block all incoming RAB assignments that try to assign more (or less) than one RAB. */ if (ranap_rab_ass_req_ies_get_count(&message->msg.raB_AssignmentRequestIEs) != 1) { - LOGP(DMGW, LOGL_ERROR, - "%s() rua_ctx_id=%d, RAB-AssignmentRequest with more than one RAB assignment -- abort!\n", - __func__, map->rua_ctx_id); + LOG_MAP(map, DMGW, LOGL_ERROR, + "%s() RAB-AssignmentRequest with more than one RAB assignment -- abort!\n", + __func__); tx_release_req(map); return -1; } @@ -886,9 +886,9 @@ /* NOTE: This situation is a corner-case. We may end up here when the co-located MGW caused a problem * on the way between RANAP RAB Assignment Request and RANAP RAB Assignment Response. */ - LOGP(DMGW, LOGL_ERROR, - "%s() rua_ctx_id=%d, no MGW fsm -- sending Iu-Release-Request!\n", - __func__, map->rua_ctx_id); + LOG_MAP(map, DMGW, LOGL_ERROR, + "%s() no MGW fsm -- sending Iu-Release-Request!\n", + __func__); /* Send a release request, to make sure that the MSC is aware of the problem. */ tx_release_req(map); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40160?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic543a3c17eddf4b1da51172223eccaa62a441fd3 Gerrit-Change-Number: 40160 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-hnbgw[master]: ranap: No need to set destructor function twice
by pespin 25 Apr '25

25 Apr '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40158?usp=email ) Change subject: ranap: No need to set destructor function twice ...................................................................... ranap: No need to set destructor function twice talloc destructor function is already being set in hnbgw_decode_ranap_ran_co(), no need to do it twice. This is a leftover from recent refactoring. Fixes: 79c5600bb65e5e940dddfd4b3be50259caa1bd34 Change-Id: I9caaff3bd6435cde51006cd14837f3824c77c68b --- M src/osmo-hnbgw/hnbgw_ranap.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved diff --git a/src/osmo-hnbgw/hnbgw_ranap.c b/src/osmo-hnbgw/hnbgw_ranap.c index f97f53f..692cf11 100644 --- a/src/osmo-hnbgw/hnbgw_ranap.c +++ b/src/osmo-hnbgw/hnbgw_ranap.c @@ -627,8 +627,6 @@ * information, for RTP mapping via MGW, or GTP mapping via UPF. */ ranap_message *message = hnbgw_decode_ranap_ran_co(ranap_msg); if (message) { - talloc_set_destructor(message, destruct_ranap_ran_rx_co_ies); - LOG_MAP(map, DCN, LOGL_DEBUG, "rx from SCCP: RANAP %s\n", get_value_string(ranap_procedure_code_vals, message->procedureCode)); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I9caaff3bd6435cde51006cd14837f3824c77c68b Gerrit-Change-Number: 40158 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-hnbgw[master]: Change level ERROR->NOTICE trying to transmit msg if RUA disconnected
by pespin 25 Apr '25

25 Apr '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40159?usp=email ) Change subject: Change level ERROR->NOTICE trying to transmit msg if RUA disconnected ...................................................................... Change level ERROR->NOTICE trying to transmit msg if RUA disconnected Change-Id: I22210e1699709853a9a8bc828cbe5d6379e79e08 --- M src/osmo-hnbgw/context_map_rua.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved diff --git a/src/osmo-hnbgw/context_map_rua.c b/src/osmo-hnbgw/context_map_rua.c index ca1a6ed..d408ddd 100644 --- a/src/osmo-hnbgw/context_map_rua.c +++ b/src/osmo-hnbgw/context_map_rua.c @@ -278,7 +278,7 @@ { struct msgb *ranap_msg = data; if (msg_has_l2_data(ranap_msg)) - LOGPFSML(fi, LOGL_ERROR, "RUA not connected, cannot dispatch RANAP message\n"); + LOGPFSML(fi, LOGL_NOTICE, "RUA not connected, cannot dispatch RANAP message\n"); /* Ignore all events. */ } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40159?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I22210e1699709853a9a8bc828cbe5d6379e79e08 Gerrit-Change-Number: 40159 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-hnbgw[master]: change log level patching GTP info NOTICE->INFO
by lynxis lazus 25 Apr '25

25 Apr '25

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40155?usp=email ) Change subject: change log level patching GTP info NOTICE->INFO ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40155?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I93b8634ff4de52fb7e3f2bfd915552173f27a09a Gerrit-Change-Number: 40155 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 17:15:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-hnbgw[master]: Change log level new conn created NOTICE->INFO
by lynxis lazus 25 Apr '25

25 Apr '25

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40154?usp=email ) Change subject: Change log level new conn created NOTICE->INFO ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40154?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ie8a50312abc3dd4a438556f6f626d069259cc551 Gerrit-Change-Number: 40154 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 17:15:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-hnbgw[master]: rua: Change log err level ERROR->NOTICE regarding received unexpected...
by lynxis lazus 25 Apr '25

25 Apr '25

Attention is currently required from: osmith, pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40152?usp=email ) Change subject: rua: Change log err level ERROR->NOTICE regarding received unexpected RUA context ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: offtopic: how does it recover? -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40152?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib588bb71ccbe716a495afec27d38f48881e7e1bc Gerrit-Change-Number: 40152 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 17:15:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-hnbgw[master]: rua: Change log err level ERROR->NOTICE regarding received unexpected...
by lynxis lazus 25 Apr '25

25 Apr '25

Attention is currently required from: osmith, pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40152?usp=email ) Change subject: rua: Change log err level ERROR->NOTICE regarding received unexpected RUA context ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40152?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib588bb71ccbe716a495afec27d38f48881e7e1bc Gerrit-Change-Number: 40152 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 17:15:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-hnbgw[master]: cosmetic: Improve ranap_msg passing ownership documentation
by lynxis lazus 25 Apr '25

25 Apr '25

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40161?usp=email ) Change subject: cosmetic: Improve ranap_msg passing ownership documentation ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40161?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I556e01b26a71b43432c623adb7ea5af2114981e3 Gerrit-Change-Number: 40161 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 17:14:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-hnbgw[master]: mgw_fsm: use LOG_MAP() to log error
by lynxis lazus 25 Apr '25

25 Apr '25

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40160?usp=email ) Change subject: mgw_fsm: use LOG_MAP() to log error ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40160?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic543a3c17eddf4b1da51172223eccaa62a441fd3 Gerrit-Change-Number: 40160 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 17:14:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log