- gerrit-log - lists.osmocom.org

[XS] Change in libosmo-sigtran[master]: asp: Make sure previous stream_srv is immediatelly destroyed when req...
by pespin 02 May '25

02 May '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40194?usp=email ) Change subject: asp: Make sure previous stream_srv is immediatelly destroyed when requested ...................................................................... asp: Make sure previous stream_srv is immediatelly destroyed when requested This will be needed when the asp is in SCTP=server mode and we request it to shutdown/restart. Change-Id: I8edd64234654ba987f35de2d7ad610e96bda27eb --- M src/osmo_ss7_asp.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/94/40194/1 diff --git a/src/osmo_ss7_asp.c b/src/osmo_ss7_asp.c index 4044003..02dbcb8 100644 --- a/src/osmo_ss7_asp.c +++ b/src/osmo_ss7_asp.c @@ -699,6 +699,12 @@ asp->client = NULL; osmo_stream_cli_destroy(cli); } + if (asp->server) { + /* Make sure we close the previous stream right now: */ + srv = asp->server; + asp->server = NULL; + osmo_stream_srv_destroy(srv); + } } else { /* We are in client mode now */ if (asp->server) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40194?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8edd64234654ba987f35de2d7ad610e96bda27eb Gerrit-Change-Number: 40194 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: asp: Make sure asp->{client,server} is nulled before destroy callback
by pespin 02 May '25

02 May '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40193?usp=email ) Change subject: asp: Make sure asp->{client,server} is nulled before destroy callback ...................................................................... asp: Make sure asp->{client,server} is nulled before destroy callback disconnect_cb() in case of stream_cli and closed_cb() in case of stream_srv may call some libosmo-sigtran code. Make sure we don't access the pointer anymore in that case for safety. Change-Id: I3f0774eac630c8bc7e9a10f874e1c72763fd14a0 --- M src/osmo_ss7_asp.c 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/93/40193/1 diff --git a/src/osmo_ss7_asp.c b/src/osmo_ss7_asp.c index c054369..4044003 100644 --- a/src/osmo_ss7_asp.c +++ b/src/osmo_ss7_asp.c @@ -686,22 +686,27 @@ * announce disconnection to upper layers. */ int ss7_asp_disconnect_stream(struct osmo_ss7_asp *asp) { + struct osmo_stream_cli *cli; + struct osmo_stream_srv *srv; + /* First tear down previous state if existing: */ if (asp->cfg.is_server) { /* We are in server mode now */ if (asp->client) { /* if we previously were in client mode, * destroy it */ - osmo_stream_cli_destroy(asp->client); + cli = asp->client; asp->client = NULL; + osmo_stream_cli_destroy(cli); } } else { /* We are in client mode now */ if (asp->server) { /* if we previously were in server mode, * destroy it */ - osmo_stream_srv_destroy(asp->server); + srv = asp->server; asp->server = NULL; + osmo_stream_srv_destroy(srv); } if (asp->client) { /* Make sure we close the previous stream before starting a new one: */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3f0774eac630c8bc7e9a10f874e1c72763fd14a0 Gerrit-Change-Number: 40193 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Store asp name in array of m3ua cfgs
by pespin 02 May '25

02 May '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40192?usp=email ) Change subject: stp: Store asp name in array of m3ua cfgs ...................................................................... stp: Store asp name in array of m3ua cfgs This way we keep STP specific config in one place instead of having to figure out the ASP name on each test where we want to modify that ASP. Change-Id: I1d5d9113dc95a8da911a7a99260c9bfe6e9de7c9 --- M stp/STP_Tests_M3UA.ttcn 1 file changed, 20 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/92/40192/1 diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn index 18076bd..bee2488 100644 --- a/stp/STP_Tests_M3UA.ttcn +++ b/stp/STP_Tests_M3UA.ttcn @@ -48,6 +48,7 @@ M3uaConfigs mp_m3ua_configs := { /* as-sender: One ASP within AS */ { + asp_name := "asp-sender", use_tcp := false, remote_port := 2905, local_port := 9999, @@ -56,12 +57,14 @@ }, /* as-receiver: Two ASP within AS */ { + asp_name := "asp-receiver0", use_tcp := false, remote_port := 2905, local_port := 10000, point_code := 42, routing_ctx := 1042 }, { + asp_name := "asp-receiver1", use_tcp := false, remote_port := 2905, local_port := 10001, @@ -70,6 +73,7 @@ }, /* as-sender-tcp: One ASP within AS */ { + asp_name := "asp-sender-tcp", use_tcp := true, remote_port := 2905, local_port := 9999, @@ -78,6 +82,7 @@ }, /* as-client: One ASP within AS */ { + asp_name := "asp-client0", use_tcp := false, remote_port := 2906, local_port := 10002, @@ -86,6 +91,7 @@ }, /* as-client60-norctx */ { + asp_name := "asp-client60-norctx0", use_tcp := false, remote_port := 2907, local_port := 11060, @@ -94,6 +100,7 @@ }, /* as-client61-norctx */ { + asp_name := "asp-client61-norctx0", use_tcp := false, remote_port := 2907, local_port := 11061, @@ -102,6 +109,7 @@ }, /* as-client-tcp: One ASP within AS */ { + asp_name := "asp-client0-tcp", use_tcp := true, remote_port := 2906, local_port := 10002, @@ -118,6 +126,8 @@ } type record M3uaConfig { + /* Name of the ASP in the STP, (eg. to access it over VTY) */ + charstring asp_name, /* use TCP (true) or SCTP (false) */ boolean use_tcp, /* STP-side SCTP (or TCP) port for M3UA */ @@ -1309,11 +1319,11 @@ f_M3UA_exp(0, tr_M3UA_SCON({adv_pc}, rctx0)); } -private function f_asp_cfg_str(charstring asp_name, in M3uaConfig cfg) +private function f_asp_cfg_str(in M3uaConfig cfg) return charstring { var charstring str; - str := "asp " & asp_name; + str := "asp " & cfg.asp_name; str := str & " " & int2str(cfg.local_port); str := str & " " & int2str(cfg.remote_port); str := str & " m3ua"; @@ -1325,14 +1335,18 @@ return str; } +private function f_vty_cs7_asp_cmd(in M3uaConfig cfg, charstring cmd) runs on RAW_M3UA_CT +{ + var charstring asp_cfg_str := f_asp_cfg_str(cfg); + f_vty_config2(VTY, {"cs7 instance 0", asp_cfg_str}, cmd); +} + private function f_quirk(charstring quirk) runs on RAW_M3UA_CT { - var charstring asp_cfg_str := f_asp_cfg_str("asp-client0", f_m3ua_srv_config(0)); - f_vty_config2(VTY, {"cs7 instance 0", asp_cfg_str}, "quirk " & quirk); + f_vty_cs7_asp_cmd(f_m3ua_srv_config(0), "quirk " & quirk) } private function f_no_quirk(charstring quirk) runs on RAW_M3UA_CT { - var charstring asp_cfg_str := f_asp_cfg_str("asp-client0", f_m3ua_srv_config(0)); - f_vty_config2(VTY, {"cs7 instance 0", asp_cfg_str}, "no quirk " & quirk); + f_vty_cs7_asp_cmd(f_m3ua_srv_config(0), "no quirk " & quirk) } /* quirk 'no_notify': Expect inbound connection from ASP/SCTP-client, followed by ASP-UP + ASP-ACT */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40192?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1d5d9113dc95a8da911a7a99260c9bfe6e9de7c9 Gerrit-Change-Number: 40192 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: Tx multiple Routing Contexts in NOTIFY on ASPs serving multiple AS
by pespin 02 May '25

02 May '25

Attention is currently required from: daniel, fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40011?usp=email ) Change subject: Tx multiple Routing Contexts in NOTIFY on ASPs serving multiple AS ...................................................................... Patch Set 5: (1 comment) This change is ready for review. Patchset: PS5: TTCN3 tests are now passing fine after having new correct expectancies here: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40191 stp: Update TC_rkm_unreg_active to expect multiple routing contexts IMHO this patch can be merged now. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I646301ec3d08ef98f227cf4d19da1039e40cedd2 Gerrit-Change-Number: 40011 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 May 2025 14:13:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Update TC_rkm_unreg_active to expect multiple routing contexts
by pespin 02 May '25

02 May '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40191?usp=email ) Change subject: stp: Update TC_rkm_unreg_active to expect multiple routing contexts ...................................................................... stp: Update TC_rkm_unreg_active to expect multiple routing contexts That test is registering a new routcing context (AS) into an existing/pre-configured ASP. As a result, the ASP serves 2 AS. When we receive notifications on that ASP then we'll be receiving info on 2 routing contexts, one for the pre-confgiured AS and one for the dynamically registered one. Depends: libosmo-sigtran.git I646301ec3d08ef98f227cf4d19da1039e40cedd2 Change-Id: I2dc4d197e6de38781b63e3079ada4c4b4a0db31d --- M stp/STP_Tests_M3UA.ttcn 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/91/40191/1 diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn index 89be9e0..18076bd 100644 --- a/stp/STP_Tests_M3UA.ttcn +++ b/stp/STP_Tests_M3UA.ttcn @@ -889,12 +889,12 @@ /* then activate the ASP, this turns the 2 AS (one for each rctx, 1234 and default 1023) * INACTIVE, handle the 2 NOTIFY manually afterwards: */ f_M3UA_asp_up(0, omit); - f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_INACTIVE, (rctxA, rctxB))); - f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_INACTIVE, (rctxA, rctxB))); + f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_INACTIVE, (rctxA & rctxB, rctxB & rctxA))); + f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_INACTIVE, (rctxA & rctxB, rctxB & rctxA))); f_M3UA_asp_act(0, omit, rctxB); - f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_ACTIVE, rctxB)); + f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_ACTIVE, (rctxA & rctxB, rctxB & rctxA))); f_M3UA_exp(0, tr_M3UA_DAVA({*}, rctxA)); - f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_ACTIVE, rctxA)); + f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_ACTIVE, (rctxA & rctxB, rctxB & rctxA))); f_M3UA_exp(0, tr_M3UA_DAVA({*}, rctxB)); /* then try to de-register -> ERR_ASP_ACTIVE */ @@ -904,8 +904,8 @@ /* deactivate ASP and properly de-register to clean up */ f_M3UA_asp_inact(0); f_M3UA_send(0, ts_M3UA_DEREG_REQ(ts_M3UA_routing_ctx(rctxA))); - f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_PENDING, (rctxA, rctxB))); - f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_PENDING, (rctxA, rctxB))); + f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_PENDING, (rctxA & rctxB, rctxB & rctxA))); + f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_PENDING, (rctxA & rctxB, rctxB & rctxA))); f_M3UA_exp(0, tr_M3UA_DEREG_RSP({tr_M3UA_dereg_res(?,c_m3UA_DEREGSTS_SUCCESS)})); f_vty_config2(VTY, {"cs7 instance 0"}, "xua rkm routing-key-allocation static-only"); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40191?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2dc4d197e6de38781b63e3079ada4c4b4a0db31d Gerrit-Change-Number: 40191 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: xua_asp_fsm: Reuse ss7_asp_get_all_rctx_be() in xua_msg_add_asp_rctx()
by pespin 02 May '25

02 May '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40190?usp=email ) Change subject: xua_asp_fsm: Reuse ss7_asp_get_all_rctx_be() in xua_msg_add_asp_rctx() ...................................................................... xua_asp_fsm: Reuse ss7_asp_get_all_rctx_be() in xua_msg_add_asp_rctx() Change-Id: I6fe4f388b11991e7c7396c9d632b376e8591a8f3 --- M src/xua_asp_fsm.c 1 file changed, 5 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/90/40190/1 diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c index 4603734..11a34b4 100644 --- a/src/xua_asp_fsm.c +++ b/src/xua_asp_fsm.c @@ -173,32 +173,14 @@ /* add M3UA_IEI_ROUTE_CTX to xua_msg containig all routing keys of ASs within ASP */ static int xua_msg_add_asp_rctx(struct xua_msg *xua, struct osmo_ss7_asp *asp) { - struct osmo_ss7_as *as; uint32_t rctx[OSMO_SS7_MAX_RCTX_COUNT]; - unsigned int i = 0; + unsigned int cnt; - /* iterate over all ASs and build array of routing contexts */ - llist_for_each_entry(as, &asp->inst->as_list, list) { - if (!osmo_ss7_as_has_asp(as, asp)) - continue; - rctx[i++] = htonl(as->cfg.routing_key.context); - if (i >= ARRAY_SIZE(rctx)-1) { - break; - } - } - /* add xUA IE with routing contests to the message (if any) */ - if (i) { - /* bail out (and not add the IE) if there's only one routing context (and hence - * only one AS) within this ASP, and that routing context is zero, meaning no routing - * context IE shall be used */ - if (i == 1 && rctx[0] == 0) - return 0; - - xua_msg_add_data(xua, M3UA_IEI_ROUTE_CTX, i*sizeof(uint32_t), (uint8_t *)rctx); - } - + cnt = ss7_asp_get_all_rctx_be(asp, rctx, ARRAY_SIZE(rctx), NULL); + if (cnt > 0) + xua_msg_add_data(xua, M3UA_IEI_ROUTE_CTX, cnt*sizeof(uint32_t), (uint8_t *)rctx); /* return count of routing contexts added */ - return i; + return cnt; } /* ask the xUA implementation to transmit a specific message */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40190?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6fe4f388b11991e7c7396c9d632b376e8591a8f3 Gerrit-Change-Number: 40190 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: M3UA_Templates: Allow passing multiple Routing Context values
by pespin 02 May '25

02 May '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40189?usp=email ) Change subject: M3UA_Templates: Allow passing multiple Routing Context values ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: See "Routing Context" in rfc4666 for those messages. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40189?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I117c63786d71aea683b554cf294fee0ceed665e0 Gerrit-Change-Number: 40189 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 02 May 2025 13:29:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: M3UA_Templates: Allow passing multiple Routing Context values
by pespin 02 May '25

02 May '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40189?usp=email ) Change subject: M3UA_Templates: Allow passing multiple Routing Context values ...................................................................... M3UA_Templates: Allow passing multiple Routing Context values Change-Id: I117c63786d71aea683b554cf294fee0ceed665e0 --- M library/M3UA_Templates.ttcn 1 file changed, 22 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/89/40189/1 diff --git a/library/M3UA_Templates.ttcn b/library/M3UA_Templates.ttcn index 3667ca0..1422b80 100644 --- a/library/M3UA_Templates.ttcn +++ b/library/M3UA_Templates.ttcn @@ -274,7 +274,7 @@ } template (value) PDU_M3UA ts_M3UA_ASPAC(template (omit) M3UA_Traffic_Mode_Type tmt, - template (omit) OCT4 rctx) := { + template (omit) octetstring rctx) := { m3UA_ASPAC := { version := c_M3UA_VERSION, reserved := '00'O, @@ -288,7 +288,7 @@ } } template (present) PDU_M3UA tr_M3UA_ASPAC(template M3UA_Traffic_Mode_Type tmt, - template OCT4 rctx) := { + template octetstring rctx) := { m3UA_ASPAC := { version := c_M3UA_VERSION, reserved := '00'O, @@ -303,7 +303,7 @@ } template (value) PDU_M3UA ts_M3UA_ASPAC_ACK(template (omit) M3UA_Traffic_Mode_Type tmt, - template (omit) OCT4 rctx) := { + template (omit) octetstring rctx) := { m3UA_ASPAC_Ack := { version := c_M3UA_VERSION, reserved := '00'O, @@ -317,7 +317,7 @@ } } template (present) PDU_M3UA tr_M3UA_ASPAC_ACK(template M3UA_Traffic_Mode_Type tmt, - template OCT4 rctx) := { + template octetstring rctx) := { m3UA_ASPAC_Ack := { version := c_M3UA_VERSION, reserved := '00'O, @@ -331,7 +331,7 @@ } } -template (value) PDU_M3UA ts_M3UA_ASPIA(template (omit) OCT4 rctx) := { +template (value) PDU_M3UA ts_M3UA_ASPIA(template (omit) octetstring rctx) := { m3UA_ASPIA := { version := c_M3UA_VERSION, reserved := '00'O, @@ -343,7 +343,7 @@ } } } -template (present) PDU_M3UA tr_M3UA_ASPIA(template OCT4 rctx) := { +template (present) PDU_M3UA tr_M3UA_ASPIA(template octetstring rctx) := { m3UA_ASPIA := { version := c_M3UA_VERSION, reserved := '00'O, @@ -357,7 +357,7 @@ } -template (value) PDU_M3UA ts_M3UA_ASPIA_ACK(template (omit) OCT4 rctx) := { +template (value) PDU_M3UA ts_M3UA_ASPIA_ACK(template (omit) octetstring rctx) := { m3UA_ASPIA_Ack := { version := c_M3UA_VERSION, reserved := '00'O, @@ -369,7 +369,7 @@ } } } -template (present) PDU_M3UA tr_M3UA_ASPIA_ACK(template OCT4 rctx) := { +template (present) PDU_M3UA tr_M3UA_ASPIA_ACK(template octetstring rctx) := { m3UA_ASPIA_Ack := { version := c_M3UA_VERSION, reserved := '00'O, @@ -418,7 +418,7 @@ } template (value) PDU_M3UA ts_M3UA_DUNA(template (value) M3UA_Point_Codes affected_pcs, - template (omit) OCT4 rctx := omit) := { + template (omit) octetstring rctx := omit) := { m3UA_DUNA := { version := c_M3UA_VERSION, reserved := '00'O, @@ -433,7 +433,7 @@ } } template (present) PDU_M3UA tr_M3UA_DUNA(template (present) M3UA_Point_Codes affected_pcs := ?, - template OCT4 rctx := *):= { + template octetstring rctx := *):= { m3UA_DUNA := { version := c_M3UA_VERSION, reserved := '00'O, @@ -449,7 +449,7 @@ } template (value) PDU_M3UA ts_M3UA_DAVA(template (value) M3UA_Point_Codes affected_pcs, - template (omit) OCT4 rctx := omit) := { + template (omit) octetstring rctx := omit) := { m3UA_DAVA := { version := c_M3UA_VERSION, reserved := '00'O, @@ -464,7 +464,7 @@ } } template (present) PDU_M3UA tr_M3UA_DAVA(template (present) M3UA_Point_Codes affected_pcs := ?, - template OCT4 rctx := *):= { + template octetstring rctx := *):= { m3UA_DAVA := { version := c_M3UA_VERSION, reserved := '00'O, @@ -480,7 +480,7 @@ } template (value) PDU_M3UA ts_M3UA_DAUD(template (value) M3UA_Point_Codes affected_pcs, - template (omit) OCT4 rctx := omit) := { + template (omit) octetstring rctx := omit) := { m3UA_DAUD := { version := c_M3UA_VERSION, reserved := '00'O, @@ -495,7 +495,7 @@ } } template (present) PDU_M3UA tr_M3UA_DAUD(template (present) M3UA_Point_Codes affected_pcs := ?, - template OCT4 rctx := *):= { + template octetstring rctx := *):= { m3UA_DAUD := { version := c_M3UA_VERSION, reserved := '00'O, @@ -511,7 +511,7 @@ } template (value) PDU_M3UA ts_M3UA_SCON(template (value) M3UA_Point_Codes affected_pcs, - template (omit) OCT4 rctx := omit) := { + template (omit) octetstring rctx := omit) := { m3UA_SCON := { version := c_M3UA_VERSION, reserved := '00'O, @@ -528,7 +528,7 @@ } } template (present) PDU_M3UA tr_M3UA_SCON(template (present) M3UA_Point_Codes affected_pcs := ?, - template OCT4 rctx := *):= { + template octetstring rctx := *):= { m3UA_SCON := { version := c_M3UA_VERSION, reserved := '00'O, @@ -548,7 +548,7 @@ template (value) PDU_M3UA ts_M3UA_DUPU(template (value) M3UA_Point_Codes affected_pcs, template (value) OCT2 cause, template (value) OCT2 user, - template (omit) OCT4 rctx := omit) := { + template (omit) octetstring rctx := omit) := { m3UA_DUPU := { version := c_M3UA_VERSION, reserved := '00'O, @@ -566,7 +566,7 @@ template (present) PDU_M3UA tr_M3UA_DUPU(template (present) M3UA_Point_Codes affected_pcs := ?, template (present) OCT2 cause := ?, template (present) OCT2 user := ?, - template OCT4 rctx := *):= { + template octetstring rctx := *):= { m3UA_DUPU := { version := c_M3UA_VERSION, reserved := '00'O, @@ -628,7 +628,7 @@ template (value) PDU_M3UA ts_M3UA_ERR(template (value) OCT4 err_code, - template (omit) OCT4 rctx) := { + template (omit) octetstring rctx) := { m3UA_ERR := { version := c_M3UA_VERSION, reserved := '00'O, @@ -644,7 +644,7 @@ } } template (present) PDU_M3UA tr_M3UA_ERR(template (present) OCT4 err_code, - template OCT4 rctx) := { + template octetstring rctx) := { m3UA_ERR := { version := c_M3UA_VERSION, reserved := '00'O, @@ -663,7 +663,7 @@ template (value) PDU_M3UA ts_M3UA_NOTIFY(template (value) OCT2 status_type, template (value) OCT2 status_info, - template (omit) OCT4 rctx, + template (omit) octetstring rctx, template (omit) OCT4 aspid := omit, template (omit) octetstring infostr := omit) := { m3UA_NOTIFY := { @@ -681,7 +681,7 @@ } template (present) PDU_M3UA tr_M3UA_NOTIFY(template (present) OCT2 status_type, template (present) OCT2 status_info, - template OCT4 rctx, + template octetstring rctx, template OCT4 aspid := *, template octetstring infostr := *) := { m3UA_NOTIFY := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40189?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I117c63786d71aea683b554cf294fee0ceed665e0 Gerrit-Change-Number: 40189 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: vty: cosmetic: fix code formatting
by fixeria 02 May '25

02 May '25

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/40186?usp=email ) Change subject: vty: cosmetic: fix code formatting ...................................................................... vty: cosmetic: fix code formatting Change-Id: I746b72dc79b6ebf2e3cb18274118f3ca9ead312a --- M src/vty/command.c 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/vty/command.c b/src/vty/command.c index 8f87e7d..8594290 100644 --- a/src/vty/command.c +++ b/src/vty/command.c @@ -3555,13 +3555,13 @@ config_write_cmd, "write", "Write running configuration to memory, network, or terminal\n") - ALIAS(config_write_file, +ALIAS(config_write_file, config_write_memory_cmd, "write memory", "Write running configuration to memory, network, or terminal\n" "Write configuration to the file (same as write file)\n") - ALIAS(config_write_file, +ALIAS(config_write_file, copy_runningconfig_startupconfig_cmd, "copy running-config startup-config", "Copy configuration\n" @@ -3569,7 +3569,7 @@ "Copy running config to startup config (same as write file)\n") /* Write current configuration into the terminal. */ - DEFUN(config_write_terminal, +DEFUN(config_write_terminal, config_write_terminal_cmd, "write terminal", "Write running configuration to memory, network, or terminal\n" @@ -3606,7 +3606,7 @@ "show running-config", SHOW_STR "running configuration\n") /* Write startup configuration into the terminal. */ - DEFUN(show_startup_config, +DEFUN(show_startup_config, show_startup_config_cmd, "show startup-config", SHOW_STR "Contentes of startup configuration\n") { @@ -3722,7 +3722,7 @@ "The UNENCRYPTED (cleartext) line password\n") /* VTY enable password set. */ - DEFUN(config_enable_password, enable_password_cmd, +DEFUN(config_enable_password, enable_password_cmd, "enable password (8|) WORD", "Modify enable password parameters\n" "Assign the privileged level password\n" @@ -3785,7 +3785,7 @@ "The UNENCRYPTED (cleartext) 'enable' password\n") /* VTY enable password delete. */ - DEFUN(no_config_enable_password, no_enable_password_cmd, +DEFUN(no_config_enable_password, no_enable_password_cmd, "no enable password", NO_STR "Modify enable password parameters\n" -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40186?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I746b72dc79b6ebf2e3cb18274118f3ca9ead312a Gerrit-Change-Number: 40186 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: VTY: Initialize fields of struct cmd_element in order of declaration
by pespin 02 May '25

02 May '25

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40188?usp=email ) Change subject: VTY: Initialize fields of struct cmd_element in order of declaration ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifaa31980f149f9c1f1a9b28f318a4850f6855472 Gerrit-Change-Number: 40188 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 02 May 2025 11:16:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log