Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40367?usp=email )
Change subject: 5gc: initial
......................................................................
Patch Set 1:
(2 comments)
File 5gc/C5G_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40367/comment/da7ff9f7_126f… :
PS1, Line 265: var charstring id := testcasename();
Do we really want doing this in each and every testcase?
Why not just calling `testcasename()` where it's needed, i.e. in `f_init_one_ngran()`?
File Makefile:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40367/comment/19d0e10c_ea42… :
PS1, Line 63: PARALLEL_MAKE ?= -j4
unrelated change
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40367?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I867433c87c6da2f0d1f299245aedf4830acbf539
Gerrit-Change-Number: 40367
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 24 May 2025 08:53:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40366?usp=email )
Change subject: library: Introduce NGAP Emulation
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File library/NGAP_Functions.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40366/comment/f9968865_7415… :
PS1, Line 3: 2019 by Harald Welte
Did Harald really write this code?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40366/comment/714edbc8_743e… :
PS1, Line 20: f_NGAP_get_AMF_UE_NGAP_ID
Looks like WIP code? Returning `omit` in all cases does not look useful?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40366?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5aea8be12c54cf907e71bffe6456efb5e60eb203
Gerrit-Change-Number: 40366
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 24 May 2025 08:47:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40364?usp=email )
Change subject: NGAP_Templates: Fix criticality of PLMNSupportList IE in NGSetupResponse
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40364?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0e73a97201e61a41ce5b056a149e185582ed187c
Gerrit-Change-Number: 40364
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 24 May 2025 08:39:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40363?usp=email )
Change subject: ngap: NGAP_Pixits: fix modulepar without default value assigned to template
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File library/ngap/NGAP_Pixits.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40363/comment/294db324_eb84… :
PS1, Line 356: PX_NEXT_HOP_NH
Maybe do `oct2bin()` to make it shorter? Not critical.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40363?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib2410457d2b25f09134509b618b079b010e6ace0
Gerrit-Change-Number: 40363
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 24 May 2025 08:39:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes