- gerrit-log - lists.osmocom.org

[S] Change in osmo-dev[master]: gen_makefile: use args.url, args.push_url directly
by osmith 26 May '25

26 May '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/40352?usp=email ) Change subject: gen_makefile: use args.url, args.push_url directly ...................................................................... gen_makefile: use args.url, args.push_url directly Change-Id: If878694d4c8477140b69b3c15dd65a4d9d28b1e3 --- M gen_makefile.py 1 file changed, 5 insertions(+), 9 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/gen_makefile.py b/gen_makefile.py index db82c8f..02ac203 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -178,7 +178,7 @@ return {} return dict(read_projects_deps(path)) -def gen_makefile_clone(proj, src, src_proj, url, push_url, update_src_copy_cmd): +def gen_makefile_clone(proj, src, src_proj, update_src_copy_cmd): if proj == "osmocom-bb_layer23": return f''' .make.{proj}.clone: .make.osmocom-bb.clone @@ -219,8 +219,8 @@ url = projects_urls[proj] cmd_set_push_url = "true" else: - url = f"{url}/{proj}" - push_url = f"{push_url}/{proj}" + url = f"{args.url}/{proj}" + push_url = f"{args.push_url or args.url}/{proj}" cmd_set_push_url = f'git -C "{src}/{proj}" remote set-url --push origin "{push_url}"' cmd_clone = f'git -C {src} clone --recurse-submodules "{url}" "{proj}"' @@ -440,7 +440,7 @@ return src_proj return os.path.join(make_dir, "src_copy", proj) -def gen_make(proj, deps, configure_opts, make_dir, src_dir, build_dir, url, push_url, sudo_make_install, no_ldconfig, ldconfig_without_sudo, make_check): +def gen_make(proj, deps, configure_opts, make_dir, src_dir, build_dir, sudo_make_install, no_ldconfig, ldconfig_without_sudo, make_check): src_proj = os.path.join(src_dir, proj) src_proj_copy = gen_src_proj_copy(src_proj, make_dir, proj) @@ -448,8 +448,6 @@ build_to_src = os.path.relpath(src_proj_copy, build_proj) build_proj = os.path.relpath(build_proj, make_dir) - push_url = push_url or url - if configure_opts: configure_opts_str = ' '.join(configure_opts) else: @@ -488,8 +486,6 @@ {gen_makefile_clone(proj, src_dir, src_proj, - url, - push_url, update_src_copy_cmd)} {gen_makefile_autoconf(proj, @@ -690,7 +686,7 @@ all_config_opts.extend(configure_opts.get('ALL') or []) all_config_opts.extend(configure_opts.get(proj) or []) content += gen_make(proj, deps, all_config_opts, - make_dir, src_dir, build_dir, args.url, args.push_url, + make_dir, src_dir, build_dir, args.sudo_make_install, args.no_ldconfig, args.ldconfig_without_sudo, args.make_check) -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40352?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: If878694d4c8477140b69b3c15dd65a4d9d28b1e3 Gerrit-Change-Number: 40352 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-dev[master]: gen_makefile: use args.jobs directly
by osmith 26 May '25

26 May '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/40351?usp=email ) Change subject: gen_makefile: use args.jobs directly ...................................................................... gen_makefile: use args.jobs directly Make the code easier to follow by not passing unmodified or slightly modified argparse parameters as function arguments through multiple functions. Access them from "args" directly. The following patches make similar adjustments for other parameters. Change-Id: I49d340fdc47e66a9419dbc27f40774c1307f9526 --- M gen_makefile.py 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/gen_makefile.py b/gen_makefile.py index 550c722..db82c8f 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -308,7 +308,7 @@ else: assert False, f"unknown buildsystem: {buildsystem}" -def gen_makefile_build(proj, distclean_cond, build_proj, docker_cmd, jobs, +def gen_makefile_build(proj, distclean_cond, build_proj, docker_cmd, check, src_proj, update_src_copy_cmd): buildsystem = projects_buildsystems.get(proj, "autotools") @@ -318,7 +318,7 @@ if {distclean_cond}; then $(MAKE) {proj}-distclean .make.{proj}.configure; fi @echo "\\n\\n\\n===== $@\\n" {update_src_copy_cmd} - {docker_cmd}$(MAKE) -C {build_proj} -j {jobs} {check} + {docker_cmd}$(MAKE) -C {build_proj} -j {args.jobs} {check} sync touch $@ ''' @@ -330,7 +330,7 @@ return f''' .make.{proj}.build: .make.{proj}.configure $({proj}_files) @echo "\\n\\n\\n===== $@\\n" - {docker_cmd}meson compile -C {build_proj} -j {jobs} + {docker_cmd}meson compile -C {build_proj} -j {args.jobs} {test_line} sync touch $@ @@ -440,7 +440,7 @@ return src_proj return os.path.join(make_dir, "src_copy", proj) -def gen_make(proj, deps, configure_opts, jobs, make_dir, src_dir, build_dir, url, push_url, sudo_make_install, no_ldconfig, ldconfig_without_sudo, make_check): +def gen_make(proj, deps, configure_opts, make_dir, src_dir, build_dir, url, push_url, sudo_make_install, no_ldconfig, ldconfig_without_sudo, make_check): src_proj = os.path.join(src_dir, proj) src_proj_copy = gen_src_proj_copy(src_proj, make_dir, proj) @@ -512,7 +512,6 @@ distclean_cond, build_proj, docker_cmd, - jobs, check, src_proj_copy, update_src_copy_cmd)} @@ -690,7 +689,7 @@ all_config_opts = [] all_config_opts.extend(configure_opts.get('ALL') or []) all_config_opts.extend(configure_opts.get(proj) or []) - content += gen_make(proj, deps, all_config_opts, args.jobs, + content += gen_make(proj, deps, all_config_opts, make_dir, src_dir, build_dir, args.url, args.push_url, args.sudo_make_install, args.no_ldconfig, args.ldconfig_without_sudo, args.make_check) -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40351?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I49d340fdc47e66a9419dbc27f40774c1307f9526 Gerrit-Change-Number: 40351 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-dev[master]: gen_makefile: use more args vars directly
by osmith 26 May '25

26 May '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/40353?usp=email ) Change subject: gen_makefile: use more args vars directly ...................................................................... gen_makefile: use more args vars directly Use args.no_ldconfig, args.sudo_ldconfig, args.sudo_make_install directly. Change-Id: I050714163bddeb17351f373ea7dd2ffdfa9a0bb5 --- M gen_makefile.py 1 file changed, 9 insertions(+), 15 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/gen_makefile.py b/gen_makefile.py index 02ac203..08d450a 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -349,8 +349,10 @@ else: assert False, f"unknown buildsystem: {buildsystem}" -def gen_makefile_install(proj, docker_cmd, sudo_make_install, build_proj, - no_ldconfig, sudo_ldconfig): +def gen_makefile_install(proj, docker_cmd, build_proj): + no_ldconfig = '#' if args.no_ldconfig else '' + sudo_ldconfig = '' if args.ldconfig_without_sudo else 'sudo ' + sudo_make_install = "sudo " if args.sudo_make_install else "" buildsystem = projects_buildsystems.get(proj, "autotools") if buildsystem == "autotools": return f''' @@ -383,8 +385,8 @@ else: assert False, f"unknown buildsystem: {buildsystem}" -def gen_makefile_reinstall(proj, deps_reinstall, sudo_make_install, - build_proj): +def gen_makefile_reinstall(proj, deps_reinstall, build_proj): + sudo_make_install = "sudo " if args.sudo_make_install else "" return f''' .PHONY: {proj}-reinstall {proj}-reinstall: {deps_reinstall} @@ -440,7 +442,7 @@ return src_proj return os.path.join(make_dir, "src_copy", proj) -def gen_make(proj, deps, configure_opts, make_dir, src_dir, build_dir, sudo_make_install, no_ldconfig, ldconfig_without_sudo, make_check): +def gen_make(proj, deps, configure_opts, make_dir, src_dir, build_dir, make_check): src_proj = os.path.join(src_dir, proj) src_proj_copy = gen_src_proj_copy(src_proj, make_dir, proj) @@ -459,9 +461,6 @@ cflags = 'CFLAGS=-g ' if args.build_debug else '' docker_cmd = f'OSMODEV_PROJECT={proj} {args.docker_cmd} ' if args.docker_cmd else '' check = 'check' if make_check else '' - no_ldconfig = '#' if no_ldconfig else '' - sudo_ldconfig = '' if ldconfig_without_sudo else 'sudo ' - sudo_make_install = 'sudo ' if sudo_make_install else '' update_src_copy_cmd = gen_update_src_copy_cmd(proj, src_dir, make_dir) return f''' @@ -514,14 +513,10 @@ {gen_makefile_install(proj, docker_cmd, - sudo_make_install, - build_proj, - no_ldconfig, - sudo_ldconfig)} + build_proj)} {gen_makefile_reinstall(proj, deps_reinstall, - sudo_make_install, build_proj)} {gen_makefile_clean(proj, build_proj)} @@ -687,8 +682,7 @@ all_config_opts.extend(configure_opts.get(proj) or []) content += gen_make(proj, deps, all_config_opts, make_dir, src_dir, build_dir, - args.sudo_make_install, args.no_ldconfig, - args.ldconfig_without_sudo, args.make_check) + args.make_check) # Replace spaces with tabs to avoid the common pitfall of inserting spaces # instead of tabs by accident into the Makefile (as the python code is indented -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40353?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I050714163bddeb17351f373ea7dd2ffdfa9a0bb5 Gerrit-Change-Number: 40353 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-dev[master]: gen_makefile: remove --auto-distclean parameter
by osmith 26 May '25

26 May '25

Attention is currently required from: neels. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/40355?usp=email ) Change subject: gen_makefile: remove --auto-distclean parameter ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40355?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I28378e6d2cafd209adcfae6b85a032d73ed14cce Gerrit-Change-Number: 40355 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 May 2025 07:08:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-dev[master]: gen_makefile: remove openbsc support
by osmith 26 May '25

26 May '25

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/40350?usp=email ) Change subject: gen_makefile: remove openbsc support ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40350?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ia375e32d2e5e9f9d55568b9393b6935c647ec9d0 Gerrit-Change-Number: 40350 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 May 2025 07:08:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo-s1gw[master]: debian: drop unneeded libpcap-dev
by fixeria 25 May '25

25 May '25

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40348?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: debian: drop unneeded libpcap-dev ...................................................................... debian: drop unneeded libpcap-dev Change-Id: I4c152b6f5f517acccfe4aa856447c59eb1212707 --- M debian/control 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/48/40348/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40348?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I4c152b6f5f517acccfe4aa856447c59eb1212707 Gerrit-Change-Number: 40348 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: parse and store Global-ENB-ID IE
by fixeria 25 May '25

25 May '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40368?usp=email ) Change subject: s1ap_proxy: parse and store Global-ENB-ID IE ...................................................................... s1ap_proxy: parse and store Global-ENB-ID IE This commit prepares for a follow-up change implementing the NFT-based KPI (GTP-U packets/bytes stats) reporting, which will need the Global-ENB-ID. Change-Id: Icc24d4daf06d161d7b5b386456e8e92ac07d5eba Related: SYS#7307 --- M src/s1ap_proxy.erl 1 file changed, 56 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/68/40368/1 diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl index 774fc66..bf5f849 100644 --- a/src/s1ap_proxy.erl +++ b/src/s1ap_proxy.erl @@ -67,8 +67,12 @@ -type enb_ue_id() :: 0..16#ffffff. -type erab_id() :: 0..16#ff. -type erab_uid() :: {mme_ue_id(), enb_ue_id(), erab_id()}. +-type plmn_id() :: {MCC :: nonempty_string(), + MNC :: nonempty_string()}. -record(proxy_state, {erabs :: dict:dict(), + enb_id :: undefined | non_neg_integer(), + plmn_id :: undefined | plmn_id(), mme_ue_id :: undefined | mme_ue_id(), enb_ue_id :: undefined | enb_ue_id(), erab_id :: undefined | erab_id(), @@ -195,6 +199,35 @@ ok. +%% Parse PLMN-ID as per 3GPP TS 24.008, Figure 10.5.13 +%% | MCC digit 2 | MCC digit 1 | octet 1 +%% | MNC digit 3 | MCC digit 3 | octet 2 +%% | MNC digit 2 | MNC digit 1 | octet 3 +-spec parse_plmn_id(<< _:24 >>) -> plmn_id(). +parse_plmn_id(<< MCC2:4, MCC1:4, + MNC3:4, MCC3:4, + MNC2:4, MNC1:4 >>) -> + MCC = parse_mcc_mnc(MCC1, MCC2, MCC3), + MNC = parse_mcc_mnc(MNC1, MNC2, MNC3), + {MCC, MNC}. + + +-define(UNHEX(H), H + 48). + +parse_mcc_mnc(D1, D2, 16#f) -> + [?UNHEX(D1), ?UNHEX(D2)]; + +parse_mcc_mnc(D1, D2, D3) -> + [?UNHEX(D1), ?UNHEX(D2), ?UNHEX(D3)]. + + +-spec parse_enb_id(tuple()) -> non_neg_integer(). +parse_enb_id({'macroENB-ID', << ID:20 >>}) -> ID; +parse_enb_id({'homeENB-ID', << ID:28 >>}) -> ID; +parse_enb_id({'short-macroENB-ID', << ID:18 >>}) -> ID; +parse_enb_id({'long-macroENB-ID', << ID:21 >>}) -> ID. + + %% Encode an S1AP PDU -spec encode_pdu(s1ap_pdu()) -> {ok, binary()} | {error, {asn1, tuple()}}. @@ -260,6 +293,17 @@ -spec handle_pdu(s1ap_pdu(), proxy_state()) -> {{proxy_action(), s1ap_pdu()}, proxy_state()} | {forward, proxy_state()}. +%% 9.1.8.4 S1 SETUP REQUEST +handle_pdu({initiatingMessage, + #'InitiatingMessage'{procedureCode = ?'id-S1Setup', + value = C0}}, S0) -> + ?LOG_DEBUG("Processing S1 SETUP REQUEST"), + %% there's nothing to patch in this PDU, so we forward it as-is + %% TODO: check result of handle_ies(), inc. ?S1GW_CTR_S1AP_PROXY_IN_PKT_PROC_ERROR + {_, S1} = handle_ies(?'id-Global-ENB-ID', + C0#'S1SetupRequest'.protocolIEs, S0), + {forward, S1}; + %% 9.1.3.1 E-RAB SETUP REQUEST handle_pdu({Outcome = initiatingMessage, #'InitiatingMessage'{procedureCode = ?'id-E-RABSetup', @@ -538,6 +582,18 @@ Result :: {handle_ie_result(), proxy_state()}. +handle_ie([?'id-Global-ENB-ID'], + #'Global-ENB-ID'{'pLMNidentity' = PLMNId, + 'eNB-ID' = ENBId} = C, S0) -> + %% store PLMNId/ENBId + %% TODO: use that as a context for logging + S1 = S0#proxy_state{plmn_id = parse_plmn_id(PLMNId), + enb_id = parse_enb_id(ENBId)}, + ?LOG_INFO("Global-ENB-ID: PLMN-ID=~p, eNB-ID=~p", + [S1#proxy_state.plmn_id, + S1#proxy_state.enb_id]), + {{ok, C}, S1}; + %% E-RAB SETUP REQUEST related IEs handle_ie([?'id-E-RABToBeSetupListBearerSUReq'], C, S) -> %% This IE contains a list of BearerSUReq, so patch inner IEs -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40368?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Icc24d4daf06d161d7b5b386456e8e92ac07d5eba Gerrit-Change-Number: 40368 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: ngap: NGAP_Pixits: fix modulepar without default value assigned to te...
by pespin 24 May '25

24 May '25

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40363?usp=email ) Change subject: ngap: NGAP_Pixits: fix modulepar without default value assigned to template ...................................................................... Patch Set 1: (1 comment) File library/ngap/NGAP_Pixits.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40363/comment/7bc96c57_673f… : PS1, Line 356: PX_NEXT_HOP_NH > Maybe do `oct2bin()` to make it shorter? Not critical. This file will most probably end up going completely away as we adapt more and more the templates to our needs. But I belive it makes sense to do that step by step in the git repo. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40363?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib2410457d2b25f09134509b618b079b010e6ace0 Gerrit-Change-Number: 40363 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 24 May 2025 21:57:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[L] Change in osmo-ttcn3-hacks[master]: library: Introduce NGAP Emulation
by fixeria 24 May '25

24 May '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40366?usp=email ) Change subject: library: Introduce NGAP Emulation ...................................................................... Patch Set 1: (1 comment) File library/NGAP_Emulation.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40366/comment/31650cf4_ed3a… : PS1, Line 408: 18 Your PR to wireshark.git (https://gitlab.com/wireshark/wireshark/-/merge_requests/19954/diffs) corrects 18 to 60, so `ppid` should be 60 here too? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40366?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5aea8be12c54cf907e71bffe6456efb5e60eb203 Gerrit-Change-Number: 40366 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 24 May 2025 09:17:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-sigtran[master]: asp: Avoid double-free of received msg if conn is teared down
by fixeria 24 May '25

24 May '25

Attention is currently required from: daniel, laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40327?usp=email ) Change subject: asp: Avoid double-free of received msg if conn is teared down ...................................................................... Patch Set 2: (3 comments) Patchset: PS2: This looks very similar to https://osmocom.org/issues/6728 (use-after-free/double-free in osmo-bts). If this is it, in how may other places do we have to do `talloc_steal()` before we finally agree on fixing the root problem? File src/ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40327/comment/d7ce0d58_ef639… : PS2, Line 884: msg being is by What do you mean here? Is owned by iofd? https://gerrit.osmocom.org/c/libosmo-sigtran/+/40327/comment/6ed4298c_d4a50… : PS2, Line 885: which may be automatically may be what? free()d? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40327?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I69f80f611c14db2b328dafd4a90247c6f2dac6fd Gerrit-Change-Number: 40327 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sat, 24 May 2025 09:03:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log