- gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: 5gc: Implement PDU Session Release procedure
by pespin 30 Jul '25

30 Jul '25

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40779?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: 5gc: Implement PDU Session Release procedure ...................................................................... 5gc: Implement PDU Session Release procedure Related: SYS#7073 Change-Id: If79cb0c97008e7a9885bb548a3d2e67e41ba170f --- M 5gc/C5G_Tests.ttcn M 5gc/ConnHdlr.ttcn M library/NGAP_Functions.ttcn M library/NG_NAS_Functions.ttcn M library/NG_NAS_Osmo_Templates.ttcn M library/NG_NAS_Osmo_Types.ttcn 6 files changed, 181 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/79/40779/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40779?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If79cb0c97008e7a9885bb548a3d2e67e41ba170f Gerrit-Change-Number: 40779 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[S] Change in libosmocore[master]: Add environment variable to set io_uring size
by pespin 30 Jul '25

30 Jul '25

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40782?usp=email ) Change subject: Add environment variable to set io_uring size ...................................................................... Patch Set 1: (1 comment) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40782/comment/0ae1a020_86840992?… : PS1, Line 111: g_io_uring_size = atoi(env); > This should be parsed with osmo_str_to_int() to make sure we don't use some weird value as a result […] Ohn, and BTW, make sure g_io_uring_size is not assigned value 0 ;) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40782?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I55289d9282e13aa1bf82f3931c85c196752f1484 Gerrit-Change-Number: 40782 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 30 Jul 2025 11:53:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: Add multiple messages buffers to io_uring read operations
by pespin 30 Jul '25

30 Jul '25

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40492?usp=email ) Change subject: Add multiple messages buffers to io_uring read operations ...................................................................... Patch Set 9: (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/7cebbbfc_1370f5b5?… : PS9, Line 166: if (idx == 0) { > the idea is to have keep the msgb buffers we could allocate. (in case of memory allocation problems. […] Ok, then please explain the intended behavior with a comment to make it clear to the user/reader, something like: "If we could obtain at least one mgb, carry on with it in best-effort instead of completelly failing" -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40492?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic4544b8fcbad5a266db748d6864d3ae93ee06bce Gerrit-Change-Number: 40492 Gerrit-PatchSet: 9 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 30 Jul 2025 11:51:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: Add multiple messages buffers to io_uring read operations
by jolly 30 Jul '25

30 Jul '25

Attention is currently required from: pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40492?usp=email ) Change subject: Add multiple messages buffers to io_uring read operations ...................................................................... Patch Set 9: (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/e05454a0_e5cc1d8d?… : PS9, Line 166: if (idx == 0) { > shouldn't this be "if (idx != io_len)" ? the idea is to have keep the msgb buffers we could allocate. (in case of memory allocation problems.) if we could not allocate any buffer, we free our msghdr and return NULL. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40492?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic4544b8fcbad5a266db748d6864d3ae93ee06bce Gerrit-Change-Number: 40492 Gerrit-PatchSet: 9 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Jul 2025 11:46:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in docker-playground[master]: Revert "ttcn3-bts-test: do not use respawn.sh"
by osmith 30 Jul '25

30 Jul '25

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/docker-playground/+/40783?usp=email ) Change subject: Revert "ttcn3-bts-test: do not use respawn.sh" ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40783?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1177e9068c49bf31a4010cd21700839dfa8d5050 Gerrit-Change-Number: 40783 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Jul 2025 11:44:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in docker-playground[master]: ttcn3-bts-test: show respawn count at the end
by pespin 30 Jul '25

30 Jul '25

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/40784?usp=email ) Change subject: ttcn3-bts-test: show respawn count at the end ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4e5c3dd46ec682bfd79f2328195b0050fe3f186d Gerrit-Change-Number: 40784 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Jul 2025 11:44:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in docker-playground[master]: Revert "ttcn3-bts-test: do not use respawn.sh"
by pespin 30 Jul '25

30 Jul '25

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/docker-playground/+/40783?usp=email ) Change subject: Revert "ttcn3-bts-test: do not use respawn.sh" ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40783?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1177e9068c49bf31a4010cd21700839dfa8d5050 Gerrit-Change-Number: 40783 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Jul 2025 11:43:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmocore[master]: Automatically increase io_uring, if too small.
by pespin 30 Jul '25

30 Jul '25

Attention is currently required from: jolly, laforge. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email ) Change subject: Automatically increase io_uring, if too small. ...................................................................... Patch Set 6: (7 comments) Patchset: PS6: Due to the comments I wrote I still personally believe this is shooting us in the foot, it's not the best approach and that we should instead at least first try to write a patch where we keep "iofds waiting to get an SQE" in a llist if getting an sqe fails. Then, when we receive a "op complete" event, we iterate over the llist to try to get sqes for those again. File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/df1bd146_19aa76bb?… : PS6, Line 116: /* ! array of rings the submitted read SQEs have been submitted */ "have been submitted to" File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/4a7bb479_e63ce609?… : PS6, Line 115: g_ring = calloc(1, sizeof(*g_ring)); use talloc. https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/16e4f1cb_10686776?… : PS6, Line 164: LOGP(DLIO, LOGL_NOTICE, "increasing io_uring size to %d.\n", g_io_uring_size); Please put this into 1 single LOGP. https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/80ee0ddc_530c1847?… : PS6, Line 172: sqe = io_uring_get_sqe(&g_ring->ring); so here we end up with 2 read SQEs on 2 different queues. How do we now we receive the read completion events in correct order? Which API guarantees that? https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/1bb55483_4e6c40ad?… : PS6, Line 527: while ((sqe = io_uring_get_sqe(iofd->u.uring.read_ring[idx])) == NULL); that looks like a really nice tight non-blocking loop filling the CPU? https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/f000786a_eb273a43?… : PS6, Line 543: while ((sqe = io_uring_get_sqe(iofd->u.uring.write_ring)) == NULL); that looks like a really nice tight non-blocking loop filling the CPU? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id9230146acc8d54bfd44834e783c31b37bd64bca Gerrit-Change-Number: 40725 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 30 Jul 2025 11:43:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in docker-playground[master]: ttcn3-bts-test: show respawn count at the end
by osmith 30 Jul '25

30 Jul '25

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/40784?usp=email ) Change subject: ttcn3-bts-test: show respawn count at the end ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I'm testing that this works as expected before merge https://jenkins.osmocom.org/jenkins/job/ttcn3-bts-test/2848/console -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4e5c3dd46ec682bfd79f2328195b0050fe3f186d Gerrit-Change-Number: 40784 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 30 Jul 2025 11:34:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: Add environment variable to set io_uring size
by pespin 30 Jul '25

30 Jul '25

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40782?usp=email ) Change subject: Add environment variable to set io_uring size ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40782/comment/647fac25_0e0488e0?… : PS1, Line 111: g_io_uring_size = atoi(env); This should be parsed with osmo_str_to_int() to make sure we don't use some weird value as a result from a typo from the user. If parsing as a number fails, then call osmo_panic(). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40782?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I55289d9282e13aa1bf82f3931c85c196752f1484 Gerrit-Change-Number: 40782 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 30 Jul 2025 11:32:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log