- gerrit-log - lists.osmocom.org

[S] Change in osmo-uecups[master]: gtp_endpoint: Avoid deadlocks logging while thread is cancelled
by pespin 30 Jul '25

30 Jul '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-uecups/+/40788?usp=email ) Change subject: gtp_endpoint: Avoid deadlocks logging while thread is cancelled ...................................................................... gtp_endpoint: Avoid deadlocks logging while thread is cancelled We cannot garantee that LOGP will not end up calling a syscall which can be a cancellation point. Since the syscall will be probably called while having the logging mutex locked, an eventual cancellation of the thread would leave the logging mutex locked forever, hence making all other threads deadlock as soon as they try to write anything to the log. Similar to what's already done in tun_device_thread(). Change-Id: I1e141175440402a7db34f3d246104c6ea38031fb --- M daemon/gtp_endpoint.c 1 file changed, 23 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-uecups refs/changes/88/40788/1 diff --git a/daemon/gtp_endpoint.c b/daemon/gtp_endpoint.c index bb417da..08c0f44 100644 --- a/daemon/gtp_endpoint.c +++ b/daemon/gtp_endpoint.c @@ -36,27 +36,36 @@ int rc, outfd; uint32_t teid; uint16_t gtp_len; + int old_cancelst_unused; if (nread < sizeof(*gtph)) { + pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_cancelst_unused); LOGEP(ep, LOGL_NOTICE, "Short read: %u < %lu\n", nread, sizeof(*gtph)); + pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, &old_cancelst_unused); return; } gtph = (struct gtp1_header *)buffer; /* check GTP header contents */ if ((gtph->flags & 0xf0) != 0x30) { + pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_cancelst_unused); LOGEP(ep, LOGL_NOTICE, "Unexpected GTP Flags: 0x%02x\n", gtph->flags); + pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, &old_cancelst_unused); return; } if (gtph->type != GTP_TPDU) { + pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_cancelst_unused); LOGEP(ep, LOGL_NOTICE, "Unexpected GTP Message Type: 0x%02x\n", gtph->type); + pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, &old_cancelst_unused); return; } gtp_len = ntohs(gtph->length); if (sizeof(*gtph)+gtp_len > nread) { + pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_cancelst_unused); LOGEP(ep, LOGL_NOTICE, "Short GTP Message: %lu < len=%u\n", sizeof(*gtph)+gtp_len, nread); + pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, &old_cancelst_unused); return; } teid = ntohl(gtph->tid); @@ -65,8 +74,10 @@ if (gtph->flags & GTP1_F_MASK) { const struct gtp1_exthdr *exthdr = (const struct gtp1_exthdr *)payload; if (gtp_len < 4) { + pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_cancelst_unused); LOGEP(ep, LOGL_NOTICE, "Short GTP Message according to flags 0x%02x: %lu < len=%u\n", gtph->flags, sizeof(*gtph) + gtp_len, nread); + pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, &old_cancelst_unused); return; } gtp_len -= 4; @@ -77,12 +88,14 @@ if (gtp_len < 1) { LOGEP(ep, LOGL_NOTICE, "Short GTP Message according to flags 0x%02x: %lu < len=%u\n", gtph->flags, sizeof(*gtph) + gtp_len, nread); + pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, &old_cancelst_unused); return; } ext_len = 1 + 1 + it[1] + 1; if (gtp_len < ext_len) { LOGEP(ep, LOGL_NOTICE, "Short GTP Message according to flags 0x%02x: %lu < len=%u\n", gtph->flags, sizeof(*gtph) + gtp_len, nread); + pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, &old_cancelst_unused); return; } gtp_len -= ext_len; @@ -96,7 +109,9 @@ t = _gtp_tunnel_find_r(d, teid, ep); if (!t) { pthread_rwlock_unlock(&d->rwlock); + pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_cancelst_unused); LOGEP(ep, LOGL_NOTICE, "Unable to find tunnel for TEID=0x%08x\n", teid); + pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, &old_cancelst_unused); return; } outfd = t->tun_dev->fd; @@ -105,16 +120,21 @@ /* 3) write to TUN device */ rc = write(outfd, payload, gtp_len); if (rc < gtp_len) { + pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_cancelst_unused); LOGEP(ep, LOGL_FATAL, "Error writing to tun device %s\n", strerror(errno)); exit(1); } } -/* one thread for reading from each GTP/UDP socket (GTP decapsulation -> tun) */ +/* one thread for reading from each GTP/UDP socket (GTP decapsulation -> tun) + * IMPORTANT!: All logging functions in this function block must be called with + * PTHREAD_CANCEL_DISABLE set, otherwise the thread could be cancelled while + * holding the logging mutex, hence causing deadlock with main (or other) + * thread. */ static void *gtp_endpoint_thread(void *arg) { struct gtp_endpoint *ep = (struct gtp_endpoint *)arg; - + int old_cancelst_unused; uint8_t buffer[sizeof(struct gtp1_header) + sizeof(struct gtp1_exthdr) + MAX_UDP_PACKET]; while (1) { @@ -123,6 +143,7 @@ /* 1) read GTP packet from UDP socket */ rc = recvfrom(ep->fd, buffer, sizeof(buffer), 0, (struct sockaddr *)NULL, 0); if (rc < 0) { + pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_cancelst_unused); LOGEP(ep, LOGL_FATAL, "Error reading from UDP socket: %s\n", strerror(errno)); exit(1); } -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40788?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I1e141175440402a7db34f3d246104c6ea38031fb Gerrit-Change-Number: 40788 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: 5gc: Implement PDU Session Release procedure
by pespin 30 Jul '25

30 Jul '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40779?usp=email ) Change subject: 5gc: Implement PDU Session Release procedure ...................................................................... Patch Set 2: (1 comment) File 5gc/ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40779/comment/b0ec2e44_f6b1… : PS1, Line 479: } > TODO: Tx "PDU session release complete", 3GPP TS 24.501 8.3. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40779?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If79cb0c97008e7a9885bb548a3d2e67e41ba170f Gerrit-Change-Number: 40779 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Jul 2025 16:44:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: library: Comment out debugging for NGAP/5G-NAS
by pespin 30 Jul '25

30 Jul '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40785?usp=email ) Change subject: library: Comment out debugging for NGAP/5G-NAS ...................................................................... library: Comment out debugging for NGAP/5G-NAS The current NGAP and 5G auth code is now working fine, so disable debug logging. Keep it commented out so it can be re-enabled at any time if some related topic needs to be debugged (will eventually happen). Change-Id: I4250766644742f0fd11ca5e24b1a1a581dc81b4b --- M library/NGAP_Emulation.ttcn M library/milenage/milenage.c 2 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/85/40785/1 diff --git a/library/NGAP_Emulation.ttcn b/library/NGAP_Emulation.ttcn index 4cb2f05..9fbaddc 100644 --- a/library/NGAP_Emulation.ttcn +++ b/library/NGAP_Emulation.ttcn @@ -143,7 +143,7 @@ NGapExpectTable[i].amf_id := omit; NGapExpectTable[i].ran_id := omit; NGapExpectTable[i].vc_conn := null; - log("Found Expect[", i, "] for ", msg, " handled at ", ret); + //log("Found Expect[", i, "] for ", msg, " handled at ", ret); return ret; } } @@ -222,18 +222,18 @@ template (omit) RAN_UE_NGAP_ID ran_id) runs on NGAP_Emulation_CT return boolean { var integer i; - log("f_ngap_ids_known(",amf_id,", ",ran_id,")"); + //log("f_ngap_ids_known(",amf_id,", ",ran_id,")"); for (i := 0; i < sizeof(NGapAssociationTable); i := i+1) { - log("tbl[",i,"]: amf=", NGapAssociationTable[i].amf_ue_ngap_id, - ", ran=", NGapAssociationTable[i].ran_ue_ngap_id); + //log("tbl[",i,"]: amf=", NGapAssociationTable[i].amf_ue_ngap_id, + // ", ran=", NGapAssociationTable[i].ran_ue_ngap_id); /* skip empty records */ if (NGapAssociationTable[i].amf_ue_ngap_id == omit and NGapAssociationTable[i].ran_ue_ngap_id == omit) { - log("skipping empty ", i); + //log("skipping empty ", i); continue; } if (NGapAssociationTable[i].amf_ue_ngap_id == omit) { - log("entry ", i, " has no AMF ID yet (ran=", NGapAssociationTable[i].ran_ue_ngap_id); + //log("entry ", i, " has no AMF ID yet (ran=", NGapAssociationTable[i].ran_ue_ngap_id); /* Table doesn't yet know the AMF side ID, let's look-up only * based on the eNB side ID */ if (match(NGapAssociationTable[i].ran_ue_ngap_id, ran_id)) { diff --git a/library/milenage/milenage.c b/library/milenage/milenage.c index d079a3d..f7a6f74 100644 --- a/library/milenage/milenage.c +++ b/library/milenage/milenage.c @@ -90,7 +90,7 @@ return 0; } -#define DEBUG +//#define DEBUG #ifdef DEBUG void hexdump(const char *text, const uint8_t *data, int len) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40785?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4250766644742f0fd11ca5e24b1a1a581dc81b4b Gerrit-Change-Number: 40785 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: 5gc: Introduce test TC_ng_register_ping4_256
by pespin 30 Jul '25

30 Jul '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40786?usp=email ) Change subject: 5gc: Introduce test TC_ng_register_ping4_256 ...................................................................... 5gc: Introduce test TC_ng_register_ping4_256 open5gs-dbctl tool is called in batches of multiple IMSIs to speed up setup, since each call takes fractions of seconds to complete. mongosh called by open5gs-dbctl actually uses quite a lot of CPU and RAM resources, hence limit the amount of parallel runs to a fair amount (eg. running the 256 of them in parallel froze my workstation with 16GB of RAM). Change-Id: I7282fa3c1a474c4b7dceeb5e358547dcdbd1fea6 --- M 5gc/C5G_Tests.ttcn M 5gc/ConnHdlr.ttcn M 5gc/create_test_subscribers.sh M 5gc/expected-results.xml M library/NGAP_Emulation.ttcn 5 files changed, 51 insertions(+), 29 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/86/40786/1 diff --git a/5gc/C5G_Tests.ttcn b/5gc/C5G_Tests.ttcn index 4cda45f..9eb6f30 100644 --- a/5gc/C5G_Tests.ttcn +++ b/5gc/C5G_Tests.ttcn @@ -49,9 +49,6 @@ import from ConnHdlr all; -/* (maximum) number of emulated UEs */ -const integer NUM_UE := 1; - modulepar { /* NG-C interface */ charstring mp_5gc_ngap_ip := "127.0.0.1"; @@ -81,16 +78,17 @@ ping_hostname := mp_ping_hostname } -template (value) UeParams ts_UeParams(integer imsi_suffix) := +template (value) UeParams ts_UeParams(integer idx) := { - imsi := f_concat_pad(lengthof(mp_imsi), substr(mp_imsi, 0, lengthof(mp_imsi) - 6), imsi_suffix), + idx := idx, + imsi := f_concat_pad(lengthof(mp_imsi), substr(mp_imsi, 0, lengthof(mp_imsi) - 6), idx), imeisv := f_rnd_imeisv(), usim_key := mp_usim_key, usim_opc := mp_usim_opc, apn := mp_apn, - run_prog_pars := ts_RunProgParams(imsi_suffix), + run_prog_pars := ts_RunProgParams(idx), ran_gtpu_ip := mp_local_gtpu_ip, - ran_gtpu_teid := int2oct(imsi_suffix + 1, 4), + ran_gtpu_teid := int2oct(idx + 1, 4), cn_gtpu_ip := omit, cn_gtpu_teid := omit, qfi := omit, @@ -108,8 +106,6 @@ port GTP1UEM_PT TEID0; timer g_Tguard := 30.0; - - var UeParams g_ue_pars[NUM_UE]; } /* send incoming unit data messages (like reset) to global NGAP_UNIT port */ @@ -156,19 +152,11 @@ NGAP_UNIT[num].receive(NGAPEM_Event:{up_down:=NGAPEM_EVENT_UP}); } -private function f_init_one_ue(inout UeParams uep, integer imsi_suffix) { - - uep := valueof(ts_UeParams(imsi_suffix)); -} - private function f_init_ngap(integer imsi_suffix := 0) runs on MTC_CT { var integer i; for (i := 0; i < NUM_NGRAN; i := i+1) { f_init_one_ngran(i); } - for (i := 0; i < NUM_UE; i := i+1) { - f_init_one_ue(g_ue_pars[i], 1000*imsi_suffix + i); - } } private function f_init_gtp1u() runs on MTC_CT { @@ -198,7 +186,7 @@ runs on MTC_CT return ConnHdlrPars { var ConnHdlrPars pars := { ngran_pars := g_ngran_pars, - ue_pars := g_ue_pars[ue_idx], + ue_pars := valueof(ts_UeParams(ue_idx)), c5g_idx := 0, kset_id := valueof(cs_NAS_KeySetIdentifier_lv(tsc_NasKsi_NoKey, '0'B)) }; @@ -329,6 +317,23 @@ vc_conn := f_start_handler_with_pars(refers(f_TC_register_ping4), pars); vc_conn.done; } +testcase TC_ng_register_ping4_256() runs on MTC_CT { + var ConnHdlr vc_conn[256]; + var integer i; + + f_init(); + f_ngap_setup(0); + + for (i := 0; i < sizeof(vc_conn); i := i + 1) { + var ConnHdlrPars pars := f_init_pars(ue_idx := i); + vc_conn[i] := f_start_handler_with_pars(refers(f_TC_register_ping4), pars); + } + + for (i := 0; i < sizeof(vc_conn); i := i + 1) { + vc_conn[i].done; + } +} + control { execute( TC_ng_setup() ); @@ -336,6 +341,7 @@ execute( TC_ng_setup_wrong_tac() ); execute( TC_ng_register() ); execute( TC_ng_register_ping4() ); + execute( TC_ng_register_ping4_256() ); } diff --git a/5gc/ConnHdlr.ttcn b/5gc/ConnHdlr.ttcn index 6c816fe..144b00b 100644 --- a/5gc/ConnHdlr.ttcn +++ b/5gc/ConnHdlr.ttcn @@ -67,6 +67,7 @@ /* parameters of emulated UE */ type record UeParams { + integer idx, HEX15n imsi, HEX16n imeisv, octetstring usim_key, @@ -367,7 +368,7 @@ f_SUCI_IMSI()), p_UESecurityCap := f_UE_SecurityCapability()); nas_pdu := enc_NG_NAS_UL_Message_Type(valueof(nas_ul_msg)); - tx_pdu := m_ngap_initMsg(m_n2_initialUeMessage(g_pars.c5g_idx, + tx_pdu := m_ngap_initMsg(m_n2_initialUeMessage(g_pars.ue_pars.idx, nas_pdu, /* Registration request */ f_ULI(), mo_Signalling)); diff --git a/5gc/create_test_subscribers.sh b/5gc/create_test_subscribers.sh index a400e0f..28a7b6f 100755 --- a/5gc/create_test_subscribers.sh +++ b/5gc/create_test_subscribers.sh @@ -17,11 +17,25 @@ sleep 1 done -# Create a test subscriber with IMSI=001010000000000 -$DBCTL_CMD add 999700000000000 3c6e0b8a9c15224a8228b9a98ca1531d 762a2206fe0b4151ace403c86a11e479 +NUM_SUBCRS=256 +get_subscr_imsi() { + subscr_idx=$1 + printf "999700000000%03u" "$subscr_idx" +} -# Mark test subscriber with IMSI=001010000000001 as: -# Subscriber-Status=OPERATOR_DETERMINED_BARRING (1) -# Operator-Determined-Barring="Barring of all outgoing inter-zonal calls except those directed to the home PLMN country" (7) -$DBCTL_CMD add 999700000000001 3c6e0b8a9c15224a8228b9a98ca1531d 762a2206fe0b4151ace403c86a11e479 -$DBCTL_CMD subscriber_status 999700000000001 1 7 +# Create a test subscriber with IMSI=001010000000000 +DBCTL_PARALLEL_JOBS=20 +idx=0 +while test "$idx" -lt "$NUM_SUBCRS"; do + remain="$((NUM_SUBCRS - idx))" + if test "$remain" -gt "$DBCTL_PARALLEL_JOBS"; then + iterations=$DBCTL_PARALLEL_JOBS + else + iterations=$remain + fi + for it in $(seq "$iterations"); do + $DBCTL_CMD add "$(get_subscr_imsi $idx)" 3c6e0b8a9c15224a8228b9a98ca1531d 762a2206fe0b4151ace403c86a11e479 & + idx=$((idx + 1)) + done + wait $(jobs -p) +done diff --git a/5gc/expected-results.xml b/5gc/expected-results.xml index 01d53a1..98dee58 100644 --- a/5gc/expected-results.xml +++ b/5gc/expected-results.xml @@ -5,4 +5,5 @@ <testcase classname='C5G_Tests' name='TC_ng_setup' time='MASKED'/> <testcase classname='C5G_Tests' name='TC_ng_register' time='MASKED'/> <testcase classname='C5G_Tests' name='TC_ng_register_ping4' time='MASKED'/> + <testcase classname='C5G_Tests' name='TC_ng_register_ping4_256' time='MASKED'/> </testsuite> diff --git a/library/NGAP_Emulation.ttcn b/library/NGAP_Emulation.ttcn index 9fbaddc..1fb571b 100644 --- a/library/NGAP_Emulation.ttcn +++ b/library/NGAP_Emulation.ttcn @@ -168,11 +168,11 @@ * to send where with CLIENT.send() to vc_conn */ port NGAP_Conn_PT NGAP_CLIENT; /* currently tracked connections */ - var AssociationData NGapAssociationTable[16]; + var AssociationData NGapAssociationTable[256]; /* pending expected NGAP Association (UE oriented) */ - var ExpectData NGapExpectTable[8]; + var ExpectData NGapExpectTable[256]; /* pending expected NGAP PDU */ - var ExpectDataProc NGapExpectTableProc[8]; + var ExpectDataProc NGapExpectTableProc[256]; /* procedure based port to register for incoming connections */ port NGAPEM_PROC_PT NGAP_PROC; /* test port for unit data messages */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40786?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7282fa3c1a474c4b7dceeb5e358547dcdbd1fea6 Gerrit-Change-Number: 40786 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: library/ngap: Support passing optional NAS-PDU to PDUSessionResourceR...
by pespin 30 Jul '25

30 Jul '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40778?usp=email ) Change subject: library/ngap: Support passing optional NAS-PDU to PDUSessionResourceReleaseCommand ...................................................................... library/ngap: Support passing optional NAS-PDU to PDUSessionResourceReleaseCommand Change-Id: I5f516f33824a83c0eaeb2c0decd82409b786867e --- M library/ngap/NGAP_Templates.ttcn 1 file changed, 90 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/ngap/NGAP_Templates.ttcn b/library/ngap/NGAP_Templates.ttcn index 85c5e0b..5ffe2a5 100644 --- a/library/ngap/NGAP_Templates.ttcn +++ b/library/ngap/NGAP_Templates.ttcn @@ -324,6 +324,51 @@ } } // End of template m_n2_PDUSessionResourceReleaseCommand + function f_ts_n2_PDUSessionResourceReleaseCommand(template (value) AMF_UE_NGAP_ID p_amfUeNgapID := PX_AMF_UE_NGAP_ID, + template (value) RAN_UE_NGAP_ID p_ranUeNgapID := PX_RAN_UE_NGAP_ID, + template (omit) NAS_PDU p_nAS_PDU, + template (value) PDUSessionResourceToReleaseListRelCmd p_pDUSessionResourceToReleaseListRelCmd) + return template (value) InitiatingMessage { + var template (value) InitiatingMessage pdu := { + procedureCode := id_PDUSessionResourceRelease, + criticality := reject, + value_ := { + PDUSessionResourceReleaseCommand := { + protocolIEs := { + { + id := id_AMF_UE_NGAP_ID, + criticality := reject, + value_ := { AMF_UE_NGAP_ID := p_amfUeNgapID } + }, + { + id := id_RAN_UE_NGAP_ID, + criticality := reject, + value_ := { RAN_UE_NGAP_ID := p_ranUeNgapID } + } + } + } + } + }; + var integer idx := lengthof(pdu.value_.PDUSessionResourceReleaseCommand.protocolIEs); + + if (isvalue(p_nAS_PDU)) { + pdu.value_.PDUSessionResourceReleaseCommand.protocolIEs[idx] := + { + id := id_NAS_PDU, + criticality := ignore, + value_ := { nAS_PDU := p_nAS_PDU } + }; + idx := idx + 1; + } + + pdu.value_.PDUSessionResourceReleaseCommand.protocolIEs[idx] := + { id := id_PDUSessionResourceToReleaseListRelCmd, + criticality := reject, + value_ := { PDUSessionResourceToReleaseListRelCmd := p_pDUSessionResourceToReleaseListRelCmd } + }; + return pdu; + } + } // End of group Send group Receive { @@ -361,6 +406,51 @@ } } // End of template mw_n2_PDUSessionResourceReleaseCommand + function f_tr_n2_PDUSessionResourceReleaseCommand(template (present) AMF_UE_NGAP_ID p_amfUeNgapID := ?, + template (present) RAN_UE_NGAP_ID p_ranUeNgapID := ?, + template NAS_PDU p_nAS_PDU := omit, + template (present) PDUSessionResourceToReleaseListRelCmd p_pDUSessionResourceToReleaseListRelCmd := ?) + return template (present) InitiatingMessage { + var template (present) InitiatingMessage pdu := { + procedureCode := id_PDUSessionResourceRelease, + criticality := reject, + value_ := { + PDUSessionResourceReleaseCommand := { + protocolIEs := { + { + id := id_AMF_UE_NGAP_ID, + criticality := reject, + value_ := { AMF_UE_NGAP_ID := p_amfUeNgapID } + }, + { + id := id_RAN_UE_NGAP_ID, + criticality := reject, + value_ := { RAN_UE_NGAP_ID := p_ranUeNgapID } + } + } + } + } + }; + var integer idx := lengthof(pdu.value_.PDUSessionResourceReleaseCommand.protocolIEs); + + if (not istemplatekind(p_nAS_PDU, "omit")) { + pdu.value_.PDUSessionResourceReleaseCommand.protocolIEs[idx] := + { + id := id_NAS_PDU, + criticality := ignore, + value_ := { nAS_PDU := p_nAS_PDU } + }; + idx := idx + 1; + } + + pdu.value_.PDUSessionResourceReleaseCommand.protocolIEs[idx] := + { id := id_PDUSessionResourceToReleaseListRelCmd, + criticality := reject, + value_ := { PDUSessionResourceToReleaseListRelCmd := p_pDUSessionResourceToReleaseListRelCmd } + }; + return pdu; + } + } // End of group Receive } // End of group PDU_SESSION_RESOURCE_RELEASE_COMMAND -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5f516f33824a83c0eaeb2c0decd82409b786867e Gerrit-Change-Number: 40778 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: library/ngap: Support passing optional NAS-PDU to PDUSessionResourceR...
by pespin 30 Jul '25

30 Jul '25

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40778?usp=email ) Change subject: library/ngap: Support passing optional NAS-PDU to PDUSessionResourceReleaseCommand ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5f516f33824a83c0eaeb2c0decd82409b786867e Gerrit-Change-Number: 40778 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Jul 2025 15:17:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: 5gc: Implement PDU Session Release procedure
by osmith 30 Jul '25

30 Jul '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40779?usp=email ) Change subject: 5gc: Implement PDU Session Release procedure ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40779?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If79cb0c97008e7a9885bb548a3d2e67e41ba170f Gerrit-Change-Number: 40779 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Jul 2025 15:15:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in docker-playground[master]: Revert "ttcn3-bts-test: do not use respawn.sh"
by osmith 30 Jul '25

30 Jul '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/40783?usp=email ) Change subject: Revert "ttcn3-bts-test: do not use respawn.sh" ...................................................................... Revert "ttcn3-bts-test: do not use respawn.sh" This reverts commit 57f680439f378f5bb5c6582297ae0636db6650f8. We're observing a lot of turbulence in ttcn3-bts-test due to the clock instability: Shutting down BTS, exit 1, reason: PC clock skew too high Even though it's no longer necessary to respawn osmo-bts-trx, let's restore the respawn.sh to recover from such failures. Related: OS#6794 Change-Id: I1177e9068c49bf31a4010cd21700839dfa8d5050 --- M ttcn3-bts-test/jenkins.sh 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index edb7030..5d5629d 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -44,6 +44,7 @@ start_bts() { local variant variant="$1" + sleep_time_respawn="$2" echo Starting container with BTS if [ -z "$variant" ]; then echo ERROR: You have to specify a BTS variant @@ -56,10 +57,11 @@ --ulimit core=-1 \ -v $VOL_BASE_DIR/bts:/data \ -v $VOL_BASE_DIR/unix:/data/unix \ + -e "SLEEP_BEFORE_RESPAWN=$sleep_time_respawn" \ --name ${BUILD_TAG}-bts -d \ $DOCKER_ARGS \ $REPO_USER/osmo-bts-$IMAGE_SUFFIX \ - /bin/sh -c "osmo-bts-$variant -c /data/osmo-bts.gen.cfg >>/data/osmo-bts.log 2>&1" + /bin/sh -c "/usr/local/bin/respawn.sh osmo-bts-$variant -c /data/osmo-bts.gen.cfg >>/data/osmo-bts.log 2>&1" } start_fake_trx() { -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40783?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1177e9068c49bf31a4010cd21700839dfa8d5050 Gerrit-Change-Number: 40783 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: NGAP_Functions.ttcn: Fix wrong offset of NGAP_ID_pair in uEContextRel...
by osmith 30 Jul '25

30 Jul '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40780?usp=email ) Change subject: NGAP_Functions.ttcn: Fix wrong offset of NGAP_ID_pair in uEContextReleaseCommand ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40780?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2302bebf75530f574a7fe2647b1eafcc4d5fd7df Gerrit-Change-Number: 40780 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Jul 2025 15:10:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: library/ngap: Support passing optional NAS-PDU to PDUSessionResourceR...
by osmith 30 Jul '25

30 Jul '25

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40778?usp=email ) Change subject: library/ngap: Support passing optional NAS-PDU to PDUSessionResourceReleaseCommand ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5f516f33824a83c0eaeb2c0decd82409b786867e Gerrit-Change-Number: 40778 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Jul 2025 15:08:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log