- gerrit-log - lists.osmocom.org

[M] Change in osmo-uecups[master]: cups_client: Use new iofd stream_srv APIs
by pespin 31 Jul '25

31 Jul '25

Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-uecups/+/40796?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: cups_client: Use new iofd stream_srv APIs ...................................................................... cups_client: Use new iofd stream_srv APIs Related: OS#6823 Change-Id: Ie9f127e82e39ad0b5cae83f870b678ba1800ded4 --- M daemon/cups_client.c 1 file changed, 35 insertions(+), 36 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-uecups refs/changes/96/40796/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: Ie9f127e82e39ad0b5cae83f870b678ba1800ded4 Gerrit-Change-Number: 40796 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-uecups[master]: cups_client: Fix memleak during conn closed
by pespin 31 Jul '25

31 Jul '25

Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-uecups/+/40795?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: cups_client: Fix memleak during conn closed ...................................................................... cups_client: Fix memleak during conn closed Change-Id: Ic4d4da7ecbf5a7903a46558482b66cdc22767c4b --- M daemon/cups_client.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-uecups refs/changes/95/40795/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40795?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: Ic4d4da7ecbf5a7903a46558482b66cdc22767c4b Gerrit-Change-Number: 40795 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-uecups[master]: Set thread names
by pespin 31 Jul '25

31 Jul '25

Attention is currently required from: fixeria, laforge, osmith, pespin. Hello Jenkins Builder, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-uecups/+/40789?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by osmith, Code-Review+2 by fixeria, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: Set thread names ...................................................................... Set thread names Change-Id: I9b44dd9eeb1d8e291c35d1d4a040a1425ba7c305 --- M daemon/gtp_endpoint.c M daemon/tun_device.c 2 files changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-uecups refs/changes/89/40789/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40789?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I9b44dd9eeb1d8e291c35d1d4a040a1425ba7c305 Gerrit-Change-Number: 40789 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-uecups[master]: cups_client: Use new iofd stream_srv APIs
by pespin 31 Jul '25

31 Jul '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-uecups/+/40796?usp=email ) Change subject: cups_client: Use new iofd stream_srv APIs ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: Ie9f127e82e39ad0b5cae83f870b678ba1800ded4 Gerrit-Change-Number: 40796 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Jul 2025 14:48:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-uecups[master]: cups_client: Fix memleak during conn closed
by pespin 31 Jul '25

31 Jul '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-uecups/+/40795?usp=email ) Change subject: cups_client: Fix memleak during conn closed ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40795?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: Ic4d4da7ecbf5a7903a46558482b66cdc22767c4b Gerrit-Change-Number: 40795 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Jul 2025 14:48:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-uecups[master]: tun_device: Make sure struct iphdr access is 4-byte aligned
by pespin 31 Jul '25

31 Jul '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/40787?usp=email ) Change subject: tun_device: Make sure struct iphdr access is 4-byte aligned ...................................................................... tun_device: Make sure struct iphdr access is 4-byte aligned "struct iphdr" from netinet/ip.h used in parse_pkt() is not "packed", hence compiler expects to find the struct pointer aligned to 4-bytes. Re-arrange the stack buffer to make sure iphdr ends up being stored aligned. This was caught by running osmo-uecups with --enable-sanitize in TTCN3 testsuite ttcn3-5gc-test. Change-Id: I610c8e9b150c234b7d4997e0b1c4d4a9ce4de9ec --- M daemon/tun_device.c 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/daemon/tun_device.c b/daemon/tun_device.c index 350e322..2c67d5c 100644 --- a/daemon/tun_device.c +++ b/daemon/tun_device.c @@ -203,7 +203,9 @@ { struct tun_device *tun = (struct tun_device *)arg; struct gtp_daemon *d = tun->d; - uint8_t base_buffer[sizeof(struct gtp1_header) + sizeof(struct gtp1_exthdr) + MAX_UDP_PACKET]; + /* Make sure "buffer" below ends up aligned to 4byte so that it can access struct iphdr in a 4-byte aligned way. */ + const size_t payload_off_4byte_aligned = ((sizeof(struct gtp1_header) + sizeof(struct gtp1_exthdr)) + 3) & (~0x3); + uint8_t base_buffer[payload_off_4byte_aligned + MAX_UDP_PACKET]; int old_cancelst_unused; pthread_cleanup_push(tun_device_pthread_cleanup_routine, tun); @@ -216,7 +218,7 @@ struct gtp_tunnel *t; struct pkt_info pinfo; int rc, nread; - uint8_t *buffer = base_buffer + sizeof(base_buffer) - MAX_UDP_PACKET; + uint8_t *buffer = base_buffer + payload_off_4byte_aligned; /* 1) read from tun */ rc = read(tun->fd, buffer, MAX_UDP_PACKET); -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40787?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I610c8e9b150c234b7d4997e0b1c4d4a9ce4de9ec Gerrit-Change-Number: 40787 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-uecups[master]: tun_device: Make sure struct iphdr access is 4-byte aligned
by pespin 31 Jul '25

31 Jul '25

Attention is currently required from: Hoernchen, fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-uecups/+/40787?usp=email ) Change subject: tun_device: Make sure struct iphdr access is 4-byte aligned ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40787?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I610c8e9b150c234b7d4997e0b1c4d4a9ce4de9ec Gerrit-Change-Number: 40787 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Jul 2025 14:47:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-uecups[master]: tun_device: Make sure struct iphdr access is 4-byte aligned
by pespin 31 Jul '25

31 Jul '25

Attention is currently required from: Hoernchen, fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-uecups/+/40787?usp=email ) Change subject: tun_device: Make sure struct iphdr access is 4-byte aligned ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: > What about __attribute__((aligned(4))) or aligned alloca? This looks as brittle as the first version […] Because I don't want to align the start of the buffer variable, but make sure an intermediate point in the buffer is aligned. File daemon/tun_device.c: https://gerrit.osmocom.org/c/osmo-uecups/+/40787/comment/999416a8_ffe92148?… : PS2, Line 208: uint8_t base_buffer[payload_off_4byte_aligned + MAX_UDP_PACKET]; > I would expect there are nice compiler pragmas/macros that allow for such alignment? I know the Linu […] It's not about the initial buffer address, which I expect to be aligned, but the middle pointer where the iphdr gets stored. -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40787?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I610c8e9b150c234b7d4997e0b1c4d4a9ce4de9ec Gerrit-Change-Number: 40787 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Jul 2025 14:47:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[NoOp] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup.app.src: Add missing 'crypto'
by laforge 31 Jul '25

31 Jul '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/20020?usp=email ) Change subject: osmo_dia2gsup.app.src: Add missing 'crypto' ...................................................................... osmo_dia2gsup.app.src: Add missing 'crypto' In a new clean environment initialized with rebar3, I ran into dependency errors related to missing libraries. Change-Id: I4a6b963daf64695acd626a434bc4718fb5be40d6 --- 0 files changed, 0 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/20020?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I4a6b963daf64695acd626a434bc4718fb5be40d6 Gerrit-Change-Number: 20020 Gerrit-PatchSet: 3 Gerrit-Owner: matt9j <matt9j(a)cs.washington.edu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup.app.src: Add missing 'crypto'
by laforge 31 Jul '25

31 Jul '25

Attention is currently required from: fixeria, matt9j. laforge has posted comments on this change by matt9j. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/20020?usp=email ) Change subject: osmo_dia2gsup.app.src: Add missing 'crypto' ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/20020?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I4a6b963daf64695acd626a434bc4718fb5be40d6 Gerrit-Change-Number: 20020 Gerrit-PatchSet: 2 Gerrit-Owner: matt9j <matt9j(a)cs.washington.edu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matt9j <matt9j(a)cs.washington.edu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Jul 2025 14:01:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log