[XS] Change in osmo-uecups[master]: tun_device: Make sure struct iphdr access is 4-byte aligned
Attention is currently required from: Hoernchen, fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-uecups/+/40787?usp=email ) Change subject: tun_device: Make sure struct iphdr access is 4-byte aligned ...................................................................... Patch Set 2: (2 comments) Patchset: PS2:
What about __attribute__((aligned(4))) or aligned alloca? This looks as brittle as the first version […] Because I don't want to align the start of the buffer variable, but make sure an intermediate point in the buffer is aligned.
File daemon/tun_device.c: https://gerrit.osmocom.org/c/osmo-uecups/+/40787/comment/999416a8_ffe92148?u... : PS2, Line 208: uint8_t base_buffer[payload_off_4byte_aligned + MAX_UDP_PACKET];
I would expect there are nice compiler pragmas/macros that allow for such alignment? I know the Linu […] It's not about the initial buffer address, which I expect to be aligned, but the middle pointer where the iphdr gets stored.
-- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40787?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I610c8e9b150c234b7d4997e0b1c4d4a9ce4de9ec Gerrit-Change-Number: 40787 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: Hoernchen <ewild@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Thu, 31 Jul 2025 14:47:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild@sysmocom.de> Comment-In-Reply-To: laforge <laforge@osmocom.org>
participants (1)
-
pespin