- gerrit-log - lists.osmocom.org

[XS] Change in osmo-ci[master]: jenkins-gerrit: print the URLs this script reads
by osmith 25 Aug '25

25 Aug '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40911?usp=email ) Change subject: jenkins-gerrit: print the URLs this script reads ...................................................................... jenkins-gerrit: print the URLs this script reads Make errors easier to understand by printing all URLs that the script is reading from. Change-Id: Ic0e7fc0e5a82927fc9ef6ec02c374b1ec7dd73e5 --- M scripts/jenkins-gerrit/comment_generate.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/scripts/jenkins-gerrit/comment_generate.py b/scripts/jenkins-gerrit/comment_generate.py index a2aec0e..c81011f 100755 --- a/scripts/jenkins-gerrit/comment_generate.py +++ b/scripts/jenkins-gerrit/comment_generate.py @@ -41,6 +41,7 @@ global re_distro url = f"{job_url}/consoleText" + print(f"Reading {url}") with urllib.request.urlopen(url) as response: content = response.read().decode("utf-8") match = re_distro.search(content) @@ -77,6 +78,7 @@ ret = {} url = f"{build_url}/consoleText" + print(f"Reading {url}") with urllib.request.urlopen(url) as response: for line in io.TextIOWrapper(response, encoding='utf-8'): # Parse start build lines @@ -123,6 +125,7 @@ ret = [] url = f"{job['url']}/consoleFull" + print(f"Reading {url}") with urllib.request.urlopen(url) as response: for line in io.TextIOWrapper(response, encoding='utf-8'): if " completed with result " in line: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic0e7fc0e5a82927fc9ef6ec02c374b1ec7dd73e5 Gerrit-Change-Number: 40911 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jenkins-gerrit: binpkgs: ignore decode errors
by osmith 25 Aug '25

25 Aug '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40912?usp=email ) Change subject: jenkins-gerrit: binpkgs: ignore decode errors ...................................................................... jenkins-gerrit: binpkgs: ignore decode errors The output of recent osmo-s1gw jobs for building binary packages contains invalid utf-8 characters, even though it should be utf-8 according to the HTTP header: content-type: text/plain;charset=utf-8 We only need to get the distro name from the output here, so simply ignore any decode errors. Fix for: $ ./comment_generate.py https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-s1gw/417/ -o gerrit_report.json -t result Reading https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-s1gw/417//consoleText Reading https://jenkins.osmocom.org/jenkins/job/gerrit-binpkgs/17255/consoleText Reading https://jenkins.osmocom.org/jenkins/job/gerrit-binpkgs/17260/consoleText Traceback (most recent call last): File "/home/user/code/osmo-dev/src/osmo-ci/scripts/jenkins-gerrit/./comment_generate.py", line 270, in <module> main() File "/home/user/code/osmo-dev/src/osmo-ci/scripts/jenkins-gerrit/./comment_generate.py", line 257, in main comment = get_comment_result(args.build_url, args.notify_on_success) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/user/code/osmo-dev/src/osmo-ci/scripts/jenkins-gerrit/./comment_generate.py", line 198, in get_comment_result pipeline = parse_pipeline(build_url) ^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/user/code/osmo-dev/src/osmo-ci/scripts/jenkins-gerrit/./comment_generate.py", line 89, in parse_pipeline stage = stage_from_job_name(job_name, job_url) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/user/code/osmo-dev/src/osmo-ci/scripts/jenkins-gerrit/./comment_generate.py", line 59, in stage_from_job_name return stage_binpkgs_from_url(job_url) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/user/code/osmo-dev/src/osmo-ci/scripts/jenkins-gerrit/./comment_generate.py", line 46, in stage_binpkgs_from_url content = response.read().decode("utf-8") ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ UnicodeDecodeError: 'utf-8' codec can't decode byte 0xef in position 237446: invalid continuation byte Change-Id: If398037272c2de54c359ea8d907b35f6fb1e2b8b --- M scripts/jenkins-gerrit/comment_generate.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/scripts/jenkins-gerrit/comment_generate.py b/scripts/jenkins-gerrit/comment_generate.py index c81011f..ff5a92a 100755 --- a/scripts/jenkins-gerrit/comment_generate.py +++ b/scripts/jenkins-gerrit/comment_generate.py @@ -43,7 +43,7 @@ url = f"{job_url}/consoleText" print(f"Reading {url}") with urllib.request.urlopen(url) as response: - content = response.read().decode("utf-8") + content = response.read().decode("utf-8", errors="ignore") match = re_distro.search(content) assert match, f"couldn't find distro name in log: {url}" return match.group(1) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40912?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If398037272c2de54c359ea8d907b35f6fb1e2b8b Gerrit-Change-Number: 40912 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jenkins-gerrit: binpkgs: ignore decode errors
by fixeria 25 Aug '25

25 Aug '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40912?usp=email ) Change subject: jenkins-gerrit: binpkgs: ignore decode errors ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40912?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If398037272c2de54c359ea8d907b35f6fb1e2b8b Gerrit-Change-Number: 40912 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Aug 2025 10:18:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jenkins-gerrit: binpkgs: ignore decode errors
by pespin 25 Aug '25

25 Aug '25

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40912?usp=email ) Change subject: jenkins-gerrit: binpkgs: ignore decode errors ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40912?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If398037272c2de54c359ea8d907b35f6fb1e2b8b Gerrit-Change-Number: 40912 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Aug 2025 10:17:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jenkins-gerrit: print the URLs this script reads
by pespin 25 Aug '25

25 Aug '25

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40911?usp=email ) Change subject: jenkins-gerrit: print the URLs this script reads ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic0e7fc0e5a82927fc9ef6ec02c374b1ec7dd73e5 Gerrit-Change-Number: 40911 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Aug 2025 10:16:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jenkins-gerrit: print the URLs this script reads
by fixeria 25 Aug '25

25 Aug '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40911?usp=email ) Change subject: jenkins-gerrit: print the URLs this script reads ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic0e7fc0e5a82927fc9ef6ec02c374b1ec7dd73e5 Gerrit-Change-Number: 40911 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Aug 2025 10:16:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jenkins-gerrit: print the URLs this script reads
by osmith 25 Aug '25

25 Aug '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/40911?usp=email ) Change subject: jenkins-gerrit: print the URLs this script reads ...................................................................... jenkins-gerrit: print the URLs this script reads Make errors easier to understand by printing all URLs that the script is reading from. Change-Id: Ic0e7fc0e5a82927fc9ef6ec02c374b1ec7dd73e5 --- M scripts/jenkins-gerrit/comment_generate.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/11/40911/1 diff --git a/scripts/jenkins-gerrit/comment_generate.py b/scripts/jenkins-gerrit/comment_generate.py index a2aec0e..c81011f 100755 --- a/scripts/jenkins-gerrit/comment_generate.py +++ b/scripts/jenkins-gerrit/comment_generate.py @@ -41,6 +41,7 @@ global re_distro url = f"{job_url}/consoleText" + print(f"Reading {url}") with urllib.request.urlopen(url) as response: content = response.read().decode("utf-8") match = re_distro.search(content) @@ -77,6 +78,7 @@ ret = {} url = f"{build_url}/consoleText" + print(f"Reading {url}") with urllib.request.urlopen(url) as response: for line in io.TextIOWrapper(response, encoding='utf-8'): # Parse start build lines @@ -123,6 +125,7 @@ ret = [] url = f"{job['url']}/consoleFull" + print(f"Reading {url}") with urllib.request.urlopen(url) as response: for line in io.TextIOWrapper(response, encoding='utf-8'): if " completed with result " in line: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic0e7fc0e5a82927fc9ef6ec02c374b1ec7dd73e5 Gerrit-Change-Number: 40911 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jenkins-gerrit: binpkgs: ignore decode errors
by osmith 25 Aug '25

25 Aug '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/40912?usp=email ) Change subject: jenkins-gerrit: binpkgs: ignore decode errors ...................................................................... jenkins-gerrit: binpkgs: ignore decode errors The output of recent osmo-s1gw jobs for building binary packages contains invalid utf-8 characters, even though it should be utf-8 according to the HTTP header: content-type: text/plain;charset=utf-8 We only need to get the distro name from the output here, so simply ignore any decode errors. Fix for: $ ./comment_generate.py https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-s1gw/417/ -o gerrit_report.json -t result Reading https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-s1gw/417//consoleText Reading https://jenkins.osmocom.org/jenkins/job/gerrit-binpkgs/17255/consoleText Reading https://jenkins.osmocom.org/jenkins/job/gerrit-binpkgs/17260/consoleText Traceback (most recent call last): File "/home/user/code/osmo-dev/src/osmo-ci/scripts/jenkins-gerrit/./comment_generate.py", line 270, in <module> main() File "/home/user/code/osmo-dev/src/osmo-ci/scripts/jenkins-gerrit/./comment_generate.py", line 257, in main comment = get_comment_result(args.build_url, args.notify_on_success) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/user/code/osmo-dev/src/osmo-ci/scripts/jenkins-gerrit/./comment_generate.py", line 198, in get_comment_result pipeline = parse_pipeline(build_url) ^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/user/code/osmo-dev/src/osmo-ci/scripts/jenkins-gerrit/./comment_generate.py", line 89, in parse_pipeline stage = stage_from_job_name(job_name, job_url) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/user/code/osmo-dev/src/osmo-ci/scripts/jenkins-gerrit/./comment_generate.py", line 59, in stage_from_job_name return stage_binpkgs_from_url(job_url) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/user/code/osmo-dev/src/osmo-ci/scripts/jenkins-gerrit/./comment_generate.py", line 46, in stage_binpkgs_from_url content = response.read().decode("utf-8") ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ UnicodeDecodeError: 'utf-8' codec can't decode byte 0xef in position 237446: invalid continuation byte Change-Id: If398037272c2de54c359ea8d907b35f6fb1e2b8b --- M scripts/jenkins-gerrit/comment_generate.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/12/40912/1 diff --git a/scripts/jenkins-gerrit/comment_generate.py b/scripts/jenkins-gerrit/comment_generate.py index c81011f..ff5a92a 100755 --- a/scripts/jenkins-gerrit/comment_generate.py +++ b/scripts/jenkins-gerrit/comment_generate.py @@ -43,7 +43,7 @@ url = f"{job_url}/consoleText" print(f"Reading {url}") with urllib.request.urlopen(url) as response: - content = response.read().decode("utf-8") + content = response.read().decode("utf-8", errors="ignore") match = re_distro.search(content) assert match, f"couldn't find distro name in log: {url}" return match.group(1) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40912?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If398037272c2de54c359ea8d907b35f6fb1e2b8b Gerrit-Change-Number: 40912 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XL] Change in libosmo-netif[master]: bring twrtp into libosmo-netif
by pespin 25 Aug '25

25 Aug '25

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email ) Change subject: bring twrtp into libosmo-netif ...................................................................... Patch Set 6: (2 comments) File include/osmocom/netif/twrtp.h: https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/7cccd5fc_eec680c… : PS1, Line 26: struct osmo_twrtp_stats { Similarly to the public struct discussion I opened in the previous twjit patch, it also applies here. File src/twrtp_base.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/f804d619_c85a007… : PS1, Line 132: * another variant of this API with that alternative behavior. > Patchset 6 includes an implementation of this requested feature, making RTCP UDP socket optional. […] I'd prefer deferr/avoid allocating rtcp iofd if not needed. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ib63215aaf13ef8ab8f2e0c8d310164cd5c8824eb Gerrit-Change-Number: 39281 Gerrit-PatchSet: 6 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 25 Aug 2025 09:52:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in libosmo-netif[master]: bring twrtp into libosmo-netif
by pespin 25 Aug '25

25 Aug '25

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email ) Change subject: bring twrtp into libosmo-netif ...................................................................... Patch Set 6: Code-Review+1 (1 comment) File src/twrtp.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/70fe5759_2bdfb0b… : PS6, Line 231: endp->iofd_rtp = osmo_iofd_setup(endp, -1, NULL, Did you think about deferring this allocation step until osmo_twrtp_supply_fds is called? at least for iofd_rtcp which may never be used based on config. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ib63215aaf13ef8ab8f2e0c8d310164cd5c8824eb Gerrit-Change-Number: 39281 Gerrit-PatchSet: 6 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 25 Aug 2025 09:50:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log