- gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: Remove old empty io_uring
by jolly 25 Aug '25

25 Aug '25

Attention is currently required from: laforge, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40855?usp=email ) Change subject: Remove old empty io_uring ...................................................................... Patch Set 6: (1 comment) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40855/comment/c86d8165_08c7dffd?… : PS5, Line 620: sqe = io_uring_get_sqe_and_count(g_ring); > Wrong ring here and down below. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40855?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id2d2a0400ad442198c684ea0ead4eaeaead4c53d Gerrit-Change-Number: 40855 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Aug 2025 14:57:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>

1 0

[S] Change in libosmocore[master]: Remove old empty io_uring
by jolly 25 Aug '25

25 Aug '25

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/40855?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: Remove old empty io_uring ...................................................................... Remove old empty io_uring A previous patch creates a new io_uring, if it becomes too small to store all SQEs. When all SQEs of the old ring are completed, the old ring will be destroyed. A counter is incremented whenever an SQE is submitted to an io_uring. The counter is decremented whenever a CQE is received and handled. This counter will determine when a ring is empty and can be destroyed. Related: OS#6705 Change-Id: Id2d2a0400ad442198c684ea0ead4eaeaead4c53d --- M src/core/osmo_io_uring.c 1 file changed, 36 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/55/40855/6 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40855?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id2d2a0400ad442198c684ea0ead4eaeaead4c53d Gerrit-Change-Number: 40855 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in pysim[master]: Identify cards by Historical bytes of ATR
by bjoern 25 Aug '25

25 Aug '25

bjoern has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/40914?usp=email ) Change subject: Identify cards by Historical bytes of ATR ...................................................................... Identify cards by Historical bytes of ATR - try to identify the CardModel by just comparing the Historical Bytes if matching by Whole ATR failed - add decompose ATR code from pyscard-contrib Change-Id: Id7555e42290d232a0e0efc47e7d97575007d846f --- M pySim/filesystem.py M pySim/utils.py 2 files changed, 137 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/14/40914/1 diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 6712755..1d71e08 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -39,7 +39,7 @@ from osmocom.tlv import bertlv_parse_one from osmocom.construct import filter_dict, parse_construct, build_construct -from pySim.utils import sw_match +from pySim.utils import sw_match, decomposeATR from pySim.jsonpath import js_path_modify from pySim.commands import SimCardCommands from pySim.exceptions import SwMatchError @@ -1545,6 +1545,13 @@ if atr == card_atr: print("Detected CardModel:", cls.__name__) return True + # if nothing found try to just compare the Historical Bytes of the ATR + card_atr_hb = decomposeATR(card_atr)['hb'] + for atr in cls._atrs: + atr_hb = decomposeATR(atr)['hb'] + if atr_hb == card_atr_hb: + print("Detected CardModel:", cls.__name__) + return True return False @staticmethod diff --git a/pySim/utils.py b/pySim/utils.py index 48a9998..b0443c8 100644 --- a/pySim/utils.py +++ b/pySim/utils.py @@ -15,6 +15,7 @@ # Copyright (C) 2009-2010 Sylvain Munaut <tnt(a)246tNt.com> # Copyright (C) 2021 Harald Welte <laforge(a)osmocom.org> +# Copyright (C) 2009-2022 Ludovic Rousseau # # This program is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -585,6 +586,134 @@ raise ValueError('invalid APDU (%s), too short!' % b2h(apdu)) +# ATR handling code under GPL from parseATR: https://github.com/LudovicRousseau/pyscard-contrib +def normalizeATR(atr): + """Transform an ATR in list of integers. + valid input formats are + "3B A7 00 40 18 80 65 A2 08 01 01 52" + "3B:A7:00:40:18:80:65:A2:08:01:01:52" + + Args: + atr: string + Returns: + list of bytes + + >>> normalize("3B:A7:00:40:18:80:65:A2:08:01:01:52") + [59, 167, 0, 64, 24, 128, 101, 162, 8, 1, 1, 82] + """ + atr = atr.replace(":", "") + atr = atr.replace(" ", "") + + res = [] + while len(atr) >= 2: + byte, atr = atr[:2], atr[2:] + res.append(byte) + if len(atr) > 0: + raise ValueError("warning: odd string, remainder: %r" % atr) + + atr = [int(x, 16) for x in res] + return atr + + +# ATR handling code under GPL from parseATR: https://github.com/LudovicRousseau/pyscard-contrib +def decomposeATR(atr_txt): + """Decompose the ATR in elementary fields + + Args: + atr_txt: ATR as a hex bytes string + Returns: + dictionary of field and values + + >>> decomposeATR("3B A7 00 40 18 80 65 A2 08 01 01 52") + { 'T0': {'value': 167}, + 'TB': {1: {'value': 0}}, + 'TC': {2: {'value': 24}}, + 'TD': {1: {'value': 64}}, + 'TS': {'value': 59}, + 'atr': [59, 167, 0, 64, 24, 128, 101, 162, 8, 1, 1, 82], + 'hb': {'value': [128, 101, 162, 8, 1, 1, 82]}, + 'hbn': 7} + """ + ATR_PROTOCOL_TYPE_T0 = 0 + atr_txt = normalizeATR(atr_txt) + atr = {} + + # the ATR itself as a list of integers + atr["atr"] = atr_txt + + # store TS and T0 + atr["TS"] = {"value": atr_txt[0]} + TDi = atr_txt[1] + atr["T0"] = {"value": TDi} + hb_length = TDi & 15 + pointer = 1 + # protocol number + pn = 1 + + # store number of historical bytes + atr["hbn"] = TDi & 0xF + + while pointer < len(atr_txt): + # Check TAi is present + if (TDi | 0xEF) == 0xFF: + pointer += 1 + if "TA" not in atr: + atr["TA"] = {} + atr["TA"][pn] = {"value": atr_txt[pointer]} + + # Check TBi is present + if (TDi | 0xDF) == 0xFF: + pointer += 1 + if "TB" not in atr: + atr["TB"] = {} + atr["TB"][pn] = {"value": atr_txt[pointer]} + + # Check TCi is present + if (TDi | 0xBF) == 0xFF: + pointer += 1 + if "TC" not in atr: + atr["TC"] = {} + atr["TC"][pn] = {"value": atr_txt[pointer]} + + # Check TDi is present + if (TDi | 0x7F) == 0xFF: + pointer += 1 + if "TD" not in atr: + atr["TD"] = {} + TDi = atr_txt[pointer] + atr["TD"][pn] = {"value": TDi} + if (TDi & 0x0F) != ATR_PROTOCOL_TYPE_T0: + atr["TCK"] = True + pn += 1 + else: + break + + # Store historical bytes + atr["hb"] = {"value": atr_txt[pointer + 1 : pointer + 1 + hb_length]} + + # Store TCK + last = pointer + 1 + hb_length + if "TCK" in atr: + try: + atr["TCK"] = {"value": atr_txt[last]} + except IndexError: + atr["TCK"] = {"value": -1} + last += 1 + + if len(atr_txt) > last: + atr["extra"] = atr_txt[last:] + + if len(atr["hb"]["value"]) < hb_length: + missing = hb_length - len(atr["hb"]["value"]) + if missing > 1: + (t1, t2) = ("s", "are") + else: + (t1, t2) = ("", "is") + atr["warning"] = "ATR is truncated: %d byte%s %s missing" % (missing, t1, t2) + + return atr + + class DataObject(abc.ABC): """A DataObject (DO) in the sense of ISO 7816-4. Contrary to 'normal' TLVs where one simply has any number of different TLVs that may occur in any order at any point, ISO 7816 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40914?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id7555e42290d232a0e0efc47e7d97575007d846f Gerrit-Change-Number: 40914 Gerrit-PatchSet: 1 Gerrit-Owner: bjoern <bjoern.c3(a)nixda.biz>

1 0

[L] Change in osmo-ttcn3-hacks[master]: 5gc: Test UE requested PDU Session Modification procedure
by osmith 25 Aug '25

25 Aug '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40895?usp=email ) Change subject: 5gc: Test UE requested PDU Session Modification procedure ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40895?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id9ac0f0e431c4a82dfab8675c93bf3c3f05442a7 Gerrit-Change-Number: 40895 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Aug 2025 12:51:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: ngap: Fix wrong IE Id in m_n2_PDUSessionResourceModifyResponse()
by osmith 25 Aug '25

25 Aug '25

Attention is currently required from: fixeria, jolly, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40898?usp=email ) Change subject: ngap: Fix wrong IE Id in m_n2_PDUSessionResourceModifyResponse() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40898?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I13547e548e5323fe54340393cbe9f333f10c5969 Gerrit-Change-Number: 40898 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Aug 2025 12:49:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo_dia2gsup[master]: rebar.config: fix invalid branch for rebar3_diameter_compiler.git
by osmith 25 Aug '25

25 Aug '25

Attention is currently required from: fixeria, laforge. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40910?usp=email ) Change subject: rebar.config: fix invalid branch for rebar3_diameter_compiler.git ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I21490a837ee039e02dfde3e19ded338cf428d291 Gerrit-Change-Number: 40910 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Aug 2025 12:32:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo_dia2gsup[master]: rebar.config: fix invalid branch for rebar3_diameter_compiler.git
by pespin 25 Aug '25

25 Aug '25

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40910?usp=email ) Change subject: rebar.config: fix invalid branch for rebar3_diameter_compiler.git ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I21490a837ee039e02dfde3e19ded338cf428d291 Gerrit-Change-Number: 40910 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Aug 2025 12:15:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: Makefile: DIR_clean_template: clean depends on Makefile
by pespin 25 Aug '25

25 Aug '25

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40909?usp=email ) Change subject: Makefile: DIR_clean_template: clean depends on Makefile ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40909?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4934f345f4a1d54fa939143d46033c1ef6751aba Gerrit-Change-Number: 40909 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Aug 2025 12:14:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo_dia2gsup[master]: rebar.config: fix invalid branch for rebar3_diameter_compiler.git
by fixeria 25 Aug '25

25 Aug '25

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40910?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: rebar.config: fix invalid branch for rebar3_diameter_compiler.git ...................................................................... rebar.config: fix invalid branch for rebar3_diameter_compiler.git The upstream has ranamed 'master' branch to 'main', so the old name is no longer valid. This resulted in osmo_dia2gsup build failures. Let's use the latest stable release (0.8.0) instead. It's quite dated (2022), yet does the job. I could not find any significant changes since 0.8.0 (mostly CI and doc improvements). Change-Id: I21490a837ee039e02dfde3e19ded338cf428d291 Related: https://github.com/carlosedp/rebar3_diameter_compiler/commit/077e7b23d9ad2c… --- M rebar.config 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/10/40910/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I21490a837ee039e02dfde3e19ded338cf428d291 Gerrit-Change-Number: 40910 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in ...osmo_dia2gsup[master]: rebar.config: fix invalid branch for rebar3_diameter_compiler.git
by osmith 25 Aug '25

25 Aug '25

Attention is currently required from: fixeria, laforge. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40910?usp=email ) Change subject: rebar.config: fix invalid branch for rebar3_diameter_compiler.git ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > > * Use the latest tag (`{tag, "0.8.0"}`) -- it's quite old though, from 2022. […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I21490a837ee039e02dfde3e19ded338cf428d291 Gerrit-Change-Number: 40910 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Aug 2025 11:53:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log