jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email )
Change subject: s1ap_proxy: Add support for S1 HANDOVER procedure
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ib2c8b1787c60d35a512c3c78d35e1f72a9d7bb08
Gerrit-Change-Number: 41006
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Sep 2025 10:30:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41015?usp=email )
Change subject: dia: restrict AVPs inherited from RFC4005
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41015/comment/850f77c0_dcb8… :
PS1, Line 15: fiiiix nasreq
> fixxx it?
I need to drop that comment I added it during development :)
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41015?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Ibc11180489db6d86819ab17a5e7e92636dfed95e
Gerrit-Change-Number: 41015
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 04 Sep 2025 10:07:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: pespin.
lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41016?usp=email )
Change subject: Remove duplicate 3GPP-AAA-Server-Name definition and break 3-way circular dependency
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I would have proposed to use ts29_273_common.dia or so for all 29.273 related avps/enums.
unresolved this comment.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41016?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Idb1a7f7588b751c59788e4d99cd1d86f1fd2b573
Gerrit-Change-Number: 41016
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Sep 2025 10:05:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: osmith, pespin.
daniel has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email )
Change subject: Regenerate code with newer asn1c
......................................................................
Patch Set 3:
(2 comments)
File include/AARE-apdu.h:
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/3932d954_cb6… :
PS3, Line 1: /*
> These header files are all in the wrong directory. […]
This library instead sets
```osmo_asn1_tcapdir = $(includedir)/osmocom/tcap```
But I can see that our other libraries keep the directory structure in the source. I'll change it
File src/constr_CHOICE_print.c:
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/3972b78a_430… :
PS3, Line 1: /*
> I would really like/suggest to keep the generated C files in a separate directory, like done in osmo […]
So far there is only the generated files.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: If43a5d518f94fa558a3dff563a1c7aa31c925fec
Gerrit-Change-Number: 41022
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Sep 2025 10:05:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41016?usp=email )
Change subject: Remove duplicate 3GPP-AAA-Server-Name definition and break 3-way circular dependency
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
I would have proposed to use ts29_273_common.dia or so for all 29.273 related avps/enums.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41016?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Idb1a7f7588b751c59788e4d99cd1d86f1fd2b573
Gerrit-Change-Number: 41016
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Sep 2025 10:05:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes