- gerrit-log - lists.osmocom.org

[S] Change in ...osmo-s1gw[master]: sctp_proxy: make fetch_info/1 return a map
by fixeria 04 Sep '25

04 Sep '25

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40905?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: sctp_proxy: make fetch_info/1 return a map ...................................................................... sctp_proxy: make fetch_info/1 return a map Maps are a lot easier to work with and have better type hints. Change-Id: I24029faa7e44efe34599b46fae731c801ff6191d --- M src/sctp_proxy.erl 1 file changed, 18 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/05/40905/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40905?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I24029faa7e44efe34599b46fae731c801ff6191d Gerrit-Change-Number: 40905 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in ...osmo-s1gw[master]: sctp_proxy: return handler Pid in fetch_info/0
by fixeria 04 Sep '25

04 Sep '25

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40904?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: sctp_proxy: return handler Pid in fetch_info/0 ...................................................................... sctp_proxy: return handler Pid in fetch_info/0 Instead of returning the E-RAB list, give the caller access to the associated s1ap_proxy process by returning its Pid. This allows the caller to use API provided by the s1ap_proxy directly. Change-Id: I3911bfc107fea3ca572cf44f1d93b768b3c82b4f --- M src/sctp_proxy.erl 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/04/40904/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40904?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I3911bfc107fea3ca572cf44f1d93b768b3c82b4f Gerrit-Change-Number: 40904 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: sctp_proxy: fix non-existent fields in fetch_info/0
by fixeria 04 Sep '25

04 Sep '25

Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40903?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: sctp_proxy: fix non-existent fields in fetch_info/0 ...................................................................... sctp_proxy: fix non-existent fields in fetch_info/0 The mme_addr and mme_port have been moved into the conn_cfg sub-map. Change-Id: I386a0268d5e465cbd5ad7ee02ed768425e6ec17f Fixes: 1221b6d ("sctp_{client,server}: accept arguments in form of a map") --- M src/sctp_proxy.erl 1 file changed, 7 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/03/40903/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40903?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I386a0268d5e465cbd5ad7ee02ed768425e6ec17f Gerrit-Change-Number: 40903 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: pfcp_peer: add fetch_info/0
by fixeria 04 Sep '25

04 Sep '25

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40902?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: pfcp_peer: add fetch_info/0 ...................................................................... pfcp_peer: add fetch_info/0 This is useful for introspection and the upcoming REST interface. Change-Id: I3fdcf7f6daac09a8c523826995a610c04f5a327b --- M src/pfcp_peer.erl 1 file changed, 26 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/02/40902/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40902?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I3fdcf7f6daac09a8c523826995a610c04f5a327b Gerrit-Change-Number: 40902 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: erab_fsm: make fetch_info/1 return a map
by fixeria 04 Sep '25

04 Sep '25

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40906?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: erab_fsm: make fetch_info/1 return a map ...................................................................... erab_fsm: make fetch_info/1 return a map Maps are a lot easier to work with and have better type hints. Change-Id: I83999fa9346d19260cb44e0bb6a36b7ee1c12ce1 --- M src/erab_fsm.erl M src/s1ap_proxy.erl M test/erab_fsm_test.erl 3 files changed, 26 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/06/40906/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40906?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I83999fa9346d19260cb44e0bb6a36b7ee1c12ce1 Gerrit-Change-Number: 40906 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in ...osmo-s1gw[master]: Add unit tests for S1 HANDOVER procedure
by jolly 04 Sep '25

04 Sep '25

Attention is currently required from: fixeria, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029?usp=email ) Change subject: Add unit tests for S1 HANDOVER procedure ...................................................................... Patch Set 2: (5 comments) File test/s1ap_proxy_test.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/9ef7a85c_46fb… : PS1, Line 380: > unrelated ws removal Done https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/a136a4db_f2a9… : PS1, Line 76: peperation > prep{E->A}ration Done https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/5aa77f79_8335… : PS1, Line 403: [?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid, HandoverRqd)), : > Here we expect the PDUs to be forwarded as-is (unmodified), right? […] Done https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/ea92ac8f_a66f… : PS1, Line 413: HANDOVER REQUEST > This PDU actually goes from the MME to the target eNB, so `[eNB <- MME]`. Done https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/a9db5147_465d… : PS1, Line 416: MME -> eNB > ... and the opposite direction here: `[eNB -> MME]`. Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I400ac73343f2a795c8206aeee75a31f1455adbd0 Gerrit-Change-Number: 41029 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Sep 2025 11:23:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in ...osmo-s1gw[master]: Add unit tests for S1 HANDOVER procedure
by jolly 04 Sep '25

04 Sep '25

Attention is currently required from: jolly, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: Add unit tests for S1 HANDOVER procedure ...................................................................... Add unit tests for S1 HANDOVER procedure Related: SYS#7309 Change-Id: I400ac73343f2a795c8206aeee75a31f1455adbd0 --- M test/s1ap_proxy_test.erl 1 file changed, 108 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/29/41029/3 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I400ac73343f2a795c8206aeee75a31f1455adbd0 Gerrit-Change-Number: 41029 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Add support for S1 HANDOVER procedure
by fixeria 04 Sep '25

04 Sep '25

Attention is currently required from: jolly, pespin. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email ) Change subject: s1ap_proxy: Add support for S1 HANDOVER procedure ...................................................................... Patch Set 4: (1 comment) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/fd01dd0a_94b1… : PS3, Line 11: * Peperation of handover on the source eNB > Done Not critical, but it's preparation (prepare, not prepere). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ib2c8b1787c60d35a512c3c78d35e1f72a9d7bb08 Gerrit-Change-Number: 41006 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Sep 2025 11:18:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Add support for S1 HANDOVER procedure
by jolly 04 Sep '25

04 Sep '25

Attention is currently required from: fixeria, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email ) Change subject: s1ap_proxy: Add support for S1 HANDOVER procedure ...................................................................... Patch Set 4: (7 comments) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/58f0d663_677b… : PS3, Line 9: The procedure is uses two parts: > "is uses" is wrong. Done https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/745de4ec_08ac… : PS3, Line 11: * Peperation of handover on the source eNB > Preparation? Done File include/s1gw_metrics.hrl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/f94611df_b34b… : PS1, Line 36: handover_rsp > Let's use `handover_req_ack` here. Done File src/s1ap_proxy.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/37135982_e949… : PS1, Line 640: PATH SWITCH > These PDUs are not implemented yet, so let's keep the TODO comments for them. Done https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/05f224be_106d… : PS1, Line 1092: 'transportLayerAddress' = TLA_In, : > cosmetic: formatting issues Done https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/d4abfba3_3593… : PS1, Line 1113: 'transportLayerAddress' = TLA_In, : > cosmetic: formatting issues Done File src/s1ap_proxy.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/d3de6e92_da1a… : PS3, Line 638: {forward, S1}; > %% forward as-is, there's nothing to patch Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ib2c8b1787c60d35a512c3c78d35e1f72a9d7bb08 Gerrit-Change-Number: 41006 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Sep 2025 11:16:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Add support for S1 HANDOVER procedure
by jolly 04 Sep '25

04 Sep '25

Attention is currently required from: fixeria, jolly. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: s1ap_proxy: Add support for S1 HANDOVER procedure ...................................................................... s1ap_proxy: Add support for S1 HANDOVER procedure The HANDOVER procedure consists of two parts: * Preperation of handover on the source eNB A list of E-RABs to be released are processed by the proxy. * Resource allocation on the target eNB A list of E-RABs to be established are processed by the proxy. GTP-TEIDs and transport layer addresses will be modified. Related: SYS#7309 Change-Id: Ib2c8b1787c60d35a512c3c78d35e1f72a9d7bb08 --- M include/s1gw_metrics.hrl M src/s1ap_proxy.erl M src/s1gw_metrics.erl 3 files changed, 127 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/06/41006/4 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ib2c8b1787c60d35a512c3c78d35e1f72a9d7bb08 Gerrit-Change-Number: 41006 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log