- gerrit-log - lists.osmocom.org

[M] Change in ...osmo-s1gw[master]: Add unit tests for S1 HANDOVER procedure
by fixeria 04 Sep '25

04 Sep '25

Attention is currently required from: jolly. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029?usp=email ) Change subject: Add unit tests for S1 HANDOVER procedure ...................................................................... Patch Set 1: (5 comments) File test/s1ap_proxy_test.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/f463dd18_24e9… : PS1, Line 380: unrelated ws removal https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/a4c1c2cc_e157… : PS1, Line 76: peperation prep{E->A}ration https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/968a0c48_3045… : PS1, Line 403: [?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid, HandoverRqd)), : Here we expect the PDUs to be forwarded as-is (unmodified), right? We should not be matching anything here (`_`), but the same binary blobs: ``` ?_assertEqual({forward, HandoverRqd}, ... ?_assertEqual({forward, HandoverCmd}, ... ``` https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/de23fb6d_3882… : PS1, Line 413: HANDOVER REQUEST This PDU actually goes from the MME to the target eNB, so `[eNB <- MME]`. https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/d135e0aa_2825… : PS1, Line 416: MME -> eNB ... and the opposite direction here: `[eNB -> MME]`. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I400ac73343f2a795c8206aeee75a31f1455adbd0 Gerrit-Change-Number: 41029 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 04 Sep 2025 11:10:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-asn1-tcap[master]: contrib/jenkins: new script
by osmith 04 Sep '25

04 Sep '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41018?usp=email ) Change subject: contrib/jenkins: new script ...................................................................... contrib/jenkins: new script Change-Id: I4d76839d89492baee2c1c3ac87944fc78aee208f --- A contrib/jenkins.sh 1 file changed, 33 insertions(+), 0 deletions(-) Approvals: osmith: Verified daniel: Looks good to me, approved pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh new file mode 100755 index 0000000..95826af --- /dev/null +++ b/contrib/jenkins.sh @@ -0,0 +1,33 @@ +#!/bin/sh -ex + +base="$PWD" +deps="$base/deps" +inst="$deps/install" +export deps inst + +osmo-clean-workspace.sh + +mkdir -p "$deps" + +verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]") + +export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH" +export LD_LIBRARY_PATH="$inst/lib" +export PATH="$inst/bin:$PATH" + +osmo-build-dep.sh libasn1c + +set +x +echo +echo +echo +echo " ========================== libosmo-asn1-tcap ==========================" +echo +set -x + +autoreconf -fi +./configure --enable-sanitize --enable-werror +$MAKE $PARALLEL_MAKE +$MAKE $PARALLEL_MAKE distcheck + +osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41018?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I4d76839d89492baee2c1c3ac87944fc78aee208f Gerrit-Change-Number: 41018 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Add support for S1 HANDOVER procedure
by fixeria 04 Sep '25

04 Sep '25

Attention is currently required from: jolly. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email ) Change subject: s1ap_proxy: Add support for S1 HANDOVER procedure ...................................................................... Patch Set 3: Code-Review+1 (5 comments) File include/s1gw_metrics.hrl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/441e3f91_f373… : PS1, Line 36: handover_rsp > Let's use `handover_req_ack` here. Done File src/s1ap_proxy.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/8edfd8cd_e0a9… : PS1, Line 640: PATH SWITCH > These PDUs are not implemented yet, so let's keep the TODO comments for them. Done https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/fbd13d53_ffa3… : PS1, Line 642: fetch {MME,eNB}-UE-S1AP-ID values (mandatory IEs) > this comment is not relevant here? Done https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/2038de9a_3b57… : PS1, Line 1092: 'transportLayerAddress' = TLA_In, : > cosmetic: formatting issues Done https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/53d7b9f1_8d81… : PS1, Line 1113: 'transportLayerAddress' = TLA_In, : > cosmetic: formatting issues Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ib2c8b1787c60d35a512c3c78d35e1f72a9d7bb08 Gerrit-Change-Number: 41006 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 04 Sep 2025 10:48:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in ...osmo-s1gw[master]: Add unit tests for S1 HANDOVER procedure
by pespin 04 Sep '25

04 Sep '25

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029?usp=email ) Change subject: Add unit tests for S1 HANDOVER procedure ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I400ac73343f2a795c8206aeee75a31f1455adbd0 Gerrit-Change-Number: 41029 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 04 Sep 2025 10:45:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Add support for S1 HANDOVER procedure
by pespin 04 Sep '25

04 Sep '25

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email ) Change subject: s1ap_proxy: Add support for S1 HANDOVER procedure ...................................................................... Patch Set 3: (3 comments) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/f6309eb3_e3e2… : PS3, Line 9: The procedure is uses two parts: "is uses" is wrong. https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/0086459a_b639… : PS3, Line 11: * Peperation of handover on the source eNB Preparation? File src/s1ap_proxy.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/b5dcac45_4dc7… : PS3, Line 638: {forward, S1}; %% forward as-is, there's nothing to patch -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ib2c8b1787c60d35a512c3c78d35e1f72a9d7bb08 Gerrit-Change-Number: 41006 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 04 Sep 2025 10:45:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmo-asn1-tcap[master]: Fix decoding of TCAP messages
by pespin 04 Sep '25

04 Sep '25

Attention is currently required from: daniel, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41021?usp=email ) Change subject: Fix decoding of TCAP messages ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > The new part […] ok, can you update the commit description to mention it doesn't work either with newer asn1c (<insert version>) used in follow-up commit? This way someone can understand it was left changed on purpose and not due to way older asn1c. -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41021?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I4a27a52b2be70b1fc50e0a3d5441ded4c151fe65 Gerrit-Change-Number: 41021 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Sep 2025 10:39:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>

1 0

[S] Change in ...osmo-epdg[master]: Remove duplicate 3GPP-AAA-Server-Name definition and break 3-way circ...
by fixeria 04 Sep '25

04 Sep '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41016?usp=email ) Change subject: Remove duplicate 3GPP-AAA-Server-Name definition and break 3-way circular dependency ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41016?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Idb1a7f7588b751c59788e4d99cd1d86f1fd2b573 Gerrit-Change-Number: 41016 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Sep 2025 10:36:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in ...osmo-epdg[master]: dia/diameter_3ggp_ts32_299.dia: Inherit RFC4005 instead of RFC7155
by fixeria 04 Sep '25

04 Sep '25

Attention is currently required from: laforge, lynxis lazus, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41014?usp=email ) Change subject: dia/diameter_3ggp_ts32_299.dia: Inherit RFC4005 instead of RFC7155 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41014/comment/8de92eab_1e54… : PS1, Line 13: doesn we .. don't -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41014?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I7742d1523026e260b8501550977a41ebd3ad1b09 Gerrit-Change-Number: 41014 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 04 Sep 2025 10:33:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XL] Change in libosmo-asn1-tcap[master]: Regenerate code with newer asn1c
by pespin 04 Sep '25

04 Sep '25

Attention is currently required from: daniel, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email ) Change subject: Regenerate code with newer asn1c ...................................................................... Patch Set 3: (1 comment) File src/constr_CHOICE_print.c: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/aafd8d16_9a8… : PS3, Line 1: /* > So far there is only the generated files. Yes, but still it makes sense to have them in well known separate directory. Furthermore, I think it makes sense to split skeleton and tcp-specific generated files in different subdirs, since they serve different purposes and are updated in different cases (ASN.1 new version vs asn1c new version). -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: If43a5d518f94fa558a3dff563a1c7aa31c925fec Gerrit-Change-Number: 41022 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Sep 2025 10:33:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>

1 0

[M] Change in ...osmo-s1gw[master]: Add unit tests for S1 HANDOVER procedure
by jolly 04 Sep '25

04 Sep '25

jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029?usp=email ) Change subject: Add unit tests for S1 HANDOVER procedure ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I400ac73343f2a795c8206aeee75a31f1455adbd0 Gerrit-Change-Number: 41029 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 04 Sep 2025 10:30:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log