Attention is currently required from: osmith.
Hello Jenkins Builder, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43649?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: library/HTTP2_*: Add initial HTTP2 client/server support
......................................................................
library/HTTP2_*: Add initial HTTP2 client/server support
An HTTP2 client is implemented through the HTTP2_Adapter module, while
an HTTP2 server is implemented throught the HTTP2_Server_Emulation
module.
This is just an initial working solution (already being used
clientand server side upcoming SMF_Tests 5G SBI patches), the interface
may be changes and extended in the future (eg. we may want to add some
intermediate layer using HTTP2_Message in the HTTP2_Adapter instead of
writing raw HTTP2_Send/HTTP2_Recv records.)
Change-Id: I3ab440517e925a7c402dd4055c223ef568405adc
---
M deps/Makefile
A library/HTTP2_Adapter.ttcn
A library/HTTP2_CodecPort.ttcn
A library/HTTP2_CodecPort_CtrlFunct.ttcn
A library/HTTP2_CodecPort_CtrlFunctDef.cc
A library/HTTP2_Functions.ttcn
A library/HTTP2_Server_Emulation.ttcn
A library/HTTP2_Templates.ttcn
8 files changed, 1,122 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/49/43649/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43649?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3ab440517e925a7c402dd4055c223ef568405adc
Gerrit-Change-Number: 43649
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Attention is currently required from: osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43649?usp=email )
Change subject: library/HTTP2_*: Add initial HTTP2 client/server support
......................................................................
Patch Set 1:
(2 comments)
File library/HTTP2_CodecPort_CtrlFunct.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43649/comment/7676b803_8f1f… :
PS1, Line 3: import from HTTP2_CodecPort all;
> Why does this file and library/HTTP2_CodecPort_CtrlFunctDef. […]
Probably because I copied them over from a file which already used those 😊 I'll change them to tabs.
File library/HTTP2_Server_Emulation.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43649/comment/6078a17f_9b07… :
PS1, Line 483: //log("HTTP2_Server: Register ", vc_conn);
> Do you want to keep the commented out log lines here and above?
I think they are good to keep as placeholders for quick debug when needed.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43649?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3ab440517e925a7c402dd4055c223ef568405adc
Gerrit-Change-Number: 43649
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 17 Sep 2026 10:04:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Attention is currently required from: Hoernchen, lynxis lazus.
dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43548?usp=email )
Change subject: osmo-smdpp: fix Twisted ALPN issues with pyOpenSSL
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
I have checked the logic, to me everything looks right. But I didn't go into the details of pyOpenSSL. I assume that you have researched and tested this carefully - so I think everything should be ok.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43548?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I5d53216f24a20625d12f0757015c19fe341303b9
Gerrit-Change-Number: 43548
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 17 Sep 2026 10:04:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43653?usp=email )
Change subject: Add support for polling multiple eIMs
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/ipa/main.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43653/comment/21491ed7_4a07c505… :
PS2, Line 151: static struct ipa_context *ctx = NULL;
I would suggest to move this to the top of the module and to add a comment.
(I don't know if this is a coding style thing, but I always prefer to declare variables at the beginning of a module or function, it is then much easier to see what states a module or function has.)
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43653?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Ifcad584dd04dc83c59124ce32e60254a72537d02
Gerrit-Change-Number: 43653
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Thu, 17 Sep 2026 09:14:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43652?usp=email )
Change subject: Add index to ipa_es10b_get_eim_cfg_data_filter
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
File src/ipa/libipa/es10b_get_eim_cfg_data.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43652/comment/299b7784_ef11d15a… :
PS2, Line 297:
maybe set *eim_cfg_data_item = NULL; for good measure?
https://gerrit.osmocom.org/c/onomondo-ipa/+/43652/comment/c5cc518c_54431b77… :
PS2, Line 309: /* In case no eim_id is specified, just pick the item from the list that is specified by index */
Maybe rephrase the comment a bit?
In case no eim_id is specified, pick the eim_cfg_data_item by its index and exit.
https://gerrit.osmocom.org/c/onomondo-ipa/+/43652/comment/fe053812_c7f2f967… :
PS2, Line 317:
Maybe add a comment?
Otherwise find the eim_cfg_data_item by the specified eim_id and exit.
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43652?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I7a3cbbf8cd765f6da955434d897d9ffbe847f525
Gerrit-Change-Number: 43652
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Thu, 17 Sep 2026 09:05:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43651?usp=email )
Change subject: smf: Initial HTTP2/SBI support
......................................................................
Patch Set 2:
(1 comment)
File library/HTTP2_Functions.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43651/comment/b19e0223_d8d1… :
PS2, Line 51: //var charstring regexpString := "([A-Za-z][A-Za-z0-9-]*):\s*(.+?)\s*";
> Hm, I've played around with this for half an hour or so and I think regex in titan is just a bit bro […]
Could it be that TITAN is supporting a different dialect of regexp (there are several of them)? Worth checking TITAN's documentation.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43651?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I377b748d8da6e9e53a96a85f1c730505793ecea8
Gerrit-Change-Number: 43651
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <axilirator(a)gmail.com>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <axilirator(a)gmail.com>
Gerrit-Comment-Date: Thu, 17 Sep 2026 08:50:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43651?usp=email )
Change subject: smf: Initial HTTP2/SBI support
......................................................................
Patch Set 2:
(1 comment)
File library/HTTP2_Functions.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43651/comment/2c653fc5_040c… :
PS2, Line 51: //var charstring regexpString := "([A-Za-z][A-Za-z0-9-]*):\s*(.+?)\s*";
> @osmith@sysmocom.de @axilirator@gmail. […]
Hm, I've played around with this for half an hour or so and I think regex in titan is just a bit broken... your regex should match "Content-Type", "a". If you remove the ? (lazy -> match as few characters as possible) then it should work as intended ("Content-Type", "application/octetstream"). This is the result I get when running the regex in python and e.g. https://regexr.com/. With titan the strings are indeed just empty.
So I recommend keeping the string split code without regex that you already have and reporting this upstream.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43651?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I377b748d8da6e9e53a96a85f1c730505793ecea8
Gerrit-Change-Number: 43651
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <axilirator(a)gmail.com>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <axilirator(a)gmail.com>
Gerrit-Comment-Date: Thu, 17 Sep 2026 08:22:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>