Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43485?usp=email )
Change subject: xua_as_fsm: Do not send NOTIFY with all AS of ASP
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43485?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I252f9e16ab92a264559385d47690552d75837569
Gerrit-Change-Number: 43485
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 01 Sep 2026 15:00:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
jolly has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43498?usp=email )
Change subject: IPAd: Run pkill with exact binary name
......................................................................
IPAd: Run pkill with exact binary name
To prevent killing other processes that include "onomondo-ipa" within
their path, use "pkill -x onomondo-ipa" to kill only the binary with
that name.
Related: SYS#8101
Change-Id: Ib858ef20e36daefd51b01c68c886a57e053a9a1b
---
M library/PIPEasp_Templates.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
osmith: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/library/PIPEasp_Templates.ttcn b/library/PIPEasp_Templates.ttcn
index 738bf57..f024b4a 100644
--- a/library/PIPEasp_Templates.ttcn
+++ b/library/PIPEasp_Templates.ttcn
@@ -84,7 +84,7 @@
charstring progname) {
timer t_flush := 0.5;
- pt.send(ts_PExecute("pkill -f " & progname, ""))
+ pt.send(ts_PExecute("pkill -x " & progname, ""))
t_flush.start;
alt {
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43498?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib858ef20e36daefd51b01c68c886a57e053a9a1b
Gerrit-Change-Number: 43498
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Attention is currently required from: laforge, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43226?usp=email )
Change subject: xUA: Handle rx multiple Routing Context in SNM messages
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
I decided to split this commit into two: The previous patch submitted to gerrit now contains validation of the Routing Context set being passed, to make sure no strange or unexpectd routing contexts are received.
This patch keeps the logic to process Routing Context other than the first one, which may need further testing as the "what to do part" may need some more thinking.
Marking this one as WIP for now, while the previous one is ready to be reviewed and merged, since it makes rx path more robust.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43226?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I9ef1e343e95961d497f55e4a512068d3e7585a0c
Gerrit-Change-Number: 43226
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 01 Sep 2026 14:25:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: laforge, osmith.
Hello Jenkins Builder, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43226?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: xUA: Handle rx multiple Routing Context in SNM messages
......................................................................
xUA: Handle rx multiple Routing Context in SNM messages
All those messages can contain multiple routing contexts inside the
Routing Context IE according to both M3UA and SUA specs.
Make sure all the Routing Contexts are processed.
Related: OS#7062
Change-Id: I9ef1e343e95961d497f55e4a512068d3e7585a0c
---
M src/xua_snm.c
1 file changed, 16 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/26/43226/4
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43226?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I9ef1e343e95961d497f55e4a512068d3e7585a0c
Gerrit-Change-Number: 43226
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>