Attention is currently required from: daniel, lynxis lazus.
Hello Jenkins Builder, daniel, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43455?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: SGSN: f_service_request: fix required authentication when doing Service Request
......................................................................
SGSN: f_service_request: fix required authentication when doing Service Request
The authentication was broken before, because f_gmm_auth was consuming the
SecurityModeCommand and it never ended in as_service_request().
Change-Id: I1a4248c93514293ffdcdf9b42857bffab1fb92d9
---
M sgsn/BSSGP_ConnHdlr.ttcn
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/55/43455/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43455?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1a4248c93514293ffdcdf9b42857bffab1fb92d9
Gerrit-Change-Number: 43455
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: lynxis lazus.
Hello Jenkins Builder, daniel, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43456?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: SGSN: ensure every tests use a new subscriber
......................................................................
SGSN: ensure every tests use a new subscriber
If a test uses the same subscriber as the previuos tests,
the test might fail, because there is no need to request for
authentication data, because the UE still has a valid security
context with the network
Change-Id: I76e4b503bae1078d1c6ec2480aa221e029abed24
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/56/43456/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43456?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I76e4b503bae1078d1c6ec2480aa221e029abed24
Gerrit-Change-Number: 43456
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: lynxis lazus.
Hello Jenkins Builder, daniel, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43457?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: SGSN: Iu: follow Service Request according to ETSI PMM IDLE exception
......................................................................
SGSN: Iu: follow Service Request according to ETSI PMM IDLE exception
The Service Request is not always responded with a Service Accept.
When the UE is in PMM IDLE, a Security Command is equivalent to a
Service Accept.
See 3GPP TS 124 008, 4.7.13.3 Service request procedure accepted by the network.
Change-Id: I04d980d27c0c61830da8e1c52b988d6fecace171
---
M sgsn/SGSN_Tests_Iu.ttcn
1 file changed, 14 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/57/43457/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43457?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I04d980d27c0c61830da8e1c52b988d6fecace171
Gerrit-Change-Number: 43457
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: lynxis lazus.
Hello Jenkins Builder, daniel, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43458?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: SGSN: osmo-sgsn.cfg: assign gummei to test-mme0
......................................................................
SGSN: osmo-sgsn.cfg: assign gummei to test-mme0
To allow Context Out tests (4G -> 2G), the SGSN must know
which mme is responsible for the given RAI
Change-Id: I4d3f6b9910756e78d3425459bdfd3196886097ef
---
M sgsn/osmo-sgsn.cfg
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/58/43458/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43458?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4d3f6b9910756e78d3425459bdfd3196886097ef
Gerrit-Change-Number: 43458
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: lynxis lazus.
Hello Jenkins Builder, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43459?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: SGSN: raiv_to_gtp_rai(): fix copy-paste error
......................................................................
SGSN: raiv_to_gtp_rai(): fix copy-paste error
Change-Id: I9001c493e9b5c37142e731b9d87c21470b39b008
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/59/43459/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43459?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9001c493e9b5c37142e731b9d87c21470b39b008
Gerrit-Change-Number: 43459
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Hello Jenkins Builder, daniel, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43460?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: SGSN: TC_sgsn_context_req_out(): rework TC and make it work
......................................................................
SGSN: TC_sgsn_context_req_out(): rework TC and make it work
The TC_sgsn_context_req_out() was broken in different ways:
- using uninitialized variable in template
- used the wrong TLLI in the RAU
- fix typo in error message
- require RAT type to be present in TC even SGSN doesn't sent it atm
Change-Id: I83a596aff460e7db88b86b7f18361db5ad91a24e
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 21 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/60/43460/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43460?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I83a596aff460e7db88b86b7f18361db5ad91a24e
Gerrit-Change-Number: 43460
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria, laforge, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email )
Change subject: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_changed
......................................................................
Patch Set 16:
(6 comments)
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/721e1f69_6f04… :
PS15, Line 2194: as_gmm_auth
> Why do you activate the authentication handler so early? According to the test scenario, it's expect […]
as_gmm_auth() triggers before lu_isd().
IMHO: the authentication is off-topic for this test case.
The testcase don't care if auth is done or not, otherwise the testcase will also fail when the authentication has a problem.
I moved it anyway, but still don't think the TC should care.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/d190dcaf_f194… :
PS15, Line 2199: // f_bssgp_client_register(g_pars.imsi, g_pars.tlli, BSSGP_PROC[0]);
> This can be removed?
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/d760280c_26e2… :
PS15, Line 2210: as_gmm_gsup_lu_isd
> IIUC, the ISD is expected to happen only after you respond to the Identity Request? Why don't you ju […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/b56d27e2_4deb… :
PS15, Line 2223: FIXME
> Is this still relevant here? I see `f_process_attach_accept()` does P-TMSI extraction.
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/36b35474_329a… :
PS15, Line 2228: Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
> Why do you need to shutdown like this here?
Removed it. Not needed
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/549d94c9_c971… :
PS15, Line 2237: Identity Request IMSI (retrans)
> Likewise, the test does reply to the 2nd Identity Request.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia721d3c29bf09014b197670ae02d1cd1901750bc
Gerrit-Change-Number: 39256
Gerrit-PatchSet: 16
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 02 Sep 2026 10:48:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>