fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/43529?usp=email )
Change subject: build: include version.h.tpl in the release tarballs
......................................................................
build: include version.h.tpl in the release tarballs
simtrace2-host-0.9.1.tar.bz2 does not compile because
this file is missing. Add it to EXTRA_DIST.
make all-recursive
make[1]: Entering directory '/build/simtrace2/src/simtrace2-0.9.1'
Making all in include
make[2]: Entering directory '/build/simtrace2/src/simtrace2-0.9.1/include'
make[2]: *** No rule to make target 'osmocom/simtrace2/version.h.tpl',
needed by 'osmocom/simtrace2/version.h'. Stop.
make[2]: Leaving directory '/build/simtrace2/src/simtrace2-0.9.1/include'
make[1]: *** [Makefile:452: all-recursive] Error 1
make[1]: Leaving directory '/build/simtrace2/src/simtrace2-0.9.1'
make: *** [Makefile:376: all] Error 2
==> ERROR: A failure occurred in build().
Aborting...
Change-Id: I8c50c8df012b2b7eb5ee6046f14ccc4d2c07194e
Fixes: d0ad985e ("Generate a version.h file")
---
M host/include/Makefile.am
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/29/43529/1
diff --git a/host/include/Makefile.am b/host/include/Makefile.am
index 3a9722c..eba4978 100644
--- a/host/include/Makefile.am
+++ b/host/include/Makefile.am
@@ -16,3 +16,5 @@
osmocom/simtrace2/gsmtap.h \
osmocom/simtrace2/version.h \
$(NULL)
+
+EXTRA_DIST = osmocom/simtrace2/version.h.tpl
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43529?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I8c50c8df012b2b7eb5ee6046f14ccc4d2c07194e
Gerrit-Change-Number: 43529
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: Hoernchen.
dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43172?usp=email )
Change subject: GP: LOAD/STORE DATA chunk size from SCP overhead
......................................................................
Patch Set 7:
(1 comment)
File tests/unittests/test_globalplatform.py:
https://gerrit.osmocom.org/c/pysim/+/43172/comment/abe704f0_0a4e00da?usp=em… :
PS7, Line 385: # GP CardSpec v2.3.1 Section 11.8.2.3.1: all lengths ofPUT KEY are always BER TLV coded
> missing space ("...length ofPUT KEY... […]
I would recommend to fix this typo, re-add +2 and then to merge this patch.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43172?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic208f3959a38896f64fb6ccefb24cc360a3ac3a2
Gerrit-Change-Number: 43172
Gerrit-PatchSet: 7
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Sep 2026 09:35:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>