Attention is currently required from: dexter.
Hello Jenkins Builder, osmith, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43537?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: eIM_Tests: move boilerplate code into f_init_handler
......................................................................
eIM_Tests: move boilerplate code into f_init_handler
Each testcase calls a set of f_init_... functions. Those function calls
are the same for all testcases. Let's move them into f_init_handler
Related: SYS#8203
Change-Id: I9fe13b02ff7856ef3bd1a8a34655774e5e6676d9
---
M eim/eIM_Tests.ttcn
1 file changed, 11 insertions(+), 66 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/37/43537/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43537?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9fe13b02ff7856ef3bd1a8a34655774e5e6676d9
Gerrit-Change-Number: 43537
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter.
Hello Jenkins Builder, osmith, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43538?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: RSPDefinitions_Templates: improve EUICCInfo1 templates
......................................................................
RSPDefinitions_Templates: improve EUICCInfo1 templates
The templates tr_EUICCInfo1 and tr_EUICCInfo1 contain hardcoded
PKIdList parameters. Let's add parameters for those, so that API
users can use custom values if necessary.
Change-Id: I900c10da2f78b500a849cd19467eec360f301da3
Related: SYS#8203
---
M library/euicc/RSPDefinitions_Templates.ttcn
1 file changed, 10 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/38/43538/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43538?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I900c10da2f78b500a849cd19467eec360f301da3
Gerrit-Change-Number: 43538
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter.
Hello Jenkins Builder, osmith, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43535?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: eIM_Tests: fix writing: Es9p => ES9+
......................................................................
eIM_Tests: fix writing: Es9p => ES9+
Related: SYS#8100
Change-Id: Ic6ab934ae8b978c6aa938c98ee34ed4d8143a194
---
M eim/eIM_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/35/43535/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43535?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic6ab934ae8b978c6aa938c98ee34ed4d8143a194
Gerrit-Change-Number: 43535
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: osmith, pespin.
Hello Jenkins Builder, osmith, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43534?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by osmith, Code-Review+2 by pespin, Verified+1 by Jenkins Builder
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: testenv: add alternate config to test JSON ESipa bindings
......................................................................
testenv: add alternate config to test JSON ESipa bindings
The testsuite normally tests the eIM using the ASN.1 ESipa bindings
(generic). In order to be able to automatically test the JSON ESipa
bindings as well, let's add a testenv configuration (esipa-json)
to the testsuite.
Related SYS#8100
Change-Id: Ic5b16d14cc675335356cd25367d44c3f9744b186
---
A eim/eIM_Tests_esipa-json.cfg
M eim/prepare.sh
C eim/testenv_esipa-json.cfg
R eim/testenv_generic.cfg
4 files changed, 28 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/34/43534/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43534?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic5b16d14cc675335356cd25367d44c3f9744b186
Gerrit-Change-Number: 43534
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: osmith, pespin.
Hello Jenkins Builder, osmith, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43536?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by osmith, Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: eIM_Tests: move response check into f_es9p_receive
......................................................................
eIM_Tests: move response check into f_es9p_receive
When passing messages via the ES9+ interface, we check the expected
response in f_es9p_transceive. However, we could also check it earlier
in f_es9p_receive. This allows gives use more freedom since we can now
use f_es9p_receive independently.
Change-Id: Iff20efba2e1ca749c258f375c7fea3fdfd3d74f6
Related: SYS#8203
---
M eim/eIM_Tests.ttcn
1 file changed, 7 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/43536/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43536?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iff20efba2e1ca749c258f375c7fea3fdfd3d74f6
Gerrit-Change-Number: 43536
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: osmith, pespin.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43534?usp=email )
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: testenv: add alternate config to test JSON ESipa bindings
......................................................................
Patch Set 2:
(1 comment)
File eim/prepare.sh:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43534/comment/59986ee9_02c5… :
PS1, Line 7: if [ -e eIM_Tests.cfg ]; then
> instead of doing this, you could also do this: […]
Thanks for the hint. I didn't know that I could pass parameters to the prepare script.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43534?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic5b16d14cc675335356cd25367d44c3f9744b186
Gerrit-Change-Number: 43534
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Sep 2026 09:31:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>