September 2026 - gerrit-log - lists.osmocom.org

[XS] Change in onomondo-eim[master]: crypto_utils: remove already fixed TODO
by laforge 08 Sep '26

08 Sep '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43501?usp=email ) Change subject: crypto_utils: remove already fixed TODO ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43501?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I214cfd5f77c497d421525a91c06b1d99e0b7d6af Gerrit-Change-Number: 43501 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Sep 2026 10:50:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in onomondo-eim[master]: crypto_utils: extend TODO for better understanding
by laforge 08 Sep '26

08 Sep '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43502?usp=email ) Change subject: crypto_utils: extend TODO for better understanding ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43502?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I411a3b4216b3c0d707d571b7a0c178e001931139 Gerrit-Change-Number: 43502 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Sep 2026 10:50:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: eIM_Tests: set error code in f_TC_proc_euicc_data_req_err explicitly
by laforge 08 Sep '26

08 Sep '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43183?usp=email ) Change subject: eIM_Tests: set error code in f_TC_proc_euicc_data_req_err explicitly ...................................................................... eIM_Tests: set error code in f_TC_proc_euicc_data_req_err explicitly When the testcase responds to the eIM with the error message, the error code comes from a constant in the template. This means the testcase is harder to understand and may break if the template changes. Let's set the error code explcitly to avoid conflicts in the future. Related: SYS#8100 Change-Id: I06a97def123bb9196db2bab8fc94aaf5cef91c40 --- M eim/eIM_Tests.ttcn M library/euicc/SGP32Definitions_Templates.ttcn 2 files changed, 6 insertions(+), 4 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/eim/eIM_Tests.ttcn b/eim/eIM_Tests.ttcn index ca490db..b263eb8 100644 --- a/eim/eIM_Tests.ttcn +++ b/eim/eIM_Tests.ttcn @@ -929,8 +929,9 @@ eimTransactionId := valueof(esipa_res.getEimPackageResponse.ipaEuiccDataRequest.eimTransactionId); /* Provide a plausible ipaEuiccDataResponse to the eIM */ - f_esipa_transceive(valueof(ts_provideEimPackageResult(eID, ts_eimPackageResult_euiccDataResp_err(eimTransactionId))), - tr_provideEimPackageResultResponse_empty); + f_esipa_transceive(valueof(ts_provideEimPackageResult(eID, + ts_eimPackageResult_euiccDataResp_err(eimTransactionId, ipaEuiccDataErrorCode := 127))), + tr_provideEimPackageResultResponse_empty); f_rest_lookup_resource(resource_id, "edr", tr_JSON_REST_success(outcome := expected_outcome) ); f_rest_delete_resource(resource_id, "edr"); diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index a0f576d..ab27369 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -1562,11 +1562,12 @@ } } template (value) EimPackageResult -ts_eimPackageResult_euiccDataResp_err(template (omit) octetstring eimTransactionId := omit) := { +ts_eimPackageResult_euiccDataResp_err(template (omit) octetstring eimTransactionId := omit, + template (value) integer ipaEuiccDataErrorCode := 127) := { ipaEuiccDataResponse := { ipaEuiccDataResponseError := { eimTransactionId := eimTransactionId, - ipaEuiccDataErrorCode := 127 + ipaEuiccDataErrorCode := ipaEuiccDataErrorCode } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43183?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I06a97def123bb9196db2bab8fc94aaf5cef91c40 Gerrit-Change-Number: 43183 Gerrit-PatchSet: 13 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: eIM: add profileInfoList fields for ecall and fallback
by laforge 08 Sep '26

08 Sep '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43392?usp=email ) Change subject: eIM: add profileInfoList fields for ecall and fallback ...................................................................... eIM: add profileInfoList fields for ecall and fallback SGP.32 V.1.2 adds three (important) new boolean fields to the profileInfoList, which are ecallIndication, fallbackAllowed and fallbackAttribute. This patch adds support for those fields so that they can be queried via the REST API. Related: SYS8100 Change-Id: Ieb820082d0e61bad8e5dd3813fb3296be2e5f72e --- M eim/REST_Types_JSON.ttcn 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve diff --git a/eim/REST_Types_JSON.ttcn b/eim/REST_Types_JSON.ttcn index 0a34939..3bbf4d7 100644 --- a/eim/REST_Types_JSON.ttcn +++ b/eim/REST_Types_JSON.ttcn @@ -112,12 +112,15 @@ charstring profileName optional, charstring iconType optional, charstring icon optional, - charstring profileClass optional + charstring profileClass optional, //TODO: notificationConfigurationInfo //TODO: profileOwner //TODO: dpProprietaryData //TODO: profilePolicyRules //TODO: serviceSpecificDataStoredInEuicc + boolean ecallIndication optional, + boolean fallbackAttribute optional, + boolean fallbackAllowed optional }; type record JSON_REST_EimIdList { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43392?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ieb820082d0e61bad8e5dd3813fb3296be2e5f72e Gerrit-Change-Number: 43392 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: eIM: re-align REST API JSON types
by laforge 08 Sep '26

08 Sep '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43393?usp=email ) Change subject: eIM: re-align REST API JSON types ...................................................................... eIM: re-align REST API JSON types The data types of the REST API responses (outcome) have been changed. This patch re-alignes the related record definitions. Depends: onomondo-eim.git Change-Id I16cc063c185727e1b30f26d656bd15154504b087 Change-Id: I078916dd83cf9114ad5d491cb7ecc54babb957cf Related: SYS#8100 --- M eim/REST_Types_JSON.ttcn M eim/eIM_Tests.ttcn 2 files changed, 39 insertions(+), 31 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/eim/REST_Types_JSON.ttcn b/eim/REST_Types_JSON.ttcn index 3bbf4d7..b3a74b7 100644 --- a/eim/REST_Types_JSON.ttcn +++ b/eim/REST_Types_JSON.ttcn @@ -146,49 +146,57 @@ charstring enableResult, charstring disableResult, charstring deleteResult, - record { - charstring finalResult, - record of JSON_REST_ProfileInfo profileInfoList optional - } listProfileInfoResult, + record of JSON_REST_ProfileInfo listProfileInfoResult, record of JSON_REST_ProfilePolicyAuthorisationRule getRATResult, charstring configureImmediateEnableResult, - charstring setFallbackAttributeResult, - charstring unsetFallbackAttributeResult, - charstring setDefaultDpAddressResult, record { - charstring addEimResultCode, + charstring addEimResultCode optional, integer associationToken optional } addEimResult, charstring deleteEimResult, charstring updateEimResult, - record { - charstring finalResult, - record of JSON_REST_EimIdList eimIdList optional - } listEimResult, + record of JSON_REST_EimIdList listEimResult, charstring rollbackResult, + charstring setFallbackAttributeResult, + charstring unsetFallbackAttributeResult, charstring processingTerminated, - charstring notificationResult, - charstring cancelSessionResult, + charstring setDefaultDpAddressResult, record { - charstring finalResult, - charstring iccid optional + charstring defaultSmdpAddress optional, + octetstring euiccInfo1 optional, + octetstring euiccInfo2 optional, + charstring rootSmdsAddress optional, + integer associationToken optional, + octetstring eumCertificate optional, + octetstring euiccCertificate optional, + octetstring ipaCapabilities optional, + octetstring deviceInfo optional, + octetstring notificationsList optional + } euiccDataResult, + record { + charstring iccid, + charstring aid, + charstring simaResponse } profileInstallationResult, record of JSON_REST_Euicc_State euiccStateResult, + charstring cancelSessionReason, + charstring euiccPackageError, + charstring ipaEuiccDataError, + charstring eimPackageResultError, + charstring initiateAuthenticationError, + charstring authenticateResponseError, + charstring authenticateClientError, + charstring downloadResponseError, + charstring getBoundProfilePackageError, + charstring cancelSessionResponseError, + charstring profileInfoListError, + charstring listEimError, record { - charstring edrResult, - record { - charstring defaultSmdpAddress optional, - octetstring euiccInfo1 optional, - octetstring euiccInfo2 optional, - charstring rootSmdsAddress optional, - integer associationToken optional, - octetstring eumCertificate optional, - octetstring euiccCertificate optional, - octetstring ipaCapabilities optional, - octetstring deviceInfo optional, - octetstring notificationsList optional - } euiccData optional - } euiccDataResult + charstring BppCommandId, + charstring ErrorReason, + charstring simaResponse + } profileInstallationError, + charstring eimProcedureError } type record of JSON_REST_Result JSON_REST_Results; diff --git a/eim/eIM_Tests.ttcn b/eim/eIM_Tests.ttcn index b263eb8..410fb25 100644 --- a/eim/eIM_Tests.ttcn +++ b/eim/eIM_Tests.ttcn @@ -918,7 +918,7 @@ var template EsipaMessageFromEimToIpa esipa_res; var template octetstring eimTransactionId; var template JSON_REST_Results expected_outcome := - { { euiccDataResult := { edrResult := "undefinedError", euiccData := omit } } }; + { { ipaEuiccDataError := "undefinedError" } }; /* Create a new download at the eIM */ resource_id := f_rest_create_order("edr", ts_JSON_REST_edr_order(eID, '80BF20BF228384A5A688A9BF2B'O)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43393?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I078916dd83cf9114ad5d491cb7ecc54babb957cf Gerrit-Change-Number: 43393 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: eIM: re-align REST API JSON types
by laforge 08 Sep '26

08 Sep '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43393?usp=email ) Change subject: eIM: re-align REST API JSON types ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43393?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I078916dd83cf9114ad5d491cb7ecc54babb957cf Gerrit-Change-Number: 43393 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Sep 2026 10:46:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: eIM: add profileInfoList fields for ecall and fallback
by laforge 08 Sep '26

08 Sep '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43392?usp=email ) Change subject: eIM: add profileInfoList fields for ecall and fallback ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43392?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ieb820082d0e61bad8e5dd3813fb3296be2e5f72e Gerrit-Change-Number: 43392 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Sep 2026 10:45:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: eIM_Tests: set error code in f_TC_proc_euicc_data_req_err explicitly
by laforge 08 Sep '26

08 Sep '26

Attention is currently required from: dexter, jolly. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43183?usp=email ) Change subject: eIM_Tests: set error code in f_TC_proc_euicc_data_req_err explicitly ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43183?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I06a97def123bb9196db2bab8fc94aaf5cef91c40 Gerrit-Change-Number: 43183 Gerrit-PatchSet: 12 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Sep 2026 10:45:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-sgsn[master]: libvlr: Remove MSC specific parts
by laforge 08 Sep '26

08 Sep '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43461?usp=email ) Change subject: libvlr: Remove MSC specific parts ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43461?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I35e3edc56c7c64ac2a4462dec8ea684b00ab3881 Gerrit-Change-Number: 43461 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 08 Sep 2026 10:45:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in osmo-sgsn[master]: add libvlr based on MSC commit 7a628a1029ef174328f7e86183f19e54e5d9df8f
by laforge 08 Sep '26

08 Sep '26

Attention is currently required from: lynxis lazus, osmith. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email ) Change subject: add libvlr based on MSC commit 7a628a1029ef174328f7e86183f19e54e5d9df8f ...................................................................... Patch Set 7: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/ea329056_3215782e?us… : PS6, Line 8: > Because it is a lot of work keeping the interface stable. […] I would also prefer a "linking" situation over a copy, where I am afraid they will deviate too much over time, have security fixes only appleid to one of them, etc. Do we really expect that much interface instability in the future? both osmo-msc and osmo-sgsn are pretty legacy these days and see very little development. This changeset may very well be the last large change to the codebase. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d Gerrit-Change-Number: 39560 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 08 Sep 2026 10:45:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log September 2026