August 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: 5gc: Fix NG NAS ul_count not incremented
by pespin 13 Aug '26

13 Aug '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43212?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: 5gc: Fix NG NAS ul_count not incremented ...................................................................... 5gc: Fix NG NAS ul_count not incremented Since open5gs.git b9823196b5de3394b7a144569f186d7d62fad6f9, open5gs properly validates received seq_nr (ul_count) of integrity protected NG-NAS message to make sure it increases with each new UL message, in order to protect against accepting replayed messages. This made the 5gc testsuite fail since our NGAP/NG-NAS emulation was not properly increasing ul_count when sending new messages, but always using ul_count=0. Change-Id: I7ea4460c902a5f612243e155a484acc89acd447f --- M library/NG_CryptoFunctions.ttcn 1 file changed, 10 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/12/43212/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43212?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7ea4460c902a5f612243e155a484acc89acd447f Gerrit-Change-Number: 43212 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[L] Change in pysim[master]: GP: mixed PSK TLS PUT KEY (Amendment B Table 3-13)
by dexter 13 Aug '26

13 Aug '26

Attention is currently required from: Hoernchen, fixeria, lynxis lazus. dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43136?usp=email ) Change subject: GP: mixed PSK TLS PUT KEY (Amendment B Table 3-13) ...................................................................... Patch Set 6: Code-Review+1 (1 comment) Patchset: PS6: I have now looked through this carefully and I couldn't spot any obvious mistakes. To me everything looks ok. I also tried to put an SCP81 key using pySim-shell.py. This seemingly worked, but it also worked before and I cannot very if the key is actually usable. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43136?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I480a9d049a052aa5ae54fe6e2771dba44e89434d Gerrit-Change-Number: 43136 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 12 Aug 2026 15:34:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: 5gc: Fix NG NAS ul_count not incremented
by pespin 13 Aug '26

13 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43212?usp=email ) Change subject: 5gc: Fix NG NAS ul_count not incremented ...................................................................... 5gc: Fix NG NAS ul_count not incremented Since open5gs.git b9823196b5de3394b7a144569f186d7d62fad6f9, open5gs properly validates received seq_nr (ul_count) of integrity protected NG-NAS message to make sure it increases with each new UL message, in order to protect against accepting replayed messages. This made the 5gc testsuite fail since our NGAP/NG-NAS emulation was not properly increasing ul_count when sending new messages, but always using ul_count=0. Change-Id: I7ea4460c902a5f612243e155a484acc89acd447f --- M library/NG_CryptoFunctions.ttcn 1 file changed, 10 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/12/43212/1 diff --git a/library/NG_CryptoFunctions.ttcn b/library/NG_CryptoFunctions.ttcn index b16029e..d53945f 100644 --- a/library/NG_CryptoFunctions.ttcn +++ b/library/NG_CryptoFunctions.ttcn @@ -307,13 +307,16 @@ var BIT4 sec_hdr_t; var OCT4 mac; var NG_NAS_UL_Message_Type nas_out; - - if (nus.use_enc == false and nus.use_int == false) { - return nas_in; - } + var OCT1 seq_nr; if (nus.new_ctx) { nus.tx_count := 0; + } else { + nus.tx_count := nus.tx_count + 1; + } + + if (nus.use_enc == false and nus.use_int == false) { + return nas_in; } var octetstring nas_enc := enc_NG_NAS_UL_Message_Type(nas_in) @@ -327,14 +330,15 @@ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Not supported"); } + seq_nr := int2oct(nus.tx_count, 1); sec_hdr_t := f_NG_NAS_determine_sec_hdr_t(nus.use_enc, nus.use_int, nus.new_ctx); mac := f_NG_NAS_mac_calc(nus.alg_int, nus.k_nas_int, nus.tx_count, bit2int(tsc_NG_RegResult_3GPP), - f_tx_is_downlink(nus), '00'O & nas_enc); + f_tx_is_downlink(nus), seq_nr & nas_enc); nas_out := valueof(cs_NG_SECURITY_PROTECTED_NAS_MESSAGE(tsc_EPD_GMM, sec_hdr_t, mac, - int2oct(nus.tx_count, 1), + seq_nr, nas_enc)); return nas_out; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43212?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7ea4460c902a5f612243e155a484acc89acd447f Gerrit-Change-Number: 43212 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in simtrace2[master]: firmware: Drop CEMU_TX_DATA when emulated sim is in-active
by lynxis lazus 13 Aug '26

13 Aug '26

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/43003?usp=email to look at the new patch set (#7). Change subject: firmware: Drop CEMU_TX_DATA when emulated sim is in-active ...................................................................... firmware: Drop CEMU_TX_DATA when emulated sim is in-active When the emulated sim is in reset or without power, drop CEMU_TX_DATA. Change-Id: I796e548225a742cddfde12bd6a60e4d2e5c04c8f --- M firmware/libcommon/include/card_emu.h M firmware/libcommon/source/card_emu.c M firmware/libcommon/source/mode_cardemu.c 3 files changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/03/43003/7 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I796e548225a742cddfde12bd6a60e4d2e5c04c8f Gerrit-Change-Number: 43003 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: 5gc: TC_ng_register_ping46_256: Increase Tguard
by pespin 13 Aug '26

13 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43211?usp=email ) Change subject: 5gc: TC_ng_register_ping46_256: Increase Tguard ...................................................................... 5gc: TC_ng_register_ping46_256: Increase Tguard The 30.0 are sometimes not enough to run the test, specially on resource-constrained systems. Change-Id: I312f132094707a39b2980529cf363af4b172e66a --- M 5gc/C5G_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/11/43211/1 diff --git a/5gc/C5G_Tests.ttcn b/5gc/C5G_Tests.ttcn index 2649a2f..2be26ff 100644 --- a/5gc/C5G_Tests.ttcn +++ b/5gc/C5G_Tests.ttcn @@ -559,7 +559,7 @@ var ConnHdlr vc_conn[256]; var integer i; - f_init(); + f_init(t_guard := 60.0); f_ngap_setup(0); for (i := 0; i < sizeof(vc_conn); i := i + 1) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43211?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I312f132094707a39b2980529cf363af4b172e66a Gerrit-Change-Number: 43211 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in pysim[master]: GP: LOAD/STORE DATA chunk size from SCP overhead
by dexter 13 Aug '26

13 Aug '26

Attention is currently required from: Hoernchen. dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43172?usp=email ) Change subject: GP: LOAD/STORE DATA chunk size from SCP overhead ...................................................................... Patch Set 7: Code-Review+2 Verified+1 (4 comments) Patchset: PS7: I have read through again and I couldn't spot any mistakes. I also have re-tested it by installing a java applet from pySim-shell with security level 3. Thanks for putting the spec references. Those helped me a lot with understanding the patch. File pySim/global_platform/__init__.py: https://gerrit.osmocom.org/c/pysim/+/43172/comment/7ba72859_8d1580c4?usp=em… : PS7, Line 158: That legacy form is accepted when parsing, but never generated, which agrees with the spec""" I have looked it up also. There is indeed a deviation from what we normally have in ASN.1 BER-TLV. This is the first time I hear about this indefinite form. I have never seen anything like that anywhere in the smartcard world. Its probably safe to say that it is not applicable to GP. File pySim/global_platform/scp.py: https://gerrit.osmocom.org/c/pysim/+/43172/comment/0af620a1_58645cca?usp=em… : PS7, Line 252: # is formatted as described in Table 11-70: preceded by the actual length of the In GlobalPlatform Card Specification 2.2.1, Table 11-70 is PUT KEY Error Conditions, in the Public Review v2.3.1.49 its Format of Key Component Block – Padding Present if Needed. So table references shift from version to version. Very distracting... File tests/unittests/test_globalplatform.py: https://gerrit.osmocom.org/c/pysim/+/43172/comment/5c809a3a_52cd03ba?usp=em… : PS7, Line 385: # GP CardSpec v2.3.1 Section 11.8.2.3.1: all lengths ofPUT KEY are always BER TLV coded missing space ("...length ofPUT KEY...") -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43172?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic208f3959a38896f64fb6ccefb24cc360a3ac3a2 Gerrit-Change-Number: 43172 Gerrit-PatchSet: 7 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Aug 2026 14:45:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in simtrace2[master]: firmware: Implement debug command via USB control vendor class
by Jenkins Builder 12 Aug '26

12 Aug '26

Attention is currently required from: laforge, lynxis lazus, pespin. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43005?usp=email ) Change subject: firmware: Implement debug command via USB control vendor class ...................................................................... Patch Set 11: (1 comment) File firmware/apps/cardem/main.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/simtrace2/+/43005/comment/4e80f66d_12d2ff92?us… : PS11, Line 44: void (*ctrl_vendor_req) (const USBGenericRequest *request); Unnecessary space before function pointer arguments -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43005?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I1f4d29335eb0d2feef376b8ecdfe57a0162914d6 Gerrit-Change-Number: 43005 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 12 Aug 2026 13:53:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in simtrace2[master]: firmware: Drop CEMU_TX_DATA when sim is in-active
by lynxis lazus 12 Aug '26

12 Aug '26

Attention is currently required from: laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43003?usp=email ) Change subject: firmware: Drop CEMU_TX_DATA when sim is in-active ...................................................................... Patch Set 6: (1 comment) File firmware/libcommon/source/card_emu.c: https://gerrit.osmocom.org/c/simtrace2/+/43003/comment/7ba86d80_054de7bd?us… : PS5, Line 218: /* if the card should enque messages */ > wording is slightly sub-optimal: A card itself (like an actual SIM) doesn't queue messages, right? […] I changed the wording. If this is not fitting, please recommend a better name. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I796e548225a742cddfde12bd6a60e4d2e5c04c8f Gerrit-Change-Number: 43003 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Aug 2026 13:52:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in simtrace2[master]: cosmetic: fix typo in comment
by lynxis lazus 12 Aug '26

12 Aug '26

Attention is currently required from: laforge, lynxis lazus. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/43141?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+2 by laforge, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: cosmetic: fix typo in comment ...................................................................... cosmetic: fix typo in comment Change-Id: I9647fd799839e1d7aa7ab9c118a2e51455536ce4 --- M host/lib/apdu_dispatch.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/41/43141/3 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43141?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I9647fd799839e1d7aa7ab9c118a2e51455536ce4 Gerrit-Change-Number: 43141 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in simtrace2[master]: firmware: Drop CEMU_TX_DATA when sim is in-active
by lynxis lazus 12 Aug '26

12 Aug '26

Attention is currently required from: laforge, lynxis lazus, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/43003?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: firmware: Drop CEMU_TX_DATA when sim is in-active ...................................................................... firmware: Drop CEMU_TX_DATA when sim is in-active When the emulated sim is in reset or without power, drop CEMU_TX_DATA. Change-Id: I796e548225a742cddfde12bd6a60e4d2e5c04c8f --- M firmware/libcommon/include/card_emu.h M firmware/libcommon/source/card_emu.c M firmware/libcommon/source/mode_cardemu.c 3 files changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/03/43003/6 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I796e548225a742cddfde12bd6a60e4d2e5c04c8f Gerrit-Change-Number: 43003 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026