August 2026 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: sua: refactor sua_parse_gt() digit loop
by laforge 22 Aug '26

22 Aug '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43348?usp=email ) Change subject: sua: refactor sua_parse_gt() digit loop ...................................................................... sua: refactor sua_parse_gt() digit loop The digit-parsing loop in sua_parse_gt() bounded output writes to gt->digits[] via mid-loop break checks against the clamped num_digits, while the loop itself iterated over datalen-8. Although provably safe, Coverity cannot correlate the break conditions with the loop bound and flags a false-positive overrun. Rewrite the loop to iterate directly over num_digits, so the bound on writes into gt->digits[] is syntactically obvious. No functional change. Change-Id: I39c1e8acbec371a27c7871799619695d77b4d61e Related: OS#7046, CID#562801 --- M src/sua.c 1 file changed, 12 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/sua.c b/src/sua.c index 35c4a8e..7c6d57f 100644 --- a/src/sua.c +++ b/src/sua.c @@ -412,16 +412,20 @@ rc = -ENOSPC; } - /* parse digits */ + /* parse digits: bounded by num_digits (already clamped above), so this + * can never write more than sizeof(gt->digits)-1 nibbles into gt->digits[] */ out_digits = gt->digits; - for (i = 0; i < datalen-8; i++) { - uint8_t byte = data[8+i]; - *out_digits++ = osmo_bcd2char(byte & 0x0F); - if (out_digits - gt->digits >= num_digits) + for (i = 0; i < num_digits; i++) { + unsigned int byte_off = 8 + i / 2; + uint8_t byte; + + if (byte_off >= datalen) break; - *out_digits++ = osmo_bcd2char(byte >> 4); - if (out_digits - gt->digits >= num_digits) - break; + byte = data[byte_off]; + if (i & 1) + *out_digits++ = osmo_bcd2char(byte >> 4); + else + *out_digits++ = osmo_bcd2char(byte & 0x0F); } *out_digits++ = '\0'; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43348?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I39c1e8acbec371a27c7871799619695d77b4d61e Gerrit-Change-Number: 43348 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in simtrace2[master]: simtrace2-cardem-pcsc: use new API osmo_apdu_segment_in2() to fix GP ...
by laforge 22 Aug '26

22 Aug '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/43350?usp=email ) Change subject: simtrace2-cardem-pcsc: use new API osmo_apdu_segment_in2() to fix GP GET DATA ...................................................................... simtrace2-cardem-pcsc: use new API osmo_apdu_segment_in2() to fix GP GET DATA The old osmo_apdu_segment_in() could not parse GP GET DATA correctly and will fail when parsing a GP GET DATA case 2 with an Le != 0. Related: SYS#8147 Change-Id: Id5642cb76da4fcbcdd318d41691415781bf0bc50 --- M host/src/simtrace2-cardem-pcsc.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/host/src/simtrace2-cardem-pcsc.c b/host/src/simtrace2-cardem-pcsc.c index f26698e..1f5c46d 100644 --- a/host/src/simtrace2-cardem-pcsc.c +++ b/host/src/simtrace2-cardem-pcsc.c @@ -159,7 +159,7 @@ /*! \brief Process a RX-DATA indication message from the SIMtrace2 */ static int process_do_rx_da(struct osmo_st2_cardem_inst *ci, uint8_t *buf, int len) { - static struct osmo_apdu_context ac; + static struct osmo_apdu_context ac, prev_ac; struct cardemu_usb_msg_rx_data *data; int rc; @@ -168,8 +168,8 @@ LOGCI(ci, LOGL_INFO, "=> DATA: flags=0x%02x (%s), %s\n ", data->flags, cemu_data_flags2str(data->flags), osmo_hexdump(data->data, data->data_len)); - rc = osmo_apdu_segment_in(&ac, data->data, data->data_len, - data->flags & CEMU_DATA_F_TPDU_HDR); + rc = osmo_apdu_segment_in2(&ac, &prev_ac, data->data, data->data_len, + data->flags & CEMU_DATA_F_TPDU_HDR); if (rc < 0) { /* At this point the communication is broken. We cannot keep running, as we * don't know if we should continue transmitting or receiving. Only a successful -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43350?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id5642cb76da4fcbcdd318d41691415781bf0bc50 Gerrit-Change-Number: 43350 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in simtrace2[master]: simtrace2-cardem-pcsc: use new API osmo_apdu_segment_in2() to fix GP ...
by laforge 22 Aug '26

22 Aug '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43350?usp=email ) Change subject: simtrace2-cardem-pcsc: use new API osmo_apdu_segment_in2() to fix GP GET DATA ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43350?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id5642cb76da4fcbcdd318d41691415781bf0bc50 Gerrit-Change-Number: 43350 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 22 Aug 2026 08:15:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-remsim[master]: cosmetic: fix missing space
by laforge 22 Aug '26

22 Aug '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43353?usp=email ) Change subject: cosmetic: fix missing space ...................................................................... cosmetic: fix missing space Change-Id: Ia83c96e5e39431dedfa64444290f1b7b816ce540 --- M src/client/remsim_client_main.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/client/remsim_client_main.c b/src/client/remsim_client_main.c index 3145f49..c3f36d6 100644 --- a/src/client/remsim_client_main.c +++ b/src/client/remsim_client_main.c @@ -214,7 +214,7 @@ OSMO_ASSERT(cfg); handle_options(cfg, argc, argv); - g_client = remsim_client_create(g_tall_ctx, hostname, "remsim-client",cfg); + g_client = remsim_client_create(g_tall_ctx, hostname, "remsim-client", cfg); osmo_fsm_inst_dispatch(g_client->srv_conn.fi, SRVC_E_ESTABLISH, NULL); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43353?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ia83c96e5e39431dedfa64444290f1b7b816ce540 Gerrit-Change-Number: 43353 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-remsim[master]: remsim_client: only set usb parameters if given by arguments
by laforge 22 Aug '26

22 Aug '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43347?usp=email ) Change subject: remsim_client: only set usb parameters if given by arguments ...................................................................... remsim_client: only set usb parameters if given by arguments When calling osmo-remsim-client-st2 without setting the usb address (-A), previous libusb_claim_interface() was called with an usb address of 255, which is not valid on usb. Only set arguments to libusb_claim_interface() when given. Change-Id: I30f27b166db72fa8796aa4da98f9fc01e348c87a --- M src/client/user_simtrace2.c 1 file changed, 12 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/client/user_simtrace2.c b/src/client/user_simtrace2.c index 2535efb..5d7d3c9 100644 --- a/src/client/user_simtrace2.c +++ b/src/client/user_simtrace2.c @@ -415,12 +415,18 @@ bc->cardem = ci; memset(ifm, 0, sizeof(*ifm)); - ifm->vendor = cfg->usb.vendor_id; - ifm->product = cfg->usb.product_id; - ifm->configuration = cfg->usb.config_id; - ifm->interface = cfg->usb.if_num; - ifm->altsetting = cfg->usb.altsetting; - ifm->addr = cfg->usb.addr; + if (cfg->usb.vendor_id > 0) + ifm->vendor = cfg->usb.vendor_id; + if (cfg->usb.product_id > 0) + ifm->product = cfg->usb.product_id; + if (cfg->usb.config_id > 0) + ifm->configuration = cfg->usb.config_id; + if (cfg->usb.if_num > 0) + ifm->interface = cfg->usb.if_num; + if (cfg->usb.altsetting > 0) + ifm->altsetting = cfg->usb.altsetting; + if (cfg->usb.addr > 0) + ifm->addr = cfg->usb.addr; if (cfg->usb.path) osmo_strlcpy(ifm->path, cfg->usb.path, sizeof(ifm->path)); transp->udp_fd = -1; -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43347?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I30f27b166db72fa8796aa4da98f9fc01e348c87a Gerrit-Change-Number: 43347 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-remsim[master]: handle_options(): exit(2) if an unparsed argument was given
by laforge 22 Aug '26

22 Aug '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43352?usp=email ) Change subject: handle_options(): exit(2) if an unparsed argument was given ...................................................................... handle_options(): exit(2) if an unparsed argument was given All osmo-remsim binaries are only supporting arguments starting with a dash ('-'), but no positional argument. Ensure all binaries will exit when an positional argument was given and do the same when an unrecognized argument was given. Change-Id: I84658bda7614d9463bd7d20eb584da8e7050f1e5 --- M src/bankd/bankd_main.c M src/client/remsim_client_main.c M src/server/remsim_server.c 3 files changed, 28 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index 9ef05a4..f924cfb 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -399,8 +399,20 @@ case 'e': log_set_log_level(osmo_stderr_target, atoi(optarg)); break; + case '?': + /* unsupported/unrecognized argument */ + exit(2); + break; + default: + break; } } + + if (argc > optind) { + while (optind < argc) + fprintf(stderr, "Unsupported positional arguments on command line %s\n", argv[optind++]); + exit(2); + } } int main(int argc, char **argv) diff --git a/src/client/remsim_client_main.c b/src/client/remsim_client_main.c index ff89478..3145f49 100644 --- a/src/client/remsim_client_main.c +++ b/src/client/remsim_client_main.c @@ -163,10 +163,20 @@ cfg->usb.path = optarg; break; #endif + case '?': + /* unsupported/unrecognized argument */ + exit(2); + break; default: break; } } + + if (argc > optind) { + while (optind < argc) + fprintf(stderr, "Unsupported positional arguments on command line %s\n", argv[optind++]); + exit(2); + } } diff --git a/src/server/remsim_server.c b/src/server/remsim_server.c index 3687f15..1821938 100644 --- a/src/server/remsim_server.c +++ b/src/server/remsim_server.c @@ -71,6 +71,10 @@ case 'L': log_set_use_color(osmo_stderr_target, 0); break; + case '?': + /* unsupported/unrecognized argument */ + exit(2); + break; default: /* ignore */ break; @@ -78,7 +82,8 @@ } if (argc > optind) { - fprintf(stderr, "Unsupported extra positional arguments in command line\n"); + while (optind < argc) + fprintf(stderr, "Unsupported positional arguments on command line %s\n", argv[optind++]); exit(2); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43352?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I84658bda7614d9463bd7d20eb584da8e7050f1e5 Gerrit-Change-Number: 43352 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-remsim[master]: remsim_client: only set usb parameters if given by arguments
by laforge 22 Aug '26

22 Aug '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43347?usp=email ) Change subject: remsim_client: only set usb parameters if given by arguments ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43347?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I30f27b166db72fa8796aa4da98f9fc01e348c87a Gerrit-Change-Number: 43347 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 22 Aug 2026 08:15:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-remsim[master]: handle_options(): exit(2) if an unparsed argument was given
by laforge 22 Aug '26

22 Aug '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43352?usp=email ) Change subject: handle_options(): exit(2) if an unparsed argument was given ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43352?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I84658bda7614d9463bd7d20eb584da8e7050f1e5 Gerrit-Change-Number: 43352 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 22 Aug 2026 08:15:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-remsim[master]: handle_options(): exit(2) if an unparsed argument was given
by laforge 22 Aug '26

22 Aug '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43352?usp=email ) Change subject: handle_options(): exit(2) if an unparsed argument was given ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43352?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I84658bda7614d9463bd7d20eb584da8e7050f1e5 Gerrit-Change-Number: 43352 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 22 Aug 2026 08:15:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-remsim[master]: remsim_client: only set usb parameters if given by arguments
by laforge 22 Aug '26

22 Aug '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43347?usp=email ) Change subject: remsim_client: only set usb parameters if given by arguments ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43347?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I30f27b166db72fa8796aa4da98f9fc01e348c87a Gerrit-Change-Number: 43347 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 22 Aug 2026 08:14:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026