August 2026 - gerrit-log - lists.osmocom.org

[S] Change in onomondo-ipa[master]: V1.2: Add eimTransactionId to InitiateAuthenticationRequestEsipa
by jolly 03 Aug '26

03 Aug '26

Attention is currently required from: dexter, jolly. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43056?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: V1.2: Add eimTransactionId to InitiateAuthenticationRequestEsipa ...................................................................... V1.2: Add eimTransactionId to InitiateAuthenticationRequestEsipa Add new eimTransactionId field to InitiateAuthenticationRequestEsipa. The eimTransactionId walks through the IPA process like this: * The eimTransactionId is retrieved from ProfileDownloadTriggerRequest at proc_eim_pkg_retr.c. * Then it is handed to the Common Mutual Authentication Procedure at proc_indirect_prfle_dwnld.c. * There it is handed to the InitiateAuthentication function at proc_cmn_mtl_auth.c. * There it is stored in initiateAuthenticationRequestEsipa at esipa_init_auth.c. Reference: SGP.32 Section 5.14.1 Related: SYS#8101 Change-Id: I1c8ef6fc0a3f7ab5735e401597fc8c6b2021fc09 --- M asn1/SGP32Definitions.asn M src/ipa/libasn/InitiateAuthenticationRequestEsipa.c M src/ipa/libasn/InitiateAuthenticationRequestEsipa.h M src/ipa/libipa/esipa_init_auth.c M src/ipa/libipa/esipa_init_auth.h M src/ipa/libipa/proc_cmn_mtl_auth.c M src/ipa/libipa/proc_cmn_mtl_auth.h M src/ipa/libipa/proc_eim_pkg_retr.c M src/ipa/libipa/proc_indirect_prfle_dwnld.c M src/ipa/libipa/proc_indirect_prfle_dwnld.h 10 files changed, 31 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/56/43056/2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43056?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I1c8ef6fc0a3f7ab5735e401597fc8c6b2021fc09 Gerrit-Change-Number: 43056 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: tcap: Avoid need of N_NOTICE.req
by fixeria 03 Aug '26

03 Aug '26

Attention is currently required from: daniel, laforge, lynxis lazus, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43152?usp=email ) Change subject: stp: tcap: Avoid need of N_NOTICE.req ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43152?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia1b7f487124584ab1720cb89bca5999cbb12392d Gerrit-Change-Number: 43152 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 03 Aug 2026 12:39:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: stp: Define IUT default T(beat) in mp_t_beat_sec_default
by fixeria 03 Aug '26

03 Aug '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43158?usp=email ) Change subject: stp: Define IUT default T(beat) in mp_t_beat_sec_default ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic518e0d35f377fef85344177b630eb8599ec22d0 Gerrit-Change-Number: 43158 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Aug 2026 12:39:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: Revert "deps: use a fork of titan.ProtocolEmulations.SCCP"
by fixeria 03 Aug '26

03 Aug '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43155?usp=email ) Change subject: Revert "deps: use a fork of titan.ProtocolEmulations.SCCP" ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43155?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4eb81e0ffc6500340199c4a23a7aabfee925c33b Gerrit-Change-Number: 43155 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Aug 2026 12:39:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: Revert "stp: add ASP_SCCP_N_NOTICE_req support and f_asp_tx_notice()"
by fixeria 03 Aug '26

03 Aug '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43154?usp=email ) Change subject: Revert "stp: add ASP_SCCP_N_NOTICE_req support and f_asp_tx_notice()" ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43154?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iecce8999b72b363a7aa3f583beeb937e79fe215f Gerrit-Change-Number: 43154 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Aug 2026 12:39:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: Revert "stp: Add TCAP_N_NOTICE_req to send a UDTS with TCAP payload"
by fixeria 03 Aug '26

03 Aug '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43153?usp=email ) Change subject: Revert "stp: Add TCAP_N_NOTICE_req to send a UDTS with TCAP payload" ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43153?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4e96d9f0ceaafb2b5883b0e1f2d8d9f6065fd415 Gerrit-Change-Number: 43153 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Aug 2026 12:38:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: tcap: Avoid need of N_NOTICE.req
by fixeria 03 Aug '26

03 Aug '26

Attention is currently required from: daniel, laforge, lynxis lazus, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43152?usp=email ) Change subject: stp: tcap: Avoid need of N_NOTICE.req ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43152?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia1b7f487124584ab1720cb89bca5999cbb12392d Gerrit-Change-Number: 43152 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 03 Aug 2026 12:38:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: tcap: Avoid need of N_NOTICE.req
by pespin 03 Aug '26

03 Aug '26

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43152?usp=email ) Change subject: stp: tcap: Avoid need of N_NOTICE.req ...................................................................... Patch Set 2: (1 comment) File stp/STP_Tests_TCAP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43152/comment/7707aab8_084c… : PS1, Line 227: SCCP_PAR_Reason_For_Return reasonForReturn > unused Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43152?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia1b7f487124584ab1720cb89bca5999cbb12392d Gerrit-Change-Number: 43152 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 03 Aug 2026 12:31:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: stp: Define IUT default T(beat) in mp_t_beat_sec_default
by pespin 03 Aug '26

03 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43158?usp=email ) Change subject: stp: Define IUT default T(beat) in mp_t_beat_sec_default ...................................................................... stp: Define IUT default T(beat) in mp_t_beat_sec_default Several tests expect to know this value from the IUT in order to test related features. Since it will be used in more places in follow-up patches, move it so the information only needs to be configured once. Change-Id: Ic518e0d35f377fef85344177b630eb8599ec22d0 --- M stp/STP_Tests_Common.ttcn M stp/STP_Tests_IPA.ttcn M stp/STP_Tests_M3UA.ttcn 3 files changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/58/43158/1 diff --git a/stp/STP_Tests_Common.ttcn b/stp/STP_Tests_Common.ttcn index 0a0a436..16b6406 100644 --- a/stp/STP_Tests_Common.ttcn +++ b/stp/STP_Tests_Common.ttcn @@ -28,6 +28,11 @@ import from SCCPasp_Types all; import from SCCP_Emulation all; +modulepar { + /* Default T(beat) configured at the IUT ASP, in seconds */ + integer mp_t_beat_sec_default := 30; +} + function f_SCCP_UDT(template (value) SCCP_PAR_Address calling := ts_SccpAddr_GT('5678'H), template (value) SCCP_PAR_Address called := ts_SccpAddr_GT('1234'H), template (omit) octetstring data := omit) return octetstring diff --git a/stp/STP_Tests_IPA.ttcn b/stp/STP_Tests_IPA.ttcn index 431bdd4..7225949 100644 --- a/stp/STP_Tests_IPA.ttcn +++ b/stp/STP_Tests_IPA.ttcn @@ -849,7 +849,7 @@ } /* return to default value: */ - f_vty_cs7_ipa_asp_cmd(g_ipa_configs[0], "timer xua beat 30"); + f_vty_cs7_ipa_asp_cmd(g_ipa_configs[0], "timer xua beat " & int2str(STP_Tests_Common.mp_t_beat_sec_default)); } /* Test the IUT sends heartbeat procedure when needed. */ diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn index ac9cc25..7debed6 100644 --- a/stp/STP_Tests_M3UA.ttcn +++ b/stp/STP_Tests_M3UA.ttcn @@ -598,7 +598,7 @@ } /* return to default value: */ - f_vty_cs7_asp_cmd(g_m3ua_configs[0], "timer xua beat 30"); + f_vty_cs7_asp_cmd(g_m3ua_configs[0], "timer xua beat " & int2str(STP_Tests_Common.mp_t_beat_sec_default)); f_clear_m3ua(); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic518e0d35f377fef85344177b630eb8599ec22d0 Gerrit-Change-Number: 43158 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: tcap: Avoid need of N_NOTICE.req
by pespin 03 Aug '26

03 Aug '26

Attention is currently required from: daniel, laforge, lynxis lazus, osmith, pespin. Hello Jenkins Builder, daniel, fixeria, laforge, lynxis lazus, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43152?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: stp: tcap: Avoid need of N_NOTICE.req ...................................................................... stp: tcap: Avoid need of N_NOTICE.req Commits 7970ceaead78ff224390a25f416b22bcd8e4e37e..32618160bdb154ca756c783b67b131533226f7ae added a fork of titan.Protocol.Emulations.SCCP with a new N-NOTICE.req primitive which was needed in STP_Tests_TCAP to trigger transmission of a UDTS message. That primitive doesn't exist in the specs, since no user of SCCP is expected to be requesting a transmision of UDTS. Hence, this commit rewrites the test to avoid the need for such a primitive, by hooking directly into the lower layer MTP3 User SAP (M3UA or IPA) and crafting and transmitting the SCCP UDTS over there directly. Follow up commits will revert the commits adding such a N-NOTICE req to the SCCP and TCAP layers. Related: SYS#8090 Change-Id: Ia1b7f487124584ab1720cb89bca5999cbb12392d --- M stp/STP_Tests_TCAP.ttcn 1 file changed, 77 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/52/43152/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43152?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia1b7f487124584ab1720cb89bca5999cbb12392d Gerrit-Change-Number: 43152 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0