August 2026 - gerrit-log - lists.osmocom.org

[L] Change in osmo-trx[master]: Transceiver52M: migrate to libosmo-trx
by fixeria 04 Aug '26

04 Aug '26

Attention is currently required from: Hoernchen, fixeria, tnt. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/43115?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Transceiver52M: migrate to libosmo-trx ...................................................................... Transceiver52M: migrate to libosmo-trx Replace the local TRXC/TRXD implementation with libosmo-trx's shared osmo_trxc_msg/osmo_trxd_burst_{ind,req} API, including SETSLOT parsing via osmo_trxc_setslot_parse()/_build(). Take a chance to fix SETSLOT to always send a response, distinguishing bogus input from unsupported VAMOS channel combinations. Only the TRXC/TRXD build/parse API is used here, not the osmo_trx_ep endpoint API: osmo-trx runs its socket I/O on dedicated threads that don't drive osmo_select_main(), which osmo_trx_ep depends on. Change-Id: I458ec85c56e2101d073c8c35f11c147191c4ea0c Related: OS#5283 --- M Transceiver52M/Makefile.am M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h D Transceiver52M/proto_trxd.c D Transceiver52M/proto_trxd.h M Transceiver52M/sigProcLib.cpp M Transceiver52M/sigProcLib.h 7 files changed, 308 insertions(+), 496 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/15/43115/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43115?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I458ec85c56e2101d073c8c35f11c147191c4ea0c Gerrit-Change-Number: 43115 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-CC: tnt <tnt(a)246tNt.com> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XL] Change in osmo-trx[master]: libosmo-trx: generate Doxygen API documentation
by fixeria 04 Aug '26

04 Aug '26

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/43113?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified-1 by Jenkins Builder Change subject: libosmo-trx: generate Doxygen API documentation ...................................................................... libosmo-trx: generate Doxygen API documentation Add Doxyfile.trx.in (based on Doxyfile.core.in from libosmocore.git, upgraded using 'doxygen -u' to get rid of obsolete tags) and the usual rules to build and install the HTML documentation, as well as the --disable-doxygen configure option, like in other libosmo-* projects. Change-Id: I54cf8c0c60215c666d8fa55dafec53379a2382d5 --- M .gitignore M configure.ac A libosmo-trx/Doxyfile.trx.in M libosmo-trx/Makefile.am 4 files changed, 3,027 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/13/43113/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43113?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I54cf8c0c60215c666d8fa55dafec53379a2382d5 Gerrit-Change-Number: 43113 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: asp: vty: Explicitly test timer lm value ranges
by pespin 04 Aug '26

04 Aug '26

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43157?usp=email ) Change subject: asp: vty: Explicitly test timer lm value ranges ...................................................................... Patch Set 1: (1 comment) File src/ss7_asp_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43157/comment/de16bdc1_f4770… : PS1, Line 906: return CMD_WARNING; > same here as in the previous patch, print a message here? Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43157?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9b2c426a1eaceb6e7c5fbe35872ada324fef5733 Gerrit-Change-Number: 43157 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Aug 2026 15:09:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: asp: Support setting timer xua beat 0 through VTY
by pespin 04 Aug '26

04 Aug '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43156?usp=email ) Change subject: asp: Support setting timer xua beat 0 through VTY ...................................................................... asp: Support setting timer xua beat 0 through VTY Previous VTY configured range for the set of tdefs in timer xua didn't allow to pass a 0 to it, which "timer xua beat 0" should be able to accept in order to disable heartbeat procedure on the ASP. In order to fix it: * Change VTY range to minimal accepted value to 0 for the whole tdef set. * Make sure the VTY command validates and rejects user trying to set a value outside the accepted range of the specific timer. * Set .min_val=1 in SS7_ASP_XUA_T_ACK, so it can't accept value 0. According to spec, T(ack) is always expected to be set, even if the resulting timeout may be handled by LM instead of simply retransmitting the packet. * Write vty tests to validate the restrictions are followed properly in the VTY. Related: SYS#8156 Change-Id: Iadd7c6751ab09640fd2df214afa2ec87274a3210 --- M src/ss7_asp.c M src/ss7_asp_vty.c M tests/vty/osmo_stp_test.vty M tests/vty/ss7_asp_test.vty 4 files changed, 101 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/src/ss7_asp.c b/src/ss7_asp.c index c47ee7c..5a47248 100644 --- a/src/ss7_asp.c +++ b/src/ss7_asp.c @@ -121,9 +121,10 @@ const struct osmo_tdef ss7_asp_xua_timer_defaults[SS7_ASP_XUA_TIMERS_LEN] = { { .T = SS7_ASP_XUA_T_ACK, .default_val = SS7_ASP_XUA_DEFAULT_T_ACK_SEC, .unit = OSMO_TDEF_S, - .desc = "Resend ASP Up/Down/Active/Inactive after timeout waiting for ASP Up/Down/Active/Inactive ACK (ASP role)(s)" }, + .desc = "T(ack): Resend ASP Up/Down/Active/Inactive after timeout waiting for ASP Up/Down/Active/Inactive ACK (ASP role) (s)", + .min_val = 1 }, { .T = SS7_ASP_XUA_T_BEAT, .default_val = SS7_ASP_XUA_DEFAULT_T_BEAT_SEC, .unit = OSMO_TDEF_S, - .desc = "Heartbeat Timer (0 = disabled) (s)" }, + .desc = "T(beat): Heartbeat Timer (0 = disabled) (s)" }, {} }; diff --git a/src/ss7_asp_vty.c b/src/ss7_asp_vty.c index c38b5b8..21d19d6 100644 --- a/src/ss7_asp_vty.c +++ b/src/ss7_asp_vty.c @@ -814,20 +814,34 @@ return CMD_SUCCESS; } -/* timer xua <name> <1-999999> +/* timer xua <name> <0-999999> * (cmdstr and doc are dynamically generated from ss7_asp_xua_timer_names.) */ DEFUN_ATTR(asp_timer_xua, asp_timer_xua_cmd, NULL, NULL, CMD_ATTR_IMMEDIATE) { struct osmo_ss7_asp *asp = vty->index; enum ss7_asp_xua_timer timer = get_string_value(ss7_asp_xua_timer_names, argv[0]); + int rc; + unsigned long new_val = atoi(argv[1]); if (timer <= 0 || timer >= SS7_ASP_XUA_TIMERS_LEN) { vty_out(vty, "%% Invalid timer: %s%s", argv[0], VTY_NEWLINE); return CMD_WARNING; } - osmo_tdef_set(asp->cfg.T_defs_xua, timer, atoi(argv[1]), OSMO_TDEF_S); + rc = osmo_tdef_set(asp->cfg.T_defs_xua, timer, new_val, OSMO_TDEF_S); + if (rc < 0) { + struct osmo_tdef *t = osmo_tdef_get_entry(asp->cfg.T_defs_xua, timer); + if (!t) + return CMD_WARNING; + if (!osmo_tdef_val_in_range(t, new_val)) { + char range_str[64]; + osmo_tdef_range_str_buf(range_str, sizeof(range_str), t); + vty_out(vty, "%% Timer %s value %lu is out of range %s%s", + argv[0], new_val, range_str, VTY_NEWLINE); + } + return CMD_WARNING; + } return CMD_SUCCESS; } @@ -861,7 +875,7 @@ def->default_val); } - osmo_talloc_asprintf(tall_vty_ctx, cmd_str, ") <1-999999>"); + osmo_talloc_asprintf(tall_vty_ctx, cmd_str, ") <0-999999>"); osmo_talloc_asprintf(tall_vty_ctx, doc_str, "Timer value, in seconds\n"); diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty index 1b452c8..2dbd5b2 100644 --- a/tests/vty/osmo_stp_test.vty +++ b/tests/vty/osmo_stp_test.vty @@ -302,7 +302,7 @@ no destination-audit asp-active quirk (no_notify|daud_in_asp|snm_inactive) no quirk (no_notify|daud_in_asp|snm_inactive) - timer xua (ack|beat) <1-999999> + timer xua (ack|beat) <0-999999> timer lm (wait_asp_up|wait_notify|wait_notify_rkm|wait_rk_reg_resp) <1-999999> block no block @@ -386,6 +386,36 @@ ... end OsmoSTP(config-cs7-asp)# no shutdown + +OsmoSTP(config-cs7-asp)# ### Test ASP node timers +OsmoSTP(config-cs7-asp)# timer ? + xua Configure ASP default xua timer values + lm Configure ASP default lm timer values +OsmoSTP(config-cs7-asp)# timer xua ? + ack T(ack): Resend ASP Up/Down/Active/Inactive after timeout waiting for ASP Up/Down/Active/Inactive ACK (ASP role) (s) (default: 2) + beat T(beat): Heartbeat Timer (0 = disabled) (s) (default: 30) +OsmoSTP(config-cs7-asp)# timer xua beat 0 +OsmoSTP(config-cs7-asp)# show running-config +... + asp my-asp 12345 54321 m3ua +... + timer xua beat 0 +... +OsmoSTP(config-cs7-asp)# timer xua beat 5 +OsmoSTP(config-cs7-asp)# show running-config +... + asp my-asp 12345 54321 m3ua +... + timer xua beat 5 +... +OsmoSTP(config-cs7-asp)# timer xua beat 30 +OsmoSTP(config-cs7-asp)# show running-config +... + asp my-asp 12345 54321 m3ua +... !timer xua beat 30 +... + + OsmoSTP(config-cs7-asp)# exit % NOTE: Skipping automatic restart of ASP since an explicit '[no] shutdown' command was entered OsmoSTP(config-cs7)# as my-ass m3ua diff --git a/tests/vty/ss7_asp_test.vty b/tests/vty/ss7_asp_test.vty index e93e037..f3193b6 100644 --- a/tests/vty/ss7_asp_test.vty +++ b/tests/vty/ss7_asp_test.vty @@ -298,7 +298,7 @@ no destination-audit asp-active quirk (no_notify|daud_in_asp|snm_inactive) no quirk (no_notify|daud_in_asp|snm_inactive) - timer xua (ack|beat) <1-999999> + timer xua (ack|beat) <0-999999> timer lm (wait_asp_up|wait_notify|wait_notify_rkm|wait_rk_reg_resp) <1-999999> block no block @@ -383,6 +383,55 @@ remote-ip 127.0.0.201 ... end + +ss7_asp_vty_test(config-cs7-asp)# ### Test ASP node timers +ss7_asp_vty_test(config-cs7-asp)# timer ? + xua Configure ASP default xua timer values + lm Configure ASP default lm timer values +ss7_asp_vty_test(config-cs7-asp)# timer xua ? + ack T(ack): Resend ASP Up/Down/Active/Inactive after timeout waiting for ASP Up/Down/Active/Inactive ACK (ASP role) (s) (default: 2) + beat T(beat): Heartbeat Timer (0 = disabled) (s) (default: 30) +ss7_asp_vty_test(config-cs7-asp)# timer xua ack 1 +ss7_asp_vty_test(config-cs7-asp)# show running-config +... + asp my-asp 12345 54321 m3ua +... + timer xua ack 1 +... +ss7_asp_vty_test(config-cs7-asp)# timer xua ack 2 +ss7_asp_vty_test(config-cs7-asp)# show running-config +... + asp my-asp 12345 54321 m3ua +... !timer xua ack 1 +... +ss7_asp_vty_test(config-cs7-asp)# timer xua ack 0 +% Timer ack value 0 is out of range [1 .. inf] +ss7_asp_vty_test(config-cs7-asp)# show running-config +... + asp my-asp 12345 54321 m3ua +... !timer xua ack 0 +... +ss7_asp_vty_test(config-cs7-asp)# timer xua beat 0 +ss7_asp_vty_test(config-cs7-asp)# show running-config +... + asp my-asp 12345 54321 m3ua +... + timer xua beat 0 +... +ss7_asp_vty_test(config-cs7-asp)# timer xua beat 5 +ss7_asp_vty_test(config-cs7-asp)# show running-config +... + asp my-asp 12345 54321 m3ua +... + timer xua beat 5 +... +ss7_asp_vty_test(config-cs7-asp)# timer xua beat 30 +ss7_asp_vty_test(config-cs7-asp)# show running-config +... + asp my-asp 12345 54321 m3ua +... !timer xua beat 30 +... + ss7_asp_vty_test(config-cs7-asp)# exit % NOTE: Make sure to use '[no] shutdown' command in 'asp' node in order to restart the ASP for new configs to be applied. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iadd7c6751ab09640fd2df214afa2ec87274a3210 Gerrit-Change-Number: 43156 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: asp: vty: Explicitly test timer lm value ranges
by pespin 04 Aug '26

04 Aug '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43157?usp=email ) Change subject: asp: vty: Explicitly test timer lm value ranges ...................................................................... asp: vty: Explicitly test timer lm value ranges Validate the value to be set provided by user over VTY is actually within the range of the specific tdef being set. Mark all of them explicitly as min_val=1 in its tdef, since they are not expected to be set to 0 (see also gen_asp_timer_lm_cmd_strs() defining a VTY range <1..999999>). Change-Id: I9b2c426a1eaceb6e7c5fbe35872ada324fef5733 --- M src/ss7_asp_vty.c M src/xua_default_lm_fsm.c M tests/vty/osmo_stp_test.vty M tests/vty/ss7_asp_test.vty 4 files changed, 34 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/src/ss7_asp_vty.c b/src/ss7_asp_vty.c index 21d19d6..5136105 100644 --- a/src/ss7_asp_vty.c +++ b/src/ss7_asp_vty.c @@ -891,13 +891,27 @@ { struct osmo_ss7_asp *asp = vty->index; enum ss7_asp_lm_timer timer = get_string_value(ss7_asp_lm_timer_names, argv[0]); + int rc; + unsigned long new_val = atoi(argv[1]); if (timer <= 0 || timer >= SS7_ASP_LM_TIMERS_LEN) { vty_out(vty, "%% Invalid timer: %s%s", argv[0], VTY_NEWLINE); return CMD_WARNING; } - osmo_tdef_set(asp->cfg.T_defs_lm, timer, atoi(argv[1]), OSMO_TDEF_S); + rc = osmo_tdef_set(asp->cfg.T_defs_lm, timer, new_val, OSMO_TDEF_S); + if (rc < 0) { + struct osmo_tdef *t = osmo_tdef_get_entry(asp->cfg.T_defs_lm, timer); + if (!t) + return CMD_WARNING; + if (!osmo_tdef_val_in_range(t, new_val)) { + char range_str[64]; + osmo_tdef_range_str_buf(range_str, sizeof(range_str), t); + vty_out(vty, "%% Timer %s value %lu is out of range %s%s", + argv[0], new_val, range_str, VTY_NEWLINE); + } + return CMD_WARNING; + } return CMD_SUCCESS; } diff --git a/src/xua_default_lm_fsm.c b/src/xua_default_lm_fsm.c index 73c4fdc..db84e6e 100644 --- a/src/xua_default_lm_fsm.c +++ b/src/xua_default_lm_fsm.c @@ -102,13 +102,17 @@ const struct osmo_tdef ss7_asp_lm_timer_defaults[SS7_ASP_LM_TIMERS_LEN] = { { .T = SS7_ASP_LM_T_WAIT_ASP_UP, .default_val = 20, .unit = OSMO_TDEF_S, - .desc = "Restart ASP after timeout waiting for ASP UP (SG role) / ASP UP ACK (ASP role) (s)" }, + .desc = "Restart ASP after timeout waiting for ASP UP (SG role) / ASP UP ACK (ASP role) (s)", + .min_val = 1 }, { .T = SS7_ASP_LM_T_WAIT_NOTIFY, .default_val = 2, .unit = OSMO_TDEF_S, - .desc = "Restart ASP after timeout waiting for NOTIFY (s)" }, + .desc = "Restart ASP after timeout waiting for NOTIFY (s)", + .min_val = 1 }, { .T = SS7_ASP_LM_T_WAIT_NOTIY_RKM, .default_val = 20, .unit = OSMO_TDEF_S, - .desc = "Restart ASP after timeout waiting for NOTIFY after RKM registration (s)" }, + .desc = "Restart ASP after timeout waiting for NOTIFY after RKM registration (s)", + .min_val = 1 }, { .T = SS7_ASP_LM_T_WAIT_RK_REG_RESP, .default_val = 10, .unit = OSMO_TDEF_S, - .desc = "Restart ASP after timeout waiting for RK_REG_RESP (s)" }, + .desc = "Restart ASP after timeout waiting for RK_REG_RESP (s)", + .min_val = 1 }, {} }; diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty index 2dbd5b2..d52ae5f 100644 --- a/tests/vty/osmo_stp_test.vty +++ b/tests/vty/osmo_stp_test.vty @@ -415,6 +415,11 @@ ... !timer xua beat 30 ... +OsmoSTP(config-cs7-asp)# timer lm ? + wait_asp_up Restart ASP after timeout waiting for ASP UP (SG role) / ASP UP ACK (ASP role) (s) (default: 20) + wait_notify Restart ASP after timeout waiting for NOTIFY (s) (default: 2) + wait_notify_rkm Restart ASP after timeout waiting for NOTIFY after RKM registration (s) (default: 20) + wait_rk_reg_resp Restart ASP after timeout waiting for RK_REG_RESP (s) (default: 10) OsmoSTP(config-cs7-asp)# exit % NOTE: Skipping automatic restart of ASP since an explicit '[no] shutdown' command was entered diff --git a/tests/vty/ss7_asp_test.vty b/tests/vty/ss7_asp_test.vty index f3193b6..5ea965b 100644 --- a/tests/vty/ss7_asp_test.vty +++ b/tests/vty/ss7_asp_test.vty @@ -432,6 +432,12 @@ ... !timer xua beat 30 ... +ss7_asp_vty_test(config-cs7-asp)# timer lm ? + wait_asp_up Restart ASP after timeout waiting for ASP UP (SG role) / ASP UP ACK (ASP role) (s) (default: 20) + wait_notify Restart ASP after timeout waiting for NOTIFY (s) (default: 2) + wait_notify_rkm Restart ASP after timeout waiting for NOTIFY after RKM registration (s) (default: 20) + wait_rk_reg_resp Restart ASP after timeout waiting for RK_REG_RESP (s) (default: 10) + ss7_asp_vty_test(config-cs7-asp)# exit % NOTE: Make sure to use '[no] shutdown' command in 'asp' node in order to restart the ASP for new configs to be applied. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43157?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9b2c426a1eaceb6e7c5fbe35872ada324fef5733 Gerrit-Change-Number: 43157 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: asp: vty: Explicitly test timer lm value ranges
by fixeria 04 Aug '26

04 Aug '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43157?usp=email ) Change subject: asp: vty: Explicitly test timer lm value ranges ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43157?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9b2c426a1eaceb6e7c5fbe35872ada324fef5733 Gerrit-Change-Number: 43157 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Aug 2026 15:08:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: asp: Support setting timer xua beat 0 through VTY
by fixeria 04 Aug '26

04 Aug '26

Attention is currently required from: daniel, laforge, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43156?usp=email ) Change subject: asp: Support setting timer xua beat 0 through VTY ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iadd7c6751ab09640fd2df214afa2ec87274a3210 Gerrit-Change-Number: 43156 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Aug 2026 15:07:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: sccp2sua: fix buffer overrun in osmo_isup_party_parse()
by pespin 04 Aug '26

04 Aug '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43163?usp=email ) Change subject: sccp2sua: fix buffer overrun in osmo_isup_party_parse() ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43163?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iccfbcf22a719544399c7a524b293de9e1a040cf8 Gerrit-Change-Number: 43163 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Aug 2026 15:00:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: sccp2sua: fix buffer overrun in osmo_isup_party_parse()
by fixeria 04 Aug '26

04 Aug '26

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43163?usp=email ) Change subject: sccp2sua: fix buffer overrun in osmo_isup_party_parse() ...................................................................... Patch Set 3: (1 comment) File src/sccp2sua.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43163/comment/d72f27b7_18503… : PS1, Line 74: if (in_num_bytes * 2 >= out_digits_size) > Ah, I guess I know what you mean. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43163?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iccfbcf22a719544399c7a524b293de9e1a040cf8 Gerrit-Change-Number: 43163 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Aug 2026 14:46:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: sccp2sua: fix buffer overrun in osmo_isup_party_parse()
by fixeria 04 Aug '26

04 Aug '26

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43163?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: sccp2sua: fix buffer overrun in osmo_isup_party_parse() ...................................................................... sccp2sua: fix buffer overrun in osmo_isup_party_parse() Add an out_digits_size parameter and check that the caller-provided buffer is large enough to hold the generated digits plus the terminating NUL, instead of blindly writing up to 2 * in_num_bytes characters into it. Change-Id: Iccfbcf22a719544399c7a524b293de9e1a040cf8 Fixes: OS#7038 --- M src/sccp2sua.c M src/xua_internal.h M tests/xua/xua_test.c M tests/xua/xua_test.ok 4 files changed, 37 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/63/43163/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43163?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iccfbcf22a719544399c7a524b293de9e1a040cf8 Gerrit-Change-Number: 43163 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0