August 2026 - gerrit-log - lists.osmocom.org

[M] Change in onomondo-ipa[master]: V1.2: Change remaining ASN1 definition to SGP.32 V1.2
by laforge 05 Aug '26

05 Aug '26

Attention is currently required from: dexter, jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43073?usp=email ) Change subject: V1.2: Change remaining ASN1 definition to SGP.32 V1.2 ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43073?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Ifa2546784a6d75170e4f5aae2a5e98edb2c0627a Gerrit-Change-Number: 43073 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Aug 2026 17:59:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in onomondo-ipa[master]: V1.2: Change of IpaEuiccDataRequest and results
by laforge 05 Aug '26

05 Aug '26

Attention is currently required from: dexter, jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43062?usp=email ) Change subject: V1.2: Change of IpaEuiccDataRequest and results ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43062?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I411111c71787ce27615b6b66fc8b19488883d15b Gerrit-Change-Number: 43062 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Aug 2026 17:59:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-trx[master]: Transceiver52M: make TRXDv2 burst batching configurable
by laforge 05 Aug '26

05 Aug '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43117?usp=email ) Change subject: Transceiver52M: make TRXDv2 burst batching configurable ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43117?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I2f58f87d85de5254bae6d7a606dffcd0ad4069d5 Gerrit-Change-Number: 43117 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Aug 2026 17:58:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: Transceiver52M: implement TRXDv2 support
by laforge 05 Aug '26

05 Aug '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43116?usp=email ) Change subject: Transceiver52M: implement TRXDv2 support ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43116?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie6a33e3980b3ca4ab05a3d4221d5a8ba0132233d Gerrit-Change-Number: 43116 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Aug 2026 17:57:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: debian: add packaging for libosmo-trx
by laforge 05 Aug '26

05 Aug '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43114?usp=email ) Change subject: debian: add packaging for libosmo-trx ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43114?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I56f0074ad121ecacb076b508d1adfdd71cce99ec Gerrit-Change-Number: 43114 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Aug 2026 17:57:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in osmo-trx[master]: libosmo-trx: generate Doxygen API documentation
by laforge 05 Aug '26

05 Aug '26

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43113?usp=email ) Change subject: libosmo-trx: generate Doxygen API documentation ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43113?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I54cf8c0c60215c666d8fa55dafec53379a2382d5 Gerrit-Change-Number: 43113 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Aug 2026 17:56:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in osmo-trx[master]: libosmo-trx/ep: add TRX endpoint module
by laforge 05 Aug '26

05 Aug '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email ) Change subject: libosmo-trx/ep: add TRX endpoint module ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I767fa43a9ca88be40c385f6dcb9de22891a6afc3 Gerrit-Change-Number: 43111 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Aug 2026 17:56:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: libosmo-trx/client: make public API operate on parsed messages
by laforge 05 Aug '26

05 Aug '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43110?usp=email ) Change subject: libosmo-trx/client: make public API operate on parsed messages ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43110?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Idf53513d06be2337383601494b225b5722c93129 Gerrit-Change-Number: 43110 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Aug 2026 17:55:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: libosmo-trx/client: add optional limit for retransmissions
by laforge 05 Aug '26

05 Aug '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43109?usp=email ) Change subject: libosmo-trx/client: add optional limit for retransmissions ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43109?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib90a032b38c69ae26023e726992d3f5f7e502fcf Gerrit-Change-Number: 43109 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Aug 2026 17:55:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: sccp2sua: fix buffer overrun in osmo_isup_party_parse()
by laforge 05 Aug '26

05 Aug '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43163?usp=email ) Change subject: sccp2sua: fix buffer overrun in osmo_isup_party_parse() ...................................................................... sccp2sua: fix buffer overrun in osmo_isup_party_parse() Add an out_digits_size parameter and check that the caller-provided buffer is large enough to hold the generated digits plus the terminating NUL, instead of blindly writing up to 2 * in_num_bytes characters into it. Change-Id: Iccfbcf22a719544399c7a524b293de9e1a040cf8 Fixes: OS#7038 --- M src/sccp2sua.c M src/xua_internal.h M tests/xua/xua_test.c M tests/xua/xua_test.ok 4 files changed, 37 insertions(+), 8 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/sccp2sua.c b/src/sccp2sua.c index 9ca1d7a..b8030a6 100644 --- a/src/sccp2sua.c +++ b/src/sccp2sua.c @@ -57,17 +57,23 @@ /*! \brief Parse ISUP style address of BCD digets * \param[out] out_digits user-allocated buffer for ASCII digits + * \param[in] out_digits_size size of the user-allocated output buffer * \param[in] in BCD-encoded digits * \param[in] in_num_bytes Size of \ref in in bytes * \param[in] odd Odd (true) or even (false) number of digits - * \returns number of digits generated + * \returns number of digits generated; negative on error * */ -int osmo_isup_party_parse(char *out_digits, const uint8_t *in, - unsigned int in_num_bytes, bool odd) +int osmo_isup_party_parse(char *out_digits, size_t out_digits_size, + const uint8_t *in, unsigned int in_num_bytes, bool odd) { char *out = out_digits; unsigned int i; + /* The output buffer must be large enough to accommodate for + * the generated digits plus the '\0' symbol. */ + if (in_num_bytes * 2 + (odd ? 0 : 1) > out_digits_size) + return -E2BIG; + for (i = 0; i < in_num_bytes; i++) { *out_digits++ = osmo_bcd2char(in[i] & 0x0F); if (i+1 == in_num_bytes && odd) @@ -203,7 +209,8 @@ sca->global_title_indicator); return -EINVAL; } - rc = osmo_isup_party_parse(out->gt.digits, cur, (addr+addrlen-cur), odd); + rc = osmo_isup_party_parse(out->gt.digits, sizeof(out->gt.digits), + cur, (addr+addrlen-cur), odd); if (rc < 0) return rc; diff --git a/src/xua_internal.h b/src/xua_internal.h index 3857a72..5195b35 100644 --- a/src/xua_internal.h +++ b/src/xua_internal.h @@ -140,8 +140,8 @@ int ipa_tx_xua_as(struct osmo_ss7_as *as, struct xua_msg *xua); int ipa_rx_msg(struct osmo_ss7_asp *asp, struct msgb *msg, uint8_t sls); -int osmo_isup_party_parse(char *out_digits, const uint8_t *in, - unsigned int in_num_bytes, bool odd); +int osmo_isup_party_parse(char *out_digits, size_t out_digits_size, + const uint8_t *in, unsigned int in_num_bytes, bool odd); int osmo_sccp_addr_parse(struct osmo_sccp_addr *out, const uint8_t *addr, unsigned int addrlen); int osmo_sccp_addr_encode(struct msgb *msg, const struct osmo_sccp_addr *in); diff --git a/tests/xua/xua_test.c b/tests/xua/xua_test.c index 0759ff7..3c5f5fd 100644 --- a/tests/xua/xua_test.c +++ b/tests/xua/xua_test.c @@ -42,15 +42,35 @@ char digits[23] = ""; int rc; - rc = osmo_isup_party_parse(digits, party0, ARRAY_SIZE(party0), false); + rc = osmo_isup_party_parse(digits, sizeof(digits), + party0, ARRAY_SIZE(party0), false); printf("digits='%s' (%d)\n", digits, rc); OSMO_ASSERT(rc == 8); OSMO_ASSERT(!strcmp(digits, "01234567")); - rc = osmo_isup_party_parse(digits, party0, ARRAY_SIZE(party0), true); + rc = osmo_isup_party_parse(digits, sizeof(digits), + party0, ARRAY_SIZE(party0), true); printf("digits='%s' (%d)\n", digits, rc); OSMO_ASSERT(rc == 7); OSMO_ASSERT(!strcmp(digits, "0123456")); + + /* out_digits_size exactly matches what's needed for an odd + * number of digits: must be accepted, not rejected with -E2BIG. */ + rc = osmo_isup_party_parse(digits, 8, party0, ARRAY_SIZE(party0), true); + printf("digits='%s' (%d)\n", digits, rc); + OSMO_ASSERT(rc == 7); + OSMO_ASSERT(!strcmp(digits, "0123456")); + + /* one byte too small: must be rejected. */ + rc = osmo_isup_party_parse(digits, 7, party0, ARRAY_SIZE(party0), true); + printf("rc=%d\n", rc); + OSMO_ASSERT(rc == -E2BIG); + + /* even number of digits, exact fit and one byte too small. */ + rc = osmo_isup_party_parse(digits, 9, party0, ARRAY_SIZE(party0), false); + OSMO_ASSERT(rc == 8); + rc = osmo_isup_party_parse(digits, 8, party0, ARRAY_SIZE(party0), false); + OSMO_ASSERT(rc == -E2BIG); } /* SCCP Address Parsing */ diff --git a/tests/xua/xua_test.ok b/tests/xua/xua_test.ok index 9d44775..02e5f49 100644 --- a/tests/xua/xua_test.ok +++ b/tests/xua/xua_test.ok @@ -1,5 +1,7 @@ digits='01234567' (8) digits='0123456' (7) +digits='0123456' (7) +rc=-7 sccp_addr_parse test case 0 expected: RI=1,SSN=6,GTI=4,GT=(TT=0,NPL=1,NAI=4,DIG=919969679389) parsed: RI=1,SSN=6,GTI=4,GT=(TT=0,NPL=1,NAI=4,DIG=919969679389) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43163?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iccfbcf22a719544399c7a524b293de9e1a040cf8 Gerrit-Change-Number: 43163 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0