August 2026 - gerrit-log - lists.osmocom.org

[M] Change in simtrace2[master]: Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA
by lynxis lazus 07 Aug '26

07 Aug '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email to look at the new patch set (#3). Change subject: Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA ...................................................................... Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA osmo_apdu_segment_in() don't have the context of the previous APDU, for nearly all calls this is fine, except for GP GET DATA, which can be a case 2 or case 4 APDU. GP GET DATA defines the Le field as 0x00 which is used to detect if this is a case 2 or case 4. But if the card responded to a case 2 GP GET DATA with Le = 0 with a SW 6cXX, the previous GP GET DATA case 2 must set the Le field to XX, which got misinterpreted by the osmo_apdu_segment_in() as a case 4 instead of a case 2 with Le != 0. Introduce osmo_apdu_segment_in2() containing the previous APDU as context. Related: SYS#8147 Change-Id: Ie238662e7e6a10dd4283ede0c8d8d73bc375c247 --- M TODO-RELEASE M host/Makefile.am M host/configure.ac M host/include/osmocom/simtrace2/apdu_dispatch.h M host/lib/apdu_dispatch.c A host/tests/apdu_dispatch/Makefile.am A host/tests/apdu_dispatch/apdu_dispatch_test.c A host/tests/apdu_dispatch/apdu_dispatch_test.ok A host/tests/testsuite.at 9 files changed, 156 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/85/43185/3 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ie238662e7e6a10dd4283ede0c8d8d73bc375c247 Gerrit-Change-Number: 43185 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in simtrace2[master]: cosmetic: fix typo in comment
by lynxis lazus 07 Aug '26

07 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/43186?usp=email ) Change subject: cosmetic: fix typo in comment ...................................................................... cosmetic: fix typo in comment Change-Id: I85939afd424c957ae872fa99f40b9cd528375537 --- M host/lib/apdu_dispatch.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/86/43186/1 diff --git a/host/lib/apdu_dispatch.c b/host/lib/apdu_dispatch.c index 4c8f505..f2fa64e 100644 --- a/host/lib/apdu_dispatch.c +++ b/host/lib/apdu_dispatch.c @@ -63,7 +63,7 @@ } /*! \brief input function for APDU segmentation - * \param ac APDU context accross successive calls + * \param ac APDU context across successive calls * \param[in] apdu_buf APDU inpud data buffer * \param[in] apdu_len Length of apdu_buf * \param[in] new_apdu Is this the beginning of a new APDU? -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43186?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I85939afd424c957ae872fa99f40b9cd528375537 Gerrit-Change-Number: 43186 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in simtrace2[master]: Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA
by lynxis lazus 07 Aug '26

07 Aug '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA ...................................................................... Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA osmo_apdu_segment_in() don't have the context of the previous APDU, for nearly all calls this is fine, except for GP GET DATA, which can be a case 2 or case 4 APDU. GP GET DATA defines the Le field as 0x00 which is used to detect if this is a case 2 or case 4. But if the card responded to a case 2 GP GET DATA with Le = 0 with a SW 6cXX, the previous GP GET DATA case 2 must set the Le field to XX, which got misinterpreted by the osmo_apdu_segment_in() as a case 4 instead of a case 2 with Le != 0. Introduce osmo_apdu_segment_in2() containing the previous APDU as context. Related: SYS#8147 Change-Id: Ie238662e7e6a10dd4283ede0c8d8d73bc375c247 --- M TODO-RELEASE M host/Makefile.am M host/configure.ac M host/include/osmocom/simtrace2/apdu_dispatch.h M host/lib/apdu_dispatch.c A host/tests/apdu_dispatch/Makefile.am A host/tests/apdu_dispatch/apdu_dispatch_test.c A host/tests/apdu_dispatch/apdu_dispatch_test.ok A host/tests/testsuite.at 9 files changed, 156 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/85/43185/2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ie238662e7e6a10dd4283ede0c8d8d73bc375c247 Gerrit-Change-Number: 43185 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

1 0

[M] Change in simtrace2[master]: Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA
by Jenkins Builder 07 Aug '26

07 Aug '26

Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email ) Change subject: Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA ...................................................................... Patch Set 1: (6 comments) File host/lib/apdu_dispatch.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/8c7325b1_b0456667?us… : PS1, Line 85: * \param ac APDU context accross successive calls 'accross' may be misspelled - perhaps 'across'? Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/0c317887_489f4c74?us… : PS1, Line 86: * \param prev_ac Previous APDU context accross successive calls 'accross' may be misspelled - perhaps 'across'? File host/tests/apdu_dispatch/apdu_dispatch_test.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/49267986_6a499543?us… : PS1, Line 78: printf("All tests passed.\n"); code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/0ca5dbd8_4fb38929?us… : PS1, Line 78: printf("All tests passed.\n"); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/e1a345ac_92187a79?us… : PS1, Line 79: return 0; code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/ec23c3c0_a00422c3?us… : PS1, Line 79: return 0; please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ie238662e7e6a10dd4283ede0c8d8d73bc375c247 Gerrit-Change-Number: 43185 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 07 Aug 2026 13:59:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in simtrace2[master]: Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA
by lynxis lazus 07 Aug '26

07 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email ) Change subject: Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA ...................................................................... Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA osmo_apdu_segment_in() don't have the context of the previous APDU, for nearly all calls this is fine, except for GP GET DATA, which can be a case 2 or case 4 APDU. GP GET DATA defines the Le field as 0x00 which is used to detect if this is a case 2 or case 4. But if the card responded to a case 2 GP GET DATA with Le = 0 with a SW 6cXX, the previous GP GET DATA case 2 must set the Le field to XX, which got misinterpreted by the osmo_apdu_segment_in() as a case 4 instead of a case 2 with Le != 0. Introduce osmo_apdu_segment_in2() containing the previous APDU as context. Related: SYS#8147 Change-Id: Ie238662e7e6a10dd4283ede0c8d8d73bc375c247 --- M TODO-RELEASE M host/Makefile.am M host/configure.ac M host/include/osmocom/simtrace2/apdu_dispatch.h M host/lib/apdu_dispatch.c A host/tests/apdu_dispatch/Makefile.am A host/tests/apdu_dispatch/apdu_dispatch_test.c A host/tests/apdu_dispatch/apdu_dispatch_test.ok A host/tests/testsuite.at 9 files changed, 156 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/85/43185/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 0ed7189..5922210 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmo-simtrace2 added osmo_apdu_segment_in2() diff --git a/host/Makefile.am b/host/Makefile.am index 338a46b..465a4e0 100644 --- a/host/Makefile.am +++ b/host/Makefile.am @@ -1,7 +1,7 @@ AUTOMAKE_OPTIONS = foreign dist-bzip2 1.6 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -SUBDIRS = include lib src contrib #tests examples doc +SUBDIRS = include lib src contrib tests # examples doc EXTRA_DIST = .version diff --git a/host/configure.ac b/host/configure.ac index 83a2b23..84b4147 100644 --- a/host/configure.ac +++ b/host/configure.ac @@ -100,4 +100,6 @@ src/Makefile lib/Makefile contrib/Makefile + tests/Makefile + tests/apdu_dispatch/Makefile Makefile) diff --git a/host/include/osmocom/simtrace2/apdu_dispatch.h b/host/include/osmocom/simtrace2/apdu_dispatch.h index 62ff762..f3c0ada 100644 --- a/host/include/osmocom/simtrace2/apdu_dispatch.h +++ b/host/include/osmocom/simtrace2/apdu_dispatch.h @@ -45,3 +45,6 @@ int osmo_apdu_segment_in(struct osmo_apdu_context *ac, const uint8_t *apdu_buf, unsigned int apdu_len, bool new_apdu); + +int osmo_apdu_segment_in2(struct osmo_apdu_context *ac, struct osmo_apdu_context *prev_ac, + const uint8_t *apdu_buf, unsigned int apdu_len, bool new_apdu); diff --git a/host/lib/apdu_dispatch.c b/host/lib/apdu_dispatch.c index 4c8f505..d504255 100644 --- a/host/lib/apdu_dispatch.c +++ b/host/lib/apdu_dispatch.c @@ -78,14 +78,54 @@ int osmo_apdu_segment_in(struct osmo_apdu_context *ac, const uint8_t *apdu_buf, unsigned int apdu_len, bool new_apdu) { + return osmo_apdu_segment_in2(ac, NULL, apdu_buf, apdu_len, new_apdu); +} + +/*! \brief input function for APDU segmentation + * \param ac APDU context accross successive calls + * \param prev_ac Previous APDU context accross successive calls + * \param[in] apdu_buf APDU input data buffer + * \param[in] apdu_len Length of apdu_buf + * \param[in] new_apdu Is this the beginning of a new APDU? + * + * The function returns APDU_ACT_TX_CAPDU_TO_CARD once there is + * sufficient data of the APDU received to transmit the command-APDU to + * the actual card. + * + * The function returns APDU_ACT_RX_MORE_CAPDU_FROM_READER when there + * is more data to be received from the card reader (GSM Phone). + */ +int osmo_apdu_segment_in2(struct osmo_apdu_context *ac, struct osmo_apdu_context *prev_ac, + const uint8_t *apdu_buf, unsigned int apdu_len, + bool new_apdu) +{ int rc = 0; if (new_apdu) { + if (prev_ac) + memcpy(prev_ac, ac, sizeof(*ac)); /* initialize the apdu context structure */ memset(ac, 0, sizeof(*ac)); /* copy APDU header over */ memcpy(&ac->hdr, apdu_buf, sizeof(ac->hdr)); ac->apdu_case = osim_determine_apdu_case(&osim_uicc_sim_cic_profile, apdu_buf); + + /* Corner case in GP when card returns SW 6CXX. + * Most of GP defines Le to be 0x00, except if card returned SW 6cXX, + * Le must be set to XX. osim_determine_apdu_case() might return the wrong + * APDU case because osim_determine_apdu_case() uses the Le field to determine if the + * GP GET DATA is a case 2 or 4 which fails when Le != 0. + */ + if (prev_ac && prev_ac->sw[0] == 0x6c && /* check if Le was invalid and must be set to sw[1] */ + ac->hdr.cla & 0x80 && /* check for GP */ + ((ac->hdr.ins & 0xca) == 0xca) && /* check for GET DATA */ + ac->hdr.cla == prev_ac->hdr.cla && /* check if CLA, INS, P1, P2 are equal */ + ac->hdr.ins == prev_ac->hdr.ins && + ac->hdr.p1 == prev_ac->hdr.p1 && + ac->hdr.p2 == prev_ac->hdr.p2) { + ac->apdu_case = prev_ac->apdu_case; + } + switch (ac->apdu_case) { case 1: /* P3 == 0, No Lc/Le */ ac->le.tot = ac->lc.tot = 0; diff --git a/host/tests/apdu_dispatch/Makefile.am b/host/tests/apdu_dispatch/Makefile.am new file mode 100644 index 0000000..06a07b5 --- /dev/null +++ b/host/tests/apdu_dispatch/Makefile.am @@ -0,0 +1,13 @@ +AM_LDFLAGS = -no-install +AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include +AM_CFLAGS=-Wall $(LIBOSMONETIF_CFLAGS) $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) +LDADD = $(top_builddir)/lib/.libs/libosmo-simtrace2.la \ + $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) $(LIBOSMOVTY_LIBS) $(LIBOSMONETIF_LIBS) $(LIBSCTP_LIBS) + +EXTRA_DIST = \ + apdu_dispatch_test.ok \ + $(NULL) + +check_PROGRAMS = apdu_dispatch_test + +apdu_dispatch_test_SOURCES = apdu_dispatch_test.c diff --git a/host/tests/apdu_dispatch/apdu_dispatch_test.c b/host/tests/apdu_dispatch/apdu_dispatch_test.c new file mode 100644 index 0000000..76b1ddd --- /dev/null +++ b/host/tests/apdu_dispatch/apdu_dispatch_test.c @@ -0,0 +1,80 @@ +#include <stdio.h> +#include <stdlib.h> +#include <string.h> +#include <stdint.h> + +#include <osmocom/simtrace2/apdu_dispatch.h> + +const uint8_t get_data_c2_ca[] = { 0x81, 0xCA, 0x00, 0x5A, 0x00 }; +const uint8_t get_data_c2_cb[] = { 0x81, 0xCB, 0x00, 0x5A, 0x00 }; + +/* teset data for 6cXX test */ +const uint8_t get_data_c2_ca_le_23[] = { 0x81, 0xCA, 0x00, 0x5A, 0x23 }; +const uint8_t get_data_c2_cb_le_23[] = { 0x81, 0xCb, 0x00, 0x5A, 0x23 }; + +#define APDU_SEGMENT_IN(apdu, exp_rc) \ + do { \ + memset(&ac, 0, sizeof(ac)); \ + memset(&prev_ac, 0, sizeof(prev_ac)); \ + printf("Testing " #apdu "\n"); \ + int rc = osmo_apdu_segment_in(&ac, apdu, ARRAY_SIZE(apdu), 1); \ + if (rc != exp_rc) \ + printf("%d (actual) != %d (intended)\n", rc, exp_rc);\ + OSMO_ASSERT(rc == exp_rc); \ + } while (0) + +#define APDU_SEGMENT_IN2(apdu, exp_rc) \ + do { \ + memset(&ac, 0, sizeof(ac)); \ + memset(&prev_ac, 0, sizeof(prev_ac)); \ + printf("Testing " #apdu "\n"); \ + int rc = osmo_apdu_segment_in2(&ac, &prev_ac, apdu, ARRAY_SIZE(apdu), 1); \ + if (rc != exp_rc) \ + printf("%d (actual) != %d (intended)\n", rc, exp_rc);\ + OSMO_ASSERT(rc == exp_rc); \ + } while (0) + +void test_apdu_dispatch_simple(void) +{ + struct osmo_apdu_context ac, prev_ac; + APDU_SEGMENT_IN(get_data_c2_ca, APDU_ACT_TX_CAPDU_TO_CARD); + APDU_SEGMENT_IN(get_data_c2_cb, APDU_ACT_TX_CAPDU_TO_CARD); + + APDU_SEGMENT_IN2(get_data_c2_ca, APDU_ACT_TX_CAPDU_TO_CARD); + APDU_SEGMENT_IN2(get_data_c2_cb, APDU_ACT_TX_CAPDU_TO_CARD); +} + +void test_apdu_dispatch_context(void) +{ + struct osmo_apdu_context ac, prev_ac; + int rc; + + printf("Testing GET DATA / 0xCA with SW 6Cxx\n"); + memset(&ac, 0, sizeof(ac)); + memset(&prev_ac, 0, sizeof(prev_ac)); + rc = osmo_apdu_segment_in2(&ac, &prev_ac, get_data_c2_ca, ARRAY_SIZE(get_data_c2_ca), 1); + OSMO_ASSERT(rc == APDU_ACT_TX_CAPDU_TO_CARD); + ac.sw[0] = 0x6c; + ac.sw[1] = 0x23; + rc = osmo_apdu_segment_in2(&ac, &prev_ac, get_data_c2_ca_le_23, ARRAY_SIZE(get_data_c2_ca_le_23), 1); + OSMO_ASSERT(rc == APDU_ACT_TX_CAPDU_TO_CARD); + + printf("Testing GET DATA / 0xCB with SW 6Cxx\n"); + memset(&ac, 0, sizeof(ac)); + memset(&prev_ac, 0, sizeof(prev_ac)); + rc = osmo_apdu_segment_in2(&ac, &prev_ac, get_data_c2_cb, ARRAY_SIZE(get_data_c2_cb), 1); + OSMO_ASSERT(rc == APDU_ACT_TX_CAPDU_TO_CARD); + ac.sw[0] = 0x6c; + ac.sw[1] = 0x23; + rc = osmo_apdu_segment_in2(&ac, &prev_ac, get_data_c2_cb_le_23, ARRAY_SIZE(get_data_c2_cb_le_23), 1); + OSMO_ASSERT(rc == APDU_ACT_TX_CAPDU_TO_CARD); +} + +int main(int argc, char **argv) +{ + test_apdu_dispatch_simple(); + test_apdu_dispatch_context(); + + printf("All tests passed.\n"); + return 0; +} diff --git a/host/tests/apdu_dispatch/apdu_dispatch_test.ok b/host/tests/apdu_dispatch/apdu_dispatch_test.ok new file mode 100644 index 0000000..108450f --- /dev/null +++ b/host/tests/apdu_dispatch/apdu_dispatch_test.ok @@ -0,0 +1,7 @@ +Testing get_data_c2_ca +Testing get_data_c2_cb +Testing get_data_c2_ca +Testing get_data_c2_cb +Testing GET DATA / 0xCA with SW 6Cxx +Testing GET DATA / 0xCB with SW 6Cxx +All tests passed. diff --git a/host/tests/testsuite.at b/host/tests/testsuite.at new file mode 100644 index 0000000..22fcdc4 --- /dev/null +++ b/host/tests/testsuite.at @@ -0,0 +1,9 @@ +AT_INIT +AT_BANNER([Regression tests.]) + +AT_SETUP([apdu_dispatch]) +AT_KEYWORDS([apdu_dispatch]) +cat $abs_srcdir/apdu_dispatch/apdu_dispatch_test.ok > expout +AT_CHECK([$abs_top_builddir/tests/apdu_dispatch/apdu_dispatch_test], [], [expout], [ignore]) +AT_CLEANUP + -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ie238662e7e6a10dd4283ede0c8d8d73bc375c247 Gerrit-Change-Number: 43185 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[L] Change in osmo-ttcn3-hacks[master]: library/euicc: add ESipa JSON encoder/decoder module
by dexter 07 Aug '26

07 Aug '26

Attention is currently required from: jolly. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43144?usp=email ) Change subject: library/euicc: add ESipa JSON encoder/decoder module ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43144?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8b6a87f39ca23658d980d19cf257b8994ea1cecb Gerrit-Change-Number: 43144 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 07 Aug 2026 13:05:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: eIM_Tests: set error code in f_TC_proc_euicc_data_req_err explicitly
by dexter 07 Aug '26

07 Aug '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43183?usp=email ) Change subject: eIM_Tests: set error code in f_TC_proc_euicc_data_req_err explicitly ...................................................................... eIM_Tests: set error code in f_TC_proc_euicc_data_req_err explicitly When the testcase responds to the eIM with the error message, the error code comes from a constant in the template. This means the testcase is harder to understand and may break if the template changes. Let's set the error code explcitly to avoid conflicts in the future. Related: SYS#8100 Change-Id: I06a97def123bb9196db2bab8fc94aaf5cef91c40 --- M eim/eIM_Tests.ttcn M library/euicc/SGP32Definitions_Templates.ttcn 2 files changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/83/43183/1 diff --git a/eim/eIM_Tests.ttcn b/eim/eIM_Tests.ttcn index adf5411..a9b127a 100644 --- a/eim/eIM_Tests.ttcn +++ b/eim/eIM_Tests.ttcn @@ -995,8 +995,9 @@ eimTransactionId := valueof(esipa_res.getEimPackageResponse.ipaEuiccDataRequest.eimTransactionId); /* Provide a plausible ipaEuiccDataResponse to the eIM */ - f_esipa_transceive(valueof(ts_provideEimPackageResult(eID, ts_eimPackageResult_euiccDataResp_err(eimTransactionId))), - tr_provideEimPackageResultResponse_empty); + f_esipa_transceive(valueof(ts_provideEimPackageResult(eID, + ts_eimPackageResult_euiccDataResp_err(eimTransactionId, ipaEuiccDataErrorCode := 127))), + tr_provideEimPackageResultResponse_empty); f_rest_lookup_resource(resource_id, "edr", tr_JSON_REST_success(outcome := expected_outcome) ); f_rest_delete_resource(resource_id, "edr"); diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index 6722e11..ea324d6 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -1508,11 +1508,12 @@ } } template (value) EimPackageResult -ts_eimPackageResult_euiccDataResp_err(template (omit) octetstring eimTransactionId := omit) := { +ts_eimPackageResult_euiccDataResp_err(template (omit) octetstring eimTransactionId := omit, + template (value) integer ipaEuiccDataErrorCode := 127) := { ipaEuiccDataResponse := { ipaEuiccDataResponseError := { eimTransactionId := eimTransactionId, - ipaEuiccDataErrorCode := 127 + ipaEuiccDataErrorCode := ipaEuiccDataErrorCode } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43183?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I06a97def123bb9196db2bab8fc94aaf5cef91c40 Gerrit-Change-Number: 43183 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: WIP: SGP32Definitions: apply (questionable) workaround
by dexter 07 Aug '26

07 Aug '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43184?usp=email ) Change subject: WIP: SGP32Definitions: apply (questionable) workaround ...................................................................... WIP: SGP32Definitions: apply (questionable) workaround Depends: onomondo-eim.git Change-Id I566571778d2433bd87a46276e81d9d526ae97325 Change-Id: I4e9834a8a5ae29397542c696c0bc81692d4d564b Related: SYS#8100 --- M library/euicc/SGP32Definitions.asn 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/84/43184/1 diff --git a/library/euicc/SGP32Definitions.asn b/library/euicc/SGP32Definitions.asn index dcfe1c5..04b13e8 100644 --- a/library/euicc/SGP32Definitions.asn +++ b/library/euicc/SGP32Definitions.asn @@ -818,9 +818,11 @@ pendingNotification [0] SGP32-PendingNotification, -- A Notification to be delivered to a Notification Receiver, possibly in compact format provideEimPackageResult [80] ProvideEimPackageResult -- Tag 'BF50' } +-- workaround: explicitly assign tag [0] to member transactionId, exactly like it is done with other esipa-types +-- workaround: explicitly assign tag [65] to member cancelSessionResponse, as it is done in other esipa-types CancelSessionRequestEsipa ::= [65] SEQUENCE { -- Tag 'BF41' - transactionId TransactionId, -- The TransactionID generated by the SM-DP+ - cancelSessionResponse SGP32-CancelSessionResponse -- This is the response from ES10b. CancelSession function, possibly in compact format + transactionId [0] TransactionId, -- The TransactionID generated by the SM-DP+ + cancelSessionResponse [65] SGP32-CancelSessionResponse -- This is the response from ES10b. CancelSession function, possibly in compact format } CancelSessionResponseEsipa ::= [65] CHOICE { -- Tag 'BF41' cancelSessionOk SGP32-CancelSessionOk, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43184?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4e9834a8a5ae29397542c696c0bc81692d4d564b Gerrit-Change-Number: 43184 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: eIM: add testcase to test an unsuccessful eUICC data request
by dexter 07 Aug '26

07 Aug '26

Attention is currently required from: jolly, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42955?usp=email ) Change subject: eIM: add testcase to test an unsuccessful eUICC data request ...................................................................... Patch Set 9: (1 comment) File eim/eIM_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42955/comment/16487627_5ab3… : PS8, Line 826: f_rest_lookup_resource(resource_id, "edr", tr_JSON_REST_success); > Maybe you should check, if the "undefinedError" was returned from eUICC. In a follow up patch (Change ID: I06a97def123bb9196db2bab8fc94aaf5cef91c40) I have edited the testacase (and the related template) passed in f_esipa_transceive so that it now sets the error code to 127 explicitly. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42955?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied212eb636cf46df5fc9f86ddee15c242c50d45a Gerrit-Change-Number: 42955 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 07 Aug 2026 13:04:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: eim/testenv: re-align path to restop.py
by dexter 07 Aug '26

07 Aug '26

Attention is currently required from: dexter. Hello Jenkins Builder, jolly, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43147?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: eim/testenv: re-align path to restop.py ...................................................................... eim/testenv: re-align path to restop.py The location of restop.py in the onomondo-eim git repository has changed. This patch re-alignes the path. Related: SYS#8100 Depends: onomondo-eim.git I4e42ce85c84b47d3561011083da4a1e54958fd8e Change-Id: I23b3085b4af8ed51c24f4b50385617e81f17a434 --- M eim/testenv.cfg 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/47/43147/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43147?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I23b3085b4af8ed51c24f4b50385617e81f17a434 Gerrit-Change-Number: 43147 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0