August 2026 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: pySim/apdu: protect SW access from None
by lynxis lazus 08 Aug '26

08 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/43197?usp=email ) Change subject: pySim/apdu: protect SW access from None ...................................................................... pySim/apdu: protect SW access from None If SW hasn't been set yet or is empty, protect access to sw Change-Id: Iff7fe02f700e0eb42766a3264a856fc7947cdcd2 --- M pySim/apdu/__init__.py 1 file changed, 7 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/97/43197/1 diff --git a/pySim/apdu/__init__.py b/pySim/apdu/__init__.py index 84ac83a..4344d3e 100644 --- a/pySim/apdu/__init__.py +++ b/pySim/apdu/__init__.py @@ -134,11 +134,12 @@ if callable(method): return method() # default case: only 9000 is success - if self.sw == b'\x90\x00': - return True - # This is not really a generic positive APDU SW but specific to UICC/SIM - if self.sw[0] == 0x91: - return True + if self.sw: + if self.sw == b'\x90\x00': + return True + # This is not really a generic positive APDU SW but specific to UICC/SIM + if self.sw[0] == 0x91: + return True return False @@ -423,7 +424,7 @@ def input_tpdu(self, tpdu:Tpdu): # handle SW=61xx / 6Cxx - if tpdu.sw[0] == 0x61 or tpdu.sw[0] == 0x6C: + if tpdu.sw and (tpdu.sw[0] == 0x61 or tpdu.sw[0] == 0x6C): self.state = 'WAIT_GET_RESPONSE' # handle successive 61/6c responses by stupid phone/modem OS if tpdu.ins != 0xC0: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43197?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iff7fe02f700e0eb42766a3264a856fc7947cdcd2 Gerrit-Change-Number: 43197 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in pysim[master]: pySim-trace: treat CTRL-C / KeyboardInterrupt as normal abort
by lynxis lazus 08 Aug '26

08 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/43195?usp=email ) Change subject: pySim-trace: treat CTRL-C / KeyboardInterrupt as normal abort ...................................................................... pySim-trace: treat CTRL-C / KeyboardInterrupt as normal abort Change-Id: Ic75e8454bea4d59d6d7c41f8d9d699dcad56514e --- M pySim-trace.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/95/43195/1 diff --git a/pySim-trace.py b/pySim-trace.py index 0aa1e9c..083fc81 100755 --- a/pySim-trace.py +++ b/pySim-trace.py @@ -117,7 +117,7 @@ try: apdu = self.source.read() apdu_counter = apdu_counter + 1 - except StopIteration: + except (StopIteration, KeyboardInterrupt): print("%i APDUs parsed, stop iteration." % apdu_counter) return 0 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43195?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic75e8454bea4d59d6d7c41f8d9d699dcad56514e Gerrit-Change-Number: 43195 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in pysim[master]: pySim-trace: ignore all other exception and retry parsing it
by lynxis lazus 08 Aug '26

08 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/43196?usp=email ) Change subject: pySim-trace: ignore all other exception and retry parsing it ...................................................................... pySim-trace: ignore all other exception and retry parsing it Change-Id: I53a5e7e7087073f242eab1d86ef8a9ec929193bd --- M pySim-trace.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/96/43196/1 diff --git a/pySim-trace.py b/pySim-trace.py index 083fc81..a1a5bb1 100755 --- a/pySim-trace.py +++ b/pySim-trace.py @@ -120,6 +120,9 @@ except (StopIteration, KeyboardInterrupt): print("%i APDUs parsed, stop iteration." % apdu_counter) return 0 + except Exception as exp: + print(f"Failed to parse APDU {exp}") + continue if isinstance(apdu, CardReset): self.rs.reset() -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43196?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I53a5e7e7087073f242eab1d86ef8a9ec929193bd Gerrit-Change-Number: 43196 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in simtrace2[master]: cosmetic: fix typo in comment
by lynxis lazus 08 Aug '26

08 Aug '26

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/43186?usp=email ) Change subject: cosmetic: fix typo in comment ...................................................................... cosmetic: fix typo in comment Change-Id: I85939afd424c957ae872fa99f40b9cd528375537 --- M host/lib/apdu_dispatch.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/host/lib/apdu_dispatch.c b/host/lib/apdu_dispatch.c index 4c8f505..f2fa64e 100644 --- a/host/lib/apdu_dispatch.c +++ b/host/lib/apdu_dispatch.c @@ -63,7 +63,7 @@ } /*! \brief input function for APDU segmentation - * \param ac APDU context accross successive calls + * \param ac APDU context across successive calls * \param[in] apdu_buf APDU inpud data buffer * \param[in] apdu_len Length of apdu_buf * \param[in] new_apdu Is this the beginning of a new APDU? -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43186?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I85939afd424c957ae872fa99f40b9cd528375537 Gerrit-Change-Number: 43186 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: TCAP: UDTS routing: stop overwriting ASP when routing UDTS
by lynxis lazus 08 Aug '26

08 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43193?usp=email ) Change subject: TCAP: UDTS routing: stop overwriting ASP when routing UDTS ...................................................................... TCAP: UDTS routing: stop overwriting ASP when routing UDTS The UDTS routing decision is final and should not go to the tcap routing a second time as a normal packet. Change-Id: I1c4eaaf352d505970e55e04c605c100d64aaaa34 --- M src/tcap_as_loadshare.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/93/43193/1 diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index bd7548f..3bd0db2 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -614,6 +614,8 @@ asp = tcap_as_asp_find_by_tcap_id(as, &called_addr, &calling_addr, *otid); if (!asp) LOGPAS(as, DLTCAP, LOGL_NOTICE, "Could not find an ASP for UDTS with otid %u/dtid %u\n", parsed.otid, parsed.dtid); + + goto out_free_sua; } /* TCAP messages towards the IPA nodes */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1c4eaaf352d505970e55e04c605c100d64aaaa34 Gerrit-Change-Number: 43193 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in libosmo-sigtran[master]: TCAP: LOG: fix missing newlines in log messages
by lynxis lazus 08 Aug '26

08 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43194?usp=email ) Change subject: TCAP: LOG: fix missing newlines in log messages ...................................................................... TCAP: LOG: fix missing newlines in log messages Change-Id: Id57d8afeb01412ed7448bb27148be87980f4f906 --- M src/tcap_trans_tracking.c 1 file changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/94/43194/1 diff --git a/src/tcap_trans_tracking.c b/src/tcap_trans_tracking.c index a5a0ca6..421ad7b 100644 --- a/src/tcap_trans_tracking.c +++ b/src/tcap_trans_tracking.c @@ -366,7 +366,8 @@ hash_for_each_safe(as->tcap.trans_track_own, i, tmp, entry, own_tid.list) { if (entry->asp == asp) { count++; - LOGPASP(entry->asp, DLTCAP, LOGL_DEBUG, "Remove Cache entry for tcap own tid %u (asp removed)", entry->own_tid.tid); + LOGPASP(entry->asp, DLTCAP, LOGL_DEBUG, "Remove Cache entry for tcap own tid %u (asp removed)\n", + entry->own_tid.tid); tcap_trans_track_entry_free(entry); } } @@ -374,7 +375,8 @@ hash_for_each_safe(as->tcap.trans_track_peer, i, tmp, entry, peer_tid.list) { if (entry->asp == asp) { count++; - LOGPASP(entry->asp, DLTCAP, LOGL_DEBUG, "Remove Cache entry for tcap own tid %u (asp removed)", entry->peer_tid.tid); + LOGPASP(entry->asp, DLTCAP, LOGL_DEBUG, "Remove Cache entry for tcap own tid %u (asp removed)\n", + entry->peer_tid.tid); tcap_trans_track_entry_free(entry); } } @@ -390,13 +392,15 @@ hash_for_each_safe(as->tcap.trans_track_own, i, tmp, entry, own_tid.list) { count++; - LOGPASP(entry->asp, DLTCAP, LOGL_DEBUG, "Remove Cache entry for tcap own tid %u (as removed)", entry->own_tid.tid); + LOGPASP(entry->asp, DLTCAP, LOGL_DEBUG, "Remove Cache entry for tcap own tid %u (as removed)\n", + entry->own_tid.tid); tcap_trans_track_entry_free(entry); } hash_for_each_safe(as->tcap.trans_track_peer, i, tmp, entry, peer_tid.list) { count++; - LOGPASP(entry->asp, DLTCAP, LOGL_DEBUG, "Remove Cache entry for tcap own tid %u (as removed)", entry->peer_tid.tid); + LOGPASP(entry->asp, DLTCAP, LOGL_DEBUG, "Remove Cache entry for tcap own tid %u (as removed)\n", + entry->peer_tid.tid); tcap_trans_track_entry_free(entry); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43194?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id57d8afeb01412ed7448bb27148be87980f4f906 Gerrit-Change-Number: 43194 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in libosmo-sigtran[master]: TCAP: implement fallback routing when no TCAP ASP can be found.
by lynxis lazus 08 Aug '26

08 Aug '26

Attention is currently required from: daniel, laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008?usp=email ) Change subject: TCAP: implement fallback routing when no TCAP ASP can be found. ...................................................................... Patch Set 3: (5 comments) File src/ss7_as_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/d686c291_162c9… : PS3, Line 266: DEFUN_USRATTR(as_tcap_unroutable_route_fallback, as_tcap_unroutable_route_fallback_cmd, > It probably make much more sense to have a VTY cmd […] Done File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/3493aa81_64fce… : PS3, Line 470: if (as->cfg.loadshare.tcap.unroutable_tcap_fallback_dpc == 0) > this is imho incorrect. 0 is a valid DPC afaiu. […] Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/66242a19_8da0f… : PS3, Line 474: new_mtp.opc = orig_mtp->opc; > this line is a noop, cam be dropped. Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/612da7d8_44775… : PS3, Line 487: * \return 0 on success and asp is set, < 0 on error, > 0 when message is routed elsewhere > I see you are updating the return signature here, but I see no modficiation on any code using the fu […] the code already handles the different rc. https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/e47defe6_5a5ea… : PS3, Line 508: /* Message is handled and will be routed else where */ > elsewhere Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3e4e634b38a1845c2ce62a3805ff91a530520d88 Gerrit-Change-Number: 43008 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sat, 08 Aug 2026 15:58:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: TCAP: Refactoring unroutable messages into own function
by lynxis lazus 08 Aug '26

08 Aug '26

Attention is currently required from: daniel, laforge, pespin. Hello Jenkins Builder, daniel, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43007?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: TCAP: Refactoring unroutable messages into own function ...................................................................... TCAP: Refactoring unroutable messages into own function In preparation of adding another method to handle those. Change-Id: Ib4d114273423730418458767d17b11de9bd815d4 --- M src/tcap_as_loadshare.c 1 file changed, 65 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/07/43007/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43007?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib4d114273423730418458767d17b11de9bd815d4 Gerrit-Change-Number: 43007 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: TCAP: implement fallback routing when no TCAP ASP can be found.
by lynxis lazus 08 Aug '26

08 Aug '26

Attention is currently required from: daniel, laforge, lynxis lazus. Hello Jenkins Builder, daniel, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: TCAP: implement fallback routing when no TCAP ASP can be found. ...................................................................... TCAP: implement fallback routing when no TCAP ASP can be found. If a TCAP message from an ongoing session can't be routed by either the TCAP session cache or by the destination TID to a known ASP, allow to route the packet to a different destination. Change-Id: I3e4e634b38a1845c2ce62a3805ff91a530520d88 --- M src/ss7_as.c M src/ss7_as.h M src/ss7_as_vty.c M src/tcap_as_loadshare.c 4 files changed, 75 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/08/43008/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3e4e634b38a1845c2ce62a3805ff91a530520d88 Gerrit-Change-Number: 43008 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: stp: TCAP: re-work tests as the TCAP routing changed
by lynxis lazus 08 Aug '26

08 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43192?usp=email ) Change subject: stp: TCAP: re-work tests as the TCAP routing changed ...................................................................... stp: TCAP: re-work tests as the TCAP routing changed Original the TCAP routing was designed in a different way. The original concept was to load-balance the TCAP sessions when they originate from M3UA -> IPA by the oTID. This changed into load-balancing TCAP sessions from M3UA -> IPA and track the session with the IPA/TCAP ids. Change-Id: Ib97a158fe544a72231aa31a7ec226736eeb32fcb --- M stp/STP_Tests_TCAP.ttcn 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/92/43192/1 diff --git a/stp/STP_Tests_TCAP.ttcn b/stp/STP_Tests_TCAP.ttcn index bc16337..16874b2 100644 --- a/stp/STP_Tests_TCAP.ttcn +++ b/stp/STP_Tests_TCAP.ttcn @@ -608,7 +608,7 @@ tcap_rt_msg.u.add_range.tid_end := 199; f_asp_tx_ipa_ext_tcap_routing(tcap_rt_msg, 3); - f_asp_tx_tcap_m3ua_ipa_transaction(0, 2, int2oct(2345, 4), int2oct(42, 4)); + f_asp_tx_tcap_m3ua_ipa_continue(0, 2, int2oct(2345, 4), int2oct(42, 4)); setverdict(pass); } @@ -760,7 +760,7 @@ pc := tcap_configs[2].cfg.own_pc, ssn := tcap_configs[2].cfg.own_ssn); f_asp_tx_ipa_ext_tcap_routing(tcap_rt_msg, 3); - f_asp_tx_tcap_m3ua_ipa_transaction(0, 3, int2oct(60, 4), int2oct(70, 4)); + f_asp_tx_tcap_m3ua_ipa_continue(0, 3, int2oct(60, 4), int2oct(70, 4)); setverdict(pass); } @@ -787,7 +787,8 @@ pc := IPA_EXT_TCAP_ROUTING_PC_WILDCARD, ssn := tcap_configs[2].cfg.own_ssn); f_asp_tx_ipa_ext_tcap_routing(tcap_rt_msg, 3); - f_asp_tx_tcap_m3ua_ipa_transaction(0, 3, int2oct(60, 4), int2oct(99, 4)); + f_asp_tx_tcap_m3ua_ipa_continue(0, 3, int2oct(79, 4), int2oct(60, 4)); + f_asp_tx_tcap_m3ua_ipa_continue(0, 2, int2oct(79, 4), int2oct(81, 4)); setverdict(pass); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43192?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib97a158fe544a72231aa31a7ec226736eeb32fcb Gerrit-Change-Number: 43192 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0