August 2026 - gerrit-log - lists.osmocom.org

[L] Change in onomondo-ipa[master]: V1.2: Add function ES10b.ReturnFromFallback
by laforge 13 Aug '26

13 Aug '26

Attention is currently required from: dexter, jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43042?usp=email ) Change subject: V1.2: Add function ES10b.ReturnFromFallback ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43042?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Ib49a8ef3a5ea5639d881ca51eaeeea24f083fe0e Gerrit-Change-Number: 43042 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Aug 2026 11:14:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in onomondo-ipa[master]: V1.2: Add function ES10b.ExecuteFallbackMechanism
by laforge 13 Aug '26

13 Aug '26

Attention is currently required from: dexter, jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43041?usp=email ) Change subject: V1.2: Add function ES10b.ExecuteFallbackMechanism ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43041?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Ia751f0888c36f39ddfadf7f8bb923a8ee50178dc Gerrit-Change-Number: 43041 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Aug 2026 11:13:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in onomondo-ipa[master]: Introduce 'operation' parameters to main file
by jolly 13 Aug '26

13 Aug '26

Attention is currently required from: dexter, laforge. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43202?usp=email ) Change subject: Introduce 'operation' parameters to main file ...................................................................... Patch Set 3: (2 comments) File src/ipa/main.c: https://gerrit.osmocom.org/c/onomondo-ipa/+/43202/comment/3fe5bdf9_e91d23c7… : PS2, Line 50: printf(" -o get-eim-package ..... Ask eIM for eIM package and process it (default operation)\n"); : printf(" -o add-initial-eim PATH..... set initial eIM configuration from given file\n"); : printf(" -o euicc-memory-reset....... reset eUICC memory\n"); > to make it more clear, those should be gruoped somewhere at the beginning or the end of the help mes […] Done https://gerrit.osmocom.org/c/onomondo-ipa/+/43202/comment/46a9c722_65e285db… : PS2, Line 193: break; > I think this change is only half-done. […] Done -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43202?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I6b960f840820990de40fb07332669ddbfcdf1e7d Gerrit-Change-Number: 43202 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Aug 2026 11:13:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[M] Change in onomondo-ipa[master]: Introduce 'operation' parameters to main file
by laforge 13 Aug '26

13 Aug '26

Attention is currently required from: dexter, jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43202?usp=email ) Change subject: Introduce 'operation' parameters to main file ...................................................................... Patch Set 3: Code-Review+1 (2 comments) File src/ipa/main.c: https://gerrit.osmocom.org/c/onomondo-ipa/+/43202/comment/bb47e4e0_6888077c… : PS2, Line 50: printf(" -o get-eim-package ..... Ask eIM for eIM package and process it (default operation)\n"); : printf(" -o add-initial-eim PATH..... set initial eIM configuration from given file\n"); : printf(" -o euicc-memory-reset....... reset eUICC memory\n"); > to make it more clear, those should be gruoped somewhere at the beginning or the end of the help mes […] Done https://gerrit.osmocom.org/c/onomondo-ipa/+/43202/comment/5e74a8c7_3a5c7c83… : PS2, Line 193: break; > I think this change is only half-done. […] Done -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43202?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I6b960f840820990de40fb07332669ddbfcdf1e7d Gerrit-Change-Number: 43202 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Aug 2026 11:13:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-ttcn3-hacks[master]: eIM_Tests: set error code in f_TC_proc_euicc_data_req_err explicitly
by laforge 13 Aug '26

13 Aug '26

Attention is currently required from: dexter, jolly. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43183?usp=email ) Change subject: eIM_Tests: set error code in f_TC_proc_euicc_data_req_err explicitly ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43183?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I06a97def123bb9196db2bab8fc94aaf5cef91c40 Gerrit-Change-Number: 43183 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Aug 2026 11:12:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-ttcn3-hacks[master]: library/euicc: add ESipa JSON encoder/decoder module
by laforge 13 Aug '26

13 Aug '26

Attention is currently required from: dexter, jolly. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43144?usp=email ) Change subject: library/euicc: add ESipa JSON encoder/decoder module ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43144?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8b6a87f39ca23658d980d19cf257b8994ea1cecb Gerrit-Change-Number: 43144 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Aug 2026 11:12:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: fix tr/ts_getBoundProfilePackageRequestEsipa
by jolly 13 Aug '26

13 Aug '26

Attention is currently required from: dexter. jolly has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43224?usp=email ) Change subject: SGP32Definitions_Templates: fix tr/ts_getBoundProfilePackageRequestEsipa ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6de1272ca22e31b906a49ce532066b76d2a80ad1 Gerrit-Change-Number: 43224 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-CC: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Aug 2026 11:09:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: fix tr/ts_getBoundProfilePackageRequestEsipa
by dexter 13 Aug '26

13 Aug '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43224?usp=email ) Change subject: SGP32Definitions_Templates: fix tr/ts_getBoundProfilePackageRequestEsipa ...................................................................... SGP32Definitions_Templates: fix tr/ts_getBoundProfilePackageRequestEsipa The templates transactionId parameter on the templates tr/ts_getBoundProfilePackageRequestEsipa is not used. In the templates itself the related member is still populated with constants. Change-Id: I6de1272ca22e31b906a49ce532066b76d2a80ad1 Related: SYS#8100 --- M library/euicc/SGP32Definitions_Templates.ttcn 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/24/43224/1 diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index be715b6..eccaee0 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -744,10 +744,10 @@ downloadResponseOk := ts_prepareDownloadResponseOk } template (present) EsipaMessageFromIpaToEim -tr_getBoundProfilePackageRequestEsipa(template (present) octetstring transactionId := 'ABCDEF'O, +tr_getBoundProfilePackageRequestEsipa(template (present) octetstring transactionId := ?, template (present) SGP32_PrepareDownloadResponse prepareDownloadResponse := tr_SGP32_prepareDownloadResponse) := { getBoundProfilePackageRequestEsipa := { - transactionId := ?, + transactionId := transactionId, prepareDownloadResponse := prepareDownloadResponse } } @@ -755,7 +755,7 @@ ts_getBoundProfilePackageRequestEsipa(template (value) octetstring transactionId := 'ABCDEF'O, template (value) SGP32_PrepareDownloadResponse prepareDownloadResponse := ts_SGP32_prepareDownloadResponse) := { getBoundProfilePackageRequestEsipa := { - transactionId := 'ABCDEF'O, + transactionId := transactionId, prepareDownloadResponse := prepareDownloadResponse } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6de1272ca22e31b906a49ce532066b76d2a80ad1 Gerrit-Change-Number: 43224 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in onomondo-ipa[master]: Use mandatory transaction ID in AuthenticateClientOkDPEsipa
by jolly 13 Aug '26

13 Aug '26

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43223?usp=email ) Change subject: Use mandatory transaction ID in AuthenticateClientOkDPEsipa ...................................................................... Use mandatory transaction ID in AuthenticateClientOkDPEsipa The transaction ID in the sequence of AuthenticateClientOkDPEsipa is optional, so lets use the mandatory transaction ID from the smdpSigned2 field instead. If the optional transaction ID exists, check if it matches with the mandatory one. Related: SYS#8101 Change-Id: I3aed3f6ff6f10b49045ff7a4b0f0019ac1d75c65 --- M src/ipa/libipa/esipa_auth_clnt.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/23/43223/1 diff --git a/src/ipa/libipa/esipa_auth_clnt.c b/src/ipa/libipa/esipa_auth_clnt.c index 8af59a6..f579dda 100644 --- a/src/ipa/libipa/esipa_auth_clnt.c +++ b/src/ipa/libipa/esipa_auth_clnt.c @@ -62,11 +62,21 @@ case AuthenticateClientResponseEsipa_PR_authenticateClientOkDPEsipa: res->auth_clnt_ok_dpe = &msg_to_ipa->choice.authenticateClientResponseEsipa.choice.authenticateClientOkDPEsipa; - res->transaction_id = res->auth_clnt_ok_dpe->transactionId; + res->transaction_id = &res->auth_clnt_ok_dpe->smdpSigned2.transactionId; if (!IPA_ASN_STR_CMP(res->transaction_id, &req->req.transactionId)) { IPA_LOGP_ESIPA("AuthenticateClient", LERROR, "eIM responded with unexpected transaction ID (expected: %s, got: %s)\n", ipa_hexdump(req->req.transactionId.buf, req->req.transactionId.size), + ipa_hexdump(res->auth_clnt_ok_dpe->smdpSigned2.transactionId.buf, + res->auth_clnt_ok_dpe->smdpSigned2.transactionId.size)); + res->auth_clnt_err = -1; + } + if (res->auth_clnt_ok_dpe->transactionId && + !IPA_ASN_STR_CMP(res->transaction_id, res->auth_clnt_ok_dpe->transactionId)) { + IPA_LOGP_ESIPA("AuthenticateClient", LERROR, + "eIM responded with different transaction IDs (%s != %s)\n", + ipa_hexdump(res->auth_clnt_ok_dpe->transactionId->buf, + res->auth_clnt_ok_dpe->transactionId->size), ipa_hexdump(res->transaction_id->buf, res->transaction_id->size)); res->auth_clnt_err = -1; } -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43223?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I3aed3f6ff6f10b49045ff7a4b0f0019ac1d75c65 Gerrit-Change-Number: 43223 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[L] Change in onomondo-ipa[master]: V1.2: Add function ES10b.ExecuteFallbackMechanism
by jolly 13 Aug '26

13 Aug '26

Attention is currently required from: dexter, jolly, laforge. Hello Jenkins Builder, dexter, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43041?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: V1.2: Add function ES10b.ExecuteFallbackMechanism ...................................................................... V1.2: Add function ES10b.ExecuteFallbackMechanism Add new library function to enable the fallback profile on IoT eUICC. Also add an option to the command line interface to call the library function. The optional refresh flag may be set via command line option. The function cannot be emulated with non-IoT eUICC. Reference: SGP.32 Section 5.9.20 Related: SYS#8101 Change-Id: Ia751f0888c36f39ddfadf7f8bb923a8ee50178dc --- M asn1/SGP32Definitions.asn M include/onomondo/ipa/ipad.h M src/ipa/libasn/CMakeLists.txt A src/ipa/libasn/ExecuteFallbackMechanismRequest.c A src/ipa/libasn/ExecuteFallbackMechanismRequest.h A src/ipa/libasn/ExecuteFallbackMechanismResponse.c A src/ipa/libasn/ExecuteFallbackMechanismResponse.h M src/ipa/libipa/CMakeLists.txt A src/ipa/libipa/es10b_exec_fallback_mech.c A src/ipa/libipa/es10b_exec_fallback_mech.h M src/ipa/libipa/ipad.c M src/ipa/main.c 12 files changed, 383 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/41/43041/6 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43041?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Ia751f0888c36f39ddfadf7f8bb923a8ee50178dc Gerrit-Change-Number: 43041 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0