lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

August 2026

  • 1 participants
  • 2269 discussions
[M] Change in libosmo-sigtran[master]: xUA: Handle rx multiple Routing Context in SNM messages
by laforge 13 Aug '26

13 Aug '26
Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43226?usp=email ) Change subject: xUA: Handle rx multiple Routing Context in SNM messages ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: do we have any test coverage for this in the TTCN-3 test suite or otherwise? It seems like the lind of intrusive code change that might breakt something, unlike the current series of fixes. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43226?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9ef1e343e95961d497f55e4a512068d3e7585a0c Gerrit-Change-Number: 43226 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Aug 2026 14:24:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[S] Change in libosmo-sigtran[master]: sua: fix buffer overflow in sua_parse_gt()
by laforge 13 Aug '26

13 Aug '26
Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43228?usp=email ) Change subject: sua: fix buffer overflow in sua_parse_gt() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: I think it would be prudent to give credit to the reporter of the bug in the commitlog. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43228?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I59f601f2d8706748797c802f0f09887e4b9ba31f Gerrit-Change-Number: 43228 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Aug 2026 14:23:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in libosmo-sigtran[master]: xUA: Avoid sending M-NOTIFY.ind with garbage if decoding xUA NOTIFY f...
by laforge 13 Aug '26

13 Aug '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43220?usp=email ) Change subject: xUA: Avoid sending M-NOTIFY.ind with garbage if decoding xUA NOTIFY fails ...................................................................... xUA: Avoid sending M-NOTIFY.ind with garbage if decoding xUA NOTIFY fails Change-Id: I59e67f03fab6fbf8aa50f44bd1d4165dcd7c8b2f --- M src/m3ua.c M src/sua.c 2 files changed, 17 insertions(+), 6 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/m3ua.c b/src/m3ua.c index 69b4438..39402fd 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -453,7 +453,12 @@ return xua; } -/* RFC4666 Ch. 3.8.2. Notify */ +/*! \brief RFC4666 Ch. 3.8.2. Notify. + * \param[in] npar Primitive to fill + * \param[in] ctx talloc context where a decoded INFO String may be allocated + * \param[in] xua xUA message to be decoded + * \return 0 on success; positive xUA error code otherwise + */ int m3ua_decode_notify(struct osmo_xlm_prim_notify *npar, void *ctx, const struct xua_msg *xua) { @@ -464,7 +469,7 @@ status_ie = xua_msg_find_tag(xua, M3UA_IEI_STATUS); if (!status_ie) { LOGP(DLM3UA, LOGL_ERROR, "M3UA NOTIFY without Status IE\n"); - return -1; + return M3UA_ERR_MISSING_PARAM; } status = *(uint32_t *) status_ie->dat; @@ -485,13 +490,13 @@ if (rctx_ie->len & 0x03) { LOGP(DLM3UA, LOGL_ERROR, "M3UA NOTIFY with Routing Context IE length non-multiple of 4!\n"); - return -1; + return M3UA_ERR_PARAM_FIELD_ERR; } if (rctx_ie->len > sizeof(npar->route_ctx)) { LOGP(DLM3UA, LOGL_ERROR, "M3UA NOTIFY with Routing Context IE containing > %zu items not supported!\n", ARRAY_SIZE(npar->route_ctx)); - return -1; + return M3UA_ERR_UNEXP_PARAM; } npar->route_ctx_count = rctx_ie->len >> 2; for (unsigned int i = 0; i < npar->route_ctx_count; i++) @@ -711,8 +716,11 @@ struct osmo_xlm_prim_notify ntfy; const char *type_name, *info_name; struct osmo_xlm_prim *prim; + int rc; - m3ua_decode_notify(&ntfy, asp, xua); + rc = m3ua_decode_notify(&ntfy, asp, xua); + if (rc != 0) + return rc; type_name = get_value_string(m3ua_ntfy_type_names, ntfy.status_type); info_name = m3ua_ntfy_info_name(ntfy.status_type, ntfy.status_info); diff --git a/src/sua.c b/src/sua.c index 572e77b..f5dcd66 100644 --- a/src/sua.c +++ b/src/sua.c @@ -655,8 +655,11 @@ struct osmo_xlm_prim_notify ntfy; const char *type_name, *info_name; struct osmo_xlm_prim *prim; + int rc; - m3ua_decode_notify(&ntfy, asp, xua); + rc = m3ua_decode_notify(&ntfy, asp, xua); + if (rc != 0) + return rc; type_name = get_value_string(m3ua_ntfy_type_names, ntfy.status_type); info_name = m3ua_ntfy_info_name(ntfy.status_type, ntfy.status_info); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43220?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I59e67f03fab6fbf8aa50f44bd1d4165dcd7c8b2f Gerrit-Change-Number: 43220 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
1 0
0 0
[XS] Change in libosmo-sigtran[master]: m3ua: always initialize asp_id and route_ctx_count in m3ua_decode_not...
by laforge 13 Aug '26

13 Aug '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43221?usp=email ) Change subject: m3ua: always initialize asp_id and route_ctx_count in m3ua_decode_notify() ...................................................................... m3ua: always initialize asp_id and route_ctx_count in m3ua_decode_notify() In theory user should have a look at npar->presence before accessing those fields, but in case it is somewhere forgotten then best having some initialized values, specially in the route_ctx_count which could turn into buffer overflows or reading more garbage from uninitialized array members. Change-Id: I8eea6c7722b2049e04632bf3f99570b3f979d751 --- M src/m3ua.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/m3ua.c b/src/m3ua.c index 39402fd..f2455eb 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -484,6 +484,8 @@ if (aspid_ie) { npar->asp_id = xua_msg_part_get_u32(aspid_ie); npar->presence |= NOTIFY_PAR_P_ASP_ID; + } else { + npar->asp_id = 0; } if (rctx_ie) { @@ -502,6 +504,8 @@ for (unsigned int i = 0; i < npar->route_ctx_count; i++) npar->route_ctx[i] = ntohl(*(uint32_t *)&rctx_ie->dat[i << 2]); npar->presence |= NOTIFY_PAR_P_ROUTE_CTX; + } else { + npar->route_ctx_count = 0; } if (info_ie) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43221?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8eea6c7722b2049e04632bf3f99570b3f979d751 Gerrit-Change-Number: 43221 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
1 0
0 0
[XS] Change in libosmo-sigtran[master]: xua: Avoid OOB read of Routing Context with len < 4
by laforge 13 Aug '26

13 Aug '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43222?usp=email ) Change subject: xua: Avoid OOB read of Routing Context with len < 4 ...................................................................... xua: Avoid OOB read of Routing Context with len < 4 Change-Id: If19f210c8d6a308f99b4f06fdc06581ffdc62696 --- M src/xua_shared.c 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve diff --git a/src/xua_shared.c b/src/xua_shared.c index 51cbbf2..53b7337 100644 --- a/src/xua_shared.c +++ b/src/xua_shared.c @@ -42,6 +42,7 @@ /* this is why we can use the M3UA constants below in a function shared between M3UA + SUA */ osmo_static_assert(M3UA_ERR_INVAL_ROUT_CTX == SUA_ERR_INVAL_ROUT_CTX, _err_rctx); osmo_static_assert(M3UA_ERR_NO_CONFGD_AS_FOR_ASP == SUA_ERR_NO_CONFGD_AS_FOR_ASP, _err_as_for_asp); +osmo_static_assert(M3UA_ERR_PARAM_FIELD_ERR == SUA_ERR_PARAM_FIELD_ERR, _err_param_field_err); /*! Find the AS for given ASP + optional routing context IE. * if rctx_ie == NULL, we assume that this ASP is only part of a single AS; @@ -58,6 +59,10 @@ *as = NULL; if (rctx_ie) { + if (rctx_ie->len < 4) { + LOGPASP(asp, log_ss, LOGL_ERROR, "%s(): Received Routing Context with len < 4\n", __func__); + return M3UA_ERR_PARAM_FIELD_ERR; + } /* Use routing context IE to look up the AS for which the * message was received. */ uint32_t rctx = xua_msg_part_get_u32(rctx_ie); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43222?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If19f210c8d6a308f99b4f06fdc06581ffdc62696 Gerrit-Change-Number: 43222 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
1 0
0 0
[XS] Change in libosmo-sigtran[master]: m3ua: Fix potential OOB read in rx NOTIFY INFO String IE
by laforge 13 Aug '26

13 Aug '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43216?usp=email ) Change subject: m3ua: Fix potential OOB read in rx NOTIFY INFO String IE ...................................................................... m3ua: Fix potential OOB read in rx NOTIFY INFO String IE Despite RFC4666 states it can contain "any meaningful UTF-8 character string", it also states that the string can be 0 bytes, which implicitly means a string could come without null char at the end. In any case, it's good practice to guard against it, as already done in all the other libosmo-sigtran code. Related: OS#7056 Reported-By: Adam Bedard <adam.bedard(a)gmail.com> Change-Id: I0bab40ba56d40436ce1295141d92d3555ea8e1d4 --- M src/m3ua.c 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/m3ua.c b/src/m3ua.c index 583800b..69b4438 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -499,10 +499,9 @@ npar->presence |= NOTIFY_PAR_P_ROUTE_CTX; } - if (info_ie) { - npar->info_string = talloc_size(ctx, info_ie->len); - memcpy(npar->info_string, info_ie->dat, info_ie->len); - } else + if (info_ie) + npar->info_string = talloc_strdup(ctx, xua_msg_part_get_str(info_ie)); + else npar->info_string = NULL; return 0; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43216?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0bab40ba56d40436ce1295141d92d3555ea8e1d4 Gerrit-Change-Number: 43216 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
1 0
0 0
[S] Change in libosmo-sigtran[master]: sua: Use helper function m3ua_ntfy_info_name()
by laforge 13 Aug '26

13 Aug '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43218?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: sua: Use helper function m3ua_ntfy_info_name() ...................................................................... sua: Use helper function m3ua_ntfy_info_name() Use the helper function already used in m3ua_rx_mgmt_ntfy(). Change-Id: Icf82c349734071a970c226aa743b5932450a2f99 --- M src/sua.c 1 file changed, 1 insertion(+), 14 deletions(-) Approvals: osmith: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/sua.c b/src/sua.c index b169d50..3b54c22 100644 --- a/src/sua.c +++ b/src/sua.c @@ -657,20 +657,7 @@ m3ua_decode_notify(&ntfy, asp, xua); type_name = get_value_string(m3ua_ntfy_type_names, ntfy.status_type); - - switch (ntfy.status_type) { - case M3UA_NOTIFY_T_STATCHG: - info_name = get_value_string(m3ua_ntfy_stchg_names, - ntfy.status_info); - break; - case M3UA_NOTIFY_T_OTHER: - info_name = get_value_string(m3ua_ntfy_other_names, - ntfy.status_info); - break; - default: - info_name = "NULL"; - break; - } + info_name = m3ua_ntfy_info_name(ntfy.status_type, ntfy.status_info); LOGPASP(asp, DLSUA, LOGL_NOTICE, "Received NOTIFY Type %s:%s (%s)\n", type_name, info_name, ntfy.info_string ? ntfy.info_string : ""); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43218?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Icf82c349734071a970c226aa743b5932450a2f99 Gerrit-Change-Number: 43218 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
1 0
0 0
[XS] Change in libosmo-sigtran[master]: xua_snm.c: Use M3UA IE define when shared with SUA IE
by laforge 13 Aug '26

13 Aug '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43217?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: xua_snm.c: Use M3UA IE define when shared with SUA IE ...................................................................... xua_snm.c: Use M3UA IE define when shared with SUA IE We use everywhere the M3UA IE define when both the M3UA and SUA IE are equivalent (for those IEs the SUA define points to the M3UA, and osmo_static_assert() are placed at the start of the file). Change-Id: Ie15e5a179b65afc7a0d1cbe145cce4cf2556c877 --- M src/xua_snm.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/xua_snm.c b/src/xua_snm.c index a2e4fde..2abc42e 100644 --- a/src/xua_snm.c +++ b/src/xua_snm.c @@ -552,8 +552,8 @@ /* an incoming SUA/M3UA DUPU was received from a remote SG */ void xua_snm_rx_dupu(struct osmo_ss7_asp *asp, struct osmo_ss7_as *as, struct xua_msg *xua) { - uint32_t aff_pc = xua_msg_get_u32(xua, SUA_IEI_AFFECTED_PC); - const char *info_str = xua_msg_get_str(xua, SUA_IEI_INFO_STRING); + uint32_t aff_pc = xua_msg_get_u32(xua, M3UA_IEI_AFFECTED_PC); + const char *info_str = xua_msg_get_str(xua, M3UA_IEI_INFO_STRING); /* TODO: should our processing depend on the RCTX included? I somehow don't think so */ //struct xua_msg_part *ie_rctx = xua_msg_find_tag(xua, SUA_IEI_ROUTE_CTX); int log_ss = osmo_ss7_asp_get_log_subsys(asp); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43217?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ie15e5a179b65afc7a0d1cbe145cce4cf2556c877 Gerrit-Change-Number: 43217 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
1 0
0 0
[XS] Change in libosmo-sigtran[master]: sua: Dispatch M-NOTIFY.ind to ASP
by laforge 13 Aug '26

13 Aug '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43219?usp=email ) Change subject: sua: Dispatch M-NOTIFY.ind to ASP ...................................................................... sua: Dispatch M-NOTIFY.ind to ASP This was already done in M3UA counterpart m3ua_rx_mgmt_ntfy(), but was missing in the SUA one. Change-Id: I62255aea1448bb76181b5f6799c3b9bf8c7daa79 --- M src/sua.c 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/sua.c b/src/sua.c index 3b54c22..572e77b 100644 --- a/src/sua.c +++ b/src/sua.c @@ -34,7 +34,6 @@ #include <osmocom/core/fsm.h> #include <osmocom/netif/stream.h> -#include "xua_msg.h" #include <osmocom/sigtran/sccp_sap.h> #include <osmocom/sigtran/protocol/mtp.h> @@ -50,6 +49,8 @@ #include "ss7_as.h" #include "ss7_asp.h" #include "ss7_internal.h" +#include "xua_msg.h" +#include "xua_lm_sap.h" /* Appendix C.4 of Q.714 (all in milliseconds) */ #define CONNECTION_TIMER ( 1 * 60 * 100) @@ -653,6 +654,7 @@ { struct osmo_xlm_prim_notify ntfy; const char *type_name, *info_name; + struct osmo_xlm_prim *prim; m3ua_decode_notify(&ntfy, asp, xua); @@ -662,10 +664,13 @@ type_name, info_name, ntfy.info_string ? ntfy.info_string : ""); + /* report this to layer manager */ + prim = xua_xlm_prim_alloc_m_notify_ind(&ntfy); + xua_asp_send_xlm_prim(asp, prim); + if (ntfy.info_string) talloc_free(ntfy.info_string); - /* TODO: should we report this somewhere? */ return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43219?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I62255aea1448bb76181b5f6799c3b9bf8c7daa79 Gerrit-Change-Number: 43219 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
1 0
0 0
[M] Change in pysim[master]: osmo-smdpp: derive the Profile Metadata from the Profile
by laforge 13 Aug '26

13 Aug '26
Attention is currently required from: dexter, jolly, jwaigel. laforge has posted comments on this change by jwaigel. ( https://gerrit.osmocom.org/c/pysim/+/43205?usp=email ) Change subject: osmo-smdpp: derive the Profile Metadata from the Profile ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43205?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie24dd5ac0ef541c1899dd923a9db568209bbfa62 Gerrit-Change-Number: 43205 Gerrit-PatchSet: 3 Gerrit-Owner: jwaigel <johannes(a)waigel.me> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jwaigel <johannes(a)waigel.me> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Aug 2026 14:21:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 151
  • 152
  • 153
  • 154
  • 155
  • 156
  • 157
  • ...
  • 227
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.