August 2026 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: stp: Validate timer xua beat 0 disables BEAT procedure
by pespin 04 Aug '26

04 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43159?usp=email ) Change subject: stp: Validate timer xua beat 0 disables BEAT procedure ...................................................................... stp: Validate timer xua beat 0 disables BEAT procedure Check in all sort of configurations that the BEAT procedure on xUA/IPA can be disabled just fine per ASP using the VTY. Related: SYS#8156 Change-Id: Id47bf862638a099bb5f6721fcfba873001aed616 --- M stp/STP_Tests_Common.ttcn M stp/STP_Tests_IPA.ttcn M stp/STP_Tests_M3UA.ttcn M stp/STP_Tests_M3UA_TCP.ttcn M stp/expected-results.xml 5 files changed, 124 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/59/43159/1 diff --git a/stp/STP_Tests_Common.ttcn b/stp/STP_Tests_Common.ttcn index 16b6406..2178a98 100644 --- a/stp/STP_Tests_Common.ttcn +++ b/stp/STP_Tests_Common.ttcn @@ -47,7 +47,8 @@ type component Test_CT { port TELNETasp_PT VTY; - timer g_Tguard := 30.0; + timer g_Tguard; + var float g_Tguard_timeout := 30.0; var boolean g_test_initialized := false; } @@ -69,7 +70,7 @@ f_vty_transceive(VTY, "enable"); activate(as_gTguard()); - g_Tguard.start; + g_Tguard.start(g_Tguard_timeout); } diff --git a/stp/STP_Tests_IPA.ttcn b/stp/STP_Tests_IPA.ttcn index 7225949..b16cb0e 100644 --- a/stp/STP_Tests_IPA.ttcn +++ b/stp/STP_Tests_IPA.ttcn @@ -852,18 +852,76 @@ f_vty_cs7_ipa_asp_cmd(g_ipa_configs[0], "timer xua beat " & int2str(STP_Tests_Common.mp_t_beat_sec_default)); } +/* Test ASP doesn't send a T(beat) when disabled over VTY ("timer xua beat 0") */ +friend function f_TC_beat_disabled(Misc_Helpers.ro_charstring asps) runs on IPA_CT +{ + var IpaConfigs ipa_configs := ipa_build_configs(asps); + var float timeout_val := int2float(STP_Tests_Common.mp_t_beat_sec_default) + 1.0; + var IpaCcmMsgtype ipa_ping_msg := IPAC_MSGT_PING; + var octetstring ipa_ping_data := int2oct(enum2int(ipa_ping_msg), 1); + + g_Tguard_timeout := 60.0; + f_init_common(); + f_init_ipa(ipa_configs := ipa_configs); + + f_vty_cs7_ipa_asp_cmd(ipa_configs[0], "timer xua beat 0"); + + if (ipa_configs[0].is_server) { + f_listen_ipa(0); + } else { + f_connect_ipa(0); + } + /* receive CCM IPA PING: */ + f_ipa_cfg_chg_ccm_enabled(IPA_CFG[0], false); + + timer T; + var ASP_IPA_Unitdata ipa_rx; + T.start(timeout_val); + alt { + [] IPA_CTRL[0].receive(t_ASP_IPA_UD(IPAC_PROTO_CCM, ipa_ping_data)) -> value ipa_rx { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Received unexpected IPA ", ipa_rx)); + } + [] IPA_CTRL[0].receive { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Received unexpected IPA before timeout expecting no ", + t_ASP_IPA_UD(IPAC_PROTO_CCM, ipa_ping_data))); + } + [] T.timeout { + setverdict(pass); + } + } + + log("No BEAT received, all good!"); + + /* return to default value: */ + f_vty_cs7_ipa_asp_cmd(ipa_configs[0], "timer xua beat " & int2str(STP_Tests_Common.mp_t_beat_sec_default)); +} + /* Test the IUT sends heartbeat procedure when needed. */ testcase TC_beat_timeout() runs on IPA_CT { var Misc_Helpers.ro_charstring asps := { "ipa-asp-override-sender" }; f_TC_beat_timeout(asps); } +/* Test the IUT sends no heartbeat procedure when disabled over VTY */ +testcase TC_beat_disabled() runs on IPA_CT { + var Misc_Helpers.ro_charstring asps := { "ipa-asp-override-sender" }; + f_TC_beat_disabled(asps); +} + /* Test the IUT sends heartbeat procedure when needed. */ testcase TC_clnt_beat_timeout() runs on IPA_CT { var Misc_Helpers.ro_charstring asps := { "ipa-asp-client0" }; f_TC_beat_timeout(asps); } +/* Test the IUT sends no heartbeat procedure when disabled over VTY */ +testcase TC_clnt_beat_disabled() runs on IPA_CT { + var Misc_Helpers.ro_charstring asps := { "ipa-asp-client0" }; + f_TC_beat_disabled(asps); +} + control { execute( TC_unknown_client_nodynamic() ); execute( TC_unknown_as_client_nodynamic() ); @@ -884,7 +942,9 @@ execute( TC_beat() ); execute( TC_beat_timeout() ); + execute( TC_beat_disabled() ); execute( TC_clnt_beat_timeout() ); + execute( TC_clnt_beat_disabled() ); } diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn index 7debed6..f1ce309 100644 --- a/stp/STP_Tests_M3UA.ttcn +++ b/stp/STP_Tests_M3UA.ttcn @@ -603,12 +603,46 @@ f_clear_m3ua(); } +/* Test ASP doesn't send a T(beat) when disabled over VTY ("timer xua beat 0") */ +friend function f_TC_beat_disabled(Misc_Helpers.ro_charstring asps) runs on RAW_M3UA_CT +{ + var M3uaConfigs m3ua_configs := m3ua_build_configs(asps); + var M3UA_RecvFrom rx; + var template (omit) M3UA_Heartbeat_Data hbd := omit; + var float timeout_val := int2float(STP_Tests_Common.mp_t_beat_sec_default) + 1.0; + + g_Tguard_timeout := 60.0; + f_init_m3ua(answer_beat := false, m3ua_configs := m3ua_configs); + f_vty_cs7_asp_cmd(g_m3ua_configs[0], "timer xua beat 0"); + + if (m3ua_configs[0].is_server) { + f_init_m3ua_srv(); + f_M3UA_CLNT_asp_up_act(0, rctx := int2oct(m3ua_configs[0].routing_ctx, 4)); + } else { + f_M3UA_asp_up(0, ntfy_after_up := c_M3UA_ST_I_AS_INACTIVE); + } + + f_M3UA_exp_no(0, tr_M3UA_BEAT(*), timeout_val := timeout_val, answer_beat := false); + log("No BEAT received, all good!"); + + /* return to default value: */ + f_vty_cs7_asp_cmd(g_m3ua_configs[0], "timer xua beat " & int2str(STP_Tests_Common.mp_t_beat_sec_default)); + + f_clear_m3ua(); +} + /* Test the IUT sends heartbeat procedure when needed. */ testcase TC_beat_timeout() runs on RAW_M3UA_CT { var Misc_Helpers.ro_charstring asps := { "asp-sender" }; f_TC_beat_timeout(asps); } +/* Test the IUT sends no heartbeat procedure when disabled over VTY */ +testcase TC_beat_disabled() runs on RAW_M3UA_CT { + var Misc_Helpers.ro_charstring asps := { "asp-sender" }; + f_TC_beat_disabled(asps); +} + /* Test the ASP-ACTIVATE procedure (without traffic-mode or routing ctx) */ testcase TC_asp_act() runs on RAW_M3UA_CT { f_init_m3ua(); @@ -1304,6 +1338,11 @@ var Misc_Helpers.ro_charstring asps := { "asp-client0" }; f_TC_beat_timeout(asps); } +/* Test the IUT sends no heartbeat procedure when disabled over VTY */ +testcase TC_clnt_beat_disabled() runs on RAW_M3UA_CT { + var Misc_Helpers.ro_charstring asps := { "asp-client0" }; + f_TC_beat_disabled(asps); +} /* Expect inbound connection from ASP/SCTP-client, followed by ASP-UP + ASP-ACT */ testcase TC_clnt_asp_act() runs on RAW_M3UA_CT { @@ -1906,6 +1945,7 @@ execute( TC_beat() ); execute( TC_beat_payload() ); execute( TC_beat_timeout() ); + execute( TC_beat_disabled() ); execute( TC_asp_act() ); execute( TC_asp_act_override() ); execute( TC_asp_act_loadshare() ); @@ -1942,6 +1982,7 @@ /* Test STP as SCTP client + M3UA ASP role */ execute( TC_clnt_connect_asp_up() ); execute( TC_clnt_beat_timeout() ); + execute( TC_clnt_beat_disabled() ); execute( TC_clnt_asp_act() ); execute( TC_clnt_sg_to_asp() ); execute( TC_clnt_asp_to_sg() ); diff --git a/stp/STP_Tests_M3UA_TCP.ttcn b/stp/STP_Tests_M3UA_TCP.ttcn index 8bed7e2..4e0706b 100644 --- a/stp/STP_Tests_M3UA_TCP.ttcn +++ b/stp/STP_Tests_M3UA_TCP.ttcn @@ -201,12 +201,24 @@ f_TC_beat_timeout(asps); } +/* Test the IUT sends no heartbeat procedure when disabled over VTY */ +testcase TC_m3ua_tcp_beat_disabled() runs on RAW_M3UA_CT { + var Misc_Helpers.ro_charstring asps := { "asp-sender-tcp" }; + f_TC_beat_disabled(asps); +} + /* Test the IUT sends heartbeat procedure when needed. */ testcase TC_m3ua_tcp_clnt_beat_timeout() runs on RAW_M3UA_CT { var Misc_Helpers.ro_charstring asps := { "asp-client0-tcp" }; f_TC_beat_timeout(asps); } +/* Test the IUT sends no heartbeat procedure when disabled over VTY */ +testcase TC_m3ua_tcp_clnt_beat_disabled() runs on RAW_M3UA_CT { + var Misc_Helpers.ro_charstring asps := { "asp-client0-tcp" }; + f_TC_beat_disabled(asps); +} + control { /* M3UA TCP Tests */ execute( TC_m3ua_tcp_cli() ); @@ -218,7 +230,9 @@ execute( TC_m3ua_tcp_cli_adm_shutdown() ); execute( TC_m3ua_tcp_beat_timeout() ); + execute( TC_m3ua_tcp_beat_disabled() ); execute( TC_m3ua_tcp_clnt_beat_timeout() ); + execute( TC_m3ua_tcp_clnt_beat_disabled() ); } } diff --git a/stp/expected-results.xml b/stp/expected-results.xml index 92f0a92..2243959 100644 --- a/stp/expected-results.xml +++ b/stp/expected-results.xml @@ -4,6 +4,7 @@ <testcase classname='STP_Tests_M3UA' name='TC_beat' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_beat_payload' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_beat_timeout' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_beat_disabled' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_asp_act' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_asp_act_override' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_asp_act_loadshare' time='MASKED'/> @@ -28,6 +29,7 @@ <testcase classname='STP_Tests_M3UA' name='TC_dyn_2asp_as_rkm_permitted' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_clnt_connect_asp_up' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_clnt_beat_timeout' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_beat_disabled' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_clnt_asp_act' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_clnt_sg_to_asp' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_clnt_asp_to_sg' time='MASKED'/> @@ -54,7 +56,9 @@ <testcase classname='STP_Tests_M3UA_TCP' name='TC_m3ua_tcp_srv_adm_shutdown' time='MASKED'/> <testcase classname='STP_Tests_M3UA_TCP' name='TC_m3ua_tcp_cli_adm_shutdown' time='MASKED'/> <testcase classname='STP_Tests_M3UA_TCP' name='TC_m3ua_tcp_beat_timeout' time='MASKED'/> + <testcase classname='STP_Tests_M3UA_TCP' name='TC_m3ua_tcp_beat_disabled' time='MASKED'/> <testcase classname='STP_Tests_M3UA_TCP' name='TC_m3ua_tcp_clnt_beat_timeout' time='MASKED'/> + <testcase classname='STP_Tests_M3UA_TCP' name='TC_m3ua_tcp_clnt_beat_disabled' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_unknown_client_nodynamic' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_unknown_as_client_nodynamic' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_known_client_nodynamic' time='MASKED'/> @@ -72,7 +76,9 @@ <testcase classname='STP_Tests_IPA' name='TC_ipa_tcp_cli_adm_shutdown' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_beat' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_beat_timeout' time='MASKED'/> + <testcase classname='STP_Tests_IPA' name='TC_beat_disabled' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_clnt_beat_timeout' time='MASKED'/> + <testcase classname='STP_Tests_IPA' name='TC_clnt_beat_disabled' time='MASKED'/> <testcase classname='STP_Tests_IPA_M3UA' name='TC_m3ua_to_ipa' time='MASKED'/> <testcase classname='STP_Tests_IPA_M3UA' name='TC_ipa_to_m3ua' time='MASKED'/> <testcase classname='STP_Tests_IPA_M3UA' name='TC_ipa_to_m3ua_ni' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43159?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id47bf862638a099bb5f6721fcfba873001aed616 Gerrit-Change-Number: 43159 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in onomondo-ipa[master]: V1.2: Add AuthenticateResponseOk and EuiccSigned1
by jolly 03 Aug '26

03 Aug '26

Attention is currently required from: jolly. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43061?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: V1.2: Add AuthenticateResponseOk and EuiccSigned1 ...................................................................... V1.2: Add AuthenticateResponseOk and EuiccSigned1 Both structures are taken from SGP.22 but do not change. The IPA process uses these new structures, because the may be expanded in the future. Reference: SGP.23 Section 5.14.3 Related: SYS#8101 Change-Id: I501247132de30618a2b1ace44c7c3772ab42eb09 --- M asn1/SGP32Definitions.asn M src/ipa/libasn/CMakeLists.txt A src/ipa/libasn/SGP32-AuthenticateResponseOk.c A src/ipa/libasn/SGP32-AuthenticateResponseOk.h M src/ipa/libasn/SGP32-AuthenticateServerResponse.c M src/ipa/libasn/SGP32-AuthenticateServerResponse.h A src/ipa/libasn/SGP32-EuiccSigned1.c A src/ipa/libasn/SGP32-EuiccSigned1.h M src/ipa/libipa/es10b_auth_serv.c M src/ipa/libipa/es10b_auth_serv.h 10 files changed, 301 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/61/43061/3 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43061?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I501247132de30618a2b1ace44c7c3772ab42eb09 Gerrit-Change-Number: 43061 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu>

1 0

[S] Change in onomondo-ipa[master]: V1.2: Add function to set Device Capabilities
by jolly 03 Aug '26

03 Aug '26

Attention is currently required from: dexter. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43060?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: V1.2: Add function to set Device Capabilities ...................................................................... V1.2: Add function to set Device Capabilities Add new library function to set the SGP.22 Device Capabilities. Also add an option to the command line interface to call the library function. The IoT device (modem) may and the IPA must set Device Capabilities. They cannot be set independently. The IoT device would overwrite what IPA has set and vice versa. Therefore add a library function for the IoT device that takes care about setting the required capabilities for IPA. Reference: SGP.22 Section 3.4.2 Related: SYS#8101 Change-Id: I866787b8cda9a87a9f2e0db4965fbb554d339a6c --- M include/onomondo/ipa/ipad.h M src/ipa/libipa/euicc.c M src/ipa/main.c 3 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/60/43060/3 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43060?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I866787b8cda9a87a9f2e0db4965fbb554d339a6c Gerrit-Change-Number: 43060 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in onomondo-ipa[master]: V1.2: Change remaining ASN1 definition to SGP.32 V1.2
by jolly 03 Aug '26

03 Aug '26

Attention is currently required from: dexter, jolly. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43073?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: V1.2: Change remaining ASN1 definition to SGP.32 V1.2 ...................................................................... V1.2: Change remaining ASN1 definition to SGP.32 V1.2 These minor changes are not relevant, because they have no impact on the process of IPAd. Most of them relate to formatting and comments. Related: SYS#8101 Change-Id: Ifa2546784a6d75170e4f5aae2a5e98edb2c0627a --- M asn1/SGP32Definitions.asn M src/ipa/libasn/EuiccPackageErrorCode.h M src/ipa/libasn/EuiccPackageErrorDataSigned.c M src/ipa/libasn/EuiccPackageErrorDataSigned.h M src/ipa/libasn/EuiccPackageSigned.c 5 files changed, 87 insertions(+), 40 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/73/43073/2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43073?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Ifa2546784a6d75170e4f5aae2a5e98edb2c0627a Gerrit-Change-Number: 43073 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in onomondo-ipa[master]: V1.2: Add function to set Device Capabilities
by jolly 03 Aug '26

03 Aug '26

Attention is currently required from: dexter. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43060?usp=email ) Change subject: V1.2: Add function to set Device Capabilities ...................................................................... Patch Set 2: (1 comment) File src/ipa/main.c: https://gerrit.osmocom.org/c/onomondo-ipa/+/43060/comment/65abcb33_ac62dffe… : PS1, Line 264: case 'D': > I wonder if it would make sense to accept a string like "00001111". […] osmo_hexparse? -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43060?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I866787b8cda9a87a9f2e0db4965fbb554d339a6c Gerrit-Change-Number: 43060 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Aug 2026 12:51:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: Revert "deps: use a fork of titan.ProtocolEmulations.SCCP"
by fixeria 03 Aug '26

03 Aug '26

fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43155?usp=email ) Change subject: Revert "deps: use a fork of titan.ProtocolEmulations.SCCP" ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > @vyanitskiy@sysmocom.de merged, feel free to remove the fixeria/udts branch if you want. Removed. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43155?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4eb81e0ffc6500340199c4a23a7aabfee925c33b Gerrit-Change-Number: 43155 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Aug 2026 12:48:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in onomondo-ipa[master]: V1.2: Add eimTransactionId to InitiateAuthenticationRequestEsipa
by jolly 03 Aug '26

03 Aug '26

Attention is currently required from: dexter. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43056?usp=email ) Change subject: V1.2: Add eimTransactionId to InitiateAuthenticationRequestEsipa ...................................................................... Patch Set 2: (3 comments) File src/ipa/libipa/esipa_init_auth.h: https://gerrit.osmocom.org/c/onomondo-ipa/+/43056/comment/ea82620c_b0d53b22… : PS1, Line 19: TransactionId_t *eim_transaction_id; > As it seems there is a tab instead of a space between type and member name. […] Done File src/ipa/libipa/proc_cmn_mtl_auth.h: https://gerrit.osmocom.org/c/onomondo-ipa/+/43056/comment/909927e0_aa2d3f6c… : PS1, Line 19: TransactionId_t *eim_transaction_id; > maybe declare this as struct OCTET_STRING *eim_transaction_id? […] Done File src/ipa/libipa/proc_indirect_prfle_dwnld.h: https://gerrit.osmocom.org/c/onomondo-ipa/+/43056/comment/c3c230de_871ed7f3… : PS1, Line 18: TransactionId_t *eim_transaction_id; > (see the other comments) Done -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43056?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I1c8ef6fc0a3f7ab5735e401597fc8c6b2021fc09 Gerrit-Change-Number: 43056 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Aug 2026 12:47:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[L] Change in onomondo-ipa[master]: V1.2: Change fields in ProvideEimPackage(Result)
by jolly 03 Aug '26

03 Aug '26

Attention is currently required from: dexter. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43055?usp=email ) Change subject: V1.2: Change fields in ProvideEimPackage(Result) ...................................................................... Patch Set 2: (1 comment) File src/ipa/libipa/esipa_prvde_eim_pkg_rslt.h: https://gerrit.osmocom.org/c/onomondo-ipa/+/43055/comment/db7c4861_2afdaf3f… : PS1, Line 20: struct OCTET_STRING *eim_trans_id; > I think its better to call it eim_transaction_id, because in other interfaces we have called it "tra […] Done -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43055?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I24baab4f9351aec27c58403b94974cba4b274c34 Gerrit-Change-Number: 43055 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Aug 2026 12:46:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: Revert "deps: use a fork of titan.ProtocolEmulations.SCCP"
by pespin 03 Aug '26

03 Aug '26

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43155?usp=email ) Change subject: Revert "deps: use a fork of titan.ProtocolEmulations.SCCP" ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > @vyanitskiy@sysmocom. […] @vyanitskiy@sysmocom.de merged, feel free to remove the fixeria/udts branch if you want. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43155?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4eb81e0ffc6500340199c4a23a7aabfee925c33b Gerrit-Change-Number: 43155 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Aug 2026 12:45:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in onomondo-ipa[master]: V1.2: Add function to set Device Capabilities
by Jenkins Builder 03 Aug '26

03 Aug '26

Attention is currently required from: dexter, jolly. Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43060?usp=email ) Change subject: V1.2: Add function to set Device Capabilities ...................................................................... Patch Set 2: (2 comments) File include/onomondo/ipa/ipad.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-ipa/+/43060/comment/6dd4ae3a_dc2d6582… : PS2, Line 90: /*! Set the Device Capabilites. 'Capabilites' may be misspelled - perhaps 'Capabilities'? File src/ipa/main.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-ipa/+/43060/comment/46754750_12ca8bc1… : PS2, Line 67: printf(" -D 0xXX .................... set SGP.22 device capabilites other than the 3 that are required by this IPAd\n"); 'capabilites' may be misspelled - perhaps 'capabilities'? -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43060?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I866787b8cda9a87a9f2e0db4965fbb554d339a6c Gerrit-Change-Number: 43060 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Aug 2026 12:45:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026