Attention is currently required from: jolly.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43068?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: V1.2: Rename field in GetBoundProfilePackageResponseEsipa
......................................................................
V1.2: Rename field in GetBoundProfilePackageResponseEsipa
Rename field profileMetadataMismatch to metadataMismatch in
GetBoundProfilePackageResponseEsipa.
Reference: SGP.23 Section 6.3.2.3
Related: SYS#8101
Change-Id: I87965b68bde39d29317f9848aa3a88d9966c4e78
---
M asn1/SGP32Definitions.asn
M src/ipa/libasn/GetBoundProfilePackageResponseEsipa.h
M src/ipa/libipa/esipa_get_bnd_prfle_pkg.c
3 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/68/43068/3
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43068?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I87965b68bde39d29317f9848aa3a88d9966c4e78
Gerrit-Change-Number: 43068
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: jolly.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43069?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: V1.2: Rename field in PSMO
......................................................................
V1.2: Rename field in PSMO
Rename two field in PSMO.
Reference: SGP.23 Section 2.11.1.1.3
Related: SYS#8101
Change-Id: I9336f18aaf104629845948877294437188979376
---
M asn1/SGP32Definitions.asn
M src/ipa/libasn/Psmo.c
M src/ipa/libasn/Psmo.h
M src/ipa/libipa/context.h
M src/ipa/libipa/es10b_euicc_mem_rst.c
M src/ipa/libipa/es10b_immediate_enable.c
M src/ipa/libipa/es10b_load_bnd_prfle_pkg.c
M src/ipa/libipa/es10b_load_euicc_pkg.c
M src/ipa/libipa/ipad.c
9 files changed, 67 insertions(+), 63 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/69/43069/3
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43069?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I9336f18aaf104629845948877294437188979376
Gerrit-Change-Number: 43069
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: jolly.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43070?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: V1.2: Change tag in TransferEimPackageResponse
......................................................................
V1.2: Change tag in TransferEimPackageResponse
Change tag value of notificationList in TransferEimPackageResponse.
Also change it from RetrieveNotificationsListResponse to
PendingNotificationList.
Reference: SGP.23 Section 6.3.1
Related: SYS#8101
Change-Id: I4c9cdd1b79ec22a1d5e36d1720cf5c703890c28b
---
M asn1/SGP32Definitions.asn
M src/ipa/libasn/SGP32-RetrieveNotificationsListResponse.c
M src/ipa/libasn/SGP32-RetrieveNotificationsListResponse.h
M src/ipa/libasn/TransferEimPackageResponse.c
M src/ipa/libasn/TransferEimPackageResponse.h
5 files changed, 9 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/70/43070/3
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43070?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I4c9cdd1b79ec22a1d5e36d1720cf5c703890c28b
Gerrit-Change-Number: 43070
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: jolly.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43071?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: V1.2: Add eimValue to CompactOtherSignedNotification
......................................................................
V1.2: Add eimValue to CompactOtherSignedNotification
The IPA just forwards the message, so no change in process is required.
Reference: SGP.23 Section 5.14.7
Related: SYS#8101
Change-Id: I0183ef6555d23d762e6c8fa8584453b3a07d4940
---
M asn1/SGP32Definitions.asn
M src/ipa/libasn/CompactOtherSignedNotification.c
M src/ipa/libasn/CompactOtherSignedNotification.h
3 files changed, 22 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/71/43071/3
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43071?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I0183ef6555d23d762e6c8fa8584453b3a07d4940
Gerrit-Change-Number: 43071
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: dexter.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43041?usp=email )
Change subject: V1.2: Add function ES10b.ExecuteFallbackMechanism
......................................................................
Patch Set 3:
(2 comments)
File src/ipa/libipa/ipad.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43041/comment/a259a266_6c6c7bea… :
PS1, Line 272: {
> I would suggest to drop the refresh_flag parameter and use ctx->cfg->refresh_flag instead. […]
Done
File src/ipa/main.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43041/comment/46f59d63_ccdaec38… :
PS1, Line 52: printf(" --execute-fallback-mechanism Trigger enabling of fallback profile\n");
> This is the only long option now. […]
I think this should be a different patch.
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43041?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Ia751f0888c36f39ddfadf7f8bb923a8ee50178dc
Gerrit-Change-Number: 43041
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 04 Aug 2026 11:36:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43113?usp=email )
Change subject: libosmo-trx: generate Doxygen API documentation
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43113?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I54cf8c0c60215c666d8fa55dafec53379a2382d5
Gerrit-Change-Number: 43113
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 04 Aug 2026 11:18:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43112?usp=email )
Change subject: libosmo-trx/ep: flush pending TRXC messages on endpoint teardown
......................................................................
Patch Set 2:
(2 comments)
File libosmo-trx/src/trx_ep.c:
https://gerrit.osmocom.org/c/osmo-trx/+/43112/comment/a1437bbd_df468fb3?usp… :
PS2, Line 245: if (res > 0 && osmo_iofd_txqueue_len(iofd) > 0)
in io_uring backend, with asynchronous write operations, the fact that the userspace iofd txqueue is empty doesn't necessarily mean that the write operation has finished.
freeing the iofd at that point could probably turn into the write being cancelled, etc.
As mentioned imho you need to track count of wrote (completed) bytes vs enqueued bytes, in order to figure out whether the stream is really done.
https://gerrit.osmocom.org/c/osmo-trx/+/43112/comment/8a909ae3_9405e418?usp… :
PS2, Line 269: talloc_steal(OTC_GLOBAL, iofd);
IMHO this is not a good idea, since you are keeping a socket alive without the data domain of the program knowing about it, hidding it to the user. For instance, my program does osmo_trx_ep_close() and then since according to the API it's closed, I do a open(), which will potentially fail because the ocal bound addr+port is still in use by the older socket.
You should incorporate the logic of "closing" being a known state into the public API, so the user of the ep can figure out when it can eg. re-open it or free it.
This can be seen in the osmo-pcap wrf structure I mentioned.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43112?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I69e6a3bcf49afc3cfca4a72afdf459625cb91e56
Gerrit-Change-Number: 43112
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 04 Aug 2026 11:17:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No