August 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ggsn[master]: gtp: clamp GSN-Address copy to sockaddr_in size
by lynxis lazus 09 Aug '26

09 Aug '26

Attention is currently required from: n0k0. lynxis lazus has posted comments on this change by n0k0. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/43187?usp=email ) Change subject: gtp: clamp GSN-Address copy to sockaddr_in size ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/43187?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: If49f1929645c0ba8d19f3c9aa95f57d0a432ad53 Gerrit-Change-Number: 43187 Gerrit-PatchSet: 1 Gerrit-Owner: n0k0 <osmocom(a)hacky.software> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: n0k0 <osmocom(a)hacky.software> Gerrit-Comment-Date: Sat, 08 Aug 2026 20:28:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: ts_31_102: EF SUCI_Calc_Info: fix decoding empty files
by lynxis lazus 09 Aug '26

09 Aug '26

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41581?usp=email to look at the new patch set (#3). Change subject: ts_31_102: EF SUCI_Calc_Info: fix decoding empty files ...................................................................... ts_31_102: EF SUCI_Calc_Info: fix decoding empty files When trying to use `edit_binary_decoded` with an empty file, pysim runs into a len(None) exception, because hpkl.to_dict()['hnet_pubkey_list'] returns None. Can reproduced with a CCC Camp 2023 usim and editing the file. a000ff..ff (len = 200) Co-authored-by: Harald Welte <laforge(a)osmocom.org> Change-Id: Ib8e322e65dd768bfd49e7a5620a2163f12a74ec7 --- M pySim/ts_31_102.py 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/81/41581/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41581?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib8e322e65dd768bfd49e7a5620a2163f12a74ec7 Gerrit-Change-Number: 41581 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in docker-playground[master]: osmo-stp: add support for tcap-loadsharing
by lynxis lazus 09 Aug '26

09 Aug '26

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/docker-playground/+/41390?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: osmo-stp: add support for tcap-loadsharing ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: Need to check if we want to have it on fedora. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41390?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib58f07d28a38109b4dd053479ddbdb1937eda64e Gerrit-Change-Number: 41390 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 08 Aug 2026 17:23:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: ts_31_102: EF SUCI_Calc_Info: fix decoding empty files
by lynxis lazus 09 Aug '26

09 Aug '26

Attention is currently required from: laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/pysim/+/41581?usp=email ) Change subject: ts_31_102: EF SUCI_Calc_Info: fix decoding empty files ...................................................................... Patch Set 1: (1 comment) File pySim/ts_31_102.py: https://gerrit.osmocom.org/c/pysim/+/41581/comment/98db3acd_f35ebf37?usp=em… : PS1, Line 392: hnet_pubkey_list = self._compact_pubkey_list(hpkl.to_dict()['hnet_pubkey_list']) > wouldn't something more compact work without interrupting the cotrol flow of the source / indent / . […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41581?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib8e322e65dd768bfd49e7a5620a2163f12a74ec7 Gerrit-Change-Number: 41581 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 08 Aug 2026 17:19:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: ts_31_102: EF SUCI_Calc_Info: fix decoding empty files
by lynxis lazus 09 Aug '26

09 Aug '26

Attention is currently required from: laforge, lynxis lazus. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41581?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: ts_31_102: EF SUCI_Calc_Info: fix decoding empty files ...................................................................... ts_31_102: EF SUCI_Calc_Info: fix decoding empty files When trying to use `edit_binary_decoded` with an empty file, pysim runs into a len(None) exception, because hpkl.to_dict()['hnet_pubkey_list'] returns None. Can reproduced with a CCC Camp 2023 usim and editing the file. a000ff..ff (len = 200) Co-authored-by: Harald Welte <laforge(a)osmocom.org> Change-Id: Ib8e322e65dd768bfd49e7a5620a2163f12a74ec7 --- M pySim/ts_31_102.py 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/81/41581/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41581?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib8e322e65dd768bfd49e7a5620a2163f12a74ec7 Gerrit-Change-Number: 41581 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in pysim[master]: pySim/global_platform: replace deprecated argument group() creation
by lynxis lazus 09 Aug '26

09 Aug '26

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/42066?usp=email ) Change subject: pySim/global_platform: replace deprecated argument group() creation ...................................................................... Abandoned master already implemented a similar patch -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42066?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4f73d3417a12b7fe94e33a265cdae244f3c9a1e9 Gerrit-Change-Number: 42066 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySim/apdu: protect SW access from None
by lynxis lazus 09 Aug '26

09 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/43197?usp=email ) Change subject: pySim/apdu: protect SW access from None ...................................................................... pySim/apdu: protect SW access from None If SW hasn't been set yet or is empty, protect access to sw Change-Id: Iff7fe02f700e0eb42766a3264a856fc7947cdcd2 --- M pySim/apdu/__init__.py 1 file changed, 7 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/97/43197/1 diff --git a/pySim/apdu/__init__.py b/pySim/apdu/__init__.py index 84ac83a..4344d3e 100644 --- a/pySim/apdu/__init__.py +++ b/pySim/apdu/__init__.py @@ -134,11 +134,12 @@ if callable(method): return method() # default case: only 9000 is success - if self.sw == b'\x90\x00': - return True - # This is not really a generic positive APDU SW but specific to UICC/SIM - if self.sw[0] == 0x91: - return True + if self.sw: + if self.sw == b'\x90\x00': + return True + # This is not really a generic positive APDU SW but specific to UICC/SIM + if self.sw[0] == 0x91: + return True return False @@ -423,7 +424,7 @@ def input_tpdu(self, tpdu:Tpdu): # handle SW=61xx / 6Cxx - if tpdu.sw[0] == 0x61 or tpdu.sw[0] == 0x6C: + if tpdu.sw and (tpdu.sw[0] == 0x61 or tpdu.sw[0] == 0x6C): self.state = 'WAIT_GET_RESPONSE' # handle successive 61/6c responses by stupid phone/modem OS if tpdu.ins != 0xC0: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43197?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iff7fe02f700e0eb42766a3264a856fc7947cdcd2 Gerrit-Change-Number: 43197 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in pysim[master]: pySim-trace: treat CTRL-C / KeyboardInterrupt as normal abort
by lynxis lazus 09 Aug '26

09 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/43195?usp=email ) Change subject: pySim-trace: treat CTRL-C / KeyboardInterrupt as normal abort ...................................................................... pySim-trace: treat CTRL-C / KeyboardInterrupt as normal abort Change-Id: Ic75e8454bea4d59d6d7c41f8d9d699dcad56514e --- M pySim-trace.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/95/43195/1 diff --git a/pySim-trace.py b/pySim-trace.py index 0aa1e9c..083fc81 100755 --- a/pySim-trace.py +++ b/pySim-trace.py @@ -117,7 +117,7 @@ try: apdu = self.source.read() apdu_counter = apdu_counter + 1 - except StopIteration: + except (StopIteration, KeyboardInterrupt): print("%i APDUs parsed, stop iteration." % apdu_counter) return 0 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43195?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic75e8454bea4d59d6d7c41f8d9d699dcad56514e Gerrit-Change-Number: 43195 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in pysim[master]: pySim-trace: ignore all other exception and retry parsing it
by lynxis lazus 09 Aug '26

09 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/43196?usp=email ) Change subject: pySim-trace: ignore all other exception and retry parsing it ...................................................................... pySim-trace: ignore all other exception and retry parsing it Change-Id: I53a5e7e7087073f242eab1d86ef8a9ec929193bd --- M pySim-trace.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/96/43196/1 diff --git a/pySim-trace.py b/pySim-trace.py index 083fc81..a1a5bb1 100755 --- a/pySim-trace.py +++ b/pySim-trace.py @@ -120,6 +120,9 @@ except (StopIteration, KeyboardInterrupt): print("%i APDUs parsed, stop iteration." % apdu_counter) return 0 + except Exception as exp: + print(f"Failed to parse APDU {exp}") + continue if isinstance(apdu, CardReset): self.rs.reset() -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43196?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I53a5e7e7087073f242eab1d86ef8a9ec929193bd Gerrit-Change-Number: 43196 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in simtrace2[master]: cosmetic: fix typo in comment
by lynxis lazus 09 Aug '26

09 Aug '26

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/43186?usp=email ) Change subject: cosmetic: fix typo in comment ...................................................................... cosmetic: fix typo in comment Change-Id: I85939afd424c957ae872fa99f40b9cd528375537 --- M host/lib/apdu_dispatch.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/host/lib/apdu_dispatch.c b/host/lib/apdu_dispatch.c index 4c8f505..f2fa64e 100644 --- a/host/lib/apdu_dispatch.c +++ b/host/lib/apdu_dispatch.c @@ -63,7 +63,7 @@ } /*! \brief input function for APDU segmentation - * \param ac APDU context accross successive calls + * \param ac APDU context across successive calls * \param[in] apdu_buf APDU inpud data buffer * \param[in] apdu_len Length of apdu_buf * \param[in] new_apdu Is this the beginning of a new APDU? -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43186?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I85939afd424c957ae872fa99f40b9cd528375537 Gerrit-Change-Number: 43186 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026