Attention is currently required from: jolly.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43067?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: V1.2: Specify tag values in HandleNotificationEsipa
......................................................................
V1.2: Specify tag values in HandleNotificationEsipa
Add specific tag values to fields in HandleNotificationEsipa.
Reference: SGP.23 Section 6.3.2.4
Related: SYS#8101
Change-Id: I3abeb7295fd43e499105086a49bd62c4f835aeed
---
M asn1/SGP32Definitions.asn
M src/ipa/libasn/HandleNotificationEsipa.c
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/67/43067/4
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43067?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I3abeb7295fd43e499105086a49bd62c4f835aeed
Gerrit-Change-Number: 43067
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: jolly.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43068?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: V1.2: Rename field in GetBoundProfilePackageResponseEsipa
......................................................................
V1.2: Rename field in GetBoundProfilePackageResponseEsipa
Rename field profileMetadataMismatch to metadataMismatch in
GetBoundProfilePackageResponseEsipa.
Reference: SGP.23 Section 6.3.2.3
Related: SYS#8101
Change-Id: I87965b68bde39d29317f9848aa3a88d9966c4e78
---
M asn1/SGP32Definitions.asn
M src/ipa/libasn/GetBoundProfilePackageResponseEsipa.h
M src/ipa/libipa/esipa_get_bnd_prfle_pkg.c
3 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/68/43068/4
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43068?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I87965b68bde39d29317f9848aa3a88d9966c4e78
Gerrit-Change-Number: 43068
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: jolly.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43069?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: V1.2: Rename field in PSMO
......................................................................
V1.2: Rename field in PSMO
Rename two field in PSMO.
Reference: SGP.23 Section 2.11.1.1.3
Related: SYS#8101
Change-Id: I9336f18aaf104629845948877294437188979376
---
M asn1/SGP32Definitions.asn
M src/ipa/libasn/Psmo.c
M src/ipa/libasn/Psmo.h
M src/ipa/libipa/context.h
M src/ipa/libipa/es10b_euicc_mem_rst.c
M src/ipa/libipa/es10b_immediate_enable.c
M src/ipa/libipa/es10b_load_bnd_prfle_pkg.c
M src/ipa/libipa/es10b_load_euicc_pkg.c
M src/ipa/libipa/ipad.c
9 files changed, 67 insertions(+), 63 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/69/43069/4
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43069?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I9336f18aaf104629845948877294437188979376
Gerrit-Change-Number: 43069
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: jolly.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43066?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: V1.2: Add error codes to GetEimPackageResponse
......................................................................
V1.2: Add error codes to GetEimPackageResponse
Add several new error codes to eimPackageError in GetEimPackageResponse.
These errors are displayed during IPA process.
Reference: SGP.23 Section 6.3.2.6
Related: SYS#8101
Change-Id: Ic0cdce1f5269794f37c5da3a63985706a7959184
---
M asn1/SGP32Definitions.asn
M src/ipa/libasn/GetEimPackageResponse.h
M src/ipa/libipa/esipa_get_eim_pkg.c
3 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/66/43066/4
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43066?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Ic0cdce1f5269794f37c5da3a63985706a7959184
Gerrit-Change-Number: 43066
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: jolly.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43070?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: V1.2: Change tag in TransferEimPackageResponse
......................................................................
V1.2: Change tag in TransferEimPackageResponse
Change tag value of notificationList in TransferEimPackageResponse.
Also change it from RetrieveNotificationsListResponse to
PendingNotificationList.
Reference: SGP.23 Section 6.3.1
Related: SYS#8101
Change-Id: I4c9cdd1b79ec22a1d5e36d1720cf5c703890c28b
---
M asn1/SGP32Definitions.asn
M src/ipa/libasn/SGP32-RetrieveNotificationsListResponse.c
M src/ipa/libasn/SGP32-RetrieveNotificationsListResponse.h
M src/ipa/libasn/TransferEimPackageResponse.c
M src/ipa/libasn/TransferEimPackageResponse.h
5 files changed, 9 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/70/43070/4
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43070?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I4c9cdd1b79ec22a1d5e36d1720cf5c703890c28b
Gerrit-Change-Number: 43070
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: jolly.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43071?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: V1.2: Add eimValue to CompactOtherSignedNotification
......................................................................
V1.2: Add eimValue to CompactOtherSignedNotification
The IPA just forwards the message, so no change in process is required.
Reference: SGP.23 Section 5.14.7
Related: SYS#8101
Change-Id: I0183ef6555d23d762e6c8fa8584453b3a07d4940
---
M asn1/SGP32Definitions.asn
M src/ipa/libasn/CompactOtherSignedNotification.c
M src/ipa/libasn/CompactOtherSignedNotification.h
3 files changed, 22 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/71/43071/4
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43071?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I0183ef6555d23d762e6c8fa8584453b3a07d4940
Gerrit-Change-Number: 43071
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/43198?usp=email )
Change subject: jenkins-gerrit/comment_generate: fail on 0 passed
......................................................................
jenkins-gerrit/comment_generate: fail on 0 passed
Don't print the success message when zero jobs has passed. If this
happens, we have an internal error somewhere.
Change-Id: I1317f14c2f3f55f2a9b6581372c80edba33528db
---
M scripts/jenkins-gerrit/comment_generate.py
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/98/43198/1
diff --git a/scripts/jenkins-gerrit/comment_generate.py b/scripts/jenkins-gerrit/comment_generate.py
index fc8a8b1..1b3bfcd 100755
--- a/scripts/jenkins-gerrit/comment_generate.py
+++ b/scripts/jenkins-gerrit/comment_generate.py
@@ -212,6 +212,8 @@
summary += f"{len(jobs['passed'])} passed:\n"
summary += get_jobs_list_str(jobs["passed"])
+ if not jobs['passed']:
+ summary += "Zero jobs passed, internal script error?\n"
if "build" in pipeline and "deb" in pipeline and "rpm" in pipeline and \
not pipeline["build"]["passed"] and pipeline["deb"]["passed"] \
@@ -227,7 +229,7 @@
summary += "https://osmocom.org/projects/cellular-infrastructure/wiki/Linting\n"
summary += "\n"
- if jobs["failed"]:
+ if jobs["failed"] or not jobs['passed']:
summary += "Build Failed\n"
summary += "\n"
summary += f"Find the Retrigger button here:\n{build_url}\n"
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43198?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I1317f14c2f3f55f2a9b6581372c80edba33528db
Gerrit-Change-Number: 43198
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Attention is currently required from: lynxis lazus, pespin.
laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/43178?usp=email )
Change subject: RFC: sim/class_tables: add a size attribute
......................................................................
Patch Set 2:
(2 comments)
File include/osmocom/sim/class_tables.h:
https://gerrit.osmocom.org/c/libosmocore/+/43178/comment/755d966d_0c4ff760?… :
PS2, Line 39: const uint8_t *hdr);
I think this breakage is serious and can't be accepted as it is used by external programs like osmo-remsim, simtrace2, possibly more. The better approach would be to add a osim_determine_apdu_case2() symbol with the new argument adn have the old one as deprecated symbol around?
https://gerrit.osmocom.org/c/libosmocore/+/43178/comment/5f80caf4_6d790fc7?… :
PS2, Line 23: i
I can potentially live with that API + ABI break, as this is really AFAICT only used by library-internal helper functions
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43178?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iee50063399a0c3b29594e737f44aaa125fd06a2e
Gerrit-Change-Number: 43178
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 10 Aug 2026 11:48:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No