Attention is currently required from: Hoernchen, laforge.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42797?usp=email )
Change subject: CCID: Send procedure byte, when not expected
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS1:
> I do not understand the test, its sends manage channel, acks with is_commands=false so fw expects pb […]
Yes, you are right, the reader should run into timeout. I changed the test accordingly. (The Cardman reader seems not to determine the 'case' by the request and not by the response.)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42797?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icffd48d99f0eb48e0898efb027854eba8c22f4a4
Gerrit-Change-Number: 42797
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 13 Jul 2026 10:12:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Attention is currently required from: Hoernchen, jolly, laforge.
Hello Hoernchen, Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42798?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review-1 by Hoernchen, Verified+1 by Jenkins Builder
Change subject: CCID: Check if reader times out while expecting procedure byte
......................................................................
CCID: Check if reader times out while expecting procedure byte
A case 2 APDU (according to ISO 7816) is sent toward the reader. The
reader expects a procedure byte or a status word. If none of these are
sent by the SIM the reader must timeout and send an error message back
to the host.
Change-Id: Iacd6aacaf8220e69b9b7038e354d54c788d1eb05
---
M ccid/CCID_Tests.ttcn
1 file changed, 49 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/98/42798/7
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42798?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iacd6aacaf8220e69b9b7038e354d54c788d1eb05
Gerrit-Change-Number: 42798
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Attention is currently required from: Hoernchen, jolly, laforge.
Hello Hoernchen, Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42796?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: CCID: Send a wrong procedure byte towards the reader
......................................................................
CCID: Send a wrong procedure byte towards the reader
A case 2 request (according to ISO 7816) is sent and a response with
data is expected, but the first byte replied by the SIM is not a
procedure byte, nor a valid status byte.
This text expects the reader to return an error that states an incorrect
received procedure byte.
Change-Id: Iaa0bd8845b3408fba309874fe41c855d8e7efccc
---
M ccid/CCID_Tests.ttcn
1 file changed, 39 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/96/42796/7
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42796?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iaa0bd8845b3408fba309874fe41c855d8e7efccc
Gerrit-Change-Number: 42796
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Attention is currently required from: Hoernchen, jolly, laforge.
Hello Hoernchen, Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42797?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: CCID: Send procedure byte, when not expected
......................................................................
CCID: Send procedure byte, when not expected
A case 1 APDU does not request any data from SIM to return. The SIM will
only return a status byte with no procedure byte in advance.
The test sends a the INS byte + procedure byte (0x62) instead of the
two status bytes as a response to the reader. The reader waits for
payload to be received from the SIM and times out.
This means that the reader uses the SIM response to determine if it is
a case 1 or case 2 APDU and not the instruction GET_RESPONSE.
Change-Id: Icffd48d99f0eb48e0898efb027854eba8c22f4a4
---
M ccid/CCID_Tests.ttcn
1 file changed, 39 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/42797/7
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42797?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icffd48d99f0eb48e0898efb027854eba8c22f4a4
Gerrit-Change-Number: 42797
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Attention is currently required from: Hoernchen, jolly, laforge.
Hello Hoernchen, Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42806?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review-1 by Hoernchen, Verified+1 by Jenkins Builder
Change subject: CCID: Check if reader handles Abort correctly
......................................................................
CCID: Check if reader handles Abort correctly
The tests aborts an ongoing case 2 APDU (according to ISO 7816). The
SIM responds with a NULL procedure byte so that the reader does not
time out.
The abort messages are sent on both, the control pipe and the bulk
pipe with the same sequence number.
This test fails with osmo-ccid-firmware, because the abort
message/handling is not yet implemented.
Change-Id: Iebe97e73497b8468ebf08faf2c4db700fc76997f
---
M ccid/CCID_Tests.ttcn
1 file changed, 72 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/06/42806/7
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42806?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iebe97e73497b8468ebf08faf2c4db700fc76997f
Gerrit-Change-Number: 42806
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
dexter has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34404?usp=email )
Change subject: mgcp_client_fsm: allocate struct mgcp_conn_peer dynamically
......................................................................
Abandoned
As far as I remember (by the comments) the context was that we wanted to allocate mgcp_conn_peer dynamically to lower the risk with ABI/memory size problems in the future. However, the price would have been to make an incompatible API change now. Given that the patch is very old and we apparently have no problems with, let's abandon it.
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34404?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I523d0fcb020f7d46323c497a4be9ee00d5f242ba
Gerrit-Change-Number: 34404
Gerrit-PatchSet: 16
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42991?usp=email )
Change subject: mnesia_db_rest: add comment on why we create an euicc entry early
......................................................................
mnesia_db_rest: add comment on why we create an euicc entry early
Even though it is technically not necessary, we ensure that an
entry is present in the euicc table on each REST API call. Let's
add a comment to explain why we do it anyway.
Change-Id: Ifb9340655c5f36e074a1a92c0e234ef62c79b9d8
---
M src/mnesia_db_rest.erl
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/91/42991/1
diff --git a/src/mnesia_db_rest.erl b/src/mnesia_db_rest.erl
index 41b4a0c..0976beb 100644
--- a/src/mnesia_db_rest.erl
+++ b/src/mnesia_db_rest.erl
@@ -41,7 +41,13 @@
% Create REST resource (order)
create(Facility, EidValue, Order) ->
+ % Ensure that an euicc entry is present in the database for the given EidValue. In case no entry exists yet, a new
+ % entry is created with default parameters from sys.config, which is is sufficient in many usecases. From the
+ % technical perspective, this is just a convenience feature, which frees the REST API user from having to create an
+ % euicc entry manually before performming the first operation.
ok = mnesia_db_euicc:create_if_not_exist(EidValue),
+
+ % Continue with the normal creation of the REST resource.
ResourceId = uuid:uuid_to_string(uuid:get_v4_urandom()),
Timestamp = os:system_time(seconds),
Row = #rest{
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42991?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Ifb9340655c5f36e074a1a92c0e234ef62c79b9d8
Gerrit-Change-Number: 42991
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42994?usp=email )
Change subject: doc/build.md: fix typo
......................................................................
doc/build.md: fix typo
Related: SYS#8100
Change-Id: Ie6a066f3289fbdde40f55bd9f38a3dd90102e7e6
---
M doc/build.md
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/94/42994/1
diff --git a/doc/build.md b/doc/build.md
index 5bb08af..660791b 100644
--- a/doc/build.md
+++ b/doc/build.md
@@ -252,7 +252,7 @@
Onomondo-eim supports the simultaneous usage of IoT eUICCs and consumer eUICCs. The type of the eUICC must be set for
each eUICC via the REST API once, if it differs from the default set with the configuration option `consumer_euicc`.
-For larger installations, where both flavours of eUICCs are used, it is recommended to run two dedicated eIM
+For larger installations, where both flavors of eUICCs are used, it is recommended to run two dedicated eIM
instances, one for each eUICC flavor.
### vm.args
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42994?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Ie6a066f3289fbdde40f55bd9f38a3dd90102e7e6
Gerrit-Change-Number: 42994
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42992?usp=email )
Change subject: contrib/tryme_euiccDataRequest: fixup example tag string
......................................................................
contrib/tryme_euiccDataRequest: fixup example tag string
The eUICC data request takes a string with TLV tags as input. The
example in this example still uses tags from SGP.32 V.1.0.1, let's
update the string so that it is compliant with SGP.32 V.1.2.
(see also SGP.32, section 2.11.1.2)
Related: SYS:8100
Change-Id: I5be04c954330638d3e7d78e8f5f280bebb707efa
---
M contrib/tryme_euiccDataRequest.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/92/42992/1
diff --git a/contrib/tryme_euiccDataRequest.sh b/contrib/tryme_euiccDataRequest.sh
index 7411c13..ba70a69 100755
--- a/contrib/tryme_euiccDataRequest.sh
+++ b/contrib/tryme_euiccDataRequest.sh
@@ -1,6 +1,6 @@
#!/bin/bash
. ./tryme.cfg
-JSON='{ "eidValue" : "'$EID'", "order" : { "edr" : {"tagList" : "80BF20BF228384A5A688A9BF2B" } } }'
+JSON='{ "eidValue" : "'$EID'", "order" : { "edr" : { "tagList" : "81BF20BF228384A5A6A8A9A0" } } }'
RC=`./restop.py -c -f edr -j "$JSON"`
echo $RC
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42992?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I5be04c954330638d3e7d78e8f5f280bebb707efa
Gerrit-Change-Number: 42992
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>