Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42915?usp=email )
Change subject: library: add f_gsm_fn_{sum,sub,diff}()
......................................................................
Patch Set 2:
(1 comment)
File library/GSM_Types.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42915/comment/52eeaf5b_1e3b… :
PS2, Line 450: function f_gsm_fn_diff(GsmFrameNumber a, GsmFrameNumber b) return GsmFrameNumber {
> Acknowledged
This API mimics what we have in libosmocore's gsm0502.h. I don't see anything wrong with having this function here, despite it's not used (yet). It's just a few lines - definitely not a big maintenance burden.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42915?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie91ccef5d3f170f4a341a6cf9d3323a896b299e6
Gerrit-Change-Number: 42915
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 02 Jul 2026 20:48:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42911?usp=email )
Change subject: common: stop buffering UL measurements when SACCH is deactivated
......................................................................
Patch Set 3:
(1 comment)
File tests/meas/meas_test.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42911/comment/4acad447_7fd73876?usp… :
PS3, Line 71: lchan->ul_sacch_active = true;
> why is this set to true here instead of false? […]
Because the testcases actually use this function as an initializer, not as a shutdown cleanup helper. Note that above this function changes the lchan state to active.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42911?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3943c788cab5d2411b06ac681d4d412852bac0a7
Gerrit-Change-Number: 42911
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 02 Jul 2026 20:42:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42911?usp=email )
Change subject: common: stop buffering UL measurements when SACCH is deactivated
......................................................................
Patch Set 3:
(1 comment)
File tests/meas/meas_test.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42911/comment/bd781c66_4d65a56b?usp… :
PS3, Line 71: lchan->ul_sacch_active = true;
why is this set to true here instead of false?
AFAIU the default state should be false?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42911?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3943c788cab5d2411b06ac681d4d412852bac0a7
Gerrit-Change-Number: 42911
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 02 Jul 2026 20:36:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: fixeria.
osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42915?usp=email )
Change subject: library: add f_gsm_fn_{sum,sub,diff}()
......................................................................
Patch Set 2:
(1 comment)
File library/GSM_Types.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42915/comment/8ca8291f_8989… :
PS2, Line 450: function f_gsm_fn_diff(GsmFrameNumber a, GsmFrameNumber b) return GsmFrameNumber {
f_gsm_fn_diff is unused, even in https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42916/2. would it maybe make more sense to only introduce it later when it actually gets used?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42915?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie91ccef5d3f170f4a341a6cf9d3323a896b299e6
Gerrit-Change-Number: 42915
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 02 Jul 2026 13:31:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No