July 2026 - gerrit-log - lists.osmocom.org

[XL] Change in osmo-trx[master]: libosmo-trx: generate Doxygen API documentation
by fixeria 29 Jul '26

29 Jul '26

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43113?usp=email ) Change subject: libosmo-trx: generate Doxygen API documentation ...................................................................... Patch Set 1: (1 comment) File libosmo-trx/src/trxc.c: https://gerrit.osmocom.org/c/osmo-trx/+/43113/comment/5b3fd872_29bd01e3?usp… : PS1, Line 171: * \param[in] buf message buffer (not necessarily zero-terminated) > I think we can squash this change into a previous commit? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43113?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I54cf8c0c60215c666d8fa55dafec53379a2382d5 Gerrit-Change-Number: 43113 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jul 2026 11:23:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in simtrace2[master]: firmware: sniffer: fix ~INS procedure byte comparison
by Hoernchen 29 Jul '26

29 Jul '26

Attention is currently required from: lynxis lazus. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/simtrace2/+/43129?usp=email ) Change subject: firmware: sniffer: fix ~INS procedure byte comparison ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Nice catch. […] We should not have more, which -Werror=sign-compare would ensure.. The problem is that this mostly spams "annoying" warnings due to loop variables and gets ignored by everyone because these kind of comparison bugs are much more fun than fixing warnings. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43129?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I800f50ef35356429d07aa685ea919e70ec34946e Gerrit-Change-Number: 43129 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 29 Jul 2026 11:22:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in simtrace2[master]: firmware: sniffer: fix ~INS procedure byte comparison
by lynxis lazus 29 Jul '26

29 Jul '26

Attention is currently required from: Hoernchen. lynxis lazus has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/simtrace2/+/43129?usp=email ) Change subject: firmware: sniffer: fix ~INS procedure byte comparison ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Nice catch. Do we have more of these unary operations with uin8_t in osmocom? -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43129?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I800f50ef35356429d07aa685ea919e70ec34946e Gerrit-Change-Number: 43129 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jul 2026 10:34:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-trx[master]: Transceiver52M: migrate to libosmo-trx
by fixeria 29 Jul '26

29 Jul '26

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43115?usp=email ) Change subject: Transceiver52M: migrate to libosmo-trx ...................................................................... Patch Set 1: (1 comment) File Transceiver52M/Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/43115/comment/d1e75ec6_bc167249?usp… : PS1, Line 100: $(top_builddir)/libosmo-trx/src/libosmotrx.la \ > Let's better put this above the LIBOSMOCORE_LIBS, since this in not only osmo-trx specific library c […] It's already above the `LIBOSMOCORE_LIBS`... Did you mean `libtransceiver_common.la` maybe? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43115?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I458ec85c56e2101d073c8c35f11c147191c4ea0c Gerrit-Change-Number: 43115 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jul 2026 09:30:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-dev[master]: ruff: ignore new failing default rules
by osmith 29 Jul '26

29 Jul '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/43121?usp=email ) Change subject: ruff: ignore new failing default rules ...................................................................... ruff: ignore new failing default rules With the new ruff 0.16 version, a lot of new default rules have been added. Ignore the ones that are failing for now to make the linter pass again. Related: https://astral.sh/blog/ruff-v0.16.0#better-default-rule-set Change-Id: I7d22481e9238e8155beb923a120ac8baea21df9d --- M .ruff.toml 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/.ruff.toml b/.ruff.toml index c673c3a..d9ae72b 100644 --- a/.ruff.toml +++ b/.ruff.toml @@ -12,8 +12,16 @@ ] [lint] -# E741: Ambiguous variable name: `l` -ignore = ["E741"] +ignore = [ + "B026", # https://docs.astral.sh/ruff/rules/star-arg-unpacking-after-keyword-arg/ + "E741", # https://docs.astral.sh/ruff/rules/ambiguous-variable-name/ + "EXE001", # https://docs.astral.sh/ruff/rules/shebang-not-executable/ + "I001", # https://docs.astral.sh/ruff/rules/unsorted-imports/ + "PLR1730", # https://docs.astral.sh/ruff/rules/if-stmt-min-max/ + "SIM103", # https://docs.astral.sh/ruff/rules/needless-bool/ + "SIM115", # https://docs.astral.sh/ruff/rules/open-file-with-context-handler/ + "UP031", # https://docs.astral.sh/ruff/rules/printf-string-formatting/ +] [format] exclude = [ -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/43121?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I7d22481e9238e8155beb923a120ac8baea21df9d Gerrit-Change-Number: 43121 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-dev[master]: ruff: ignore new failing default rules
by osmith 29 Jul '26

29 Jul '26

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/43121?usp=email ) Change subject: ruff: ignore new failing default rules ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/43121?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I7d22481e9238e8155beb923a120ac8baea21df9d Gerrit-Change-Number: 43121 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jul 2026 08:50:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: ruff: ignore new failing default rules
by osmith 29 Jul '26

29 Jul '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43119?usp=email ) Change subject: ruff: ignore new failing default rules ...................................................................... ruff: ignore new failing default rules With the new ruff 0.16 version, a lot of new default rules have been added. Ignore the ones that are failing for now to make the linter pass again. Related: https://astral.sh/blog/ruff-v0.16.0#better-default-rule-set Change-Id: If95dc72c1826b4b96961453b2c2ed1d2c81ba149 --- M .ruff.toml 1 file changed, 23 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/.ruff.toml b/.ruff.toml index ad8c0b5..63013d2 100644 --- a/.ruff.toml +++ b/.ruff.toml @@ -2,3 +2,26 @@ exclude = [ "compare-results.py", ] + +[lint] +ignore = [ + "B006", # https://docs.astral.sh/ruff/rules/mutable-argument-default/ + "B026", # https://docs.astral.sh/ruff/rules/star-arg-unpacking-after-keyword-arg/ + "BLE001", # https://docs.astral.sh/ruff/rules/blind-except/ + "DTZ001", # https://docs.astral.sh/ruff/rules/call-datetime-without-tzinfo/ + "DTZ004", # https://docs.astral.sh/ruff/rules/call-datetime-utcfromtimestamp/ + "DTZ005", # https://docs.astral.sh/ruff/rules/call-datetime-now-without-tzinfo/ + "DTZ007", # https://docs.astral.sh/ruff/rules/call-datetime-strptime-without-zone/ + "FURB105", # https://docs.astral.sh/ruff/rules/print-empty-string/ + "I001", # https://docs.astral.sh/ruff/rules/unsorted-imports/ + "LOG015", # https://docs.astral.sh/ruff/rules/root-logger-call/ + "PIE808", # https://docs.astral.sh/ruff/rules/unnecessary-range-start/ + "PLC0206", # https://docs.astral.sh/ruff/rules/dict-index-missing-items/ + "PLW0602", # https://docs.astral.sh/ruff/rules/global-variable-not-assigned/ + "PLW1510", # https://docs.astral.sh/ruff/rules/subprocess-run-without-check/ + "RUF012", # https://docs.astral.sh/ruff/rules/mutable-class-default/ + "SIM102", # https://docs.astral.sh/ruff/rules/collapsible-if/ + "SIM103", # https://docs.astral.sh/ruff/rules/needless-bool/ + "SIM118", # https://docs.astral.sh/ruff/rules/in-dict-keys/ + "UP032", # https://docs.astral.sh/ruff/rules/f-string/ +] -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43119?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If95dc72c1826b4b96961453b2c2ed1d2c81ba149 Gerrit-Change-Number: 43119 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: fix B006
by osmith 29 Jul '26

29 Jul '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43120?usp=email ) Change subject: testenv: fix B006 ...................................................................... testenv: fix B006 Fix "B006 Do not use mutable data structures for argument defaults". I ran into bugs caused by this a couple of times actually, it is good to check for that. Related: https://docs.astral.sh/ruff/rules/mutable-argument-default/ Change-Id: Id860c1cba20c0218aa1d1bb17378a0f5a521cfe0 --- M .ruff.toml M _testenv/testenv/cmd.py M _testenv/testenv/podman.py 3 files changed, 14 insertions(+), 6 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/.ruff.toml b/.ruff.toml index 63013d2..ebf5d74 100644 --- a/.ruff.toml +++ b/.ruff.toml @@ -5,7 +5,6 @@ [lint] ignore = [ - "B006", # https://docs.astral.sh/ruff/rules/mutable-argument-default/ "B026", # https://docs.astral.sh/ruff/rules/star-arg-unpacking-after-keyword-arg/ "BLE001", # https://docs.astral.sh/ruff/rules/blind-except/ "DTZ001", # https://docs.astral.sh/ruff/rules/call-datetime-without-tzinfo/ diff --git a/_testenv/testenv/cmd.py b/_testenv/testenv/cmd.py index c14f694..97e5c0d 100644 --- a/_testenv/testenv/cmd.py +++ b/_testenv/testenv/cmd.py @@ -88,7 +88,8 @@ raise RuntimeError("shell command related error, find details right above this python trace") -def generate_env(env={}, podman=False): +def generate_env(env=None, podman=False): + env = env or {} ret = dict(env_extra) path = os.path.join(testenv.data_dir, "scripts") path += f":{os.path.join(testenv.data_dir, 'scripts/qemu')}" @@ -120,7 +121,8 @@ return ret -def run(cmd, check=True, env={}, no_podman=False, stdin=subprocess.DEVNULL, *args, **kwargs): +def run(cmd, check=True, env=None, no_podman=False, stdin=subprocess.DEVNULL, *args, **kwargs): + env = env or {} if not no_podman and testenv.args.podman: return testenv.podman.exec_cmd(cmd, check=check, env=env, *args, **kwargs) diff --git a/_testenv/testenv/podman.py b/_testenv/testenv/podman.py index a3e7948..eefa911 100644 --- a/_testenv/testenv/podman.py +++ b/_testenv/testenv/podman.py @@ -82,7 +82,8 @@ ) -def generate_env_podman(env={}): +def generate_env_podman(env=None): + env = env or {} ret = [] for key, val in testenv.cmd.generate_env(env, True).items(): @@ -136,7 +137,10 @@ run_shell_on_stop = True -def exec_cmd(cmd, podman_opts=[], cwd=None, env={}, *args, **kwargs): +def exec_cmd(cmd, podman_opts=None, cwd=None, env=None, *args, **kwargs): + podman_opts = podman_opts or [] + env = env or {} + if not container_name: raise RuntimeError(f"Attempting to execute a command in podman, but the container isn't running anymore: {cmd}") @@ -159,7 +163,10 @@ ) -def exec_cmd_background(cmd, podman_opts=[], cwd=None, env={}): +def exec_cmd_background(cmd, podman_opts=None, cwd=None, env=None): + podman_opts = podman_opts or [] + env = env or {} + podman_opts = list(podman_opts) + generate_env_podman(env) if cwd: -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43120?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id860c1cba20c0218aa1d1bb17378a0f5a521cfe0 Gerrit-Change-Number: 43120 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: fix B006
by osmith 29 Jul '26

29 Jul '26

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43120?usp=email ) Change subject: testenv: fix B006 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43120?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id860c1cba20c0218aa1d1bb17378a0f5a521cfe0 Gerrit-Change-Number: 43120 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jul 2026 08:49:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: ruff: ignore new failing default rules
by osmith 29 Jul '26

29 Jul '26

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43119?usp=email ) Change subject: ruff: ignore new failing default rules ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43119?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If95dc72c1826b4b96961453b2c2ed1d2c81ba149 Gerrit-Change-Number: 43119 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jul 2026 08:49:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log July 2026