July 2026 - gerrit-log - lists.osmocom.org

[XS] Change in onomondo-ipa[master]: Minor fix of compiler warning in esipa.c
by jolly 16 Jul '26

16 Jul '26

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43020?usp=email ) Change subject: Minor fix of compiler warning in esipa.c ...................................................................... Minor fix of compiler warning in esipa.c Related: SYS#8101 Change-Id: Ied72573a5fd4486f59e0fe71ae678374cafd6b19 --- M src/ipa/libipa/esipa.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/20/43020/1 diff --git a/src/ipa/libipa/esipa.c b/src/ipa/libipa/esipa.c index a0ec4de..d88da5d 100644 --- a/src/ipa/libipa/esipa.c +++ b/src/ipa/libipa/esipa.c @@ -126,7 +126,7 @@ rc = der_encode(&asn_DEF_EsipaMessageFromIpaToEim, msg_to_eim, ipa_asn1c_consume_bytes_cb, &buf_encoded); if (rc.encoded <= 0) { - IPA_LOGP_ESIPA(function_name, LERROR, "cannot encode eIM request! rc = %d\n", rc.encoded); + IPA_LOGP_ESIPA(function_name, LERROR, "cannot encode eIM request! rc = %zd\n", rc.encoded); IPA_FREE(buf_encoded); return NULL; } -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43020?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Ied72573a5fd4486f59e0fe71ae678374cafd6b19 Gerrit-Change-Number: 43020 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[S] Change in onomondo-ipa[master]: Generate ASN.1 code with recent master branch of asn1c
by jolly 16 Jul '26

16 Jul '26

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43021?usp=email ) Change subject: Generate ASN.1 code with recent master branch of asn1c ...................................................................... Generate ASN.1 code with recent master branch of asn1c Commit-Hash of asn1c using from now on: 2f7f40dab3973f707d66f4a67cae0cc1bc8e62b5 Related: SYS#8101 Change-Id: I1ac4cf8980af501bb119208213242468ee4f3c06 --- M src/ipa/libasn/asn_internal.c M src/ipa/libasn/asn_internal.h M src/ipa/libasn/constr_CHOICE.c 3 files changed, 32 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/21/43021/1 diff --git a/src/ipa/libasn/asn_internal.c b/src/ipa/libasn/asn_internal.c index 91e537c..3b8a2d5 100644 --- a/src/ipa/libasn/asn_internal.c +++ b/src/ipa/libasn/asn_internal.c @@ -1,5 +1,13 @@ #include <asn_internal.h> +#ifdef ASN__DEBUG_INDENT_NEEDS_DEFINITION +/* + * The single definition of the debugging indentation level, + * shared by all units which refer to it via "extern" in asn_internal.h. + */ +int asn_debug_indent; +#endif + ssize_t asn__format_to_callback(int (*cb)(const void *, size_t, void *key), void *key, const char *fmt, ...) { diff --git a/src/ipa/libasn/asn_internal.h b/src/ipa/libasn/asn_internal.h index 76dac64..0dffd35 100644 --- a/src/ipa/libasn/asn_internal.h +++ b/src/ipa/libasn/asn_internal.h @@ -21,7 +21,7 @@ #endif /* Environment version might be used to avoid running with the old library */ -#define ASN1C_ENVIRONMENT_VERSION 923 /* Compile-time version */ +#define ASN1C_ENVIRONMENT_VERSION 929 /* Compile-time version */ int get_asn1c_environment_version(void); /* Run-time version */ #include <onomondo/ipa/mem.h> @@ -51,7 +51,8 @@ #else /* !ASN_THREAD_SAFE */ #undef ASN_DEBUG_INDENT_ADD #undef asn_debug_indent -int asn_debug_indent; +extern int asn_debug_indent; /* A single definition is in asn_internal.c */ +#define ASN__DEBUG_INDENT_NEEDS_DEFINITION 1 #define ASN_DEBUG_INDENT_ADD(i) do { asn_debug_indent += i; } while(0) #endif /* ASN_THREAD_SAFE */ #define ASN_DEBUG(fmt, args...) do { \ @@ -126,8 +127,25 @@ /* * Check stack against overflow, if limit is set. + * ASan inflates stack frames by ~30x (red zones per variable), making the + * distance-based check fire false positives at normal call depth. Disable + * when building under ASan — ASan itself catches real stack overflows. + * GCC and MSVC define __SANITIZE_ADDRESS__; Clang only exposes + * __has_feature(address_sanitizer). */ +#if defined(__SANITIZE_ADDRESS__) +#define ASN__ASAN_ENABLED 1 +#elif defined(__has_feature) +#if __has_feature(address_sanitizer) +#define ASN__ASAN_ENABLED 1 +#endif +#endif + +#ifdef ASN__ASAN_ENABLED +#define ASN__DEFAULT_STACK_MAX (0) +#else #define ASN__DEFAULT_STACK_MAX (30000) +#endif static int CC_NOTUSED ASN__STACK_OVERFLOW_CHECK(const asn_codec_ctx_t *ctx) { if(ctx && ctx->max_stack_size) { diff --git a/src/ipa/libasn/constr_CHOICE.c b/src/ipa/libasn/constr_CHOICE.c index 628979e..6d26dd1 100644 --- a/src/ipa/libasn/constr_CHOICE.c +++ b/src/ipa/libasn/constr_CHOICE.c @@ -340,6 +340,10 @@ ADVANCE(2); ctx->left++; continue; + } else { + ASN_DEBUG("Unexpected continuation in %s", + td->name); + RETURN(RC_FAIL); } } else { ASN_DEBUG("Unexpected continuation in %s", -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43021?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I1ac4cf8980af501bb119208213242468ee4f3c06 Gerrit-Change-Number: 43021 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[S] Change in onomondo-ipa[master]: V1.2: Update imported ASN.1 definitions
by jolly 16 Jul '26

16 Jul '26

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43022?usp=email ) Change subject: V1.2: Update imported ASN.1 definitions ...................................................................... V1.2: Update imported ASN.1 definitions Define what ASN.1 defintions are inported from RSPDefinitions by SGP32Definitions. Related: SYS#8101 Change-Id: Id86c682e5c9fee43b6af6ec011b91565b82fa776 --- M asn1/SGP32Definitions.asn 1 file changed, 9 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/22/43022/1 diff --git a/asn1/SGP32Definitions.asn b/asn1/SGP32Definitions.asn index a492f92..b953420 100644 --- a/asn1/SGP32Definitions.asn +++ b/asn1/SGP32Definitions.asn @@ -10,17 +10,16 @@ FROM PKIX1Explicit88 {iso(1) identified-organization(3) dod(6) internet(1) security(5) mechanisms(5) pkix(7) id-mod(0) id-pkix1-explicit(18)} SubjectKeyIdentifier FROM PKIX1Implicit88 {iso(1) identified-organization(3) dod(6) internet(1) security(5) mechanisms(5) pkix(7) id-mod(0) id-pkix1-implicit(19)} -ProfileInfo, EuiccSigned1, CancelSessionReason, RetrieveNotificationsListResponse, -ServerSigned1, RspCapability, Iccid, TransactionId, ProfileInfoListRequest, -ProfileInfoListResponse, RulesAuthorisationTable, EUICCInfo1, DeviceInfo, -VersionType, UICCCapability, PprIds, -CertificationDataObject, Octet1, Octet16, Octet32, PrepareDownloadResponse, -PrepareDownloadResponseOk, PrepareDownloadResponseError, -AuthenticateServerResponse, AuthenticateResponseOk, AuthenticateResponseError, -CtxParams1, ProfileInstallationResult, ProfileInstallationResultData, +CancelSessionReason, ServerSigned1, RspCapability, Iccid, TransactionId, +ProfileInfoListRequest, RulesAuthorisationTable, EUICCInfo1, DeviceInfo, +VersionType, UICCCapability, PprIds, CertificationDataObject, Octet1, Octet16, +Octet32, PrepareDownloadResponseOk, PrepareDownloadResponseError, +AuthenticateResponseError, CtxParams1, ProfileInstallationResultData, OtherSignedNotification, EuiccSignPIR, ErrorResult, NotificationMetadata, -CancelSessionResponse, CancelSessionResponseOk, -StoreMetadataRequest, SmdpSigned2, BoundProfilePackage, NotificationEvent +CancelSessionResponseOk, SmdpSigned2, BoundProfilePackage, NotificationEvent, +VendorSpecificExtension, DpProprietaryData, OperatorId, +NotificationConfigurationInformation, ProfileClass, IconType, ProfileState, +OctetTo16 FROM RSPDefinitions {joint-iso-itu-t(2) international-organizations(23) gsma(146) rsp(1) asn1modules(1) sgp22v2(2)}; -- ASN1STOP -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43022?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Id86c682e5c9fee43b6af6ec011b91565b82fa776 Gerrit-Change-Number: 43022 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[M] Change in osmo-ttcn3-hacks[master]: CCID: Check if reader handles Abort correctly
by jolly 16 Jul '26

16 Jul '26

jolly has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42806?usp=email ) ( 8 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: CCID: Check if reader handles Abort correctly ...................................................................... CCID: Check if reader handles Abort correctly The tests aborts an ongoing case 2 APDU (according to ISO 7816). The SIM responds with a NULL procedure byte so that the reader does not time out. The abort messages are sent on both, the control pipe and the bulk pipe with the same sequence number. This test fails with osmo-ccid-firmware, because the abort message/handling is not yet implemented. Change-Id: Iebe97e73497b8468ebf08faf2c4db700fc76997f --- M ccid/CCID_Tests.ttcn 1 file changed, 72 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Hoernchen: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/ccid/CCID_Tests.ttcn b/ccid/CCID_Tests.ttcn index 643f78f..00387d4 100644 --- a/ccid/CCID_Tests.ttcn +++ b/ccid/CCID_Tests.ttcn @@ -803,6 +803,77 @@ f_start_and_wait(); } +/* The SIM transfer is aborted. */ +private function f_TC_abort() runs on CardemSlot_CT +{ + var octetstring req := c_SIM_READ_BINARY; + var CCID_PDU ccid_pdu; + var boolean v_slot_status_received := false; + + /* We need to emulate a SIM that does not respond, so we can be sure + * that the reader is still waiting while we abort. + */ + f_cardem_manager(); + + f_ccid_power_on(CCID_PWRSEL_3V0); + + /* Send a request towards reader. */ + CCID.send(ts_CCID_XfrBlock(g_slot_nr, req, 0)); + /* Receive the request by SIM. */ + f_cardem_receive(tr_SIMTRACE_CEMU_RX_DATA(?, req)); + /* Transmit NULL procedure byte by SIM. */ + f_cardem_transmit(ts_SIMTRACE_CEMU_TX_DATA(ts_CardEmu_DataFlags(pb_and_tx := true, final := true), + '60'O)); + /* Send abort toward reader. Note that CCID_Emulation.ttcn will detect + * the PC_to_RDR_Abort message type and sends another abort message to + * the control pipe in advance with the same sequence number. This is + * done there, because the sequence number is set at CCID_Emulation.ttcn + * upon transmission of the two messages. */ + CCID.send(ts_CCID_Abort(g_slot_nr, 0)); + /* Wait for slot status, but eat the possible 'DataBlock' that will be received after timeout. */ + timer T := 3.0; + T.start; + alt { + [] CCID.receive(tr_CCID_DataBlock(g_slot_nr, ?, ?, ?)) -> value ccid_pdu { + log("Eating 'DataBlock'."); + if (ccid_pdu.hdr_in.bStatus.bmCommandStatus != CCID_CMD_STATUS_FAILED) { + setverdict(fail, "Unexpected Datablock status after abort command."); + mtc.stop; + } + if (ccid_pdu.hdr_in.bError != CCID_ERR_CMD_ABORTED) { + setverdict(fail, "Unexpected Datablock error code after abort command."); + mtc.stop; + } + repeat; + } + [] CCID.receive(tr_CCID_SlotStatus(g_slot_nr, ?, ?, ?)) -> value ccid_pdu { + v_slot_status_received := true; + if (ccid_pdu.hdr_in.bStatus.bmCommandStatus != CCID_CMD_STATUS_OK) { + setverdict(fail, "Unexpected Response to abort command."); + mtc.stop; + } + } + [] T.timeout { } + } + + if (not v_slot_status_received) { + setverdict(fail, "No response to abort command."); + mtc.stop; + } + + /* Stop simtrace emulation, to prevent race condition. */ + vc_Cardem.stop; + vc_Cardem.done; +} +testcase TC_abort() runs on Test_CT +{ + f_init(); + + f_start_handler(refers(f_TC_abort), mp_simtrace_slot, true); + + f_start_and_wait(); +} + /* TODO */ @@ -1205,6 +1276,7 @@ execute( TC_256_bytes_response() ); execute( TC_null_procedure_byte() ); execute( TC_255_bytes_request() ); + execute( TC_abort() ); /* error handling */ execute( TC_inval_slot() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42806?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iebe97e73497b8468ebf08faf2c4db700fc76997f Gerrit-Change-Number: 42806 Gerrit-PatchSet: 10 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-ttcn3-hacks[master]: CCID: Check if reader times out while expecting procedure byte
by jolly 16 Jul '26

16 Jul '26

jolly has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42798?usp=email ) Change subject: CCID: Check if reader times out while expecting procedure byte ...................................................................... CCID: Check if reader times out while expecting procedure byte A case 2 APDU (according to ISO 7816) is sent toward the reader. The reader expects a procedure byte or a status word. If none of these are sent by the SIM the reader must timeout and send an error message back to the host. Change-Id: Iacd6aacaf8220e69b9b7038e354d54c788d1eb05 --- M ccid/CCID_Tests.ttcn 1 file changed, 49 insertions(+), 0 deletions(-) Approvals: jolly: Looks good to me, approved Jenkins Builder: Verified diff --git a/ccid/CCID_Tests.ttcn b/ccid/CCID_Tests.ttcn index 5d80c16..643f78f 100644 --- a/ccid/CCID_Tests.ttcn +++ b/ccid/CCID_Tests.ttcn @@ -1121,6 +1121,54 @@ f_start_and_wait(); } +/* The SIM does not send the expected procedure byte. */ +private function f_TC_procedure_byte_timeout() runs on CardemSlot_CT +{ + var octetstring req := c_SIM_READ_BINARY; + var CCID_PDU ccid_pdu; + + f_cardem_manager(); + + f_ccid_power_on(CCID_PWRSEL_3V0); + + /* Send a request towards reader. */ + CCID.send(ts_CCID_XfrBlock(g_slot_nr, req, 0)); + /* Receive the request by SIM. */ + f_cardem_receive(tr_SIMTRACE_CEMU_RX_DATA(?, req)); + /* Transmit procedure byte from SIM. */ + f_cardem_transmit(ts_SIMTRACE_CEMU_TX_DATA(ts_CardEmu_DataFlags(pb_and_tx := true, final := true), + '60'O)); + /* Eat the possible 'Time Extension status' */ + timer T := 0.2; + T.start; + alt { + [] CCID.receive(tr_CCID_DataBlock(g_slot_nr, ?, tr_CCID_HeaderIN(?, CCID_CMD_STATUS_TIME_EXT, ?), ?)) { + log("Eating 'Time Extension status'."); + repeat; + } + [] as_ccid_any(); + [] T.timeout { } + } + /* Receive the response from reader. */ + ccid_pdu := f_ccid_receive(tr_CCID_DataBlock(g_slot_nr, ?, ?, ?)); + if (ccid_pdu.hdr_in.bError != CCID_ERR_ICC_MUTE) { + setverdict(fail, "Unexpected Response or error code"); + mtc.stop; + } + + /* Stop simtrace emulation, to prevent race condition. */ + vc_Cardem.stop; + vc_Cardem.done; +} +testcase TC_procedure_byte_timeout() runs on Test_CT +{ + f_init(); + + f_start_handler(refers(f_TC_procedure_byte_timeout), mp_simtrace_slot, true); + + f_start_and_wait(); +} + /* TODO */ /* IccPowerOn with wrong voltage (> 0x04) */ @@ -1171,6 +1219,7 @@ execute( TC_status_word_timeout() ); execute( TC_status_word_incomplete() ); execute( TC_wrong_procedure_byte() ); + execute( TC_procedure_byte_timeout() ); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iacd6aacaf8220e69b9b7038e354d54c788d1eb05 Gerrit-Change-Number: 42798 Gerrit-PatchSet: 10 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-ttcn3-hacks[master]: CCID: Check if reader times out while expecting procedure byte
by jolly 16 Jul '26

16 Jul '26

Attention is currently required from: Hoernchen, laforge. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42798?usp=email ) Change subject: CCID: Check if reader times out while expecting procedure byte ...................................................................... Patch Set 9: Code-Review+2 (1 comment) Patchset: PS9: No code change, just moved during rebase. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iacd6aacaf8220e69b9b7038e354d54c788d1eb05 Gerrit-Change-Number: 42798 Gerrit-PatchSet: 9 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 16 Jul 2026 14:01:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: saip.PES.rebuild_mandatory_services(): set 5G get-identity, profile-a...
by lynxis lazus 16 Jul '26

16 Jul '26

Attention is currently required from: dexter, neels. lynxis lazus has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/42829?usp=email ) Change subject: saip.PES.rebuild_mandatory_services(): set 5G get-identity, profile-a-x25519, profile-b-p256 ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/42829/comment/47bad40d_f0c0c76a?usp=em… : PS5, Line 1739: # - Iff the SUCI-CalcInfo for USIM (DF.SAIP) contains a key of profile-A ("identifier": 1), typo in Iff -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42829?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibc29c6437c5c92e2b14938b733156536863465c1 Gerrit-Change-Number: 42829 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Jul 2026 13:47:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: saip.PES.rebuild_mandatory_services(): set 5G get-identity, profile-a...
by laforge 16 Jul '26

16 Jul '26

Attention is currently required from: dexter, lynxis lazus, neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/42829?usp=email ) Change subject: saip.PES.rebuild_mandatory_services(): set 5G get-identity, profile-a-x25519, profile-b-p256 ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42829?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibc29c6437c5c92e2b14938b733156536863465c1 Gerrit-Change-Number: 42829 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Jul 2026 13:34:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in simtrace2[master]: firmware: Implement debug command via USB control vendor class
by Jenkins Builder 16 Jul '26

16 Jul '26

Attention is currently required from: laforge. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43005?usp=email ) Change subject: firmware: Implement debug command via USB control vendor class ...................................................................... Patch Set 8: (1 comment) File firmware/apps/cardem/main.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/simtrace2/+/43005/comment/4d2ada6b_6d17e888?us… : PS8, Line 44: void (*ctrl_vendor_req) (const USBGenericRequest *request); Unnecessary space before function pointer arguments -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43005?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I1f4d29335eb0d2feef376b8ecdfe57a0162914d6 Gerrit-Change-Number: 43005 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 16 Jul 2026 13:29:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in simtrace2[master]: firmware: Implement debug command via USB control vendor class
by lynxis lazus 16 Jul '26

16 Jul '26

Attention is currently required from: laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43005?usp=email ) Change subject: firmware: Implement debug command via USB control vendor class ...................................................................... Patch Set 7: (1 comment) File firmware/libcommon/source/mode_cardemu.c: https://gerrit.osmocom.org/c/simtrace2/+/43005/comment/7f9c61b7_eb90fc77?us… : PS6, Line 714: struct cardem_inst *ci = &cardem_inst[i]; > I would simply definde a struct with named members at the simtrace protocol level, and then use that […] Done -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43005?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I1f4d29335eb0d2feef376b8ecdfe57a0162914d6 Gerrit-Change-Number: 43005 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 16 Jul 2026 13:29:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log July 2026