lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

June 2026

  • 1 participants
  • 870 discussions
[M] Change in osmo-trx[master]: Transceiver52M: fix viterbi-eq soft bits on platforms where char is u...
by manawyrm 09 Jun '26

09 Jun '26
Attention is currently required from: Hoernchen, fixeria, laforge, pespin. manawyrm has posted comments on this change by manawyrm. ( https://gerrit.osmocom.org/c/osmo-trx/+/42822?usp=email ) Change subject: Transceiver52M: fix viterbi-eq soft bits on platforms where char is unsigned ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Agree with fixeria. Fixed, now using sbit_t. Please re-review 😊 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1cda66228f3d48e1b941b25614d599c16ad79aa0 Gerrit-Change-Number: 42822 Gerrit-PatchSet: 2 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 09 Jun 2026 16:20:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[M] Change in osmo-trx[master]: Transceiver52M: fix viterbi-eq soft bits on platforms where char is u...
by manawyrm 09 Jun '26

09 Jun '26
Attention is currently required from: Hoernchen, fixeria, laforge, manawyrm. Hello Hoernchen, Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/42822?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: Transceiver52M: fix viterbi-eq soft bits on platforms where char is unsigned ...................................................................... Transceiver52M: fix viterbi-eq soft bits on platforms where char is unsigned The viterbi-eq demodulator stores soft bits into chars. "char" is signed on x86/amd64 but unsigned on arm64. On arm64 the stored byte 0x81 (== -127) is read back as +129, so after the sign flip and vectorSlicer() clamp every soft bit collapses to 0.0. The same issue also appears to be present in the MS code path, so it was (blindly) fixed there as well. The MS fixes are untested! Change-Id: I1cda66228f3d48e1b941b25614d599c16ad79aa0 --- M Transceiver52M/Transceiver.cpp M Transceiver52M/grgsm_vitac/grgsm_vitac.cpp M Transceiver52M/grgsm_vitac/grgsm_vitac.h M Transceiver52M/ms/ms.h M Transceiver52M/ms/ms_rx_lower.cpp M Transceiver52M/ms/ms_upper.h M utils/va-test/burst-gen.cpp 7 files changed, 36 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/22/42822/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1cda66228f3d48e1b941b25614d599c16ad79aa0 Gerrit-Change-Number: 42822 Gerrit-PatchSet: 2 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: stp: tcap-loadshare: add TC_tcap_loadshare_m3ua_to_ipa_udts
by lynxis lazus 09 Jun '26

09 Jun '26
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42824?usp=email ) Change subject: stp: tcap-loadshare: add TC_tcap_loadshare_m3ua_to_ipa_udts ...................................................................... stp: tcap-loadshare: add TC_tcap_loadshare_m3ua_to_ipa_udts If a TCAP message arrives which is: * not a TCAP Begin or Abort (e.g. a TCAP Continue) * not in the TCAP session cache/tracking * not have a dTID for a registered TCAP Add Range The tcap load-share will reject this message with a UDTS Related: SYS#8061 Change-Id: I181b25aedfd70d156c08197d361560b6d055e65a --- M stp/STP_Tests_TCAP.ttcn 1 file changed, 43 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/24/42824/1 diff --git a/stp/STP_Tests_TCAP.ttcn b/stp/STP_Tests_TCAP.ttcn index d7c45dc..0528d42 100644 --- a/stp/STP_Tests_TCAP.ttcn +++ b/stp/STP_Tests_TCAP.ttcn @@ -841,6 +841,48 @@ setverdict(pass); } +testcase TC_tcap_loadshare_m3ua_to_ipa_udts() runs on TCAP_CT { + var template (value) IPA_EXT_TCAP_ROUTING_Message tcap_rt_msg; + var template (value) TCMessage tcap_msg; + var Misc_Helpers.ro_charstring tcap_asps := { "asp-m3ua-loadshare-0-0", + "asp-m3ua-loadshare-0-1", + "asp-ipa-loadshare-0-0", + "asp-ipa-loadshare-0-1" }; + var TCAP_CT_Configurations tcap_configs := tcap_build_configs(tcap_asps); + + f_init_tcap(tcap_configs); + f_tcap_loadshare_register(2, 0, 99, 3, 100, 199); + + /* Transmit a TCAP Continue outside of the range which should rejected with a UDTS */ + tcap_msg := ts_TCAP_Continue(int2oct(198, 4), int2oct(202, 4)); + f_asp_tx_tcap(tcap_msg, 0); + + /* expect a UDTS */ + var template (present) TCAP_N_NOTICE_ind exp_sccp_utds := + tr_TCAP_N_NOTICE_ind(g_tcap[0].sccp_addr_own, + g_tcap[0].sccp_addr_peer, + 3, /* Subsystem failure */ + tcap_msg); + timer T := 5.0; + T.start; + alt { + [] SCCP_TCAP[0].receive(exp_sccp_utds) { + log("Received UTDS via TCAP[0] ASP"); + } + [] SCCP_TCAP[1].receive(exp_sccp_utds) { + log("Received UTDS via TCAP[1] ASP"); + } + [] T.timeout { + setverdict(fail, __SCOPE__, "(): Timeout waiting for SCCP UTDS / TCAP message"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + } + } + + setverdict(pass); +} + + + /* TODO: test TCAP Abort message is used. * TODO: test TCAP Begin+End message is used. * TODO: test TCAP GlobalTitles ISD @@ -863,6 +905,7 @@ execute( TC_tcap_loadshare_ipa_tcap_range_success_pc_ssn2() ); execute( TC_tcap_loadshare_ipa_tcap_range_fail_pc_ssn_overlap() ); execute( TC_tcap_loadshare_ipa_tcap_norange() ); + execute( TC_tcap_loadshare_m3ua_to_ipa_udts() ); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42824?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I181b25aedfd70d156c08197d361560b6d055e65a Gerrit-Change-Number: 42824 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: stp: for TCAP loadshare: use NI == national
by lynxis lazus 09 Jun '26

09 Jun '26
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42825?usp=email ) Change subject: stp: for TCAP loadshare: use NI == national ...................................................................... stp: for TCAP loadshare: use NI == national Use a non-zero NI. The TCAP tests don't check it on the receive path, but the osmo-stp is checking it if it matches the configuration. Related: SYS#8061 Change-Id: I51ef302ad72ff3c434fddb39006ce50106a5918f --- M stp/STP_Tests_TCAP.cfg M stp/osmo-stp-tcap.confmerge 2 files changed, 13 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/25/42825/1 diff --git a/stp/STP_Tests_TCAP.cfg b/stp/STP_Tests_TCAP.cfg index a096d26..1bba06f 100644 --- a/stp/STP_Tests_TCAP.cfg +++ b/stp/STP_Tests_TCAP.cfg @@ -28,7 +28,7 @@ own_ssn := 8, /* MSC (MAP) */ peer_pc := 5, peer_ssn := 6, /* HLR (MAP) */ - sio := '03'O, # NI=International, SI=SCCP + sio := '83'O, # NI=National, SI=SCCP rctx := 1000 } }, @@ -47,7 +47,7 @@ own_ssn := 8, /* MSC (MAP) */ peer_pc := 5, peer_ssn := 6, /* HLR (MAP) */ - sio := '03'O, # NI=International, SI=SCCP + sio := '83'O, # NI=National, SI=SCCP rctx := 1000 } }, @@ -67,7 +67,7 @@ own_ssn := 8, /* MSC (MAP) */ peer_pc := 25, peer_ssn := 6, /* HLR (MAP) */ - sio := '03'O, # NI=International, SI=SCCP + sio := '83'O, # NI=National, SI=SCCP rctx := 1001 } }, @@ -86,7 +86,7 @@ own_ssn := 8, /* MSC (MAP) */ peer_pc := 25, peer_ssn := 6, /* HLR (MAP) */ - sio := '03'O, # NI=International, SI=SCCP + sio := '83'O, # NI=National, SI=SCCP rctx := 1001 } }, @@ -106,7 +106,7 @@ own_ssn := 8, /* MSC (MAP) */ peer_pc := 24, peer_ssn := 6, /* HLR (MAP) */ - sio := '03'O, # NI=International, SI=SCCP + sio := '83'O, # NI=National, SI=SCCP rctx := 1002 } }, @@ -125,7 +125,7 @@ own_ssn := 8, /* MSC (MAP) */ peer_pc := 24, peer_ssn := 6, /* HLR (MAP) */ - sio := '03'O, # NI=International, SI=SCCP + sio := '83'O, # NI=National, SI=SCCP rctx := 1002 } }, @@ -147,7 +147,7 @@ own_ssn := 6, /* HLR (MAP) */ peer_pc := 23, peer_ssn := 8, /* MSC (MAP) */ - sio := '03'O, # NI=International, SI=SCCP + sio := '83'O, # NI=National, SI=SCCP rctx := 0 } }, @@ -168,7 +168,7 @@ own_ssn := 6, /* HLR (MAP) */ peer_pc := 23, peer_ssn := 8, /* MSC (MAP) */ - sio := '03'O, # NI=International, SI=SCCP + sio := '83'O, # NI=National, SI=SCCP rctx := 0 } }, @@ -190,7 +190,7 @@ own_ssn := 6, /* HLR (MAP) */ peer_pc := 7, peer_ssn := 8, /* MSC (MAP) */ - sio := '03'O, # NI=International, SI=SCCP + sio := '83'O, # NI=National, SI=SCCP rctx := 0 } }, @@ -211,7 +211,7 @@ own_ssn := 6, /* HLR (MAP) */ peer_pc := 7, peer_ssn := 8, /* MSC (MAP) */ - sio := '03'O, # NI=International, SI=SCCP + sio := '83'O, # NI=National, SI=SCCP rctx := 0 } }, @@ -233,7 +233,7 @@ own_ssn := 8, /* MSC (MAP) */ peer_pc := 6, peer_ssn := 6, /* HLR (MAP) */ - sio := '03'O, # NI=International, SI=SCCP + sio := '83'O, # NI=National, SI=SCCP rctx := 0 } }, @@ -254,7 +254,7 @@ own_ssn := 8, /* MSC (MAP) */ peer_pc := 6, peer_ssn := 6, /* HLR (MAP) */ - sio := '03'O, # NI=International, SI=SCCP + sio := '83'O, # NI=National, SI=SCCP rctx := 0 } } diff --git a/stp/osmo-stp-tcap.confmerge b/stp/osmo-stp-tcap.confmerge index 4090099..da607a5 100644 --- a/stp/osmo-stp-tcap.confmerge +++ b/stp/osmo-stp-tcap.confmerge @@ -2,6 +2,7 @@ ! !M3UA AS/ASP as(p)-m3ua-loadshare-0: ! + network-indicator national asp asp-m3ua-loadshare-0-0 9900 2905 m3ua local-ip 127.0.0.1 local-ip ::1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42825?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I51ef302ad72ff3c434fddb39006ce50106a5918f Gerrit-Change-Number: 42825 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
1 0
0 0
[XS] Change in osmo-ci[master]: coverity/jenkins: check if upload was successful
by daniel 09 Jun '26

09 Jun '26
Attention is currently required from: fixeria, lynxis lazus, osmith. daniel has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42820?usp=email ) Change subject: coverity/jenkins: check if upload was successful ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42820?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie63a33dfa7648b38f1f01cb8c87db76949f69e10 Gerrit-Change-Number: 42820 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 09 Jun 2026 15:46:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in libosmo-sigtran[master]: m3ua: fix missing decoding of message priority & network indicator flag
by daniel 09 Jun '26

09 Jun '26
Attention is currently required from: laforge, lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42823?usp=email ) Change subject: m3ua: fix missing decoding of message priority & network indicator flag ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I7a07363646f66c5c672a2c0d261ca33356b43031 Gerrit-Change-Number: 42823 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 09 Jun 2026 15:42:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in libosmo-sigtran[master]: m3ua: fix missing decoding of message priority & network indicator flag
by pespin 09 Jun '26

09 Jun '26
Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42823?usp=email ) Change subject: m3ua: fix missing decoding of message priority & network indicator flag ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I7a07363646f66c5c672a2c0d261ca33356b43031 Gerrit-Change-Number: 42823 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 09 Jun 2026 15:41:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in libosmo-sigtran[master]: m3ua: fix missing decoding of message priority & network indicator flag
by lynxis lazus 09 Jun '26

09 Jun '26
Attention is currently required from: daniel, lynxis lazus. Hello Jenkins Builder, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42823?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by daniel Change subject: m3ua: fix missing decoding of message priority & network indicator flag ...................................................................... m3ua: fix missing decoding of message priority & network indicator flag The missing parenthesis always or'ed with a 0x0 into the sio field because of operator precendence. Left shift is stronger than a binary and. Related: SYS#8061 Change-Id: I7a07363646f66c5c672a2c0d261ca33356b43031 --- M src/m3ua.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/23/42823/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I7a07363646f66c5c672a2c0d261ca33356b43031 Gerrit-Change-Number: 42823 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
1 0
0 0
[XS] Change in libosmo-sigtran[master]: m3ua: fix missing decoding of message priority & network indicator flag
by daniel 09 Jun '26

09 Jun '26
Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42823?usp=email ) Change subject: m3ua: fix missing decoding of message priority & network indicator flag ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I7a07363646f66c5c672a2c0d261ca33356b43031 Gerrit-Change-Number: 42823 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 09 Jun 2026 15:38:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in libosmo-sigtran[master]: m3ua: fix missing decoding of message priority & network indicator flag
by lynxis lazus 09 Jun '26

09 Jun '26
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42823?usp=email ) Change subject: m3ua: fix missing decoding of message priority & network indicator flag ...................................................................... m3ua: fix missing decoding of message priority & network indicator flag The missing parenthesis always or'ed with a 0x0 into the sio field because of operator precendence. Left shift is stronger than a binary and. Change-Id: I7a07363646f66c5c672a2c0d261ca33356b43031 --- M src/m3ua.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/23/42823/1 diff --git a/src/m3ua.c b/src/m3ua.c index 243f5b9..583800b 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -324,8 +324,8 @@ param->sls = mdh->sls; /* re-construct SIO */ param->sio = (mdh->si & 0xF) | - (mdh->mp & 0x3 << 4) | - (mdh->ni & 0x3 << 6); + ((mdh->mp & 0x3) << 4) | + ((mdh->ni & 0x3) << 6); } struct msgb *m3ua_msgb_alloc(const char *name) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I7a07363646f66c5c672a2c0d261ca33356b43031 Gerrit-Change-Number: 42823 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 55
  • 56
  • 57
  • 58
  • 59
  • 60
  • 61
  • ...
  • 87
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.