June 2026 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-sigtran[master]: tcap loadshare: move last_asp_idx_sent from cfg to runtime struct
by lynxis lazus 02 Jun '26

02 Jun '26

Attention is currently required from: lynxis lazus, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42761?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Code-Review+2 by pespin, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: tcap loadshare: move last_asp_idx_sent from cfg to runtime struct ...................................................................... tcap loadshare: move last_asp_idx_sent from cfg to runtime struct The last_asp_idx_sent is a runtime information and not configurable. Move it to the other runtime state. Change-Id: Id52bb0f6c67949b5e03f7ad36996f37a0d25214a --- M src/ss7_as.h M src/tcap_as_loadshare.c 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/61/42761/8 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42761?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id52bb0f6c67949b5e03f7ad36996f37a0d25214a Gerrit-Change-Number: 42761 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in libosmo-sigtran[master]: vty-tests: remove help from expected output
by lynxis lazus 02 Jun '26

02 Jun '26

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42764?usp=email ) Change subject: vty-tests: remove help from expected output ...................................................................... vty-tests: remove help from expected output Until the vty tests support regex, remove the help message as it depends on the compile option TCAP Routing and can't handle both compile options. It will be re-introduced later Change-Id: I0d8141c00525f49c0a9f9f63b73fee531f591e5c --- M tests/vty/osmo_stp_test.vty 1 file changed, 0 insertions(+), 14 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty index 3c6e466..c180dd7 100644 --- a/tests/vty/osmo_stp_test.vty +++ b/tests/vty/osmo_stp_test.vty @@ -406,20 +406,6 @@ no point-code override (opc|dpc) point-code override patch-sccp (disabled|both) -OsmoSTP(config-cs7-as)# ? -... - description Save human-readable description of the object - asp Specify that a given ASP is part of this AS - no Negate a command or set its defaults - traffic-mode Specifies traffic mode of operation of the ASP within the AS - sls-shift Shift SLS bits used during routing decision -... - binding-table AS Loadshare binding table operations - recovery-timeout Specifies RFC4666 recovery timer T(r) timeout - qos-class Specity QoS Class of AS - routing-key Define a routing key - point-code Point Code Specific Features - OsmoSTP(config-cs7-as)# no ? asp Specify ASP to be removed from this AS traffic-mode Remove explicit traffic mode of operation of this AS -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42764?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0d8141c00525f49c0a9f9f63b73fee531f591e5c Gerrit-Change-Number: 42764 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: tcap loadshare: Add session miss counter
by lynxis lazus 02 Jun '26

02 Jun '26

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42758?usp=email ) Change subject: tcap loadshare: Add session miss counter ...................................................................... tcap loadshare: Add session miss counter When a non-starting TCAP message (Continue, End, Abort) is received and no session can be associated with it, count these as session miss. Those should not appear under normal operation, except after a restart of osmo-stp. Related: SYS#5432 Change-Id: I23319294e899e6acb6421d89675ce456048f7475 --- M src/ss7_as.c M src/ss7_as.h M src/tcap_as_loadshare.c 3 files changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/src/ss7_as.c b/src/ss7_as.c index c73ca35..8cddae9 100644 --- a/src/ss7_as.c +++ b/src/ss7_as.c @@ -137,6 +137,7 @@ [SS7_AS_CTR_TCAP_ASP_SELECTED] = { "tcap:asp:selected", "ASP selection successful for a TCAP-message (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_ASP_FALLBACK] = { "tcap:asp:fallback", "Fallback ASP selected for a TCAP-message (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_ASP_FAILED] = { "tcap:asp:failed", "ASP selection failed for a TCAP-message (loadshare-tcap)" }, + [SS7_AS_CTR_TCAP_ASP_MISS] = { "tcap:session:miss", "A non-starting TCAP message (Continue, End, Abort) was missing a session entry, but routed successful. (loadshare-tcap)" }, #endif /* WITH_TCAP_LOADSHARING */ }; diff --git a/src/ss7_as.h b/src/ss7_as.h index 793cb26..e67ca1b 100644 --- a/src/ss7_as.h +++ b/src/ss7_as.h @@ -71,6 +71,7 @@ SS7_AS_CTR_TCAP_ASP_SELECTED, SS7_AS_CTR_TCAP_ASP_FALLBACK, SS7_AS_CTR_TCAP_ASP_FAILED, + SS7_AS_CTR_TCAP_ASP_MISS, #endif /* WITH_TCAP_LOADSHARING */ }; diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 1a5d0ff..a6b71d2 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -544,6 +544,7 @@ asp = tcap_trans_track_continue(as, &called_addr, &parsed.dtid, &calling_addr, &parsed.otid); if (!asp) { LOGPAS(as, DLTCAP, LOGL_INFO, "Couldn't find cached ASP for TCAP Continue, dtid %u/otid %u, using tcap route", parsed.dtid, parsed.otid); + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_MISS); asp = tcap_as_asp_find_by_tcap_id(as, &calling_addr, &called_addr, parsed.dtid); if (asp) tcap_trans_track_entry_create(as, asp, &called_addr, &parsed.dtid, &calling_addr, &parsed.otid); @@ -561,7 +562,9 @@ asp = tcap_trans_track_end(as, &called_addr, &parsed.dtid, &calling_addr, NULL); if (!asp) { LOGPAS(as, DLTCAP, LOGL_INFO, "Couldn't find cached ASP for TCAP End, dtid %u, using tcap route", parsed.dtid); + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_MISS); asp = tcap_as_asp_find_by_tcap_id(as, &calling_addr, &called_addr, parsed.dtid); + /* Don't create an entry for an End */ } rc = asp ? 0 : -ENOKEY; break; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42758?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I23319294e899e6acb6421d89675ce456048f7475 Gerrit-Change-Number: 42758 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: tcap loadshare: count all ENOKEY as a FAILED
by lynxis lazus 02 Jun '26

02 Jun '26

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42756?usp=email ) Change subject: tcap loadshare: count all ENOKEY as a FAILED ...................................................................... tcap loadshare: count all ENOKEY as a FAILED The ASP should count all message which couldn't routed as failed. Related: SYS#5432 Change-Id: I8bee6db5c75195855a3d378579e30886cd4d6fa8 --- M src/tcap_as_loadshare.c 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: daniel: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 5cc7d44..1a5d0ff 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -528,7 +528,6 @@ } else { /* Couldn't find a suitable canditate */ LOGPAS(as, DLTCAP, LOGL_DEBUG, "Couldn't find a suitable canditate for TCAP Begin otid %u\n", parsed.otid); - rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FAILED); rc = -ENOKEY; goto out_free_sua; } @@ -574,6 +573,9 @@ break; } out_free_sua: + if (rc == -ENOKEY) + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FAILED); + /* RFC3868 4.7.3: "If an ASP is not available, the SG may generate (X)UDTS "routing failure", * if the return option is used." * See also ITU Q.714 4.2 */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42756?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8bee6db5c75195855a3d378579e30886cd4d6fa8 Gerrit-Change-Number: 42756 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: tcap loadshare: Rework initial selection of a node
by lynxis lazus 02 Jun '26

02 Jun '26

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42755?usp=email ) Change subject: tcap loadshare: Rework initial selection of a node ...................................................................... tcap loadshare: Rework initial selection of a node The original TCAP loadshare plan was to used the OTID of a TCAP Begin to select the node. However this should not be used anymore. Instead the correct one would be to do a load-sharing across all available ASP and keep this relation ("sticky" sessions). The counter SS7_AS_CTR_TCAP_ASP_FALLBACK will be re-used by a later patch. Related: SYS#5432 Change-Id: I151e6acb59e1f3c481487e76d2b01236fcee755f --- M src/tcap_as_loadshare.c 1 file changed, 6 insertions(+), 14 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, approved diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 1dc4f71..5cc7d44 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -522,23 +522,15 @@ goto out_free_sua; } - /* lookup a new ASP */ - asp = tcap_as_asp_find_by_tcap_id(as, &calling_addr, &called_addr, parsed.otid); - + asp = select_asp_tcap_enabled_rr(as); if (asp) { rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_SELECTED); } else { - /* if no ASP found for this TCAP, try to find a non-tcap-range ASP as fallback*/ - asp = select_asp_tcap_enabled_rr(as); - if (asp) - rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FALLBACK); - else { - /* couldn't find a suitable canditate for OTID */ - rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FAILED); - LOGPAS(as, DLTCAP, LOGL_DEBUG, "Couldn't find a suitable canditate for TCAP Begin otid %u\n", parsed.otid); - rc = -ENOKEY; - goto out_free_sua; - } + /* Couldn't find a suitable canditate */ + LOGPAS(as, DLTCAP, LOGL_DEBUG, "Couldn't find a suitable canditate for TCAP Begin otid %u\n", parsed.otid); + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FAILED); + rc = -ENOKEY; + goto out_free_sua; } tcap_trans_track_begin(as, asp, &called_addr, NULL, &calling_addr, &parsed.otid); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42755?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I151e6acb59e1f3c481487e76d2b01236fcee755f Gerrit-Change-Number: 42755 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: ss7_as: fix indention
by lynxis lazus 02 Jun '26

02 Jun '26

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42757?usp=email ) Change subject: ss7_as: fix indention ...................................................................... ss7_as: fix indention Related: SYS#5432 Change-Id: Id006f4fcbf9ae6b5b50be3d41fb216c7f9bb2dfb --- M src/ss7_as.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/ss7_as.c b/src/ss7_as.c index a25e068..c73ca35 100644 --- a/src/ss7_as.c +++ b/src/ss7_as.c @@ -132,8 +132,8 @@ [SS7_AS_CTR_TX_MSU_SLS_14] = { "tx:msu:sls:14", SS7_AS_CTR_TX_MSU_SLS_STR "14" }, [SS7_AS_CTR_TX_MSU_SLS_15] = { "tx:msu:sls:15", SS7_AS_CTR_TX_MSU_SLS_STR "15" }, #ifdef WITH_TCAP_LOADSHARING - [SS7_AS_CTR_RX_TCAP_DECODED] = { "tcap:decoded", "Number of TCAP-messages decoded successfully (loadshare-tcap)" }, - [SS7_AS_CTR_RX_TCAP_FAILED] = { "tcap:failed", "Number of TCAP-messages that failed decoding (loadshare-tcap)" }, + [SS7_AS_CTR_RX_TCAP_DECODED] = { "tcap:decoded", "Number of TCAP-messages decoded successfully (loadshare-tcap)" }, + [SS7_AS_CTR_RX_TCAP_FAILED] = { "tcap:failed", "Number of TCAP-messages that failed decoding (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_ASP_SELECTED] = { "tcap:asp:selected", "ASP selection successful for a TCAP-message (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_ASP_FALLBACK] = { "tcap:asp:fallback", "Fallback ASP selected for a TCAP-message (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_ASP_FAILED] = { "tcap:asp:failed", "ASP selection failed for a TCAP-message (loadshare-tcap)" }, -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42757?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id006f4fcbf9ae6b5b50be3d41fb216c7f9bb2dfb Gerrit-Change-Number: 42757 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: tcap loadshare: Rework initial selection of a node
by lynxis lazus 02 Jun '26

02 Jun '26

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42755?usp=email ) Change subject: tcap loadshare: Rework initial selection of a node ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: 1+1 = 2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42755?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I151e6acb59e1f3c481487e76d2b01236fcee755f Gerrit-Change-Number: 42755 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 02 Jun 2026 09:51:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: trx-usrp1: make single daughterboard VTY configurable
by fixeria 02 Jun '26

02 Jun '26

Attention is currently required from: tempest. fixeria has posted comments on this change by tempest. ( https://gerrit.osmocom.org/c/osmo-trx/+/42811?usp=email ) Change subject: trx-usrp1: make single daughterboard VTY configurable ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File CommonLibs/trx_vty.c: https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/cd9acfc6_e7569618?usp… : PS2, Line 643: if (strcmp("disable", argv[0]) == 0) : trx->cfg.usrp1_singledb = false; : : if (strcmp("enable", argv[0]) == 0) : ```suggestion trx->cfg.usrp1_singledb = (strcmp(argv[0], "enable") == 0); ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42811?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I618fdcc7fec1ca1e87249992798c265430c177a0 Gerrit-Change-Number: 42811 Gerrit-PatchSet: 2 Gerrit-Owner: tempest <jackleea1b(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: tempest <jackleea1b(a)gmail.com> Gerrit-Comment-Date: Tue, 02 Jun 2026 09:44:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: trx-usrp1: make single daughterboard VTY configurable
by tempest 02 Jun '26

02 Jun '26

tempest has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-trx/+/42811?usp=email ) Change subject: trx-usrp1: make single daughterboard VTY configurable ...................................................................... trx-usrp1: make single daughterboard VTY configurable Adds the usrp1-singledb enable/disable option to specify the daughterboard configuration on USRP1 devices. This will allow users to use single-daughterboard devices without compliling from source to use the --with-singledb configure option. Also removed some daughterboard configuration related code that wasn't being used. More info in the modified trx-backends.adoc Change-Id: I618fdcc7fec1ca1e87249992798c265430c177a0 --- M CommonLibs/config_defs.h M CommonLibs/trx_vty.c M Transceiver52M/device/usrp1/USRPDevice.cpp M configure.ac M doc/manuals/chapters/trx-backends.adoc 5 files changed, 31 insertions(+), 39 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/11/42811/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42811?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I618fdcc7fec1ca1e87249992798c265430c177a0 Gerrit-Change-Number: 42811 Gerrit-PatchSet: 2 Gerrit-Owner: tempest <jackleea1b(a)gmail.com> Gerrit-CC: Jenkins Builder

1 0

[M] Change in osmo-trx[master]: trx-usrp1: make single daughterboard VTY configurable
by Jenkins Builder 02 Jun '26

02 Jun '26

Jenkins Builder has posted comments on this change by tempest. ( https://gerrit.osmocom.org/c/osmo-trx/+/42811?usp=email ) Change subject: trx-usrp1: make single daughterboard VTY configurable ...................................................................... Patch Set 1: (22 comments) File CommonLibs/trx_vty.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/b475e6dc_713c360c?usp… : PS1, Line 636: "usrp1-singledb (disable|enable)", code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/d54974cc_8b1260b8?usp… : PS1, Line 636: "usrp1-singledb (disable|enable)", please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/1a320484_70bcb4d9?usp… : PS1, Line 637: "Use single daughterboard on USRP1 (default=disable)\n" code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/f3440ab8_43f561ef?usp… : PS1, Line 637: "Use single daughterboard on USRP1 (default=disable)\n" please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/ce3280c0_edcc37af?usp… : PS1, Line 638: "Use dual daughterboard configuration (TX on DB A, RX on DB B)\n" code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/cb43ed5b_fc9159d6?usp… : PS1, Line 638: "Use dual daughterboard configuration (TX on DB A, RX on DB B)\n" please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/559b528b_c37085cd?usp… : PS1, Line 639: "Use single daughterboard configuration (TX/RX on DB A)\n") code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/b5fb8fe6_20e3cf5a?usp… : PS1, Line 639: "Use single daughterboard configuration (TX/RX on DB A)\n") please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/79a3de56_e58266a7?usp… : PS1, Line 641: struct trx_ctx *trx = trx_from_vty(vty); code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/96f2cfed_a9e41985?usp… : PS1, Line 641: struct trx_ctx *trx = trx_from_vty(vty); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/bc2c505d_75d8c235?usp… : PS1, Line 643: if (strcmp("disable", argv[0]) == 0) code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/44edb7e7_aa75f4f3?usp… : PS1, Line 643: if (strcmp("disable", argv[0]) == 0) please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/d97ebfd4_6a589113?usp… : PS1, Line 644: trx->cfg.usrp1_singledb = false; code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/7eb34edf_6b0196f1?usp… : PS1, Line 644: trx->cfg.usrp1_singledb = false; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/6a12ae70_52d31e19?usp… : PS1, Line 646: if (strcmp("enable", argv[0]) == 0) code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/0aa7d2f2_b623a464?usp… : PS1, Line 646: if (strcmp("enable", argv[0]) == 0) please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/7b587387_7b0f93e8?usp… : PS1, Line 647: trx->cfg.usrp1_singledb = true; code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/3819a4f4_512e35e6?usp… : PS1, Line 647: trx->cfg.usrp1_singledb = true; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/9f6fc803_c8ef46b2?usp… : PS1, Line 649: return CMD_SUCCESS; code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/d74582c4_91c48baf?usp… : PS1, Line 649: return CMD_SUCCESS; please, no spaces at the start of a line File doc/manuals/chapters/trx-backends.adoc: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/f2f985c7_07bee358?usp… : PS1, Line 69: By default, osmo-trx-usrp1 will use daughterboard A for transmitting and trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/a6c9c4bf_68f83918?usp… : PS1, Line 70: daughterboard B for receiving. Some USRP1 configurations use only a single trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42811?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I618fdcc7fec1ca1e87249992798c265430c177a0 Gerrit-Change-Number: 42811 Gerrit-PatchSet: 1 Gerrit-Owner: tempest <jackleea1b(a)gmail.com> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 02 Jun 2026 07:33:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log June 2026