June 2026 - gerrit-log - lists.osmocom.org

[XS] Change in onomondo-ipa[master]: scard: add comment about memory-leak in libpcsclite
by jolly 24 Jun '26

24 Jun '26

Attention is currently required from: dexter. jolly has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/42873?usp=email ) Change subject: scard: add comment about memory-leak in libpcsclite ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42873?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I5224f3824ce2ad33e678cd859ad28c47788dbb24 Gerrit-Change-Number: 42873 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 24 Jun 2026 09:17:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in onomondo-ipa[master]: es10b_get_euicc_info: add explanatory comments regarding EUICCInfo2
by jolly 24 Jun '26

24 Jun '26

Attention is currently required from: dexter. jolly has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/42872?usp=email ) Change subject: es10b_get_euicc_info: add explanatory comments regarding EUICCInfo2 ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42872?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I282fa91a4099a771a353101b0ce17ae3daae9c42 Gerrit-Change-Number: 42872 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 24 Jun 2026 09:10:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in onomondo-ipa[master]: es10b_get_euicc_info: add explanatory comments regarding EUICCInfo2
by dexter 24 Jun '26

24 Jun '26

Attention is currently required from: dexter, jolly. Hello Jenkins Builder, jolly, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42872?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: es10b_get_euicc_info: add explanatory comments regarding EUICCInfo2 ...................................................................... es10b_get_euicc_info: add explanatory comments regarding EUICCInfo2 onomondo-ipa has a built-in IoT eUICC emulation. This means that we have to deal with two different EUICCInfo2 formats, which requires additional logic in ipa_es10b_get_euicc_info_free to free the allocated structs correctly. Since it is not immediately obvious how the logic works, let's add some explanary comments to make it obvious. Related: SYS#8101 Change-Id: I282fa91a4099a771a353101b0ce17ae3daae9c42 --- M src/ipa/libipa/es10b_get_euicc_info.c 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/72/42872/3 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42872?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I282fa91a4099a771a353101b0ce17ae3daae9c42 Gerrit-Change-Number: 42872 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in onomondo-ipa[master]: es10b_get_euicc_info: add explanatory comments regarding EUICCInfo2
by Jenkins Builder 24 Jun '26

24 Jun '26

Attention is currently required from: dexter, jolly. Jenkins Builder has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/42872?usp=email ) Change subject: es10b_get_euicc_info: add explanatory comments regarding EUICCInfo2 ...................................................................... Patch Set 2: (1 comment) File src/ipa/libipa/es10b_get_euicc_info.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-ipa/+/42872/comment/82a8867a_400da834… : PS2, Line 116: }q space required after that close brace '}' -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42872?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I282fa91a4099a771a353101b0ce17ae3daae9c42 Gerrit-Change-Number: 42872 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 24 Jun 2026 08:23:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in onomondo-ipa[master]: es10b_get_euicc_info: add explanatory comments regarding EUICCInfo2
by Jenkins Builder 24 Jun '26

24 Jun '26

Attention is currently required from: jolly. Jenkins Builder has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/42872?usp=email ) Change subject: es10b_get_euicc_info: add explanatory comments regarding EUICCInfo2 ...................................................................... Patch Set 1: (1 comment) File src/ipa/libipa/es10b_get_euicc_info.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-ipa/+/42872/comment/ed2c9f3f_11dd9666… : PS1, Line 116: }q space required after that close brace '}' -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42872?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I282fa91a4099a771a353101b0ce17ae3daae9c42 Gerrit-Change-Number: 42872 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-CC: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 24 Jun 2026 08:22:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in onomondo-ipa[master]: es10b_get_euicc_info: add explanatory comments regarding EUICCInfo2
by dexter 24 Jun '26

24 Jun '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/42872?usp=email ) Change subject: es10b_get_euicc_info: add explanatory comments regarding EUICCInfo2 ...................................................................... es10b_get_euicc_info: add explanatory comments regarding EUICCInfo2 onomondo-ipa has a built-in IoT eUICC emulation. This means that we have to deal with two different EUICCInfo2 formats, which requires additional logic in ipa_es10b_get_euicc_info_free to free the allocated structs correctly. Since it is not immediately obvious how the logic works, let's add some explanary comments to make it obvious. Related: SYS#8101 Change-Id: I282fa91a4099a771a353101b0ce17ae3daae9c42 --- M src/ipa/libipa/es10b_get_euicc_info.c 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/72/42872/1 diff --git a/src/ipa/libipa/es10b_get_euicc_info.c b/src/ipa/libipa/es10b_get_euicc_info.c index db9c541..a0aba7d 100644 --- a/src/ipa/libipa/es10b_get_euicc_info.c +++ b/src/ipa/libipa/es10b_get_euicc_info.c @@ -105,14 +105,15 @@ if (!asn) return -EINVAL; + /* Present EUICCInfo2 in SGP.32 format (see comment in header file) */ euicc_info->euicc_info_2 = asn; - /* Also offer EUICCInfo2 in SGP.32 format */ + /* Present derived EUICCInfo2 in SGP.32 format */ euicc_info->sgp32_euicc_info_2 = IPA_ALLOC(struct SGP32_EUICCInfo2); convert_euicc_info_2(euicc_info->sgp32_euicc_info_2, euicc_info->euicc_info_2); return 0; -} +}q static int dec_get_euicc_info2_sgp32(struct ipa_es10b_euicc_info *euicc_info, const struct ipa_buf *es10b_res) { @@ -122,6 +123,10 @@ if (!asn) return -EINVAL; + /* We do not present EUICCInfo2 in SGP.22 in this case (see comment in header file) */ + euicc_info->euicc_info_2 = NULL; + + /* Present derived EUICCInfo2 in SGP.32 format */ euicc_info->sgp32_euicc_info_2 = asn; return 0; @@ -190,9 +195,17 @@ ASN_STRUCT_FREE(asn_DEF_EUICCInfo1, res->euicc_info_1); if (res->euicc_info_2) { + /* res->sgp32_euicc_info_2 has been created from res->euicc_info_2 (see also dec_get_euicc_info2). This + * means that res->euicc_info_2 holds the original output of the ASN.1 decoder while + * res->sgp32_euicc_info_2 only holds pointers to res->euicc_info_2. This is the reason why we use + * ASN_STRUCT_FREE on res->euicc_info_2 and IPA_FREE on res->sgp32_euicc_info_2. + * (see also comment in header file) */ IPA_FREE(res->sgp32_euicc_info_2); ASN_STRUCT_FREE(asn_DEF_EUICCInfo2, res->euicc_info_2); } else { + /* res->sgp32_euicc_info_2 has been decoded by the ASN.1 decoder, so we have to use the ASN_STRUCT_FREE + * to free it. (res->euicc_info_2 NULL in this case and does not require freeing. + * (see also dec_get_euicc_info2_sgp32) */ ASN_STRUCT_FREE(asn_DEF_SGP32_EUICCInfo2, res->sgp32_euicc_info_2); } -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42872?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I282fa91a4099a771a353101b0ce17ae3daae9c42 Gerrit-Change-Number: 42872 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in onomondo-ipa[master]: scard: add comment about memory-leak in libpcsclite
by dexter 24 Jun '26

24 Jun '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/42873?usp=email ) Change subject: scard: add comment about memory-leak in libpcsclite ...................................................................... scard: add comment about memory-leak in libpcsclite As it seems, SCardReleaseContext does not free all of the memory allocated by SCardEstablishContext. The probem has no real-world impact, but still showas up in valgrind. Let's add a comment so that we do not forget what causes the leak. Related: SYS#8101 Change-Id: I5224f3824ce2ad33e678cd859ad28c47788dbb24 --- M src/ipa/scard.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/73/42873/1 diff --git a/src/ipa/scard.c b/src/ipa/scard.c index 806bb9d..b41ba24 100644 --- a/src/ipa/scard.c +++ b/src/ipa/scard.c @@ -182,6 +182,9 @@ rc = SCardDisconnect(ctx->hCard, SCARD_UNPOWER_CARD); PCSC_ERROR(ctx->reader_num, rc, "SCardDisconnect"); + /* As it seems the libpcsc-lite API calls SCardReleaseContext / SCardEstablishContext leak memoroy. There is + * always a remaining, still reachable amount of 1,614 bytes present when the program exits. Since we establish + * the hContext only once in this implementation this problem is no matter of concern. */ rc = SCardReleaseContext(ctx->hContext); PCSC_ERROR(ctx->reader_num, rc, "SCardReleaseContext"); -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42873?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I5224f3824ce2ad33e678cd859ad28c47788dbb24 Gerrit-Change-Number: 42873 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: tcap-loadshare: add TC_tcap_loadshare_m3ua_to_ipa_udts
by lynxis lazus 24 Jun '26

24 Jun '26

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42824?usp=email ) Change subject: stp: tcap-loadshare: add TC_tcap_loadshare_m3ua_to_ipa_udts ...................................................................... stp: tcap-loadshare: add TC_tcap_loadshare_m3ua_to_ipa_udts If a TCAP message arrives which is: * not a TCAP Begin or Abort (e.g. a TCAP Continue) * not in the TCAP session cache/tracking * not have a dTID for a registered TCAP Add Range The tcap load-share will reject this message with a UDTS Related: SYS#8061 Change-Id: I181b25aedfd70d156c08197d361560b6d055e65a --- M stp/STP_Tests_TCAP.ttcn 1 file changed, 50 insertions(+), 0 deletions(-) Approvals: daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/stp/STP_Tests_TCAP.ttcn b/stp/STP_Tests_TCAP.ttcn index d7c45dc..d443690 100644 --- a/stp/STP_Tests_TCAP.ttcn +++ b/stp/STP_Tests_TCAP.ttcn @@ -841,6 +841,55 @@ setverdict(pass); } +/* Test UDTS rejection with TCAP load-sharing + * If a TCAP message arrives which is: + * * not a TCAP Begin or Abort (e.g. a TCAP Continue) + * * not in the TCAP session cache/tracking + * * not have a dTID for a registered TCAP Add Range + * The tcap load-share will reject this message with a UDTS + */ +testcase TC_tcap_loadshare_m3ua_to_ipa_udts() runs on TCAP_CT { + var template (value) IPA_EXT_TCAP_ROUTING_Message tcap_rt_msg; + var template (value) TCMessage tcap_msg; + var Misc_Helpers.ro_charstring tcap_asps := { "asp-m3ua-loadshare-0-0", + "asp-m3ua-loadshare-0-1", + "asp-ipa-loadshare-0-0", + "asp-ipa-loadshare-0-1" }; + var TCAP_CT_Configurations tcap_configs := tcap_build_configs(tcap_asps); + + f_init_tcap(tcap_configs); + f_tcap_loadshare_register(2, 0, 99, 3, 100, 199); + + /* Transmit a TCAP Continue outside of the range which should rejected with a UDTS */ + tcap_msg := ts_TCAP_Continue(int2oct(198, 4), int2oct(202, 4)); + f_asp_tx_tcap(tcap_msg, 0); + + /* expect a UDTS */ + var template (present) TCAP_N_NOTICE_ind exp_sccp_utds := + tr_TCAP_N_NOTICE_ind(g_tcap[0].sccp_addr_own, + g_tcap[0].sccp_addr_peer, + 3, /* Subsystem failure */ + tcap_msg); + timer T := 5.0; + T.start; + alt { + [] SCCP_TCAP[0].receive(exp_sccp_utds) { + log("Received UTDS via TCAP[0] ASP"); + } + [] SCCP_TCAP[1].receive(exp_sccp_utds) { + log("Received UTDS via TCAP[1] ASP"); + } + [] T.timeout { + setverdict(fail, __SCOPE__, "(): Timeout waiting for SCCP UTDS / TCAP message"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + } + } + + setverdict(pass); +} + + + /* TODO: test TCAP Abort message is used. * TODO: test TCAP Begin+End message is used. * TODO: test TCAP GlobalTitles ISD @@ -863,6 +912,7 @@ execute( TC_tcap_loadshare_ipa_tcap_range_success_pc_ssn2() ); execute( TC_tcap_loadshare_ipa_tcap_range_fail_pc_ssn_overlap() ); execute( TC_tcap_loadshare_ipa_tcap_norange() ); + execute( TC_tcap_loadshare_m3ua_to_ipa_udts() ); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42824?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I181b25aedfd70d156c08197d361560b6d055e65a Gerrit-Change-Number: 42824 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: osmo-bts-trx: fix spurious shutdown on first CLCK.ind from osmo-trx
by pespin 23 Jun '26

23 Jun '26

Attention is currently required from: Hoernchen, fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42871?usp=email ) Change subject: osmo-bts-trx: fix spurious shutdown on first CLCK.ind from osmo-trx ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42871?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I25e76e02d29fd8f88130d15d0adfe8d90a017924 Gerrit-Change-Number: 42871 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Jun 2026 20:31:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: tcap-loadshare: add TC_tcap_loadshare_m3ua_to_ipa_udts
by pespin 23 Jun '26

23 Jun '26

Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42824?usp=email ) Change subject: stp: tcap-loadshare: add TC_tcap_loadshare_m3ua_to_ipa_udts ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42824?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I181b25aedfd70d156c08197d361560b6d055e65a Gerrit-Change-Number: 42824 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 23 Jun 2026 20:29:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log June 2026