April 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-bsc[master]: handover_fsm: fix send_handover_performed() using wrong lchan
by jolly 08 Apr '26

08 Apr '26

Attention is currently required from: fixeria. jolly has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42593?usp=email ) Change subject: handover_fsm: fix send_handover_performed() using wrong lchan ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/handover_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/42593/comment/5cbe41c8_ee4151cc?usp… : PS2, Line 901: struct gsm_lchan *lchan = ho->new_lchan; What if new_lchan is NULL? If I look at the caller of this function (handover_end()), I am not sure, if it is never NULL. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42593?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4111351dc38fc2dbe844c2bd07b3ecfaaadd864e Gerrit-Change-Number: 42593 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Apr 2026 10:33:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-bsc[master]: assignment_fsm: check ipaccess channel mode support
by laforge 08 Apr '26

08 Apr '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42590?usp=email ) Change subject: assignment_fsm: check ipaccess channel mode support ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42590?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I680ba7993786f5486d671f931e75df4543670a37 Gerrit-Change-Number: 42590 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Apr 2026 10:17:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bsc[master]: lchan_fsm: ignore late lchan_rtp_fsm events
by fixeria 08 Apr '26

08 Apr '26

Attention is currently required from: neels. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42591?usp=email ) Change subject: lchan_fsm: ignore late lchan_rtp_fsm events ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42591?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie6333bd941e4e5a6ddf0e3f113b8764e8bc2bbc0 Gerrit-Change-Number: 42591 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Apr 2026 09:45:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: assignment_fsm: pass lchan to lchan_type_compat_with_mode()
by fixeria 08 Apr '26

08 Apr '26

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42589?usp=email ) Change subject: assignment_fsm: pass lchan to lchan_type_compat_with_mode() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I51d5d1a1cf3c51f85f738196967d5c69870681bb Gerrit-Change-Number: 42589 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 08 Apr 2026 09:38:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bsc[master]: ipaccess: store Supported Features IE to the MO state
by fixeria 08 Apr '26

08 Apr '26

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42588?usp=email ) Change subject: ipaccess: store Supported Features IE to the MO state ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic89d42c478677ffda4d544f461e7850dd3157040 Gerrit-Change-Number: 42588 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 08 Apr 2026 09:38:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bsc[master]: assignment_fsm: check ipaccess channel mode support
by jolly 08 Apr '26

08 Apr '26

Attention is currently required from: fixeria. jolly has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42590?usp=email ) Change subject: assignment_fsm: check ipaccess channel mode support ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42590?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I680ba7993786f5486d671f931e75df4543670a37 Gerrit-Change-Number: 42590 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Apr 2026 09:38:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: assignment_fsm: pass lchan to lchan_type_compat_with_mode()
by jolly 08 Apr '26

08 Apr '26

Attention is currently required from: fixeria. jolly has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42589?usp=email ) Change subject: assignment_fsm: pass lchan to lchan_type_compat_with_mode() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I51d5d1a1cf3c51f85f738196967d5c69870681bb Gerrit-Change-Number: 42589 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Apr 2026 09:28:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bsc[master]: ipaccess: store Supported Features IE to the MO state
by jolly 08 Apr '26

08 Apr '26

Attention is currently required from: fixeria. jolly has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42588?usp=email ) Change subject: ipaccess: store Supported Features IE to the MO state ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic89d42c478677ffda4d544f461e7850dd3157040 Gerrit-Change-Number: 42588 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Apr 2026 09:26:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bsc[master]: ipaccess: fix buffer overread in ipacc_parse_supp_flags()
by fixeria 08 Apr '26

08 Apr '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42587?usp=email ) Change subject: ipaccess: fix buffer overread in ipacc_parse_supp_flags() ...................................................................... ipaccess: fix buffer overread in ipacc_parse_supp_flags() The loop used OSMO_MAX(e->len, 4), which iterates at least 4 times even when the IE is shorter than 4 bytes, causing a buffer overread. Replace with OSMO_MIN(e->len, sizeof(u32)) to cap the iteration both at the actual IE length and at the uint32_t accumulator size. Change-Id: I97c69a71eb650cbef1cc3652d0a2a966cfd6cf60 --- M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve jolly: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c index 23196fc..a197a79 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c @@ -47,7 +47,7 @@ { uint32_t u32 = 0; - for (unsigned int i = 0; i < OSMO_MAX(e->len, 4); i++) + for (unsigned int i = 0; i < OSMO_MIN(e->len, sizeof(u32)); i++) u32 |= e->val[i] << (i * 8); for (const struct value_string *vs = flags; vs->value && vs->str; vs++) { if (u32 & vs->value) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42587?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I97c69a71eb650cbef1cc3652d0a2a966cfd6cf60 Gerrit-Change-Number: 42587 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-bsc[master]: bssap: mark some pointers as const
by fixeria 08 Apr '26

08 Apr '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42584?usp=email ) Change subject: bssap: mark some pointers as const ...................................................................... bssap: mark some pointers as const Change-Id: Iebb28d6ae0b468545994669248a442dd17f36d4c --- M include/osmocom/bsc/vgcs_fsm.h M src/osmo-bsc/osmo_bsc_bssap.c 2 files changed, 33 insertions(+), 18 deletions(-) Approvals: jolly: Looks good to me, but someone else must approve fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/bsc/vgcs_fsm.h b/include/osmocom/bsc/vgcs_fsm.h index 80ea21f..57acae0 100644 --- a/include/osmocom/bsc/vgcs_fsm.h +++ b/include/osmocom/bsc/vgcs_fsm.h @@ -104,9 +104,12 @@ int vgcs_vbs_chan_start(struct gsm_subscriber_connection *conn, struct msgb *msg); int vgcs_vbs_call_start(struct gsm_subscriber_connection *conn, struct msgb *msg); -int bssmap_handle_ass_req_ct_speech(struct gsm_subscriber_connection *conn, struct gsm_bts *bts, - struct tlv_parsed *tp, struct gsm0808_channel_type *ct, - struct assignment_request *req, uint8_t *cause); +int bssmap_handle_ass_req_ct_speech(struct gsm_subscriber_connection *conn, + struct gsm_bts *bts, + const struct tlv_parsed *tp, + const struct gsm0808_channel_type *ct, + struct assignment_request *req, + uint8_t *cause); void bsc_tx_setup_ack(struct gsm_subscriber_connection *conn, struct gsm0808_vgcs_feature_flags *ff); void bsc_tx_setup_refuse(struct gsm_subscriber_connection *conn, uint8_t cause); void bsc_tx_vgcs_vbs_assignment_result(struct gsm_subscriber_connection *conn, struct gsm0808_channel_type *ct, diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c index 395fa49..7a9688d 100644 --- a/src/osmo-bsc/osmo_bsc_bssap.c +++ b/src/osmo-bsc/osmo_bsc_bssap.c @@ -684,7 +684,8 @@ * lchan is requested. The preferred lchan will be requested first. If we * find an alternate setting here, this one will be tried secondly if our * primary choice fails. */ -static int select_data_rates(struct assignment_request *req, struct gsm0808_channel_type *ct, +static int select_data_rates(struct assignment_request *req, + const struct gsm0808_channel_type *ct, struct gsm_subscriber_connection *conn) { int rc, i, nc = 0; @@ -815,7 +816,8 @@ return 0; } -static int select_sign_chan(struct assignment_request *req, struct gsm0808_channel_type *ct) +static int select_sign_chan(struct assignment_request *req, + const struct gsm0808_channel_type *ct) { int i, nc = 0; @@ -864,7 +866,8 @@ return nc > 0 ? 0 : -EINVAL; } -static int bssmap_handle_ass_req_tp_cic(struct tlv_parsed *tp, bool aoip, uint16_t *cic, uint8_t *cause) +static int bssmap_handle_ass_req_tp_cic(const struct tlv_parsed *tp, + bool aoip, uint16_t *cic, uint8_t *cause) { if (TLVP_PRESENT(tp, GSM0808_IE_CIRCUIT_IDENTITY_CODE)) { /* CIC is permitted in both AoIP and SCCPlite */ @@ -882,7 +885,7 @@ return 0; } -static int bssmap_handle_ass_req_tp_rtp_addr(struct tlv_parsed *tp, bool aoip, char *msc_rtp_addr, +static int bssmap_handle_ass_req_tp_rtp_addr(const struct tlv_parsed *tp, bool aoip, char *msc_rtp_addr, size_t msc_rtp_addr_len, uint16_t *msc_rtp_port, uint8_t *cause) { struct sockaddr_storage rtp_addr; @@ -927,7 +930,8 @@ return 0; } -static int bssmap_handle_ass_req_tp_osmux(struct gsm_subscriber_connection *conn, struct tlv_parsed *tp, +static int bssmap_handle_ass_req_tp_osmux(struct gsm_subscriber_connection *conn, + const struct tlv_parsed *tp, bool *use_osmux, uint8_t *osmux_cid, uint8_t *cause) { int rc; @@ -963,8 +967,9 @@ return 0; } -static int bssmap_handle_ass_req_tp_codec_list(struct gsm_subscriber_connection *conn, struct tlv_parsed *tp, bool aoip, - uint8_t *cause) +static int bssmap_handle_ass_req_tp_codec_list(struct gsm_subscriber_connection *conn, + const struct tlv_parsed *tp, + bool aoip, uint8_t *cause) { int rc; @@ -993,7 +998,7 @@ return 0; } -static int bssmap_handle_ass_req_tp_rtp_ext(struct tlv_parsed *tp, +static int bssmap_handle_ass_req_tp_rtp_ext(const struct tlv_parsed *tp, struct assignment_request *req, uint8_t *cause) { @@ -1013,8 +1018,10 @@ return 0; } -static int bssmap_handle_ass_req_ct_data(struct gsm_subscriber_connection *conn, struct tlv_parsed *tp, - struct gsm0808_channel_type *ct, struct assignment_request *req, +static int bssmap_handle_ass_req_ct_data(struct gsm_subscriber_connection *conn, + const struct tlv_parsed *tp, + const struct gsm0808_channel_type *ct, + struct assignment_request *req, uint8_t *cause) { bool aoip = gscon_is_aoip(conn); @@ -1045,9 +1052,12 @@ return 0; } -int bssmap_handle_ass_req_ct_speech(struct gsm_subscriber_connection *conn, struct gsm_bts *bts, - struct tlv_parsed *tp, struct gsm0808_channel_type *ct, - struct assignment_request *req, uint8_t *cause) +int bssmap_handle_ass_req_ct_speech(struct gsm_subscriber_connection *conn, + struct gsm_bts *bts, + const struct tlv_parsed *tp, + const struct gsm0808_channel_type *ct, + struct assignment_request *req, + uint8_t *cause) { bool aoip = gscon_is_aoip(conn); int rc; @@ -1084,8 +1094,10 @@ return 0; } -static int bssmap_handle_ass_req_ct_sign(struct gsm_subscriber_connection *conn, struct gsm0808_channel_type *ct, - struct assignment_request *req, uint8_t *cause) +static int bssmap_handle_ass_req_ct_sign(struct gsm_subscriber_connection *conn, + const struct gsm0808_channel_type *ct, + struct assignment_request *req, + uint8_t *cause) { int rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42584?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iebb28d6ae0b468545994669248a442dd17f36d4c Gerrit-Change-Number: 42584 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026