April 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: ansible: debian: remove logic for jessie
by osmith 17 Apr '26

17 Apr '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42629?usp=email ) Change subject: ansible: debian: remove logic for jessie ...................................................................... ansible: debian: remove logic for jessie This is a really old release we don't use anymore, so clean up related commands from the ansible tasks. Change-Id: Ifad5e9088e026a61b2e3463936c1ba602f4a99df --- M ansible/roles/osmocom-jenkins-slave/tasks/debian.yml 1 file changed, 0 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/29/42629/1 diff --git a/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml b/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml index f009283..f8009bb 100644 --- a/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml +++ b/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml @@ -17,19 +17,6 @@ install_recommends: no when: install_jenkins_utilities -- name: stop checking release validity for old stable - copy: - content: 'Acquire::Check-Valid-Until "false";' - dest: '/etc/apt/apt.conf.d/90-stop-check-release-validity' - when: ansible_distribution == 'Debian' and ansible_distribution_release == 'jessie' - -- name: enable backports for jessie - apt_repository: - repo: 'deb http://archive.debian.org/debian jessie-backports main' - filename: 'backports' - update_cache: yes - when: ansible_distribution == 'Debian' and ansible_distribution_release == 'jessie' - # Install a recent java directly from download.java.net. This method works for # all debian versions, even really old ones, but only for x86_64 and aarch64. # Get links for new releases here: https://jdk.java.net/26/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42629?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ifad5e9088e026a61b2e3463936c1ba602f4a99df Gerrit-Change-Number: 42629 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: ansible: lx2-raspbian{12 => 13}build-ansible
by osmith 17 Apr '26

17 Apr '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42630?usp=email ) Change subject: ansible: lx2-raspbian{12 => 13}build-ansible ...................................................................... ansible: lx2-raspbian{12 => 13}build-ansible Change-Id: I66afdc0ba86cfde6613226abba900c31e486f846 --- M ansible/hosts M ansible/util/known_hosts 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/30/42630/1 diff --git a/ansible/hosts b/ansible/hosts index f2390af..f1432bb 100644 --- a/ansible/hosts +++ b/ansible/hosts @@ -17,7 +17,7 @@ rpi4-raspbian12build-ansible-1 ansible_host=10.9.25.50 docker_max_image_space="20 GB" rpi4-raspbian12build-ansible-2 ansible_host=10.9.25.60 docker_max_image_space="20 GB" rpi4-raspbian12build-ansible-3 ansible_host=10.9.25.70 docker_max_image_space="20 GB" -lx2-raspbian12build-ansible ansible_host=10.9.25.28 docker_max_image_space="20 GB" jenkins_tmpfs=True +lx2-raspbian13build-ansible ansible_host=10.9.25.28 docker_max_image_space="20 GB" jenkins_tmpfs=True [simtester] simtest ansible_host=10.9.25.80 diff --git a/ansible/util/known_hosts b/ansible/util/known_hosts index b7236d0..0222bf7 100644 --- a/ansible/util/known_hosts +++ b/ansible/util/known_hosts @@ -7,9 +7,9 @@ 10.9.25.70 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIJ4KE0enH9e76eWTy8HLFO/2pzrZaP8G93mtWvfD8//W 2a01:4f8:121:200a::1:3 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIGafw2VdeZo4YNvbu8VEBjDrsCFL+ZSbHtvhspNIQ9PR 2a01:4f8:121:200a::1:2 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIFyp0daWkfsRHErCVCcP/FZmtiRvFNAsK2A5TlQ6Ja+P -10.9.25.28 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIG0rQGxSxWJHwNNT5XdeuMPSYCAXpcDnFDzvyw5+sH3l 2a01:4f8:140:926a::1:3 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIFU0ICXO2Mq6HjOrgWJqWifEYwz+Y3eyPd8ZOkp8el3l 2a01:4f8:140:926a::1:2 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIOQvi5s82dH4Duhp2YV4mo71+i3J6bybD/Ph/ibysdGE build5.osmocom.org ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIJafKRvWKA+B+cEz20YlWO+5XrWY+t4tacLAfm5DMMal build4.osmocom.org ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIHdLymAofmutYuXMgiWQaNiFUHfu+2j60pmWemd5hddw 10.9.25.26 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAICHw8f7STEM6tZj/14dMG0aPcOLzpC0uSwoOlwAMv7Z3 +10.9.25.28 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAINEWffWCaHxwMs1W+m55WDHJSIR4O0eiTtcteJCBjKZK -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42630?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I66afdc0ba86cfde6613226abba900c31e486f846 Gerrit-Change-Number: 42630 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ccid-firmware[master]: tests/fetch_image: support copying from artifact
by osmith 16 Apr '26

16 Apr '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42627?usp=email ) Change subject: tests/fetch_image: support copying from artifact ...................................................................... tests/fetch_image: support copying from artifact Allow copying the image from another job in octsim_osmo-ccid-firmware-artifacts job. Related: osmo-ci I736b2b194813e6edff0197145fe08168c3e66903 Change-Id: I9445d6d5e4723bf6a87d4bffcdc638560471328b --- M tests/sysmo-octsim/fetch_image.sh 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/27/42627/1 diff --git a/tests/sysmo-octsim/fetch_image.sh b/tests/sysmo-octsim/fetch_image.sh index 119d611..7958f3a 100755 --- a/tests/sysmo-octsim/fetch_image.sh +++ b/tests/sysmo-octsim/fetch_image.sh @@ -2,5 +2,12 @@ . ./test-data echo "fetch image" -wget -O $DFU_IMAGE http://ftp.osmocom.org/binaries/osmo-ccid-firmware/latest/sysmoOCTSIM.bin -nv + +if [ "$JENKINS_COPY_DFU_IMAGE_ARTIFACTS" = 1 ]; then + # FIXME + exit 1 +else + wget -O $DFU_IMAGE https://ftp.osmocom.org/binaries/osmo-ccid-firmware/latest/sysmoOCTSIM.bin -nv +fi + echo "done" -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42627?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I9445d6d5e4723bf6a87d4bffcdc638560471328b Gerrit-Change-Number: 42627 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: requirements: ensure safe version of PyYAML >= 5.4 (CVE-2020-1747)
by fixeria 16 Apr '26

16 Apr '26

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42626?usp=email ) Change subject: requirements: ensure safe version of PyYAML >= 5.4 (CVE-2020-1747) ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42626?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I901c76c59e9c1bab030eab81038e04a475b32510 Gerrit-Change-Number: 42626 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Apr 2026 12:26:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in osmo-ccid-firmware[master]: fw source: force reformat once and for all
by laforge 16 Apr '26

16 Apr '26

Attention is currently required from: Hoernchen, osmith. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330?usp=email ) Change subject: fw source: force reformat once and for all ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: can you please rebase this patch to make sure it actually works and passes V+1 now? -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Iacc086bb566551225e7a21b639a1ad2ec257484f Gerrit-Change-Number: 42330 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Apr 2026 11:03:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-msc[master]: Check for protocol extension bit in message type at a central location
by laforge 16 Apr '26

16 Apr '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/38579?usp=email ) Change subject: Check for protocol extension bit in message type at a central location ...................................................................... Check for protocol extension bit in message type at a central location Bits 8 and 7 of message type can be used as sequence number or have specific default values. The added check will verify the bits according to the prococol descriptor and Release version. The Rules for these bits are described in GSM TS 124.007, clause 11.2.3.2.1 for Release <= 98 and 11.2.3.2.2 for Release >= 99. There is also no need to clear bit 7 in message type for these protocols, as it is done already in gsm48_hdr_msg_type(). Some unit tests fail without fixes that are included in this patch. Change-Id: Iae41bc6a2e9fd85583509b6c6154dd5a935fb5df --- M src/libmsc/gsm_04_08_cc.c M src/libmsc/msc_a.c M src/libmsc/msc_vgcs.c M tests/msc_vlr/msc_vlr_test_authen_reuse.c M tests/msc_vlr/msc_vlr_test_call.c M tests/msc_vlr/msc_vlr_test_gsm_ciph.c M tests/msc_vlr/msc_vlr_test_umts_authen.c M tests/msc_vlr/msc_vlr_tests.c M tests/msc_vlr/msc_vlr_tests.h 9 files changed, 64 insertions(+), 10 deletions(-) Approvals: pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c index 46ab176..11bebb0 100644 --- a/src/libmsc/gsm_04_08_cc.c +++ b/src/libmsc/gsm_04_08_cc.c @@ -2681,6 +2681,7 @@ #define DATASLLEN \ (sizeof(datastatelist) / sizeof(struct datastate)) + int gsm0408_rcv_cc(struct msc_a *msc_a, struct msgb *msg) { struct gsm48_hdr *gh = msgb_l3(msg); @@ -2691,11 +2692,6 @@ struct gsm_network *net = msc_a_net(msc_a); int i, rc = 0; - if (msg_type & 0x80) { - LOG_TRANS(trans, LOGL_DEBUG, "MSG 0x%2x not defined for PD error\n", msg_type); - return -EINVAL; - } - if (!vsub) { LOG_TRANS(trans, LOGL_ERROR, "Invalid conn: no subscriber\n"); /* Decrement use counter that has been incremented by CM Service Request (CC). diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c index c682004..631e711 100644 --- a/src/libmsc/msc_a.c +++ b/src/libmsc/msc_a.c @@ -1455,6 +1455,45 @@ return silent_call_rx(conn, msg); #endif + /* Check for correct Bit 8. + * In R99 or above, it is used as sequence number for MM, CC and SS protocol. + * In any other case it must be set to default (0). */ + if (!is_r99 || (pdisc != GSM48_PDISC_MM && pdisc != GSM48_PDISC_CC && pdisc != GSM48_PDISC_NC_SS)) { + if ((gh->msg_type & 0x80)) { + LOG_MSC_A_CAT(msc_a, DRLL, LOGL_NOTICE, "MSG 0x%2x not defined for PD (bit 8 is not 0)\n", + gh->msg_type); + return -EINVAL; + } + } + + /* Check for correct Bit 7. + * For MM, CC, SS, GCC, BCC and LCS, it is used as sequence number. + * For RR it is part of the message type. + * For any other case it must be set to default (1 for SM, 0 for others). */ + switch (pdisc) { + case GSM48_PDISC_CC: + case GSM48_PDISC_MM: + case GSM48_PDISC_NC_SS: + case GSM48_PDISC_GROUP_CC: + case GSM48_PDISC_BCAST_CC: + case GSM48_PDISC_LOC: + case GSM48_PDISC_RR: + break; + case GSM48_PDISC_SM_GPRS: + if (!(gh->msg_type & 0x40)) { + LOG_MSC_A_CAT(msc_a, DRLL, LOGL_NOTICE, "SM MSG 0x%2x not defined for PD (bit 7 is not 1)\n", + gh->msg_type); + return -EINVAL; + } + break; + default: + if ((gh->msg_type & 0x40)) { + LOG_MSC_A_CAT(msc_a, DRLL, LOGL_NOTICE, "MSG 0x%2x not defined for PD (bit 7 is not 0)\n", + gh->msg_type); + return -EINVAL; + } + } + switch (pdisc) { case GSM48_PDISC_GROUP_CC: case GSM48_PDISC_BCAST_CC: diff --git a/src/libmsc/msc_vgcs.c b/src/libmsc/msc_vgcs.c index 528d282..fdb5356 100644 --- a/src/libmsc/msc_vgcs.c +++ b/src/libmsc/msc_vgcs.c @@ -1468,9 +1468,6 @@ uint8_t da, ua, comm, oi; int rc = 0; - /* Remove sequence number (bit 7) from message type. */ - msg_type &= 0xbf; - /* Parse messages. */ switch (msg_type) { case OSMO_GSM44068_MSGT_SETUP: diff --git a/tests/msc_vlr/msc_vlr_test_authen_reuse.c b/tests/msc_vlr/msc_vlr_test_authen_reuse.c index 04f7da8..181c073 100644 --- a/tests/msc_vlr/msc_vlr_test_authen_reuse.c +++ b/tests/msc_vlr/msc_vlr_test_authen_reuse.c @@ -42,6 +42,7 @@ rx_from_ran = via_ran; btw("Location Update request causes a GSUP Send Auth Info request to HLR"); + release_99 = true; lu_result_sent = RES_NONE; gsup_expect_tx("080108" "09710000000156f0" CN_DOMAIN VLR_TO_HLR); ms_sends_msg("0508" /* MM LU */ @@ -257,6 +258,7 @@ gsup_expect_tx("0c010809710000000156f0" CN_DOMAIN VLR_TO_HLR); ms_sends_msg("050130" "089910070000106005" /* IMSI */); + release_99 = false; ASSERT_RELEASE_CLEAR(via_ran); ran_sends_clear_complete(via_ran); diff --git a/tests/msc_vlr/msc_vlr_test_call.c b/tests/msc_vlr/msc_vlr_test_call.c index 376a8c7..0ddba96 100644 --- a/tests/msc_vlr/msc_vlr_test_call.c +++ b/tests/msc_vlr/msc_vlr_test_call.c @@ -53,6 +53,7 @@ rx_from_ran = OSMO_RAT_UTRAN_IU; btw("Location Update request causes a GSUP Send Auth Info request to HLR"); + release_99 = true; lu_result_sent = RES_NONE; gsup_expect_tx("080108" "09710000000156f0" CN_DOMAIN VLR_TO_HLR); ms_sends_msg("0508" /* MM LU */ @@ -171,6 +172,7 @@ net->vlr->cfg.assign_tmsi = false; btw("Location Update request causes a GSUP LU request to HLR"); + release_99 = true; lu_result_sent = RES_NONE; gsup_expect_tx("04010809710000000156f0280102" VLR_TO_HLR); ms_sends_msg("0508" /* MM LU */ @@ -319,6 +321,7 @@ EXPECT_CONN_COUNT(0); clear_vlr(); comment_end(); + release_99 = false; } static void test_call_mt() @@ -455,6 +458,7 @@ EXPECT_CONN_COUNT(0); clear_vlr(); comment_end(); + release_99 = false; } static void test_call_mt2() @@ -580,6 +584,7 @@ clear_vlr(); comment_end(); + release_99 = false; } static void test_call_mo_to_unknown() @@ -678,6 +683,7 @@ EXPECT_CONN_COUNT(0); clear_vlr(); comment_end(); + release_99 = false; } static void test_call_mo_to_unknown_timeout() @@ -777,6 +783,7 @@ EXPECT_CONN_COUNT(0); clear_vlr(); comment_end(); + release_99 = false; } #define LIST_END 0xffff @@ -1630,6 +1637,7 @@ EXPECT_CONN_COUNT(0); clear_vlr(); comment_end(); + release_99 = false; } msc_vlr_test_func_t msc_vlr_tests[] = { diff --git a/tests/msc_vlr/msc_vlr_test_gsm_ciph.c b/tests/msc_vlr/msc_vlr_test_gsm_ciph.c index 4bf786f..0c9883d 100644 --- a/tests/msc_vlr/msc_vlr_test_gsm_ciph.c +++ b/tests/msc_vlr/msc_vlr_test_gsm_ciph.c @@ -848,6 +848,7 @@ rx_from_ran = OSMO_RAT_GERAN_A; btw("Location Update request causes a GSUP Send Auth Info request to HLR"); + release_99 = true; lu_result_sent = RES_NONE; gsup_expect_tx("080108" "09710000000156f0" CN_DOMAIN VLR_TO_HLR); ms_sends_msg("0508" /* MM LU */ @@ -1054,6 +1055,7 @@ ms_sends_msg("050130" "089910070000106005" /* IMSI */); VERBOSE_ASSERT(bssap_clear_sent, == true, "%d"); + release_99 = false; ran_sends_clear_complete(); EXPECT_CONN_COUNT(0); diff --git a/tests/msc_vlr/msc_vlr_test_umts_authen.c b/tests/msc_vlr/msc_vlr_test_umts_authen.c index 37aa96a..168173c 100644 --- a/tests/msc_vlr/msc_vlr_test_umts_authen.c +++ b/tests/msc_vlr/msc_vlr_test_umts_authen.c @@ -23,6 +23,8 @@ #include "msc_vlr_tests.h" + + static void _test_umts_authen(enum osmo_rat_type via_ran) { struct vlr_subscr *vsub; @@ -57,6 +59,7 @@ rx_from_ran = via_ran; btw("Location Update request causes a GSUP Send Auth Info request to HLR"); + release_99 = true; lu_result_sent = RES_NONE; gsup_expect_tx("080108" "09710000000156f0" CN_DOMAIN VLR_TO_HLR); ms_sends_msg("0508" /* MM LU */ @@ -338,6 +341,7 @@ gsup_expect_tx("0c010809710000000156f0" CN_DOMAIN VLR_TO_HLR); ms_sends_msg("050130" "089910070000106005" /* IMSI */); + release_99 = false; ASSERT_RELEASE_CLEAR(via_ran); ran_sends_clear_complete(via_ran); @@ -390,6 +394,7 @@ rx_from_ran = via_ran; btw("Location Update request causes a GSUP Send Auth Info request to HLR"); + release_99 = true; lu_result_sent = RES_NONE; gsup_expect_tx("080108" "09710000000156f0" CN_DOMAIN VLR_TO_HLR); ms_sends_msg("0508" /* MM LU */ @@ -598,6 +603,7 @@ btw("MS sends TMSI Realloc Complete"); expect_release_clear(via_ran); ms_sends_msg("055b"); + release_99 = false; ASSERT_RELEASE_CLEAR(via_ran); ran_sends_clear_complete(via_ran); diff --git a/tests/msc_vlr/msc_vlr_tests.c b/tests/msc_vlr/msc_vlr_tests.c index 376b2a4..a2f3c85 100644 --- a/tests/msc_vlr/msc_vlr_tests.c +++ b/tests/msc_vlr/msc_vlr_tests.c @@ -90,6 +90,8 @@ bool expecting_crcx[2] = {}; bool got_crcx[2] = {}; +bool release_99 = false; + extern int ran_dec_dtap_undup_pdisc_ctr_bin(uint8_t pdisc); /* static state variables for the L3 send sequence numbers */ @@ -105,10 +107,10 @@ if (bin >= 0 && bin < ARRAY_SIZE(n_sd)) { /* patch in n_sd into the msg_type octet */ - *msg_type_oct = (*msg_type_oct & 0x3f) | ((n_sd[bin] & 0x3) << 6); + *msg_type_oct = (*msg_type_oct & 0x3f) | ((n_sd[bin] & (release_99 ? 0x3 : 0x1)) << 6); //fprintf(stderr, "pdisc=0x%02x bin=%d, patched n_sd=%u\n\n", pdisc, bin, n_sd[bin] & 3); /* increment N(SD) */ - n_sd[bin] = (n_sd[bin] + 1) % 4; + n_sd[bin] = (n_sd[bin] + 1) % (release_99 ? 4 : 2); } else { //fprintf(stderr, "pdisc=0x%02x NO SEQ\n\n", pdisc); } diff --git a/tests/msc_vlr/msc_vlr_tests.h b/tests/msc_vlr/msc_vlr_tests.h index f095a7f..2938d96 100644 --- a/tests/msc_vlr/msc_vlr_tests.h +++ b/tests/msc_vlr/msc_vlr_tests.h @@ -120,6 +120,8 @@ extern uint32_t cc_to_mncc_tx_got_callref; extern char cc_to_mncc_tx_last_sdp[1024]; +extern bool release_99; + extern struct gsm_mncc *on_call_release_mncc_sends_to_cc_data; static inline void expect_iu_release() -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38579?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iae41bc6a2e9fd85583509b6c6154dd5a935fb5df Gerrit-Change-Number: 38579 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-msc[master]: Reset 'release_99' flag in test cases at comment_start()
by laforge 16 Apr '26

16 Apr '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/42623?usp=email ) Change subject: Reset 'release_99' flag in test cases at comment_start() ...................................................................... Reset 'release_99' flag in test cases at comment_start() Rather than resetting release_99 flag in every test case that did set it, do it in comment_start(). Change-Id: I55a49dd24a5df6ee8e28fa6b410988e82d10c554 --- M tests/msc_vlr/msc_vlr_test_authen_reuse.c M tests/msc_vlr/msc_vlr_test_call.c M tests/msc_vlr/msc_vlr_test_gsm_ciph.c M tests/msc_vlr/msc_vlr_test_umts_authen.c M tests/msc_vlr/msc_vlr_tests.h 5 files changed, 4 insertions(+), 11 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/tests/msc_vlr/msc_vlr_test_authen_reuse.c b/tests/msc_vlr/msc_vlr_test_authen_reuse.c index 181c073..98708a4 100644 --- a/tests/msc_vlr/msc_vlr_test_authen_reuse.c +++ b/tests/msc_vlr/msc_vlr_test_authen_reuse.c @@ -258,7 +258,6 @@ gsup_expect_tx("0c010809710000000156f0" CN_DOMAIN VLR_TO_HLR); ms_sends_msg("050130" "089910070000106005" /* IMSI */); - release_99 = false; ASSERT_RELEASE_CLEAR(via_ran); ran_sends_clear_complete(via_ran); diff --git a/tests/msc_vlr/msc_vlr_test_call.c b/tests/msc_vlr/msc_vlr_test_call.c index 0ddba96..bfee0fc 100644 --- a/tests/msc_vlr/msc_vlr_test_call.c +++ b/tests/msc_vlr/msc_vlr_test_call.c @@ -321,7 +321,6 @@ EXPECT_CONN_COUNT(0); clear_vlr(); comment_end(); - release_99 = false; } static void test_call_mt() @@ -458,7 +457,6 @@ EXPECT_CONN_COUNT(0); clear_vlr(); comment_end(); - release_99 = false; } static void test_call_mt2() @@ -584,7 +582,6 @@ clear_vlr(); comment_end(); - release_99 = false; } static void test_call_mo_to_unknown() @@ -683,7 +680,6 @@ EXPECT_CONN_COUNT(0); clear_vlr(); comment_end(); - release_99 = false; } static void test_call_mo_to_unknown_timeout() @@ -783,7 +779,6 @@ EXPECT_CONN_COUNT(0); clear_vlr(); comment_end(); - release_99 = false; } #define LIST_END 0xffff @@ -1637,7 +1632,6 @@ EXPECT_CONN_COUNT(0); clear_vlr(); comment_end(); - release_99 = false; } msc_vlr_test_func_t msc_vlr_tests[] = { diff --git a/tests/msc_vlr/msc_vlr_test_gsm_ciph.c b/tests/msc_vlr/msc_vlr_test_gsm_ciph.c index 0c9883d..d7c4e8f 100644 --- a/tests/msc_vlr/msc_vlr_test_gsm_ciph.c +++ b/tests/msc_vlr/msc_vlr_test_gsm_ciph.c @@ -1055,7 +1055,6 @@ ms_sends_msg("050130" "089910070000106005" /* IMSI */); VERBOSE_ASSERT(bssap_clear_sent, == true, "%d"); - release_99 = false; ran_sends_clear_complete(); EXPECT_CONN_COUNT(0); diff --git a/tests/msc_vlr/msc_vlr_test_umts_authen.c b/tests/msc_vlr/msc_vlr_test_umts_authen.c index 168173c..b23b16e 100644 --- a/tests/msc_vlr/msc_vlr_test_umts_authen.c +++ b/tests/msc_vlr/msc_vlr_test_umts_authen.c @@ -341,7 +341,6 @@ gsup_expect_tx("0c010809710000000156f0" CN_DOMAIN VLR_TO_HLR); ms_sends_msg("050130" "089910070000106005" /* IMSI */); - release_99 = false; ASSERT_RELEASE_CLEAR(via_ran); ran_sends_clear_complete(via_ran); @@ -603,7 +602,6 @@ btw("MS sends TMSI Realloc Complete"); expect_release_clear(via_ran); ms_sends_msg("055b"); - release_99 = false; ASSERT_RELEASE_CLEAR(via_ran); ran_sends_clear_complete(via_ran); diff --git a/tests/msc_vlr/msc_vlr_tests.h b/tests/msc_vlr/msc_vlr_tests.h index 2938d96..ae1bcdb 100644 --- a/tests/msc_vlr/msc_vlr_tests.h +++ b/tests/msc_vlr/msc_vlr_tests.h @@ -53,7 +53,10 @@ #define btw(fmt, args...) _log("- " fmt, ## args ) #define log(fmt, args...) _log(" " fmt, ## args ) -#define comment_start() fprintf(stderr, "===== %s\n", __func__); +#define comment_start() do { \ + fprintf(stderr, "===== %s\n", __func__); \ + release_99 = false; \ + } while (false) #define comment_end() fprintf(stderr, "===== %s: SUCCESS\n\n", __func__); extern void *msc_vlr_tests_ctx; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/42623?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I55a49dd24a5df6ee8e28fa6b410988e82d10c554 Gerrit-Change-Number: 42623 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-msc[master]: Reset 'release_99' flag in test cases at comment_start()
by laforge 16 Apr '26

16 Apr '26

Attention is currently required from: jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/42623?usp=email ) Change subject: Reset 'release_99' flag in test cases at comment_start() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/42623?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I55a49dd24a5df6ee8e28fa6b410988e82d10c554 Gerrit-Change-Number: 42623 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 16 Apr 2026 11:02:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: pySim-prog: fix Insecure PRNG for SIM Authentication Keys (CWE-338)
by laforge 16 Apr '26

16 Apr '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42624?usp=email ) Change subject: pySim-prog: fix Insecure PRNG for SIM Authentication Keys (CWE-338) ...................................................................... pySim-prog: fix Insecure PRNG for SIM Authentication Keys (CWE-338) Root Cause: pySim-prog.py uses Python's random module (Mersenne Twister MT19937) to generate Ki and OPC — the root authentication keys for SIM cards. MT19937 is a deterministic PRNG that is not cryptographically secure. Its internal state (624 × 32-bit words, 19,937 bits) can be fully recovered after observing 624 consecutive outputs. Impact: 1. SIM Card Cloning: An attacker who determines the PRNG state can predict all Ki/OPC values generated before and after. With these keys, SIM cards can be cloned. 2. Network Authentication Bypass: Ki/OPC are used in the Milenage algorithm for 3G/4G/5G authentication. Predictable keys mean an attacker can authenticate as any subscriber whose SIM was provisioned with the weak RNG. 3. Batch Compromise: In bulk provisioning scenarios (pySim-prog's primary use case), hundreds or thousands of SIMs may be programmed sequentially. Compromising one batch means recovering the PRNG state to predict all keys. Fix: Replace random.randrange() with os.urandom() Change-Id: Id3e00d3ec5386f17c1525cacfc7d3f5bba43381f --- M pySim-prog.py 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim-prog.py b/pySim-prog.py index 3f2bb94..6111fc1 100755 --- a/pySim-prog.py +++ b/pySim-prog.py @@ -27,7 +27,6 @@ import hashlib import argparse import os -import random import re import sys import traceback @@ -436,7 +435,7 @@ if not re.match('^[0-9a-fA-F]{32}$', ki): raise ValueError('Ki needs to be 128 bits, in hex format') else: - ki = ''.join(['%02x' % random.randrange(0, 256) for i in range(16)]) + ki = os.urandom(16).hex() # OPC (random) if opts.opc is not None: @@ -447,7 +446,7 @@ elif opts.op is not None: opc = derive_milenage_opc(ki, opts.op) else: - opc = ''.join(['%02x' % random.randrange(0, 256) for i in range(16)]) + opc = os.urandom(16).hex() pin_adm = sanitize_pin_adm(opts.pin_adm, opts.pin_adm_hex) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42624?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id3e00d3ec5386f17c1525cacfc7d3f5bba43381f Gerrit-Change-Number: 42624 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: pySim-prog: fix Insecure PRNG for SIM Authentication Keys (CWE-338)
by laforge 16 Apr '26

16 Apr '26

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42624?usp=email ) Change subject: pySim-prog: fix Insecure PRNG for SIM Authentication Keys (CWE-338) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42624?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id3e00d3ec5386f17c1525cacfc7d3f5bba43381f Gerrit-Change-Number: 42624 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Apr 2026 11:00:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026