April 2026 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: vty: fix osmo_cpu_sched_vty_init() prototype
by fixeria 28 Apr '26

28 Apr '26

Attention is currently required from: Timur Davydov. fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/42709?usp=email ) Change subject: vty: fix osmo_cpu_sched_vty_init() prototype ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42709?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia86e8063178ad82de098c2ff693cfbcd7e9f2192 Gerrit-Change-Number: 42709 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Tue, 28 Apr 2026 20:13:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bsc[master]: rsl: don't send legacy Chan Ident IE for Nokia BTS
by fixeria 28 Apr '26

28 Apr '26

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42717?usp=email ) Change subject: rsl: don't send legacy Chan Ident IE for Nokia BTS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42717?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibce7a841907ac87ae378ded3ddb174d38b70b7b7 Gerrit-Change-Number: 42717 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 28 Apr 2026 20:12:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: nokia: respond to BTS_COMMISS_TEST_REQ
by fixeria 28 Apr '26

28 Apr '26

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42716?usp=email ) Change subject: nokia: respond to BTS_COMMISS_TEST_REQ ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42716?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0f2710c3cdb38a9e5b37e40ca5584237a730a902 Gerrit-Change-Number: 42716 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 28 Apr 2026 20:08:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bsc[master]: nokia bts-reset-timer: raise the maximum to 300 s
by fixeria 28 Apr '26

28 Apr '26

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42715?usp=email ) Change subject: nokia bts-reset-timer: raise the maximum to 300 s ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42715?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie5b784c9cce56e27800084471a7fb0b867cc0c69 Gerrit-Change-Number: 42715 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 28 Apr 2026 20:06:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: nokia: make Rx diversity configurable
by fixeria 28 Apr '26

28 Apr '26

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42714?usp=email ) Change subject: nokia: make Rx diversity configurable ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/42714/comment/e2803337_402016f0?usp… : PS1, Line 487: bts->type != GSM_BTS_TYPE_NOKIA_SITE Is this parameter Nokia *Site specific? If not, better use `!is_nokia_bts(bts)` here like other VTY commands do. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42714?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I73bd91b717a8c8b338bacb6ed9db73bb07245c12 Gerrit-Change-Number: 42714 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 28 Apr 2026 20:05:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: nokia vty: change help strings away from "*Site"
by fixeria 28 Apr '26

28 Apr '26

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42713?usp=email ) Change subject: nokia vty: change help strings away from "*Site" ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/42713/comment/de4f09af_243d12bf?usp… : PS1, Line 395: nokia_site You can also rename `nokia_site` in VTY commands and add `ALIAS` or `ALIAS_DEPRECATED` for backwards compatibility. This would require duplicating command and help strings though. Alternatively, you can change all commands to start with `(nokia|nokia_site) `. Just an idea, not a merge blocker. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42713?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I55556b7b5aa5bc6efcbee815e9011497a933697c Gerrit-Change-Number: 42713 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 28 Apr 2026 19:57:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bsc[master]: nokia: add support for Flexi Multiradio
by fixeria 28 Apr '26

28 Apr '26

Attention is currently required from: falconia, osmith. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email ) Change subject: nokia: add support for Flexi Multiradio ...................................................................... Patch Set 1: Code-Review+1 Verified+1 (2 comments) File include/osmocom/bsc/bts.h: https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/cbe3cb95_d351790f?usp… : PS1, Line 512: 256 cosmetic: add define for `256` too, e.g. `NOKIA_OML_MAX_SEGMENT_LEN`? File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/7dd039e3_cdca7d30?usp… : PS1, Line 1785: static int abis_nm_rcvmsg_fom(struct e1inp_sign_link *sign_link, > > Avoid multiple line dereference - prefer 'run.static' […] The liner is indeed hallucinating here. Might be something for @osmith@sysmocom.de to check. For now, I am simply removing Jenkins' V-1 vote and adding my V+1. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icd429552c3b5e90d6c5d3ae5f52afd6550e3cebc Gerrit-Change-Number: 42712 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 28 Apr 2026 19:46:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>

1 0

[M] Change in osmo-bsc[master]: nokia: add support for Flexi Multiradio
by falconia 28 Apr '26

28 Apr '26

falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email ) Change subject: nokia: add support for Flexi Multiradio ...................................................................... Patch Set 1: (2 comments) File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/a286c739_416bf42d?usp… : PS1, Line 1778: It is also possible to configure the BTS without a reset, but in this case > please, no spaces at the start of a line In this case I am changing the word content of an existing comment without changing its formatting style. How do we override the overzealous linter in such cases? https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/a9c5f5a2_65188a93?usp… : PS1, Line 1785: static int abis_nm_rcvmsg_fom(struct e1inp_sign_link *sign_link, > Avoid multiple line dereference - prefer 'run.static' What the heck is it complaining about? Functions with long argument lists have those lists split into multiple lines all the time, to keep line length under control, which is all I am doing here. Once again, I need some way to override the overzealous linter. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icd429552c3b5e90d6c5d3ae5f52afd6550e3cebc Gerrit-Change-Number: 42712 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 28 Apr 2026 17:56:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-bsc[master]: nokia: add support for Flexi Multiradio
by Jenkins Builder 28 Apr '26

28 Apr '26

Jenkins Builder has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email ) Change subject: nokia: add support for Flexi Multiradio ...................................................................... Patch Set 1: (5 comments) File src/osmo-bsc/bts_nokia_site.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/6aa80188_f56f2265?usp… : PS1, Line 1778: It is also possible to configure the BTS without a reset, but in this case please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/76114543_09306349?usp… : PS1, Line 1779: the BTS does not accept any changes in configuration - therefore, the mode please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/5226232d_01ed4c2c?usp… : PS1, Line 1780: of skipping BSC-driven BTS reset is only for use during osmo-bsc development, please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/ad8c4bc5_4326cee1?usp… : PS1, Line 1781: when the developer-operator resets the BTS manually before each test run. please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/fd3a38ef_a59f616f?usp… : PS1, Line 1785: static int abis_nm_rcvmsg_fom(struct e1inp_sign_link *sign_link, Avoid multiple line dereference - prefer 'run.static' -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icd429552c3b5e90d6c5d3ae5f52afd6550e3cebc Gerrit-Change-Number: 42712 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 28 Apr 2026 17:44:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-bsc[master]: rsl: don't send legacy Chan Ident IE for Nokia BTS
by falconia 28 Apr '26

28 Apr '26

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42717?usp=email ) Change subject: rsl: don't send legacy Chan Ident IE for Nokia BTS ...................................................................... rsl: don't send legacy Chan Ident IE for Nokia BTS The description of CHAN ACTIV command message in TS 48.058 section 8.4.1 lists Channel Identification as an optional IE, with a note that reads "Included if compatibility with phase1 is required." This note may have been misinterpreted as referring to compatibility with Phase 1 phones - but since this network-internal Abis detail is invisible to phones, the real intent of GSM spec authors here must have been compatibility with Phase 1 BTS. Previous versions of OsmoBSC would always include this IE, and it appears that all previously supported BTS models would simply ignore it. However, newer Nokia BTS models (observed on Flexi Multiradio at least) dislike this IE and return CHAN ACTIV NACK with an optional IE error cause if it is included. To avoid changing OsmoBSC behavior for other users, let us conditionalize removal of this legacy IE on Nokia BTS for now. This change has been tested on InSite, MetroSite and Flexi Multiradio - no adverse effects on previously supported *Site models. Change-Id: Ibce7a841907ac87ae378ded3ddb174d38b70b7b7 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 46 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/17/42717/1 diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 42a164a..4627914 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -577,6 +577,31 @@ msgb_put_u8(msg, tsc); } +static void add_phase1_chan_ident(struct msgb *msg, const struct gsm48_chan_desc *cd) +{ + uint8_t *len; + + /* + * This Channel Identification IE is a Phase1 backward compatibility + * measure. It contains the GSM48 Channel Description and the + * Mobile Allocation. TS 48.058 section 9.3.5 asks for MA + * to have a length of zero. We are using msgb_l3len() to calculate + * the length of both messages. + */ + msgb_v_put(msg, RSL_IE_CHAN_IDENT); + len = msgb_put(msg, 1); + msgb_tv_fixed_put(msg, GSM48_IE_CHANDESC_2, sizeof(*cd), (const uint8_t *) cd); + + /* See 3GPP TS 48.058 (version 15.0.0), section 9.3.5 "Channel Identification". + * The 3GPP TS 24.008 "Mobile Allocation" shall for compatibility reasons + * be included but empty, i.e. the length shall be zero. */ + msgb_tlv_put(msg, GSM48_IE_MA_AFTER, 0, NULL); + + /* update the calculated size */ + msg->l3h = len + 1; + *len = msgb_l3len(msg); +} + /* Chapter 8.4.1 */ int rsl_tx_chan_activ(struct gsm_lchan *lchan, uint8_t act_type, uint8_t ho_ref) { @@ -585,7 +610,6 @@ struct abis_rsl_dchan_hdr *dh; struct msgb *msg; int rc; - uint8_t *len; struct rsl_ie_chan_mode cm; struct gsm48_chan_desc cd; @@ -625,25 +649,28 @@ msgb_tlv_put(msg, RSL_IE_CHAN_MODE, sizeof(cm), (uint8_t *) &cm); - /* - * The Channel Identification is needed for Phase1 phones - * and it contains the GSM48 Channel Description and the - * Mobile Allocation. The GSM 08.58 asks for the Mobile - * Allocation to have a length of zero. We are using the - * msgb_l3len to calculate the length of both messages. + /* The description of CHAN ACTIV command message in TS 48.058 + * section 8.4.1 lists Channel Identification as an optional IE, + * with a note that reads "Included if compatibility with phase1 + * is required." This note may have been misinterpreted as + * referring to compatibility with Phase 1 phones - but since + * this network-internal Abis detail is invisible to phones, + * the real intent of GSM spec authors here must have been + * compatibility with Phase 1 BTS. + * + * Previous versions of OsmoBSC would always include this IE, + * and it appears that all previously supported BTS models + * would simply ignore it. However, newer Nokia BTS models + * (observed on Flexi Multiradio at least) dislike this IE + * and return CHAN ACTIV NACK with an optional IE error cause + * if it is included. + * + * To avoid changing OsmoBSC behavior for other users, + * let us conditionalize removal of this legacy IE on + * Nokia BTS for now. */ - msgb_v_put(msg, RSL_IE_CHAN_IDENT); - len = msgb_put(msg, 1); - msgb_tv_fixed_put(msg, GSM48_IE_CHANDESC_2, sizeof(cd), (const uint8_t *) &cd); - - /* See 3GPP TS 48.058 (version 15.0.0), section 9.3.5 "Channel Identification". - * The 3GPP TS 24.008 "Mobile Allocation" shall for compatibility reasons - * be included but empty, i.e. the length shall be zero. */ - msgb_tlv_put(msg, GSM48_IE_MA_AFTER, 0, NULL); - - /* update the calculated size */ - msg->l3h = len + 1; - *len = msgb_l3len(msg); + if (!is_nokia_bts(bts)) + add_phase1_chan_ident(msg, &cd); if (lchan->encr.alg_a5_n > 0) { uint8_t encr_info[MAX_A5_KEY_LEN+2]; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42717?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibce7a841907ac87ae378ded3ddb174d38b70b7b7 Gerrit-Change-Number: 42717 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026