[S] Change in osmo-bsc[master]: nokia: make Rx diversity configurable - gerrit-log

28 Apr 2026


      Attention is currently required from: falconia.
fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42714?usp=email )
Change subject: nokia: make Rx diversity configurable
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/osmo-bsc/bts_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/42714/comment/e2803337_402016f0?usp=... :
PS1, Line 487: bts->type != GSM_BTS_TYPE_NOKIA_SITE
Is this parameter Nokia *Site specific?
If not, better use `!is_nokia_bts(bts)` here like other VTY commands do.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42714?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I73bd91b717a8c8b338bacb6ed9db73bb07245c12
Gerrit-Change-Number: 42714
Gerrit-PatchSet: 1
Gerrit-Owner: falconia falcon@freecalypso.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: falconia falcon@freecalypso.org
Gerrit-Comment-Date: Tue, 28 Apr 2026 20:05:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes