Attention is currently required from: laforge, pespin.
Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email )
Change subject: fix --disable-log-macros
......................................................................
Patch Set 2:
(1 comment)
File configure.ac:
https://gerrit.osmocom.org/c/libosmocore/+/42203/comment/55ee2e76_e2a69f72?… :
PS1, Line 511: if test x"$log_macros" == x"yes"
> The problem is not the $enableval above, which I think is fine. […]
But the problem is that we "enable" the flag by disabling and ENABLE_LIBOSMOCORE_NO_LOGGING_DEFAULT is obviously "no" by default... this is precisely why it is broken.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I809ab2f61e72428ba21061055296eb83d6d710ab
Gerrit-Change-Number: 42203
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Feb 2026 16:34:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: Hoernchen, laforge, pespin.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review-1 by pespin, Verified+1 by Jenkins Builder
Change subject: fix --disable-log-macros
......................................................................
fix --disable-log-macros
Before 9197c1ac, the AC_ARG_ENABLE(log_macros, ...)
action was hardcoded to [log_macros="yes"], so *any*
use of the flag --enable-log-macros or --disable-log-macros
would set log_macros="yes" -> AC_DEFINE([LIBOSMOCORE_NO_LOGGING]).
The commit changed this to the standard [log_macros=$enableval], but
broke the conditional test, so
- AC_ARG_ENABLE sets $enableval to "no" for --disable-* flags
-> log_macros is now "no"
-> test fails
-> LIBOSMOCORE_NO_LOGGING is never defined...
The opposite of what it should do...
Change-Id: I809ab2f61e72428ba21061055296eb83d6d710ab
---
M configure.ac
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/03/42203/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I809ab2f61e72428ba21061055296eb83d6d710ab
Gerrit-Change-Number: 42203
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: Timur Davydov.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: fix(threads): centralize portable strerror handling
......................................................................
fix(threads): centralize portable strerror handling
- Move strerror_r portability logic to Utils
- Add strerror_buf() helper
- Add strerror_str() wrapper using std::error_code
- Simplify thread error logging in Threads.cpp
Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039
---
M CommonLibs/Threads.cpp
M CommonLibs/Utils.cpp
M CommonLibs/Utils.h
3 files changed, 27 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/99/42199/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039
Gerrit-Change-Number: 42199
Gerrit-PatchSet: 2
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Attention is currently required from: falconia.
fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42166?usp=email )
Change subject: RTP: use new abstraction layer instead of direct osmo_ortp
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42166?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5e3de4f84e8e8875437cb94a9b8feeb07f9cc1cf
Gerrit-Change-Number: 42166
Gerrit-PatchSet: 3
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Wed, 25 Feb 2026 16:33:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: falconia.
pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42206?usp=email )
Change subject: remove bogons from src/osmo-bts-oc2g/Makefile.am
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42206?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id9f091a42118393f973b982e18d1920f72bfcbb4
Gerrit-Change-Number: 42206
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Wed, 25 Feb 2026 16:32:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: falconia.
pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42197?usp=email )
Change subject: RTP: make ortp optional at compile time
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File contrib/Makefile.am:
https://gerrit.osmocom.org/c/osmo-bts/+/42197/comment/fe52d3c7_771c0d66?usp… :
PS3, Line 4: SUBDIRS += ber
we'll probably have to port stuff under ber/ to use the abs_rtp stuff you added before dropping ortp support.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42197?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib171bd42a65117457319befee2615e0c36c8d9e1
Gerrit-Change-Number: 42197
Gerrit-PatchSet: 3
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Wed, 25 Feb 2026 16:32:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: laforge, pespin.
Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email )
Change subject: core: fix config.h
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Once the 1st patch is reworked and this is merged, I guess it makes sense to make a libosmocore patc […]
I am only interested in working embedded builds right now, but I guess I should check the other code as well, which has the same issues.....
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic2cf52a3b60f43a2f5d3fe01c41a41f6fd9a8000
Gerrit-Change-Number: 42205
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Feb 2026 16:27:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/42206?usp=email )
Change subject: remove bogons from src/osmo-bts-oc2g/Makefile.am
......................................................................
remove bogons from src/osmo-bts-oc2g/Makefile.am
This Makefile.am contained references to ORTP_CFLAGS and ORTP_LIBS,
which are bogons because our configure makes no pkg-config calls
for ortp, whether ortp support is included or excluded - instead
these pkg-config calls that produce ORTP_CFLAGS and ORTP_LIBS
happen only in libosmo-abis, while all subsequent ortp users in
Osmocom go through osmo_ortp shim provided by that library.
Related: OS#6474
Change-Id: Id9f091a42118393f973b982e18d1920f72bfcbb4
---
M src/osmo-bts-oc2g/Makefile.am
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/06/42206/1
diff --git a/src/osmo-bts-oc2g/Makefile.am b/src/osmo-bts-oc2g/Makefile.am
index 29374ef..05bb938 100644
--- a/src/osmo-bts-oc2g/Makefile.am
+++ b/src/osmo-bts-oc2g/Makefile.am
@@ -14,7 +14,6 @@
$(LIBOSMONETIF_CFLAGS) \
$(LIBGPS_CFLAGS) \
$(LIBSYSTEMD_CFLAGS) \
- $(ORTP_CFLAGS) \
$(NULL)
COMMON_LDADD = \
@@ -26,7 +25,6 @@
$(LIBOSMOABIS_LIBS) \
$(LIBOSMOTRAU_LIBS) \
$(LIBOSMONETIF_LIBS) \
- $(ORTP_LIBS) \
$(NULL)
AM_CFLAGS += -DENABLE_OC2GBTS
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42206?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id9f091a42118393f973b982e18d1920f72bfcbb4
Gerrit-Change-Number: 42206
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>