February 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ccid-firmware[master]: ccid: fix rdr_to_pc_parameters and rdr_to_pc_hardware_error
by Hoernchen 21 Feb '26

21 Feb '26

Attention is currently required from: lynxis lazus. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email ) Change subject: ccid: fix rdr_to_pc_parameters and rdr_to_pc_hardware_error ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157/comment/f2cab7e4_8c… : PS1, Line 8: > You're fixing two messages which were wrong in different ways and had different problems. […] No. This patch stays exactly like this. Both messages were wrong, and now they agree with the spec. There is nothing else to it, and I'm not interested in wasting more time with bullshit discussions about "how wrong" messages are or splitting a fucking 11 line change into two separate commits. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I67d5cb876d20b29f4759d5b194606f34b8b966c4 Gerrit-Change-Number: 42157 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 21 Feb 2026 15:23:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-ccid-firmware[master]: ccid: fix rdr_to_pc_parameters and rdr_to_pc_hardware_error
by lynxis lazus 21 Feb '26

21 Feb '26

Attention is currently required from: Hoernchen. lynxis lazus has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email ) Change subject: ccid: fix rdr_to_pc_parameters and rdr_to_pc_hardware_error ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157/comment/75f5fc67_bd… : PS1, Line 8: > The title literally says that "what was wrong" is "ccid:" and two named messages, so two ccid messag […] You're fixing two messages which were wrong in different ways and had different problems. Also those changes are quiet important. Please split up the commit in two commits: One for the missing bProtocolNum / ccid_gen_parameters One for the wrong interrupt header in ccid_rdr_to_pc_hardware_error. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I67d5cb876d20b29f4759d5b194606f34b8b966c4 Gerrit-Change-Number: 42157 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Sat, 21 Feb 2026 14:55:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-ccid-firmware[master]: ccid: fix rdr_to_pc_parameters and rdr_to_pc_hardware_error
by Hoernchen 21 Feb '26

21 Feb '26

Attention is currently required from: lynxis lazus. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email ) Change subject: ccid: fix rdr_to_pc_parameters and rdr_to_pc_hardware_error ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157/comment/5fac97f1_6b… : PS1, Line 8: > Could you explain what was wrong and missing The title literally says that "what was wrong" is "ccid:" and two named messages, so two ccid messages were wrong, and the very few lines of changes explain what is different. There is nothing else to explain, the reader is either familiar with usb ccid, or not, and the reader will either believe that the messages are now fixed, or the reader will consult the ccid spec and verify that my claim that these messages are fixed now is true. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I67d5cb876d20b29f4759d5b194606f34b8b966c4 Gerrit-Change-Number: 42157 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 21 Feb 2026 14:27:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid_common: iso_handle_fsm_events: add missing return
by lynxis lazus 21 Feb '26

21 Feb '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42160?usp=email ) Change subject: ccid_common: iso_handle_fsm_events: add missing return ...................................................................... ccid_common: iso_handle_fsm_events: add missing return Fix warning about control reaches end of non-void function. Change-Id: I4066c8a1ab1eadb3d8f8cbaf5aa0afbbb2e5dd80 --- M ccid_common/ccid_slot_fsm.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/60/42160/1 diff --git a/ccid_common/ccid_slot_fsm.c b/ccid_common/ccid_slot_fsm.c index 0c56275..c34ad72 100644 --- a/ccid_common/ccid_slot_fsm.c +++ b/ccid_common/ccid_slot_fsm.c @@ -199,7 +199,8 @@ } /* do not free msgbs passed from the fsms, they are statically allocated! */ -static int iso_handle_fsm_events(struct ccid_slot *cs, bool enable){ +static int iso_handle_fsm_events(struct ccid_slot *cs, bool enable) +{ struct iso_fsm_slot *ss = ccid_slot2iso_fsm_slot(cs); struct msgb *tpdu, *resp; volatile uint32_t event = cs->event; @@ -338,6 +339,8 @@ __func__, event, data); break; } + + return 0; } static int iso_fsm_slot_xfr_block_async(struct ccid_slot *cs, struct msgb *msg, -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42160?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I4066c8a1ab1eadb3d8f8cbaf5aa0afbbb2e5dd80 Gerrit-Change-Number: 42160 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-ccid-firmware[master]: ccid: fix rdr_to_pc_parameters and rdr_to_pc_hardware_error
by lynxis lazus 20 Feb '26

20 Feb '26

Attention is currently required from: Hoernchen. lynxis lazus has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email ) Change subject: ccid: fix rdr_to_pc_parameters and rdr_to_pc_hardware_error ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157/comment/33f21074_14… : PS1, Line 8: Could you explain what was wrong and missing -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I67d5cb876d20b29f4759d5b194606f34b8b966c4 Gerrit-Change-Number: 42157 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Feb 2026 19:59:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-remsim[master]: Bump version: 1.1.2 → 1.1.3
by osmith 20 Feb '26

20 Feb '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42159?usp=email ) Change subject: Bump version: 1.1.2 → 1.1.3 ...................................................................... Bump version: 1.1.2 → 1.1.3 Change-Id: I4ffcc7d6bba6fd86525dd93fc8c643d50d81b7f0 --- M debian/changelog 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: lynxis lazus: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/changelog b/debian/changelog index ad0056f..961152f 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,13 @@ +osmo-remsim (1.1.3) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * rspro_server.c: Fix missing include for inet_ntoa() + + [ Alexander Couzens ] + * rspro_server: fix releasing timed out clients + + -- Oliver Smith <osmith(a)sysmocom.de> Fri, 20 Feb 2026 13:31:51 +0100 + osmo-remsim (1.1.2) unstable; urgency=medium [ Alexander Couzens ] -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42159?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I4ffcc7d6bba6fd86525dd93fc8c643d50d81b7f0 Gerrit-Change-Number: 42159 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-remsim[master]: Bump version: 1.1.2 → 1.1.3
by lynxis lazus 20 Feb '26

20 Feb '26

Attention is currently required from: osmith, pespin. lynxis lazus has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42159?usp=email ) Change subject: Bump version: 1.1.2 → 1.1.3 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42159?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I4ffcc7d6bba6fd86525dd93fc8c643d50d81b7f0 Gerrit-Change-Number: 42159 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Feb 2026 12:33:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-remsim[master]: Bump version: 1.1.2 → 1.1.3
by osmith 20 Feb '26

20 Feb '26

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42158?usp=email ) Change subject: Bump version: 1.1.2 → 1.1.3 ...................................................................... Abandoned new: https://gerrit.osmocom.org/c/osmo-remsim/+/42159 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ibc9d5efa85def78cfc3f1f09f0cde46aa7cfbd3c Gerrit-Change-Number: 42158 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[S] Change in osmo-remsim[master]: Bump version: 1.1.2 → 1.1.3
by osmith 20 Feb '26

20 Feb '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42159?usp=email ) Change subject: Bump version: 1.1.2 → 1.1.3 ...................................................................... Bump version: 1.1.2 → 1.1.3 Change-Id: I4ffcc7d6bba6fd86525dd93fc8c643d50d81b7f0 --- M debian/changelog 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/59/42159/1 diff --git a/debian/changelog b/debian/changelog index ad0056f..961152f 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,13 @@ +osmo-remsim (1.1.3) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * rspro_server.c: Fix missing include for inet_ntoa() + + [ Alexander Couzens ] + * rspro_server: fix releasing timed out clients + + -- Oliver Smith <osmith(a)sysmocom.de> Fri, 20 Feb 2026 13:31:51 +0100 + osmo-remsim (1.1.2) unstable; urgency=medium [ Alexander Couzens ] -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42159?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I4ffcc7d6bba6fd86525dd93fc8c643d50d81b7f0 Gerrit-Change-Number: 42159 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-remsim[master]: rspro_server: fix releasing timed out clients
by lynxis lazus 20 Feb '26

20 Feb '26

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42133?usp=email ) Change subject: rspro_server: fix releasing timed out clients ...................................................................... rspro_server: fix releasing timed out clients Fix crash on reconnects of clients if they timed out. The duplicate check will use conn->peer of the old peer, but conn->peer is NULL because rspro_client_conn_destroy() never destroys the connection if conn->peer is valid when rspro_client_conn_destroy() is called. void rspro_client_conn_destroy(conn) { if (conn->peer) { peer = conn->peer; conn->peer = NULL; osmo_stream_srv_destroy(peer); /* calls sock_closed_cb() } [..] } int sock_closed_cb(peer) { [..] if (conn->peer) { osmo_fsm_inst_dispatch(conn->fi, CLNTC_E_TCP_DOWN, NULL); /* calls in the end rspro_client_conn_destroy() */ } return 0; } Re-organize the clean up: * rspro_client_conn_destroy() will be only called by the FSM clean up * closed_cb will inform the fi to clean up Fixes: 8cfe1d808a57 ("Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif") Related: OS#6957 Change-Id: I1f7faf5ffdd909362c492ab434b63fa7e79ada95 --- M src/server/rspro_server.c 1 file changed, 11 insertions(+), 8 deletions(-) Approvals: osmith: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c index 4e3666c..70d59c1 100644 --- a/src/server/rspro_server.c +++ b/src/server/rspro_server.c @@ -763,18 +763,21 @@ { struct rspro_client_conn *conn = osmo_stream_srv_get_data(peer); OSMO_ASSERT(conn); + osmo_stream_srv_set_data(peer, NULL); if (conn->ka_fi) { osmo_ipa_ka_fsm_stop(conn->ka_fi); osmo_ipa_ka_fsm_free(conn->ka_fi); conn->ka_fi = NULL; } - if (conn->fi) { - if (conn->peer) { - conn->peer = NULL; + + if (conn->peer) { + conn->peer = NULL; + if (conn->fi) osmo_fsm_inst_dispatch(conn->fi, CLNTC_E_TCP_DOWN, NULL); - } /* else: rspro conn is already being destroyed, do nothing. */ } + /* else: rspro conn is already being destroyed, do nothing. */ + return 0; } @@ -920,13 +923,13 @@ /* only to be used by the FSM cleanup. */ static void rspro_client_conn_destroy(struct rspro_client_conn *conn) { - /* this will internally call closed_cb() which will dispatch a TCP_DOWN event */ + /* only the FSM should call this in the clean up, when conn->fi is already NULL */ + OSMO_ASSERT(conn->fi == NULL); + if (conn->peer) { struct osmo_stream_srv *peer = conn->peer; - conn->peer = NULL; osmo_stream_srv_destroy(peer); - return; - } /* else: destroy initiated by conn->peer's closed_cb(). */ + } /* ensure all slotmaps are unlinked + returned to NEW or deleted */ slotmaps_wrlock(conn->srv->slotmaps); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42133?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I1f7faf5ffdd909362c492ab434b63fa7e79ada95 Gerrit-Change-Number: 42133 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log February 2026