February 2026 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-abis[master]: Add CAS channel support
by jolly 01 Feb '26

01 Feb '26

Attention is currently required from: jolly, laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/41140?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review-1 by pespin, Verified-1 by Jenkins Builder Change subject: Add CAS channel support ...................................................................... Add CAS channel support CAS is currently supported by e1d driver only. Change-Id: I81cc89e01bb4207dc899ab28f24a131f24b61c9c --- M TODO-RELEASE M include/osmocom/abis/e1_input.h M src/e1_input.c M src/input/e1d.c 4 files changed, 46 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/40/41140/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41140?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I81cc89e01bb4207dc899ab28f24a131f24b61c9c Gerrit-Change-Number: 41140 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in osmo-e1d[master]: Add Channel-Associated Signalling (CAS) support
by jolly 01 Feb '26

01 Feb '26

Attention is currently required from: jolly, tnt. Hello Jenkins Builder, laforge, tnt, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-e1d/+/41139?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Add Channel-Associated Signalling (CAS) support ...................................................................... Add Channel-Associated Signalling (CAS) support CAS frames are sent and received repeatedly. They consist of 16 frames (octets) on time slot 16. This is a CAS multiframe. This multiframe carries 30 individual CAS signaling channels. Whenever a CAS frames changes, an event (E1DP_EVT_CAS) is forwarded to the e1d client. The event includes one octet with the CAS information. The e1d client requests to transmit a new CAS frame by sending a command (E1DP_CMD_CAS). The command includes one octet with the CAS information. The e1d client requests to receive current CAS frame of a given time slot by setting a query flag in the E1DP_CMD_CAS command. This is useful if the CAS signals changed before the application was started. The lower 4 bits of each octet in the message represent the signaling sub-channels: A, B, C and D. They are packed like this: 'xxxxABCD' To enable cas support on an interface, set line attribute "cas" via VTY. Change-Id: Ib4f5e6ef02c9b0d1eec2a86d9c48376112805972 --- M TODO-RELEASE M include/osmocom/e1d/proto.h M include/osmocom/e1d/proto_clnt.h M src/ctl.c M src/e1d.h M src/intf_line.c M src/mux_demux.c M src/proto.c M src/proto_clnt.c M src/vty.c 10 files changed, 270 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/39/41139/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/41139?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib4f5e6ef02c9b0d1eec2a86d9c48376112805972 Gerrit-Change-Number: 41139 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: tnt <tnt(a)246tNt.com>

1 0

[XS] Change in dahdi-linux[master]: wctdb24xxp/xhfc.c: Fix uninitialized variable
by laforge 01 Feb '26

01 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42001?usp=email ) Change subject: wctdb24xxp/xhfc.c: Fix uninitialized variable ...................................................................... wctdb24xxp/xhfc.c: Fix uninitialized variable This fixes a compiler error when building for kernel v6.2: In function ‘xhfc_getreg’, inlined from ‘b400m_probe’ at dahdi-linux/drivers/dahdi/wctdm24xxp/xhfc.c:2563:7: dahdi-linux/drivers/dahdi/wctdm24xxp/xhfc.c:624:12: error: ‘x’ is used uninitialized [-Werror=uninitialized] 624 | if (*lastreg != (unsigned char)addr) { | ^ dahdi-linux/drivers/dahdi/wctdm24xxp/xhfc.c: In function ‘b400m_probe’: dahdi-linux/drivers/dahdi/wctdm24xxp/xhfc.c:2557:27: note: ‘x’ was declared here 2557 | unsigned char id, x; | ^ Change-Id: I49ca7825ab238333b7d55b0ce5cae5e9e92a2cfb --- M drivers/dahdi/wctdm24xxp/xhfc.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/drivers/dahdi/wctdm24xxp/xhfc.c b/drivers/dahdi/wctdm24xxp/xhfc.c index d37fbd5..3fd2a96 100644 --- a/drivers/dahdi/wctdm24xxp/xhfc.c +++ b/drivers/dahdi/wctdm24xxp/xhfc.c @@ -2554,7 +2554,7 @@ static int b400m_probe(struct wctdm *wc, int modpos) { - unsigned char id, x; + unsigned char id, x = 0; struct b400m *b4; unsigned long flags; int chiprev; -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42001?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I49ca7825ab238333b7d55b0ce5cae5e9e92a2cfb Gerrit-Change-Number: 42001 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in dahdi-linux[master]: dahdi_base.c: Avoid unnecessary strlen call when with strncat.
by laforge 01 Feb '26

01 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/41999?usp=email ) Change subject: dahdi_base.c: Avoid unnecessary strlen call when with strncat. ...................................................................... dahdi_base.c: Avoid unnecessary strlen call when with strncat. It is not necessary to call strlen on the destination buffer when calling strncat. Resolves: #89 Change-Id: Idd3e6145682e276abb9bc67029df974197bf8b1b --- M drivers/dahdi/dahdi-base.c 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/drivers/dahdi/dahdi-base.c b/drivers/dahdi/dahdi-base.c index 0aa1de7..6411e52 100644 --- a/drivers/dahdi/dahdi-base.c +++ b/drivers/dahdi/dahdi-base.c @@ -5449,14 +5449,12 @@ */ continue; } - strncat(vi.echo_canceller + strlen(vi.echo_canceller), - ec_name, space); + strncat(vi.echo_canceller, ec_name, space); space -= strlen(ec_name); if (space < 1) break; if (cur->list.next && (cur->list.next != &ecfactory_list)) { - strncat(vi.echo_canceller + strlen(vi.echo_canceller), - ", ", space); + strncat(vi.echo_canceller, ", ", space); space -= 2; if (space < 1) break; -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/41999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Idd3e6145682e276abb9bc67029df974197bf8b1b Gerrit-Change-Number: 41999 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in dahdi-linux[master]: dahdi-base: Use strncpy instead of strncat for beginning of buffer
by laforge 01 Feb '26

01 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42000?usp=email ) Change subject: dahdi-base: Use strncpy instead of strncat for beginning of buffer ...................................................................... dahdi-base: Use strncpy instead of strncat for beginning of buffer This fixes a build failure I observe with kernel v6.2: from dahdi-linux/drivers/dahdi/dahdi-base.c:40: ./include/linux/fortify-string.h:388:32: note: expected ‘char *’ but argument is of type ‘long unsigned int’ 388 | char *strncat(char * const POS p, const char * const POS q, __kernel_size_t count) | ~~~~~~~~~~~~~~~~~^ make[2]: *** [scripts/Makefile.build:252: dahdi-linux/drivers/dahdi/dahdi-base.o] Error 1 Change-Id: I539167b46f265d3c8e6dc52c978f39d58c37405f --- M drivers/dahdi/dahdi-base.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/drivers/dahdi/dahdi-base.c b/drivers/dahdi/dahdi-base.c index 6411e52..a0238e6 100644 --- a/drivers/dahdi/dahdi-base.c +++ b/drivers/dahdi/dahdi-base.c @@ -5449,7 +5449,7 @@ */ continue; } - strncat(vi.echo_canceller, ec_name, space); + strncpy(vi.echo_canceller, ec_name, space); space -= strlen(ec_name); if (space < 1) break; -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42000?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I539167b46f265d3c8e6dc52c978f39d58c37405f Gerrit-Change-Number: 42000 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in dahdi-linux[master]: wctdb24xxp/xhfc.c: Fix uninitialized variable
by laforge 01 Feb '26

01 Feb '26

laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42001?usp=email ) Change subject: wctdb24xxp/xhfc.c: Fix uninitialized variable ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42001?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: deleteVote Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I49ca7825ab238333b7d55b0ce5cae5e9e92a2cfb Gerrit-Change-Number: 42001 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in dahdi-linux[master]: wctdb24xxp/xhfc.c: Fix uninitialized variable
by laforge 01 Feb '26

01 Feb '26

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42001?usp=email ) Change subject: wctdb24xxp/xhfc.c: Fix uninitialized variable ...................................................................... Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42001?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I49ca7825ab238333b7d55b0ce5cae5e9e92a2cfb Gerrit-Change-Number: 42001 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 01 Feb 2026 10:41:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in dahdi-linux[master]: dahdi-base: Use strncpy instead of strncat for beginning of buffer
by laforge 01 Feb '26

01 Feb '26

laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42000?usp=email ) Change subject: dahdi-base: Use strncpy instead of strncat for beginning of buffer ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42000?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: deleteVote Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I539167b46f265d3c8e6dc52c978f39d58c37405f Gerrit-Change-Number: 42000 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in dahdi-linux[master]: dahdi-base: Use strncpy instead of strncat for beginning of buffer
by laforge 01 Feb '26

01 Feb '26

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42000?usp=email ) Change subject: dahdi-base: Use strncpy instead of strncat for beginning of buffer ...................................................................... Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42000?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I539167b46f265d3c8e6dc52c978f39d58c37405f Gerrit-Change-Number: 42000 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 01 Feb 2026 10:40:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in dahdi-linux[master]: dahdi_base.c: Avoid unnecessary strlen call when with strncat.
by laforge 01 Feb '26

01 Feb '26

laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/41999?usp=email ) Change subject: dahdi_base.c: Avoid unnecessary strlen call when with strncat. ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/41999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: deleteVote Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Idd3e6145682e276abb9bc67029df974197bf8b1b Gerrit-Change-Number: 41999 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log February 2026