February 2026 - gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: saip-tool: rename parser_tree correctly
by lynxis lazus 05 Feb '26

05 Feb '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42065?usp=email ) Change subject: saip-tool: rename parser_tree correctly ...................................................................... saip-tool: rename parser_tree correctly parser_info is already defined and this seems to be a copy/paste accident. Change-Id: Icc30dbf02a266211fa4d3aee8e7cec14185e716c --- M contrib/saip-tool.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/65/42065/1 diff --git a/contrib/saip-tool.py b/contrib/saip-tool.py index 71113d3..a4af001 100755 --- a/contrib/saip-tool.py +++ b/contrib/saip-tool.py @@ -107,7 +107,7 @@ parser_esrv.add_argument('--add-flag', default=[], choices=esrv_flag_choices, action='append', help='Add flag to mandatory services list') parser_esrv.add_argument('--remove-flag', default=[], choices=esrv_flag_choices, action='append', help='Remove flag from mandatory services list') -parser_info = subparsers.add_parser('tree', help='Display the filesystem tree') +parser_tree = subparsers.add_parser('tree', help='Display the filesystem tree') def write_pes(pes: ProfileElementSequence, output_file:str): """write the PE sequence to a file""" -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42065?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icc30dbf02a266211fa4d3aee8e7cec14185e716c Gerrit-Change-Number: 42065 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Fix asp selection if no tcap-range was found
by pespin 05 Feb '26

05 Feb '26

Attention is currently required from: daniel. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064?usp=email ) Change subject: tcap_as_loadshare: Fix asp selection if no tcap-range was found ...................................................................... Patch Set 1: (1 comment) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064/comment/de9ec6d0_acd54… : PS1, Line 247: return asp; > How do you return back a NULL in case non of the given asp is valid? ACK. It probably makes sense to assign last_asp_idx_sent and return asp inside the condition in the loop, and return NULL here. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I07e77548ecb75df9227487901b75018261bd1232 Gerrit-Change-Number: 42064 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Feb 2026 16:54:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Fix asp selection if no tcap-range was found
by lynxis lazus 05 Feb '26

05 Feb '26

Attention is currently required from: daniel, pespin. lynxis lazus has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064?usp=email ) Change subject: tcap_as_loadshare: Fix asp selection if no tcap-range was found ...................................................................... Patch Set 1: (2 comments) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064/comment/f7812d17_19c12… : PS1, Line 233: struct osmo_ss7_asp *asp; I would also set it to NULL https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064/comment/6ec7c0a0_35778… : PS1, Line 247: return asp; How do you return back a NULL in case non of the given asp is valid? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I07e77548ecb75df9227487901b75018261bd1232 Gerrit-Change-Number: 42064 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Feb 2026 16:38:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Fix asp selection if no tcap-range was found
by daniel 05 Feb '26

05 Feb '26

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064?usp=email ) Change subject: tcap_as_loadshare: Fix asp selection if no tcap-range was found ...................................................................... tcap_as_loadshare: Fix asp selection if no tcap-range was found Keep doing loadshare round-robin style, but select only active asps that have tcap enabled in the config. Related: SYS#5423 Change-Id: I07e77548ecb75df9227487901b75018261bd1232 --- M src/ss7_as.h M src/tcap_as_loadshare.c 2 files changed, 12 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/64/42064/1 diff --git a/src/ss7_as.h b/src/ss7_as.h index 50df338..252e863 100644 --- a/src/ss7_as.h +++ b/src/ss7_as.h @@ -159,6 +159,7 @@ struct { bool enabled; unsigned int timeout_s; + uint8_t last_asp_idx_sent; } tcap; #endif /* WITH_TCAP_LOADSHARING */ } loadshare; diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 623bd3b..d1daaeb 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -230,15 +230,19 @@ static struct osmo_ss7_asp *find_asp_no_tcap_range(struct osmo_ss7_as *as) { - struct osmo_ss7_asp *asp = NULL; + struct osmo_ss7_asp *asp; + unsigned int i; + unsigned int first_idx; - for (int i = 0; i < ARRAY_SIZE(as->cfg.asps); i++) { + first_idx = (as->cfg.loadshare.tcap.last_asp_idx_sent + 1) % ARRAY_SIZE(as->cfg.asps); + i = first_idx; + do { asp = as->cfg.asps[i]; - if (!asp) - continue; - if (!asp->tcap.enabled) - return asp; - } + if (asp && osmo_ss7_asp_active(asp) && asp->tcap.enabled) + break; + i = (i + 1) % ARRAY_SIZE(as->cfg.asps); + } while (i != first_idx); + as->cfg.loadshare.tcap.last_asp_idx_sent = i; return asp; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42064?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I07e77548ecb75df9227487901b75018261bd1232 Gerrit-Change-Number: 42064 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>

1 0

[M] Change in osmo-bts[master]: power_control: lchan_ms_pwr_ctrl(): always log input values
by fixeria 05 Feb '26

05 Feb '26

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42061?usp=email ) Change subject: power_control: lchan_ms_pwr_ctrl(): always log input values ...................................................................... Patch Set 2: (1 comment) File src/common/power_control.c: https://gerrit.osmocom.org/c/osmo-bts/+/42061/comment/ce48ffd3_c87009de?usp… : PS1, Line 233: LOGPLCHAN(lchan, DLOOP, LOGL_INFO, "Rx UL Measurement Report: " > Good catch. `LOGL_DEBUG` was my original intention but I forgot to change it. Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42061?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3b8466f062624fc8a2ea6f8220c057d3812f2c35 Gerrit-Change-Number: 42061 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Feb 2026 14:53:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-bts[master]: power_control: lchan_ms_pwr_ctrl(): always log input values
by pespin 05 Feb '26

05 Feb '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42061?usp=email ) Change subject: power_control: lchan_ms_pwr_ctrl(): always log input values ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42061?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3b8466f062624fc8a2ea6f8220c057d3812f2c35 Gerrit-Change-Number: 42061 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Feb 2026 14:52:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bts[master]: power_control: lchan_ms_pwr_ctrl(): always log input values
by fixeria 05 Feb '26

05 Feb '26

Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/42061?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: power_control: lchan_ms_pwr_ctrl(): always log input values ...................................................................... power_control: lchan_ms_pwr_ctrl(): always log input values Depending on the power control interval (P_Con_INTERVAL), the MS power loop may delay the power control decision for a certain amount of SACCH block periods. In this case lchan_ms_pwr_ctrl() returns early and no logging is printed at all. Let's always log the input values (reported level, UL measurements) early in lchan_ms_pwr_ctrl(). This is useful for debugging, and this is exactly what lchan_bs_pwr_ctrl() does. Change-Id: I3b8466f062624fc8a2ea6f8220c057d3812f2c35 --- M src/common/power_control.c M tests/power/ms_power_loop_test.err 2 files changed, 82 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/61/42061/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42061?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3b8466f062624fc8a2ea6f8220c057d3812f2c35 Gerrit-Change-Number: 42061 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-bts[master]: power_control: lchan_ms_pwr_ctrl(): always log input values
by fixeria 05 Feb '26

05 Feb '26

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42061?usp=email ) Change subject: power_control: lchan_ms_pwr_ctrl(): always log input values ...................................................................... Patch Set 1: (1 comment) File src/common/power_control.c: https://gerrit.osmocom.org/c/osmo-bts/+/42061/comment/a5139c51_2079a79d?usp… : PS1, Line 233: LOGPLCHAN(lchan, DLOOP, LOGL_INFO, "Rx UL Measurement Report: " > shouldn't this be LOGL_DEBUG? Good catch. `LOGL_DEBUG` was my original intention but I forgot to change it. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42061?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3b8466f062624fc8a2ea6f8220c057d3812f2c35 Gerrit-Change-Number: 42061 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Feb 2026 14:51:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-bts[master]: power_control: lchan_ms_pwr_ctrl(): always log input values
by pespin 05 Feb '26

05 Feb '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42061?usp=email ) Change subject: power_control: lchan_ms_pwr_ctrl(): always log input values ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/common/power_control.c: https://gerrit.osmocom.org/c/osmo-bts/+/42061/comment/3b736e37_44b80f95?usp… : PS1, Line 233: LOGPLCHAN(lchan, DLOOP, LOGL_INFO, "Rx UL Measurement Report: " shouldn't this be LOGL_DEBUG? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42061?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3b8466f062624fc8a2ea6f8220c057d3812f2c35 Gerrit-Change-Number: 42061 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Feb 2026 14:48:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: hnbgw: expected-results.xml: Add missing TC_sccp_cr_limit
by pespin 05 Feb '26

05 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42063?usp=email ) Change subject: hnbgw: expected-results.xml: Add missing TC_sccp_cr_limit ...................................................................... hnbgw: expected-results.xml: Add missing TC_sccp_cr_limit Change-Id: I4138cff311f82358f040290f3af483df8facc4cf --- M hnbgw/expected-results.xml 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/63/42063/1 diff --git a/hnbgw/expected-results.xml b/hnbgw/expected-results.xml index f1fe858..fb61c8f 100644 --- a/hnbgw/expected-results.xml +++ b/hnbgw/expected-results.xml @@ -14,6 +14,7 @@ <testcase classname='HNBGW_Tests' name='TC_ranap_ps_initial_ue_empty_cr' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ranap_cs_bidir' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ranap_ps_bidir' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_sccp_cr_limit' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_rab_assignment' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_rab_assignment_concurrent' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_rab_release' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42063?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4138cff311f82358f040290f3af483df8facc4cf Gerrit-Change-Number: 42063 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log February 2026