lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

November 2026

  • 1 participants
  • 714 discussions
[S] Change in libosmocore[master]: core: osmo_init_logging2(): Log talloc output through osmo_logging sy...
by fixeria 20 Nov '26

20 Nov '26
Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/44137?usp=email ) Change subject: core: osmo_init_logging2(): Log talloc output through osmo_logging system ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/44137?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibe85438616d731636579981cce3756922295f48a Gerrit-Change-Number: 44137 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Nov 2026 12:48:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in osmo-sgsn[master]: sgsn_libgtp: encode IMEISV via a local LV buffer
by laforge 20 Nov '26

20 Nov '26
Attention is currently required from: bucketking657. laforge has posted comments on this change by bucketking657. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/44150?usp=email ) Change subject: sgsn_libgtp: encode IMEISV via a local LV buffer ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/44150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ied06aa05ee6850ec0df34a51cdce6df12e0b594c Gerrit-Change-Number: 44150 Gerrit-PatchSet: 3 Gerrit-Owner: bucketking657 <joshuashilts(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: bucketking657 <joshuashilts(a)gmail.com> Gerrit-Comment-Date: Fri, 20 Nov 2026 12:42:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in libosmocore[master]: gb: ns2: clamp embedded NS PDU to msgb tailroom
by laforge 20 Nov '26

20 Nov '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/44138?usp=email ) Change subject: gb: ns2: clamp embedded NS PDU to msgb tailroom ...................................................................... gb: ns2: clamp embedded NS PDU to msgb tailroom Per TS 48.016 9.2.7.2 an NS-STATUS PDU embeds the PDU that caused the error. reject_status_msg() copies it in without any length check, and ns2_tx_status() clamps it against nsvc->bind->mtu only, not against the space left in the reply msgb. For an NS-over-IP bind that MTU is 65527 (gprs_ns2_udp.c:344), while the STATUS msgb from ns2_msgb_alloc() offers 3052 usable bytes (NS_ALLOC_SIZE 3072 minus NS_ALLOC_HEADROOM 20), of which 3048 remain after the NS header and the Cause IE. A received PDU of 3046 bytes or more therefore makes msgb_tvlv_put() -> msgb_put() hit MSGB_ABORT, which aborts the process. No NS-VC, handshake or credentials are needed to reach either site. Clamp against the msgb tailroom in both places, and use a saturating clamp instead of a subtraction on an unsigned (the old form could underflow if the MTU were smaller than the message built so far). bssgp_tx_status() in the same tree already does this correctly via OSMO_MIN(..., msgb_tailroom(msg) - 3). Fixes: 6a161497cfd8cacfef10c2e81cff85a45447e107 Change-Id: Iac1c5c15875f30f34d0f7e9fc74264530a02b6ae --- M src/gb/gprs_ns2.c M src/gb/gprs_ns2_message.c 2 files changed, 32 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c index 4e496c1..8d77e9e 100644 --- a/src/gb/gprs_ns2.c +++ b/src/gb/gprs_ns2.c @@ -751,10 +751,21 @@ case NS_CAUSE_PDU_INCOMP_PSTATE: case NS_CAUSE_PROTO_ERR_UNSPEC: case NS_CAUSE_INVAL_ESSENT_IE: - case NS_CAUSE_MISSING_ESSENT_IE: - msgb_tvlv_put(msg, NS_IE_PDU, msgb_l2len(orig_msg), - orig_msg->l2h); + case NS_CAUSE_MISSING_ESSENT_IE: { + /* The original PDU can be larger than what is left in our own + * msgb (NS_ALLOC_SIZE), so clamp it. TvLV header is 3 bytes. */ + const unsigned int avail = msgb_tailroom(msg); + unsigned int embed_len = msgb_l2len(orig_msg); + + if (avail < 3) + embed_len = 0; + else if (avail < 3 + embed_len) + embed_len = avail - 3; + + if (embed_len > 0) + msgb_tvlv_put(msg, NS_IE_PDU, embed_len, orig_msg->l2h); break; + } default: break; } diff --git a/src/gb/gprs_ns2_message.c b/src/gb/gprs_ns2_message.c index de63b7a..0fa2e26 100644 --- a/src/gb/gprs_ns2_message.c +++ b/src/gb/gprs_ns2_message.c @@ -426,7 +426,7 @@ struct msgb *msg = ns2_msgb_alloc(); struct gprs_ns_hdr *nsh; uint16_t encoded_nsvci; - unsigned int orig_len, max_orig_len; + unsigned int orig_len, avail; log_set_context(LOG_CTX_GB_NSE, nsvc->nse); log_set_context(LOG_CTX_GB_NSVC, nsvc); @@ -458,12 +458,24 @@ case NS_CAUSE_INVAL_ESSENT_IE: case NS_CAUSE_MISSING_ESSENT_IE: /* Section 9.2.7.2: Static conditions for NS PDU */ - /* ensure the PDU doesn't exceed the MTU */ + /* Trim available space to the MTU. bind->mtu can be far larger + * than NS_ALLOC_SIZE (65527 for NS-over-IP), so the msgb + * tailroom is the other bound we need. */ + avail = msgb_tailroom(msg); + if (msgb_length(msg) > nsvc->bind->mtu) + avail = 0; + else if (nsvc->bind->mtu - msgb_length(msg) < avail) + avail = nsvc->bind->mtu - msgb_length(msg); + + /* Figure out how many origin PDU bytes fit; TvLV header is 3 bytes: */ orig_len = msgb_l2len(orig_msg); - max_orig_len = msgb_length(msg) + TVLV_GROSS_LEN(orig_len); - if (max_orig_len > nsvc->bind->mtu) - orig_len -= max_orig_len - nsvc->bind->mtu; - msgb_tvlv_put(msg, NS_IE_PDU, orig_len, orig_msg->l2h); + if (avail < 3) + orig_len = 0; + else if (avail < 3 + orig_len) + orig_len = avail - 3; + + if (orig_len > 0) + msgb_tvlv_put(msg, NS_IE_PDU, orig_len, orig_msg->l2h); break; case NS_CAUSE_BVCI_UNKNOWN: /* Section 9.2.7.3: Static conditions for BVCI */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/44138?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iac1c5c15875f30f34d0f7e9fc74264530a02b6ae Gerrit-Change-Number: 44138 Gerrit-PatchSet: 3 Gerrit-Owner: ws1004 <ws1004(a)kakao.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <daniel(a)totalueberwachung.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in libosmocore[master]: gb: ns2: clamp embedded NS PDU to msgb tailroom
by laforge 20 Nov '26

20 Nov '26
Attention is currently required from: daniel, fixeria, lynxis, ws1004. laforge has posted comments on this change by ws1004. ( https://gerrit.osmocom.org/c/libosmocore/+/44138?usp=email ) Change subject: gb: ns2: clamp embedded NS PDU to msgb tailroom ...................................................................... Patch Set 3: (1 comment) File src/gb/gprs_ns2_message.c: https://gerrit.osmocom.org/c/libosmocore/+/44138/comment/aca8e34d_a800b890?… : PS3, Line 464: avail = msgb_tailroom(msg); > Happy to use the same shape here for consistency, and PS3 does that. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/44138?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iac1c5c15875f30f34d0f7e9fc74264530a02b6ae Gerrit-Change-Number: 44138 Gerrit-PatchSet: 3 Gerrit-Owner: ws1004 <ws1004(a)kakao.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <daniel(a)totalueberwachung.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis <lynxis(a)fe80.eu> Gerrit-Attention: daniel <daniel(a)totalueberwachung.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: ws1004 <ws1004(a)kakao.com> Gerrit-Comment-Date: Fri, 20 Nov 2026 12:42:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ws1004 <ws1004(a)kakao.com>
1 0
0 0
[S] Change in pysim[master]: esim/asn1/rsp: add the two types the SGP.32 module imports
by laforge 20 Nov '26

20 Nov '26
Attention is currently required from: dexter, hampushellsberg. laforge has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44008?usp=email ) Change subject: esim/asn1/rsp: add the two types the SGP.32 module imports ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44008?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I23d8c7e061a5573caa750fe76a6e8756ddbf0898 Gerrit-Change-Number: 44008 Gerrit-PatchSet: 2 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Comment-Date: Fri, 20 Nov 2026 12:41:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XL] Change in pysim[master]: esim/asn1: add the SGP.22 v3.1 RSPDefinitions module as rsp_v3
by laforge 20 Nov '26

20 Nov '26
Attention is currently required from: dexter, hampushellsberg. laforge has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44007?usp=email ) Change subject: esim/asn1: add the SGP.22 v3.1 RSPDefinitions module as rsp_v3 ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File pySim/esim/rsp.py: https://gerrit.osmocom.org/c/pysim/+/44007/comment/1bee60b0_fc35bfc1?usp=em… : PS1, Line 35: asn1_v3 > There is: since Python 3. […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44007?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I670ec73f9958882a8d3fe4b589bdafa3fbf702ea Gerrit-Change-Number: 44007 Gerrit-PatchSet: 2 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Comment-Date: Fri, 20 Nov 2026 12:40:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: hampushellsberg <hampushellsberg(a)gmail.com>
1 0
0 0
[S] Change in pysim[master]: esim.bsp: keep encrypted segments within 1020 bytes
by laforge 20 Nov '26

20 Nov '26
Attention is currently required from: dexter, hampushellsberg. laforge has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44153?usp=email ) Change subject: esim.bsp: keep encrypted segments within 1020 bytes ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44153?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie59a8fb3d6cefc079e4e065d8ab9bd9cec886513 Gerrit-Change-Number: 44153 Gerrit-PatchSet: 2 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Comment-Date: Fri, 20 Nov 2026 12:39:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in pysim[master]: esim.bsp: keep encrypted segments within 1020 bytes
by laforge 20 Nov '26

20 Nov '26
laforge has uploaded a new patch set (#2) to the change originally created by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44153?usp=email ) Change subject: esim.bsp: keep encrypted segments within 1020 bytes ...................................................................... esim.bsp: keep encrypted segments within 1020 bytes SGP.22 limits a segment to 1020 bytes including tag, length field and MAC, which leaves 1008 bytes for the ciphertext. encrypt_and_mac() cut the plaintext at 1008 bytes; the mandatory '80' padding then added a whole block and the segment got 1036 bytes long. An eUICC that enforces the limit can refuse the first such segment of a profile. Cut encrypted plaintext at 1007 bytes; MAC-only segments keep 1008. The folder osmocom-pysim-bsp-segment-size of hampushellsberg-dev/PySIM-upstream-patches on GitHub has the analysis and a repro. Change-Id: Ie59a8fb3d6cefc079e4e065d8ab9bd9cec886513 Closes: OS#7120 --- M pySim/esim/bsp.py M tests/unittests/test_esim_bsp.py 2 files changed, 37 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/53/44153/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44153?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie59a8fb3d6cefc079e4e065d8ab9bd9cec886513 Gerrit-Change-Number: 44153 Gerrit-PatchSet: 2 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Reviewer: Jenkins Builder
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: nssf: Remove unneeded file open5gs-eir.yaml
by pespin 20 Nov '26

20 Nov '26
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44151?usp=email ) Change subject: nssf: Remove unneeded file open5gs-eir.yaml ...................................................................... nssf: Remove unneeded file open5gs-eir.yaml This file was wrongly added when creating the testsuite. Change-Id: Ic4bb24c2791be8cc0821c2366ebf9aee433f9c6b --- D nssf/open5gs-eir.yaml 1 file changed, 0 insertions(+), 18 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/nssf/open5gs-eir.yaml b/nssf/open5gs-eir.yaml deleted file mode 100644 index efbef3a..0000000 --- a/nssf/open5gs-eir.yaml +++ /dev/null @@ -1,18 +0,0 @@ -db_uri: mongodb://127.0.0.103/open5gs -logger: - level: debug - -global: - max: - ue: 1024 - -eir: - sbi: - server: - - address: 127.0.0.21 - port: 7777 - client: -# nrf: -# - uri: http://127.0.0.10:7777 - scp: - - uri: http://127.0.0.200:7777 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44151?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic4bb24c2791be8cc0821c2366ebf9aee433f9c6b Gerrit-Change-Number: 44151 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-sgsn[master]: sgsn_libgtp: encode IMEISV via a local LV buffer
by pespin 20 Nov '26

20 Nov '26
Attention is currently required from: bucketking657. pespin has posted comments on this change by bucketking657. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/44150?usp=email ) Change subject: sgsn_libgtp: encode IMEISV via a local LV buffer ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/sgsn/sgsn_libgtp.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/44150/comment/b194fde7_07825bad?us… : PS3, Line 312: memcpy(&pdp->imeisv.v[0], &bcd_lv[1], pdp->imeisv.l); Maybe add an "OSMO_ASSERT(pdp->imeisv.l + 1 <= sizeof(bcd_lv));" -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/44150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ied06aa05ee6850ec0df34a51cdce6df12e0b594c Gerrit-Change-Number: 44150 Gerrit-PatchSet: 3 Gerrit-Owner: bucketking657 <joshuashilts(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: bucketking657 <joshuashilts(a)gmail.com> Gerrit-Comment-Date: Fri, 20 Nov 2026 09:08:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
1 0
0 0
  • ← Newer
  • 1
  • 2
  • 3
  • 4
  • 5
  • 6
  • ...
  • 72
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.