October 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-sgsn[master]: mm_state_gb_fsm: cosmetic
by lynxis lazus 06 Oct '26

06 Oct '26

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43661?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: mm_state_gb_fsm: cosmetic ...................................................................... mm_state_gb_fsm: cosmetic Have only one event per line and one state per line. Change-Id: I8b13c7ac3490859bb62418fbdc10a853630aa7e0 --- M src/sgsn/gprs_mm_state_gb_fsm.c 1 file changed, 10 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/61/43661/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43661?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I8b13c7ac3490859bb62418fbdc10a853630aa7e0 Gerrit-Change-Number: 43661 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-sgsn[master]: mm_state_gb_fsm: Allow Idle -> Ready transition for RA Update
by lynxis lazus 06 Oct '26

06 Oct '26

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39564?usp=email to look at the new patch set (#22). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: mm_state_gb_fsm: Allow Idle -> Ready transition for RA Update ...................................................................... mm_state_gb_fsm: Allow Idle -> Ready transition for RA Update Change-Id: Ic26d237976f51a061ac394cee1daef20db048517 --- M src/sgsn/gprs_mm_state_gb_fsm.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/64/39564/22 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39564?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic26d237976f51a061ac394cee1daef20db048517 Gerrit-Change-Number: 39564 Gerrit-PatchSet: 22 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-sgsn[master]: gprs_gmm: Set RAT on the VLR object
by lynxis lazus 06 Oct '26

06 Oct '26

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43470?usp=email to look at the new patch set (#16). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: gprs_gmm: Set RAT on the VLR object ...................................................................... gprs_gmm: Set RAT on the VLR object Will be used in GSUP messages. Change-Id: I66270d07371501afc9e6bc00c654d7612543e0ca --- M src/sgsn/gprs_gmm.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/70/43470/16 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43470?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I66270d07371501afc9e6bc00c654d7612543e0ca Gerrit-Change-Number: 43470 Gerrit-PatchSet: 16 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-sgsn[master]: On GMM_RAU_E_VLR_RAU_REJECT: terminate the RAU FSM after transmitting...
by lynxis lazus 06 Oct '26

06 Oct '26

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43701?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: On GMM_RAU_E_VLR_RAU_REJECT: terminate the RAU FSM after transmitting a FSM ...................................................................... On GMM_RAU_E_VLR_RAU_REJECT: terminate the RAU FSM after transmitting a FSM Unclear if this is the best solution, because the VLR LU fsm transmits this message and terminates afterwards. Change-Id: I4347c208edb77f1afb69e4b6f1fb563db187d916 --- M src/sgsn/gmm_rau_fsm.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/01/43701/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43701?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4347c208edb77f1afb69e4b6f1fb563db187d916 Gerrit-Change-Number: 43701 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-sgsn[master]: sgsn_vty: correct show 2nd PDP Address
by lynxis lazus 06 Oct '26

06 Oct '26

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43702?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: sgsn_vty: correct show 2nd PDP Address ...................................................................... sgsn_vty: correct show 2nd PDP Address Change-Id: If684dfa1c712e5a16bf87110b4ab582f1dab5b4d --- M src/sgsn/sgsn_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/02/43702/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43702?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: If684dfa1c712e5a16bf87110b4ab582f1dab5b4d Gerrit-Change-Number: 43702 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XL] Change in osmo-sgsn[master]: Rework SGSN code to use new libvlr code
by lynxis lazus 06 Oct '26

06 Oct '26

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email ) Change subject: Rework SGSN code to use new libvlr code ...................................................................... Patch Set 22: (4 comments) File src/sgsn/sgsn_vty.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/7c1e0f13_d1f42095?us… : PS16, Line 806: /* FIXME: do we still have ACLs? */ > what about this? afaiu in the commit message you said we removed it? Then all this needs to be depre […] Moved the ACL removal commit into here. https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/33490f37_27d14aad?us… : PS16, Line 985: /* FIXME: reset VLR */ > what about this? Done https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/63df856e_a81b561d?us… : PS16, Line 1003: /* FIXME list VLR or MMctx */ > what about this? Done File src/sgsn/sgsn_vty.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/ed2028cb_40e0e512?us… : PS20, Line 1088: if (pdp->pdp_address[0].u.sa.sa_family != AF_UNSPEC) > I'm totally lost here. […] This commit never changed this, so this bugfix would be done in a separate commit. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9c5b4ec1b337c35e85c2d1a3d09b318380ae6ef8 Gerrit-Change-Number: 39562 Gerrit-PatchSet: 22 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Oct 2026 13:57:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ci[master]: publish-manuals-for-tags: build osmo-msc with SMPP
by fixeria 06 Oct '26

06 Oct '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/43793?usp=email ) Change subject: publish-manuals-for-tags: build osmo-msc with SMPP ...................................................................... publish-manuals-for-tags: build osmo-msc with SMPP ... so that the related commands appear in the VTY reference PDFs. Change-Id: Ia4cfa432107509aec0a42f0259747c77d24ef6c8 Related: OS#7094 --- M scripts/manuals/publish-manuals-for-tags.sh 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/scripts/manuals/publish-manuals-for-tags.sh b/scripts/manuals/publish-manuals-for-tags.sh index d375989..426d9bb 100755 --- a/scripts/manuals/publish-manuals-for-tags.sh +++ b/scripts/manuals/publish-manuals-for-tags.sh @@ -278,7 +278,10 @@ osmo-hnbgw) echo "--enable-pfcp" ;; - osmo-msc|osmo-sgsn) + osmo-msc) + echo "--enable-iu --enable-smpp" + ;; + osmo-sgsn) echo "--enable-iu" ;; osmo-trx) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43793?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia4cfa432107509aec0a42f0259747c77d24ef6c8 Gerrit-Change-Number: 43793 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: publish-manuals-for-tags: build osmo-msc with SMPP
by osmith 06 Oct '26

06 Oct '26

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/43793?usp=email ) Change subject: publish-manuals-for-tags: build osmo-msc with SMPP ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43793?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia4cfa432107509aec0a42f0259747c77d24ef6c8 Gerrit-Change-Number: 43793 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Oct 2026 12:45:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: publish-manuals-for-tags: build osmo-msc with SMPP
by fixeria 06 Oct '26

06 Oct '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/43793?usp=email ) Change subject: publish-manuals-for-tags: build osmo-msc with SMPP ...................................................................... publish-manuals-for-tags: build osmo-msc with SMPP ... so that the related commands appear in the VTY reference PDFs. Change-Id: Ia4cfa432107509aec0a42f0259747c77d24ef6c8 Related: OS#7094 --- M scripts/manuals/publish-manuals-for-tags.sh 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/93/43793/1 diff --git a/scripts/manuals/publish-manuals-for-tags.sh b/scripts/manuals/publish-manuals-for-tags.sh index d375989..426d9bb 100755 --- a/scripts/manuals/publish-manuals-for-tags.sh +++ b/scripts/manuals/publish-manuals-for-tags.sh @@ -278,7 +278,10 @@ osmo-hnbgw) echo "--enable-pfcp" ;; - osmo-msc|osmo-sgsn) + osmo-msc) + echo "--enable-iu --enable-smpp" + ;; + osmo-sgsn) echo "--enable-iu" ;; osmo-trx) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43793?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia4cfa432107509aec0a42f0259747c77d24ef6c8 Gerrit-Change-Number: 43793 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in dahdi-linux[master]: drivers/dahdi/icE1usb: defer USB transfer when setting loopback mode
by manawyrm 06 Oct '26

06 Oct '26

manawyrm has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/43642?usp=email ) Change subject: drivers/dahdi/icE1usb: defer USB transfer when setting loopback mode ...................................................................... drivers/dahdi/icE1usb: defer USB transfer when setting loopback mode The icE1usb driver would deadlock/hang the kernel when trying to configure a internal loopback mode via the "dahdi_maint" utility. Previously, it tried to do a USB transfer without enabled interrupts inside a spinlock, which caused the infinite hang. This change moves the ice1usb_tx_config() call to a workqueue. Change-Id: Iba99fc5261059c77cc89d867b21c70a34c9b4ea6 --- M drivers/dahdi/icE1usb/icE1usb.c 1 file changed, 26 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve tnt: Looks good to me, approved Jenkins Builder: Verified diff --git a/drivers/dahdi/icE1usb/icE1usb.c b/drivers/dahdi/icE1usb/icE1usb.c index a861515..ebeaee6 100644 --- a/drivers/dahdi/icE1usb/icE1usb.c +++ b/drivers/dahdi/icE1usb/icE1usb.c @@ -29,6 +29,7 @@ #include <linux/slab.h> #include <linux/kernel.h> #include <linux/spinlock.h> +#include <linux/workqueue.h> #include <linux/pm_runtime.h> #include <dahdi/kernel.h> @@ -135,6 +136,8 @@ } dahdi; /* is the device still present (true) or already absent/unplugged (false) */ bool present; + /* deferred ice1usb_tx_config(), scheduled from the atomic .maint callback */ + struct work_struct tx_config_work; /* spinlock protecting concurrent access to fc, {read,write}chunk_idx, ... */ spinlock_t lock; /* maximum number of 32-byte E1 frames to send in one ISO OUT packet */ @@ -880,11 +883,26 @@ return 0; } -/* set some maintenance mode according to 'cmd' */ +static void ice1usb_deferred_tx_config(struct work_struct *work) +{ + struct ice1usb *ieu = container_of(work, struct ice1usb, tx_config_work); + int rc; + + if (!ieu->present) + return; + + rc = ice1usb_tx_config(ieu); + if (rc < 0) + ieu_err(ieu, "Failed to apply maint TX config: %d\n", rc); +} + +/* set some maintenance mode according to 'cmd' + * + * Called by the DAHDI core with span->lock held and IRQs disabled, so the + * blocking USB I/O is deferred to ice1usb_deferred_tx_config(). */ static int e1u_d_maint(struct dahdi_span *span, int cmd) { struct ice1usb *ieu = container_of(span, struct ice1usb, dahdi.span); - int rc = 0; ieu_dbg(ieu, "entering %s(%d)", __FUNCTION__, cmd); @@ -892,12 +910,12 @@ case DAHDI_MAINT_NONE: ieu_info(ieu, "Clearing all maint modes\n"); ieu->cfg.tx.ext_loopback = ICE1USB_TX_EXT_LOOPBACK_OFF; - rc = ice1usb_tx_config(ieu); + schedule_work(&ieu->tx_config_work); break; case DAHDI_MAINT_NETWORKLINELOOP: ieu_info(ieu, "Turning on network line loopback\n"); ieu->cfg.tx.ext_loopback = ICE1USB_TX_EXT_LOOPBACK_SAME; - rc = ice1usb_tx_config(ieu); + schedule_work(&ieu->tx_config_work); break; /* TODO: DAHDI_MAINT_*_DEFECT */ /* TODO: DAHDI_MAINT_ALARM_SIM */ @@ -910,7 +928,7 @@ return -ENOSYS; } - return rc; + return 0; } static const struct dahdi_span_ops ice1usb_span_ops = { @@ -1413,6 +1431,7 @@ ieu->fc.r_sw = 8192; ieu->present = true; spin_lock_init(&ieu->lock); + INIT_WORK(&ieu->tx_config_work, ice1usb_deferred_tx_config); /* locate ON / OFF altsettings */ ieu->alt_off = find_altsetting_off(ieu->usb_intf); @@ -1514,6 +1533,8 @@ /* will in turn call e1u_d_shutdown() which stops all transfers */ dahdi_unregister_device(ieu->dahdi.dev); + cancel_work_sync(&ieu->tx_config_work); + ice1usb_free(ieu); } -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/43642?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Iba99fc5261059c77cc89d867b21c70a34c9b4ea6 Gerrit-Change-Number: 43642 Gerrit-PatchSet: 1 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com>

1 0

2026

2025

2024

2023

2022

gerrit-log October 2026