October 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: jobs/gerrit: modernize osmo-ttcn3-hacks
by pespin 15 Oct '26

15 Oct '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43900?usp=email ) Change subject: jobs/gerrit: modernize osmo-ttcn3-hacks ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I89791d7457d4d8659716837aa5901c262789eada Gerrit-Change-Number: 43900 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Oct 2026 12:19:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: jobs/gerrit: modernize osmo-ttcn3-hacks
by osmith 15 Oct '26

15 Oct '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/43900?usp=email ) Change subject: jobs/gerrit: modernize osmo-ttcn3-hacks ...................................................................... jobs/gerrit: modernize osmo-ttcn3-hacks * Use the debian 13 based testenv image (which we also use for building in ttcn3-*-test jobs) instead of debian-bookworm-titan (debian 12) from docker-playground. * Use rootless podman instead of docker, which means we don't need to create and switch to a user with the right PID to avoid messing up permissions on the host system. * Remove the logic for symlinking deps to a clone inside the container. This made sense in the past to avoid fetching too often from eclipse gitlab, but nowadays we clone from https://gitea.osmocom.org/mirrors so it's fine to do fresh clones every time and this makes the deps fetching logic simpler. With the previous version it could happen that checkouts became stale. * Run "make deps" separately so the output for it is clearly separated (e.g. it may say "Nothing to be done for 'deps'." instead of silently moving on with the compile target). * Wipe at the beginning to ensure we don't have stale deps and clean when done to save disk space. Change-Id: I89791d7457d4d8659716837aa5901c262789eada --- M jobs/gerrit-verifications.yml 1 file changed, 15 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/00/43900/1 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 27bd888..034d02b 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -581,21 +581,25 @@ - osmo-ttcn3-hacks: slave_axis: !!python/tuple [ttcn3] cmd: | - docker run \ + TITAN_VERSION=11.1.0 + DISTRO="debian:trixie" + IMAGE="registry.osmocom.org/osmocom-build/"$(echo "$DISTRO" | tr : -)"-osmo-ttcn3-testenv" + + podman run \ --rm \ -v "$PWD:/build" \ - "registry.osmocom.org/osmocom-build/debian-bookworm-titan" \ + -w "/build" \ + "$IMAGE" \ {timeout_cmd} \ - sh -e -x -c ' - useradd --uid=1000 build - for i in /osmo-ttcn3-hacks/deps/*/; do - if ! [ -e /build/deps/"$(basename "$i")" ]; then - ln -s "$i" /build/deps/ - fi - done - su build -c "make -C /build clean compile" - ' + sh -e -x -c " + export TTCN3_DIR='/opt/eclipse-titan-$TITAN_VERSION' + export PATH=\"\$TTCN3_DIR/bin:\$PATH\" + make deps + make compile + make clean + " pipeline_binpkgs: "" + wipe: true - dahdi-tools: pipeline_lint: false -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I89791d7457d4d8659716837aa5901c262789eada Gerrit-Change-Number: 43900 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-hnbgw[master]: sigtran: N-NOTICE.ind: Use proper SCCP-User return reason
by pespin 15 Oct '26

15 Oct '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/43808?usp=email ) Change subject: sigtran: N-NOTICE.ind: Use proper SCCP-User return reason ...................................................................... sigtran: N-NOTICE.ind: Use proper SCCP-User return reason Until recently, libosmo-sigtran was incorrectly expecting low-level wire-format cause in N-NOTICE.ind. Nowadays it supports specific reason values in the SCCP-User SAP, so use those instead. This change is backward-compatible since the value for both enums are the same as per specs. Related: OS#2601 Change-Id: I38c218f4595af0be9a17cff436b2beaabd6f8487 --- M TODO-RELEASE M src/osmo-hnbgw/hnbgw_sccp.c 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index b6d61b1..5e970b9 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -8,3 +8,4 @@ # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line libosmo-sigtran >2.3.0 OSMO_SCCP_REL_REASON_NSU_* +libosmo-sigtran >2.3.0 OSMO_SCCP_RETURN_REASON_*, osmo_sccp_return_reason_name() diff --git a/src/osmo-hnbgw/hnbgw_sccp.c b/src/osmo-hnbgw/hnbgw_sccp.c index 2e9b79a..2e97269 100644 --- a/src/osmo-hnbgw/hnbgw_sccp.c +++ b/src/osmo-hnbgw/hnbgw_sccp.c @@ -32,7 +32,6 @@ #include <osmocom/sigtran/sccp_sap.h> #include <osmocom/sigtran/sccp_helpers.h> #include <osmocom/sigtran/protocol/sua.h> -#include <osmocom/sccp/sccp_types.h> #include <osmocom/hnbgw/hnbgw_cn.h> #include <osmocom/hnbgw/context_map.h> @@ -122,18 +121,18 @@ if (!cnlink) { LOGP(DCN, LOGL_DEBUG, "(calling_addr=%s) N-NOTICE.ind cause=%u='%s' importance=%u didn't match any cnlink, ignoring\n", osmo_sccp_addr_dump(&param->calling_addr), - param->cause, osmo_sccp_return_cause_name(param->cause), + param->cause, osmo_sccp_return_reason_name(param->cause), param->importance); return; } LOG_CNLINK(cnlink, DCN, LOGL_NOTICE, "N-NOTICE.ind cause=%u='%s' importance=%u\n", - param->cause, osmo_sccp_return_cause_name(param->cause), + param->cause, osmo_sccp_return_reason_name(param->cause), param->importance); CNLINK_CTR_INC(cnlink, CNLINK_CTR_SCCP_N_NOTICE_IND); switch (param->cause) { - case SCCP_RETURN_CAUSE_SUBSYSTEM_CONGESTION: - case SCCP_RETURN_CAUSE_NETWORK_CONGESTION: + case OSMO_SCCP_RETURN_REASON_SUBSYSTEM_CONGESTION: + case OSMO_SCCP_RETURN_REASON_NETWORK_CONGESTION: /* Transient failures (hopefully), keep going. */ return; default: -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/43808?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I38c218f4595af0be9a17cff436b2beaabd6f8487 Gerrit-Change-Number: 43808 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-hnbgw[master]: sigtran: N-DISCONNECT.req: Use proper SCCP-User release reason
by pespin 15 Oct '26

15 Oct '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/43800?usp=email ) Change subject: sigtran: N-DISCONNECT.req: Use proper SCCP-User release reason ...................................................................... sigtran: N-DISCONNECT.req: Use proper SCCP-User release reason Until recently, libosmo-sigtran was incorrectly expecting low-level wire-format cause in N-DISCONNECT.req. Nowadays it supports specific reason values in the SCCP-User SAP, so use those instead. Related: OS#2601 Change-Id: I702718a00031592c2aa870ea8981228848129659 --- M TODO-RELEASE M src/osmo-hnbgw/hnbgw_sccp.c 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index 0ed7189..b6d61b1 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmo-sigtran >2.3.0 OSMO_SCCP_REL_REASON_NSU_* diff --git a/src/osmo-hnbgw/hnbgw_sccp.c b/src/osmo-hnbgw/hnbgw_sccp.c index 6f01f7c..2e9b79a 100644 --- a/src/osmo-hnbgw/hnbgw_sccp.c +++ b/src/osmo-hnbgw/hnbgw_sccp.c @@ -449,7 +449,7 @@ } rc = osmo_sccp_tx_disconn(hsu->sccp_user, scu_conn_id, NULL, - SCCP_RELEASE_CAUSE_END_USER_ORIGINATED); + OSMO_SCCP_REL_REASON_NSU_DISC_NORMAL); if (rc) LOG_HSU(hsu, DCN, LOGL_ERROR, "Failed to send SCCP N-DISCONNECT.req(%u)\n", scu_conn_id); return rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/43800?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I702718a00031592c2aa870ea8981228848129659 Gerrit-Change-Number: 43800 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-hnbgw[master]: sigtran: N-NOTICE.ind: Use proper SCCP-User return reason
by fixeria 15 Oct '26

15 Oct '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/43808?usp=email ) Change subject: sigtran: N-NOTICE.ind: Use proper SCCP-User return reason ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/43808?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I38c218f4595af0be9a17cff436b2beaabd6f8487 Gerrit-Change-Number: 43808 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Oct 2026 12:14:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-hnbgw[master]: sigtran: N-DISCONNECT.req: Use proper SCCP-User release reason
by fixeria 15 Oct '26

15 Oct '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/43800?usp=email ) Change subject: sigtran: N-DISCONNECT.req: Use proper SCCP-User release reason ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/43800?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I702718a00031592c2aa870ea8981228848129659 Gerrit-Change-Number: 43800 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Oct 2026 12:14:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: optionally compress big ttcn3 logs
by pespin 15 Oct '26

15 Oct '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43896?usp=email ) Change subject: testenv: optionally compress big ttcn3 logs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43896?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0766f6236f023ea8e3329c1364c9ee048e00c6d0 Gerrit-Change-Number: 43896 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Oct 2026 12:12:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: jobs/registry-rebuild-upload-titan: add mail param
by fixeria 15 Oct '26

15 Oct '26

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43897?usp=email ) Change subject: jobs/registry-rebuild-upload-titan: add mail param ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43897?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I928fd316d092b688bd60a65f8a447dd648ee255f Gerrit-Change-Number: 43897 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Oct 2026 12:12:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/ttcn3: set TESTENV_COMPRESS_BIG_LOGS=1
by fixeria 15 Oct '26

15 Oct '26

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43899?usp=email ) Change subject: jobs/ttcn3: set TESTENV_COMPRESS_BIG_LOGS=1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ieef7681c34260919a4c652f210726de960173836 Gerrit-Change-Number: 43899 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Oct 2026 12:12:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/registry-rebuild-upload-titan: set REPODIR
by pespin 15 Oct '26

15 Oct '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43898?usp=email ) Change subject: jobs/registry-rebuild-upload-titan: set REPODIR ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43898?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie0e28e4bdad3e666dc4b25030a2f6a134a2f3030 Gerrit-Change-Number: 43898 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Oct 2026 12:11:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0